@repository-settings/app 3.0.0-beta.1 → 3.0.0-beta.2

package/lib/plugins/environments.js

@@ -2,6 +2,62 @@ const Diffable = require('./diffable')
 
 const environmentRepoEndpoint = '/repos/:org/:repo/environments/:environment_name'
 
+function shouldUseProtectedBranches (protectedBranches, customBranchPolicies) {
+  return !!(protectedBranches || customBranchPolicies === undefined || customBranchPolicies === null)
+}
+
+function attributeSorter (a, b) {
+  if (a.id < b.id) return -1
+  if (a.id > b.id) return 1
+  if (a.type < b.type) return -1
+  if (a.type > b.type) return 1
+  return 0
+}
+
+function reviewersToString (reviewers) {
+  if (reviewers === null || reviewers === undefined) {
+    return ''
+  } else {
+    reviewers.sort(attributeSorter)
+
+    return JSON.stringify(
+      reviewers.map(reviewer => {
+        return {
+          id: reviewer.id,
+          type: reviewer.type
+        }
+      })
+    )
+  }
+}
+
+function deploymentBranchPolicyToString (attrs) {
+  if (attrs === null || attrs === undefined) {
+    return ''
+  } else {
+    return JSON.stringify(
+      shouldUseProtectedBranches(attrs.protected_branches, attrs.custom_branches)
+        ? { protected_branches: true }
+        : { custom_branches: attrs.custom_branches.sort() }
+    )
+  }
+}
+
+function waitTimerHasChanged (existing, attrs) {
+  return (existing.wait_timer || 0) !== attrs.wait_timer
+}
+
+function reviewersHasChanged (existing, attrs) {
+  return reviewersToString(existing.reviewers) !== reviewersToString(attrs.reviewers)
+}
+
+function deploymentBranchPolicyHasChanged (existing, attrs) {
+  return (
+    deploymentBranchPolicyToString(existing.deployment_branch_policy) !==
+    deploymentBranchPolicyToString(attrs.deployment_branch_policy)
+  )
+}
+
 module.exports = class Environments extends Diffable {
   constructor (...args) {
     super(...args)
@@ -21,6 +77,7 @@ module.exports = class Environments extends Diffable {
       org: this.repo.owner,
       repo: this.repo.repo
     })
+
     return Promise.all(
       environments.map(async environment => {
         if (environment.deployment_branch_policy) {
@@ -39,6 +96,7 @@ module.exports = class Environments extends Diffable {
             }
           }
         }
+
         return {
           ...environment,
           // Force all names to lowercase to avoid comparison issues.
@@ -54,17 +112,18 @@ module.exports = class Environments extends Diffable {
 
   changed (existing, attrs) {
     if (!attrs.wait_timer) attrs.wait_timer = 0
+
     return (
-      (existing.wait_timer || 0) !== attrs.wait_timer ||
-      this.reviewersToString(existing.reviewers) !== this.reviewersToString(attrs.reviewers) ||
-      this.deploymentBranchPolicyToString(existing.deployment_branch_policy) !==
-        this.deploymentBranchPolicyToString(attrs.deployment_branch_policy)
+      waitTimerHasChanged(existing, attrs) ||
+      reviewersHasChanged(existing, attrs) ||
+      deploymentBranchPolicyHasChanged(existing, attrs)
     )
   }
 
   async update (existing, attrs) {
     if (existing.deployment_branch_policy && existing.deployment_branch_policy.custom_branches) {
       const branchPolicies = await this.getDeploymentBranchPolicies(this.repo.owner, this.repo.repo, existing.name)
+
       await Promise.all(
         branchPolicies.map(branchPolicy =>
           this.github.request(
@@ -79,15 +138,17 @@ module.exports = class Environments extends Diffable {
         )
       )
     }
+
     return this.add(attrs)
   }
 
   async add (attrs) {
     await this.github.request(`PUT ${environmentRepoEndpoint}`, this.toParams({ name: attrs.name }, attrs))
+
     if (attrs.deployment_branch_policy && attrs.deployment_branch_policy.custom_branches) {
       await Promise.all(
         attrs.deployment_branch_policy.custom_branches.map(name =>
-          this.github.request(`POST /repos/:org/:repo/environments/:environment_name/deployment-branch-policies`, {
+          this.github.request('POST /repos/:org/:repo/environments/:environment_name/deployment-branch-policies', {
             org: this.repo.owner,
             repo: this.repo.repo,
             environment_name: attrs.name,
@@ -106,40 +167,6 @@ module.exports = class Environments extends Diffable {
     })
   }
 
-  reviewersToString (attrs) {
-    if (attrs === null || attrs === undefined) {
-      return ''
-    } else {
-      attrs.sort((a, b) => {
-        if (a.id < b.id) return -1
-        if (a.id > b.id) return 1
-        if (a.type < b.type) return -1
-        if (a.type > b.type) return 1
-        return 0
-      })
-      return JSON.stringify(
-        attrs.map(reviewer => {
-          return {
-            id: reviewer.id,
-            type: reviewer.type
-          }
-        })
-      )
-    }
-  }
-
-  deploymentBranchPolicyToString (attrs) {
-    if (attrs === null || attrs === undefined) {
-      return ''
-    } else {
-      return JSON.stringify(
-        this.shouldUseProtectedBranches(attrs.protected_branches, attrs.custom_branches)
-          ? { protected_branches: true }
-          : { custom_branches: attrs.custom_branches.sort() }
-      )
-    }
-  }
-
   async getDeploymentBranchPolicies (owner, repo, environmentName) {
     const {
       data: { branch_policies: branchPolicies }
@@ -148,18 +175,20 @@ module.exports = class Environments extends Diffable {
       repo,
       environment_name: environmentName
     })
+
     return branchPolicies
   }
 
   toParams (existing, attrs) {
     const deploymentBranchPolicy = attrs.deployment_branch_policy
-      ? this.shouldUseProtectedBranches(
+      ? shouldUseProtectedBranches(
           attrs.deployment_branch_policy.protected_branches,
           attrs.deployment_branch_policy.custom_branches
         )
         ? { protected_branches: true, custom_branch_policies: false }
         : { protected_branches: false, custom_branch_policies: true }
       : null
+
     return {
       environment_name: existing.name,
       repo: this.repo.repo,
@@ -169,12 +198,4 @@ module.exports = class Environments extends Diffable {
       deployment_branch_policy: deploymentBranchPolicy
     }
   }
-
-  shouldUseProtectedBranches (protectedBranches, customBranchPolicies) {
-    if (protectedBranches || customBranchPolicies === undefined || customBranchPolicies === null) {
-      return true // Returning booleans like this to avoid unexpected datatypes that result in truthy values
-    } else {
-      return false
-    }
-  }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@repository-settings/app",
-  "version": "3.0.0-beta.1",
+  "version": "3.0.0-beta.2",
   "description": "Pull Requests for GitHub repository settings",
   "repository": "github:repository-settings/app",
   "main": "index.js",
@@ -15,8 +15,12 @@
     "lint:peer": "npm ls >/dev/null",
     "test:unit": "jest 'test/unit/'",
     "test:unit:watch": "npm run test:unit -- --watch",
-    "test:integration": "jest 'test/integration/'",
-    "test:integration:debug": "LOG_LEVEL=debug DEBUG=nock.* run-s test:integration",
+    "test:integration": "run-s 'test:integration:base -- --profile noWip'",
+    "test:integration:base": "NODE_OPTIONS=--enable-source-maps DEBUG=any cucumber-js test/integration",
+    "test:integration:debug": "DEBUG=test run-s test:integration",
+    "test:integration:wip": "run-s 'test:integration:base -- --profile wip'",
+    "test:integration:wip:debug": "DEBUG=test run-s 'test:integration:wip'",
+    "test:integration:focus": "run-s 'test:integration:base -- --profile focus'",
     "generate:md": "remark . --output"
   },
   "author": "Brandon Keepers",
@@ -24,9 +28,10 @@
   "dependencies": {
     "deepmerge": "4.3.1",
     "js-yaml": "4.1.0",
-    "probot": "12.3.3"
+    "probot": "^13.0.2"
   },
   "devDependencies": {
+    "@cucumber/cucumber": "9.6.0",
     "@form8ion/remark-preset": "1.0.0",
     "@travi/any": "3.0.2",
     "http-status-codes": "2.3.0",
@@ -34,6 +39,7 @@
     "jest-when": "3.6.0",
     "lockfile-lint": "4.12.1",
     "ls-engines": "0.9.1",
+    "msw": "2.1.4",
     "nock": "13.5.0",
     "nodemon": "3.0.3",
     "npm-run-all2": "6.1.1",