@replikanti/flowlint-core 0.10.0 → 0.12.1

package/README.md

@@ -1,6 +1,6 @@
 # @replikanti/flowlint-core
 
-![Coverage](https://img.shields.io/badge/coverage-86.48%25-green)
+![Coverage](https://img.shields.io/badge/coverage-86.84%25-green)
 
 Core static analysis engine for [n8n](https://n8n.io) workflows. This package contains the parser, rules engine, and default rule definitions.
 
@@ -70,6 +70,7 @@ This package includes 14 built-in rules:
 | R12 | Unhandled error path | must |
 | R13 | Webhook acknowledgment | must |
 | R14 | Retry-After compliance | should |
+| R15 | Error handler set in settings | must |
 
 ## License
 

package/dist/index.d.mts

@@ -56,6 +56,9 @@ interface RetryAfterComplianceConfig {
     suggest_exponential_backoff?: boolean;
     suggest_jitter?: boolean;
 }
+interface ErrorHandlerSetInSettingsConfig {
+    enabled: boolean;
+}
 interface RulesConfig {
     rate_limit_retry: RateLimitRetryConfig;
     error_handling: ErrorHandlingConfig;
@@ -71,6 +74,7 @@ interface RulesConfig {
     config_literals: ConfigLiteralsConfig;
     webhook_acknowledgment: WebhookAcknowledgmentConfig;
     retry_after_compliance: RetryAfterComplianceConfig;
+    error_handler_set_in_settings: ErrorHandlerSetInSettingsConfig;
 }
 interface FilesConfig {
     include: string[];
@@ -168,7 +172,7 @@ type RuleContext = {
     cfg: FlowLintConfig;
     nodeLines?: Record<string, number>;
 };
-declare function runAllRules(graph: Graph, ctx: RuleContext): Finding[];
+declare function runAllRules(graph: Graph, ctx: RuleContext, extraRules?: RuleRunner[]): Finding[];
 
 interface RuleMetadata {
     id: string;

package/dist/index.d.ts

@@ -56,6 +56,9 @@ interface RetryAfterComplianceConfig {
     suggest_exponential_backoff?: boolean;
     suggest_jitter?: boolean;
 }
+interface ErrorHandlerSetInSettingsConfig {
+    enabled: boolean;
+}
 interface RulesConfig {
     rate_limit_retry: RateLimitRetryConfig;
     error_handling: ErrorHandlingConfig;
@@ -71,6 +74,7 @@ interface RulesConfig {
     config_literals: ConfigLiteralsConfig;
     webhook_acknowledgment: WebhookAcknowledgmentConfig;
     retry_after_compliance: RetryAfterComplianceConfig;
+    error_handler_set_in_settings: ErrorHandlerSetInSettingsConfig;
 }
 interface FilesConfig {
     include: string[];
@@ -168,7 +172,7 @@ type RuleContext = {
     cfg: FlowLintConfig;
     nodeLines?: Record<string, number>;
 };
-declare function runAllRules(graph: Graph, ctx: RuleContext): Finding[];
+declare function runAllRules(graph: Graph, ctx: RuleContext, extraRules?: RuleRunner[]): Finding[];
 
 interface RuleMetadata {
     id: string;

package/dist/index.js

@@ -401,6 +401,11 @@ function findAllUpstreamNodes(graph, startNodeId) {
   }
   return visited;
 }
+function isMainWorkflow(graph) {
+  return graph.nodes.some(
+    (node) => /trigger|webhook|schedule|form|\bstart\b/i.test(node.type) && !/executeworkflow/i.test(node.type) && !/manualTrigger/i.test(node.type)
+  );
+}
 var EXAMPLES_BASE_URL = "https://github.com/Replikanti/flowlint-examples/tree/main";
 function getExampleLink(ruleId) {
   return `${EXAMPLES_BASE_URL}/${ruleId}`;
@@ -615,7 +620,8 @@ function parseN8n(doc) {
     edges,
     meta: {
       credentials: !!parsed.credentials,
-      nodeLines: Object.fromEntries(nodeLines)
+      nodeLines: Object.fromEntries(nodeLines),
+      settings: parsed.settings
     }
   };
 }
@@ -1159,6 +1165,40 @@ var r14RetryAfterCompliance = createNodeRule(metadata14.id, metadata14.name, (no
   };
 });
 
+// src/rules/lib/r15-error-handler-set-in-settings.ts
+var metadata15 = {
+  id: "R15",
+  name: "error_handler_set_in_settings",
+  severity: "must",
+  description: "Ensures main workflows have an error handler workflow configured in settings",
+  details: "Main workflows (triggered by webhook, schedule, form, etc.) should have settings.errorWorkflow set to receive error notifications. Sub-workflows (Execute Workflow Trigger) are excluded from this check."
+};
+function getWorkflowSettings(meta) {
+  const settings = meta.settings;
+  if (settings != null && typeof settings === "object" && !Array.isArray(settings)) {
+    return settings;
+  }
+  return void 0;
+}
+function r15ErrorHandlerSetInSettings(graph, ctx) {
+  const cfg = ctx.cfg.rules.error_handler_set_in_settings;
+  if (!cfg?.enabled) return [];
+  if (!isMainWorkflow(graph)) return [];
+  const settings = getWorkflowSettings(graph.meta);
+  if (settings?.errorWorkflow && typeof settings.errorWorkflow === "string" && settings.errorWorkflow.trim().length > 0) {
+    return [];
+  }
+  return [
+    {
+      rule: metadata15.id,
+      severity: metadata15.severity,
+      path: ctx.path,
+      message: "Main workflow does not have an error handler workflow configured in settings",
+      raw_details: "Set settings.errorWorkflow to a valid workflow ID so that runtime errors trigger a notification workflow."
+    }
+  ];
+}
+
 // src/rules/index.ts
 var rules = [
   r1Retry,
@@ -1174,10 +1214,11 @@ var rules = [
   r11DeprecatedNodes,
   r12UnhandledErrorPath,
   r13WebhookAcknowledgment,
-  r14RetryAfterCompliance
+  r14RetryAfterCompliance,
+  r15ErrorHandlerSetInSettings
 ];
-function runAllRules(graph, ctx) {
-  return rules.flatMap((rule) => rule(graph, ctx));
+function runAllRules(graph, ctx, extraRules = []) {
+  return [...rules, ...extraRules].flatMap((rule) => rule(graph, ctx));
 }
 
 // src/rules/metadata.ts
@@ -1195,7 +1236,8 @@ var RULES_METADATA = [
   metadata11,
   metadata12,
   metadata13,
-  metadata14
+  metadata14,
+  metadata15
 ];
 
 // src/config/default-config.ts
@@ -1263,7 +1305,8 @@ var defaultConfig = {
       enabled: true,
       suggest_exponential_backoff: true,
       suggest_jitter: true
-    }
+    },
+    error_handler_set_in_settings: { enabled: true }
   }
 };