@renaiss-shipflow/cli 0.10.0 → 0.11.0

package/dist/review-contract.d.ts

@@ -0,0 +1,59 @@
+/** Unified verdict vocabulary. The loop reviewer's `approve`/`request_changes`/
+ *  `reject` plus the server's advisory `comment`. */
+export type Verdict = "approve" | "comment" | "request_changes" | "reject";
+/** Severity badge — byte-identical to the server's severityBadge(). */
+export declare function severityBadge(severity: string): string;
+/** CodeRabbit-style fix-size tag after the badge — mirrors the server. */
+export declare function effortTag(effort?: string): string;
+/** Verdict header, shared by the inline review body and any fallback comment. */
+export declare function verdictHeader(verdict: Verdict): string;
+export interface ReviewFinding {
+    path: string;
+    line: number;
+    severity: string;
+    issue: string;
+    why?: string;
+    fix?: string;
+    effort?: string;
+    suggestion?: string;
+    code?: string;
+}
+/** One finding's comment body — mirrors renderInlineFinding(): badge + effort +
+ *  issue, why, fix, and a committable ```suggestion block when present. */
+export declare function renderFindingBody(f: ReviewFinding): string;
+/** Repo-relative path in one canonical shape: forward slashes, no leading
+ *  "./". Applied to both diff keys and finding paths so `./src/x` / `src\\x`
+ *  still anchor. NOT a filesystem realpath — diff paths aren't fs paths. */
+export declare function normPath(p: string): string;
+/** Map of path → set of new-file line numbers that GitHub will accept a
+ *  RIGHT-side inline comment on (context + added lines). Mirrors the server's
+ *  annotatePatch line numbering so a bad anchor can't 422 the whole review. */
+export declare function diffAnchors(diff: string): Map<string, Set<number>>;
+/** Partition findings into ones that anchor to a real diff line (postable
+ *  inline) and ones that must fold into the summary body (bad line / file). */
+export declare function splitAnchorable(findings: ReviewFinding[], anchors: Map<string, Set<number>>): {
+    inline: ReviewFinding[];
+    body: ReviewFinding[];
+};
+export interface ReviewComment {
+    path: string;
+    line: number;
+    side: "RIGHT";
+    body: string;
+}
+export interface ReviewPayload {
+    event: "COMMENT";
+    body: string;
+    comments: ReviewComment[];
+}
+/** Build the GitHub "create review" payload: a COMMENT-event review (ShipFlow
+ *  reviews are advisory — approval authority stays with the label gate, so the
+ *  event is never APPROVE/REQUEST_CHANGES; the verdict lives in the header),
+ *  with on-diff findings as inline comments and the rest folded into the body. */
+export declare function buildReviewPayload(opts: {
+    summary: string;
+    verdict: Verdict;
+    findings: ReviewFinding[];
+    anchors: Map<string, Set<number>>;
+}): ReviewPayload;
+//# sourceMappingURL=review-contract.d.ts.map

package/dist/review-contract.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-contract.d.ts","sourceRoot":"","sources":["../src/review-contract.ts"],"names":[],"mappings":"AAKA;qDACqD;AACrD,MAAM,MAAM,OAAO,GAAG,SAAS,GAAG,SAAS,GAAG,iBAAiB,GAAG,QAAQ,CAAC;AAE3E,uEAAuE;AACvE,wBAAgB,aAAa,CAAC,QAAQ,EAAE,MAAM,GAAG,MAAM,CAOtD;AAED,0EAA0E;AAC1E,wBAAgB,SAAS,CAAC,MAAM,CAAC,EAAE,MAAM,GAAG,MAAM,CAMjD;AAED,iFAAiF;AACjF,wBAAgB,aAAa,CAAC,OAAO,EAAE,OAAO,GAAG,MAAM,CAOtD;AAED,MAAM,WAAW,aAAa;IAC5B,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,EAAE,MAAM,CAAC;IACjB,KAAK,EAAE,MAAM,CAAC;IACd,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,IAAI,CAAC,EAAE,MAAM,CAAC;CACf;AAID;2EAC2E;AAC3E,wBAAgB,iBAAiB,CAAC,CAAC,EAAE,aAAa,GAAG,MAAM,CAS1D;AAED;;4EAE4E;AAC5E,wBAAgB,QAAQ,CAAC,CAAC,EAAE,MAAM,GAAG,MAAM,CAE1C;AAKD;;+EAE+E;AAC/E,wBAAgB,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC,CAkBlE;AAED;+EAC+E;AAC/E,wBAAgB,eAAe,CAC7B,QAAQ,EAAE,aAAa,EAAE,EACzB,OAAO,EAAE,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC,GAChC;IAAE,MAAM,EAAE,aAAa,EAAE,CAAC;IAAC,IAAI,EAAE,aAAa,EAAE,CAAA;CAAE,CAQpD;AAED,MAAM,WAAW,aAAa;IAAG,IAAI,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,OAAO,CAAC;IAAC,IAAI,EAAE,MAAM,CAAC;CAAE;AAC3F,MAAM,WAAW,aAAa;IAAG,KAAK,EAAE,SAAS,CAAC;IAAC,IAAI,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,aAAa,EAAE,CAAC;CAAE;AAE7F;;;kFAGkF;AAClF,wBAAgB,kBAAkB,CAAC,IAAI,EAAE;IACvC,OAAO,EAAE,MAAM,CAAC;IAChB,OAAO,EAAE,OAAO,CAAC;IACjB,QAAQ,EAAE,aAAa,EAAE,CAAC;IAC1B,OAAO,EAAE,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC;CACnC,GAAG,aAAa,CAqBhB"}

package/dist/review-contract.js

@@ -0,0 +1,129 @@
+// Canonical review contract shared by the loop reviewer (this CLI) — the
+// single source of truth for verdict vocabulary, severity badges, finding
+// rendering, and diff anchoring, mirroring the server's runner_pr_review.go so
+// the two reviewers post CONSISTENTLY (epic #96). Pure + testable; no I/O.
+/** Severity badge — byte-identical to the server's severityBadge(). */
+export function severityBadge(severity) {
+    switch (severity.trim().toLowerCase()) {
+        case "critical": return "🔴 **critical**";
+        case "high": return "🟠 **high**";
+        case "low": return "🔵 **low**";
+        default: return "🟡 **medium**";
+    }
+}
+/** CodeRabbit-style fix-size tag after the badge — mirrors the server. */
+export function effortTag(effort) {
+    switch ((effort ?? "").trim().toLowerCase()) {
+        case "quick": return " · ⚡ quick fix";
+        case "involved": return " · 🔨 involved";
+        default: return "";
+    }
+}
+/** Verdict header, shared by the inline review body and any fallback comment. */
+export function verdictHeader(verdict) {
+    switch (verdict) {
+        case "approve": return "**✅ APPROVE — ShipFlow review**";
+        case "request_changes": return "**🔴 CHANGES REQUESTED — ShipFlow review**";
+        case "reject": return "**⛔ REJECT — ShipFlow review**";
+        default: return "**💬 ShipFlow review — comments**";
+    }
+}
+const REVIEW_MARKER = "<!-- shipflow:loop-review -->";
+/** One finding's comment body — mirrors renderInlineFinding(): badge + effort +
+ *  issue, why, fix, and a committable ```suggestion block when present. */
+export function renderFindingBody(f) {
+    let b = `${severityBadge(f.severity)}${effortTag(f.effort)} ${f.issue}`;
+    if (f.why?.trim())
+        b += `\n\n${f.why.trim()}`;
+    if (f.fix?.trim())
+        b += `\n\n**Fix:** ${f.fix.trim()}`;
+    const sug = (f.suggestion ?? "").replace(/\n+$/, "");
+    const code = (f.code ?? "").replace(/\n+$/, "");
+    if (sug.trim())
+        b += `\n\`\`\`suggestion\n${sug}\n\`\`\``;
+    else if (code.trim())
+        b += `\n\`\`\`\n${code}\n\`\`\``;
+    return `${b}\n\n${REVIEW_MARKER}`;
+}
+/** Repo-relative path in one canonical shape: forward slashes, no leading
+ *  "./". Applied to both diff keys and finding paths so `./src/x` / `src\\x`
+ *  still anchor. NOT a filesystem realpath — diff paths aren't fs paths. */
+export function normPath(p) {
+    return p.replace(/\\/g, "/").replace(/^\.\//, "").trim();
+}
+const HUNK_RE = /^@@ -\d+(?:,\d+)? \+(\d+)(?:,\d+)? @@/;
+const FILE_RE = /^\+\+\+ b\/(.+)$/;
+/** Map of path → set of new-file line numbers that GitHub will accept a
+ *  RIGHT-side inline comment on (context + added lines). Mirrors the server's
+ *  annotatePatch line numbering so a bad anchor can't 422 the whole review. */
+export function diffAnchors(diff) {
+    const out = new Map();
+    let path = "";
+    let ln = 0;
+    for (const raw of diff.split(/\r?\n/)) {
+        const fm = FILE_RE.exec(raw);
+        if (fm) {
+            path = normPath(fm[1]);
+            ln = 0;
+            continue;
+        }
+        const hm = HUNK_RE.exec(raw);
+        if (hm) {
+            ln = parseInt(hm[1], 10);
+            continue;
+        }
+        if (!path || ln === 0)
+            continue;
+        if (raw.startsWith("-"))
+            continue; // removed: no RIGHT-side line
+        if (raw.startsWith("+") || raw.startsWith(" ")) {
+            if (!out.has(path))
+                out.set(path, new Set());
+            out.get(path).add(ln);
+            ln++;
+        }
+    }
+    return out;
+}
+/** Partition findings into ones that anchor to a real diff line (postable
+ *  inline) and ones that must fold into the summary body (bad line / file). */
+export function splitAnchorable(findings, anchors) {
+    const inline = [];
+    const body = [];
+    for (const f of findings) {
+        if (f.line > 0 && anchors.get(normPath(f.path))?.has(f.line))
+            inline.push(f);
+        else
+            body.push(f);
+    }
+    return { inline, body };
+}
+/** Build the GitHub "create review" payload: a COMMENT-event review (ShipFlow
+ *  reviews are advisory — approval authority stays with the label gate, so the
+ *  event is never APPROVE/REQUEST_CHANGES; the verdict lives in the header),
+ *  with on-diff findings as inline comments and the rest folded into the body. */
+export function buildReviewPayload(opts) {
+    const { inline, body: unanchored } = splitAnchorable(opts.findings, opts.anchors);
+    const lines = [verdictHeader(opts.verdict)];
+    if (opts.summary.trim())
+        lines.push("", opts.summary.trim());
+    if (unanchored.length) {
+        lines.push("", "**Further findings (outside the annotated diff lines):**");
+        for (const f of unanchored) {
+            const anchor = f.line > 0 ? `${f.path}:${f.line}` : f.path;
+            const fbLines = renderFindingBody(f).split("\n\n" + REVIEW_MARKER)[0].split("\n");
+            lines.push(`- \`${anchor}\` — ${fbLines[0]}`);
+            // Indent why/fix/suggestion continuation two spaces so GitHub keeps them
+            // nested under the bullet instead of rendering as top-level paragraphs.
+            for (let i = 1; i < fbLines.length; i++)
+                lines.push(fbLines[i] ? `  ${fbLines[i]}` : "");
+        }
+    }
+    lines.push("", REVIEW_MARKER);
+    return {
+        event: "COMMENT",
+        body: lines.join("\n"),
+        comments: inline.map((f) => ({ path: f.path, line: f.line, side: "RIGHT", body: renderFindingBody(f) })),
+    };
+}
+//# sourceMappingURL=review-contract.js.map

package/dist/review-contract.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-contract.js","sourceRoot":"","sources":["../src/review-contract.ts"],"names":[],"mappings":"AAAA,yEAAyE;AACzE,0EAA0E;AAC1E,+EAA+E;AAC/E,2EAA2E;AAM3E,uEAAuE;AACvE,MAAM,UAAU,aAAa,CAAC,QAAgB;IAC5C,QAAQ,QAAQ,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,CAAC;QACtC,KAAK,UAAU,CAAC,CAAC,OAAO,iBAAiB,CAAC;QAC1C,KAAK,MAAM,CAAC,CAAC,OAAO,aAAa,CAAC;QAClC,KAAK,KAAK,CAAC,CAAC,OAAO,YAAY,CAAC;QAChC,OAAO,CAAC,CAAC,OAAO,eAAe,CAAC;IAClC,CAAC;AACH,CAAC;AAED,0EAA0E;AAC1E,MAAM,UAAU,SAAS,CAAC,MAAe;IACvC,QAAQ,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,CAAC;QAC5C,KAAK,OAAO,CAAC,CAAC,OAAO,gBAAgB,CAAC;QACtC,KAAK,UAAU,CAAC,CAAC,OAAO,gBAAgB,CAAC;QACzC,OAAO,CAAC,CAAC,OAAO,EAAE,CAAC;IACrB,CAAC;AACH,CAAC;AAED,iFAAiF;AACjF,MAAM,UAAU,aAAa,CAAC,OAAgB;IAC5C,QAAQ,OAAO,EAAE,CAAC;QAChB,KAAK,SAAS,CAAC,CAAC,OAAO,iCAAiC,CAAC;QACzD,KAAK,iBAAiB,CAAC,CAAC,OAAO,4CAA4C,CAAC;QAC5E,KAAK,QAAQ,CAAC,CAAC,OAAO,gCAAgC,CAAC;QACvD,OAAO,CAAC,CAAC,OAAO,mCAAmC,CAAC;IACtD,CAAC;AACH,CAAC;AAcD,MAAM,aAAa,GAAG,+BAA+B,CAAC;AAEtD;2EAC2E;AAC3E,MAAM,UAAU,iBAAiB,CAAC,CAAgB;IAChD,IAAI,CAAC,GAAG,GAAG,aAAa,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,SAAS,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,CAAC;IACxE,IAAI,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE;QAAE,CAAC,IAAI,OAAO,CAAC,CAAC,GAAG,CAAC,IAAI,EAAE,EAAE,CAAC;IAC9C,IAAI,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE;QAAE,CAAC,IAAI,gBAAgB,CAAC,CAAC,GAAG,CAAC,IAAI,EAAE,EAAE,CAAC;IACvD,MAAM,GAAG,GAAG,CAAC,CAAC,CAAC,UAAU,IAAI,EAAE,CAAC,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IACrD,MAAM,IAAI,GAAG,CAAC,CAAC,CAAC,IAAI,IAAI,EAAE,CAAC,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IAChD,IAAI,GAAG,CAAC,IAAI,EAAE;QAAE,CAAC,IAAI,uBAAuB,GAAG,UAAU,CAAC;SACrD,IAAI,IAAI,CAAC,IAAI,EAAE;QAAE,CAAC,IAAI,aAAa,IAAI,UAAU,CAAC;IACvD,OAAO,GAAG,CAAC,OAAO,aAAa,EAAE,CAAC;AACpC,CAAC;AAED;;4EAE4E;AAC5E,MAAM,UAAU,QAAQ,CAAC,CAAS;IAChC,OAAO,CAAC,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;AAC3D,CAAC;AAED,MAAM,OAAO,GAAG,uCAAuC,CAAC;AACxD,MAAM,OAAO,GAAG,kBAAkB,CAAC;AAEnC;;+EAE+E;AAC/E,MAAM,UAAU,WAAW,CAAC,IAAY;IACtC,MAAM,GAAG,GAAG,IAAI,GAAG,EAAuB,CAAC;IAC3C,IAAI,IAAI,GAAG,EAAE,CAAC;IACd,IAAI,EAAE,GAAG,CAAC,CAAC;IACX,KAAK,MAAM,GAAG,IAAI,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC;QACtC,MAAM,EAAE,GAAG,OAAO,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAC7B,IAAI,EAAE,EAAE,CAAC;YAAC,IAAI,GAAG,QAAQ,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;YAAC,EAAE,GAAG,CAAC,CAAC;YAAC,SAAS;QAAC,CAAC;QACrD,MAAM,EAAE,GAAG,OAAO,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAC7B,IAAI,EAAE,EAAE,CAAC;YAAC,EAAE,GAAG,QAAQ,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAAC,SAAS;QAAC,CAAC;QAC/C,IAAI,CAAC,IAAI,IAAI,EAAE,KAAK,CAAC;YAAE,SAAS;QAChC,IAAI,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC;YAAE,SAAS,CAAe,8BAA8B;QAC/E,IAAI,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;YAC/C,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,IAAI,CAAC;gBAAE,GAAG,CAAC,GAAG,CAAC,IAAI,EAAE,IAAI,GAAG,EAAE,CAAC,CAAC;YAC7C,GAAG,CAAC,GAAG,CAAC,IAAI,CAAE,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YACvB,EAAE,EAAE,CAAC;QACP,CAAC;IACH,CAAC;IACD,OAAO,GAAG,CAAC;AACb,CAAC;AAED;+EAC+E;AAC/E,MAAM,UAAU,eAAe,CAC7B,QAAyB,EACzB,OAAiC;IAEjC,MAAM,MAAM,GAAoB,EAAE,CAAC;IACnC,MAAM,IAAI,GAAoB,EAAE,CAAC;IACjC,KAAK,MAAM,CAAC,IAAI,QAAQ,EAAE,CAAC;QACzB,IAAI,CAAC,CAAC,IAAI,GAAG,CAAC,IAAI,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC;YAAE,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;;YACxE,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IACpB,CAAC;IACD,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC;AAC1B,CAAC;AAKD;;;kFAGkF;AAClF,MAAM,UAAU,kBAAkB,CAAC,IAKlC;IACC,MAAM,EAAE,MAAM,EAAE,IAAI,EAAE,UAAU,EAAE,GAAG,eAAe,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;IAClF,MAAM,KAAK,GAAa,CAAC,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC;IACtD,IAAI,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE;QAAE,KAAK,CAAC,IAAI,CAAC,EAAE,EAAE,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,CAAC;IAC7D,IAAI,UAAU,CAAC,MAAM,EAAE,CAAC;QACtB,KAAK,CAAC,IAAI,CAAC,EAAE,EAAE,0DAA0D,CAAC,CAAC;QAC3E,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;YAC3B,MAAM,MAAM,GAAG,CAAC,CAAC,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;YAC3D,MAAM,OAAO,GAAG,iBAAiB,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,GAAG,aAAa,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;YAClF,KAAK,CAAC,IAAI,CAAC,OAAO,MAAM,QAAQ,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;YAC9C,yEAAyE;YACzE,wEAAwE;YACxE,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC,EAAE;gBAAE,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;QAC3F,CAAC;IACH,CAAC;IACD,KAAK,CAAC,IAAI,CAAC,EAAE,EAAE,aAAa,CAAC,CAAC;IAC9B,OAAO;QACL,KAAK,EAAE,SAAS;QAChB,IAAI,EAAE,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;QACtB,QAAQ,EAAE,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,EAAE,IAAI,EAAE,iBAAiB,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;KACzG,CAAC;AACJ,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@renaiss-shipflow/cli",
-  "version": "0.10.0",
+  "version": "0.11.0",
   "description": "CLI tool for RenaissShipFlow - AI-powered project management automation",
   "type": "module",
   "bin": {