@remotion/studio-server 4.0.466 → 4.0.467

package/dist/codemods/update-effect-props/update-effect-props.d.ts

@@ -1,5 +1,5 @@
 import type { ArrayExpression, CallExpression, JSXAttribute } from '@babel/types';
-import type { SequenceNodePath } from 'remotion';
+import type { SequenceNodePath, SequenceSchema } from 'remotion';
 export type EffectPropUpdate = {
     key: string;
     value: unknown;
@@ -11,6 +11,11 @@ export type UpdateEffectPropsResult = {
     oldValueString: string;
     logLine: number;
     effectCallee: string;
+    removedProps: PropDelta[];
+};
+export type PropDelta = {
+    key: string;
+    valueString: string;
 };
 export declare const findEffectsAttr: (attrs: readonly unknown[]) => JSXAttribute | null;
 export type EffectArrayElement = {
@@ -33,21 +38,24 @@ export declare const findEffectCallExpression: ({ attr, effectIndex, }: {
     kind: "error";
     reason: "not-call-expression" | "not-found";
 };
-export declare const updateEffectPropsAst: ({ input, sequenceNodePath, effectIndex, update, }: {
+export declare const updateEffectPropsAst: ({ input, sequenceNodePath, effectIndex, update, schema, }: {
     input: string;
     sequenceNodePath: SequenceNodePath;
     effectIndex: number;
     update: EffectPropUpdate;
+    schema: SequenceSchema;
 }) => {
     serialized: string;
     oldValueString: string;
     logLine: number;
     effectCallee: string;
+    removedProps: PropDelta[];
 };
-export declare const updateEffectProps: ({ input, sequenceNodePath, effectIndex, update, prettierConfigOverride, }: {
+export declare const updateEffectProps: ({ input, sequenceNodePath, effectIndex, update, schema, prettierConfigOverride, }: {
     input: string;
     sequenceNodePath: SequenceNodePath;
     effectIndex: number;
     update: EffectPropUpdate;
+    schema: SequenceSchema;
     prettierConfigOverride?: Record<string, unknown> | null | undefined;
 }) => Promise<UpdateEffectPropsResult>;

package/dist/codemods/update-effect-props/update-effect-props.js

@@ -36,6 +36,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.updateEffectProps = exports.updateEffectPropsAst = exports.findEffectCallExpression = exports.enumerateEffectArrayElements = exports.findEffectsAttr = void 0;
 const studio_shared_1 = require("@remotion/studio-shared");
 const recast = __importStar(require("recast"));
+const no_react_1 = require("remotion/no-react");
 const can_update_sequence_props_1 = require("../../preview-server/routes/can-update-sequence-props");
 const format_file_content_1 = require("../format-file-content");
 const parse_ast_1 = require("../parse-ast");
@@ -132,7 +133,24 @@ const findObjectProperty = (objExpr, propertyName) => {
             : undefined,
     };
 };
-const updateEffectPropsAst = ({ input, sequenceNodePath, effectIndex, update, }) => {
+const printObjectPropertyValue = (prop) => recast
+    .print(prop.value)
+    .code.replace(/[\n\r\t]+/g, ' ')
+    .replace(/,(\s*[}\]])/g, '$1')
+    .trim();
+const removeObjectProperty = ({ objExpr, propertyName, }) => {
+    const { propIndex, prop } = findObjectProperty(objExpr, propertyName);
+    if (!prop || propIndex === -1) {
+        return null;
+    }
+    const valueString = printObjectPropertyValue(prop);
+    objExpr.properties.splice(propIndex, 1);
+    return {
+        key: propertyName,
+        valueString,
+    };
+};
+const updateEffectPropsAst = ({ input, sequenceNodePath, effectIndex, update, schema, }) => {
     var _a, _b, _c, _d;
     var _e, _f, _g, _h, _j;
     const ast = (0, parse_ast_1.parseAst)(input);
@@ -162,6 +180,7 @@ const updateEffectPropsAst = ({ input, sequenceNodePath, effectIndex, update, })
                 oldValueString: '',
                 logLine: (_g = (_f = (_a = call.loc) === null || _a === void 0 ? void 0 : _a.start.line) !== null && _f !== void 0 ? _f : (_b = jsx.loc) === null || _b === void 0 ? void 0 : _b.start.line) !== null && _g !== void 0 ? _g : 1,
                 effectCallee,
+                removedProps: [],
             };
         }
         objExpr = b.objectExpression([]);
@@ -174,6 +193,7 @@ const updateEffectPropsAst = ({ input, sequenceNodePath, effectIndex, update, })
         objExpr = call.arguments[0];
     }
     const { prop } = findObjectProperty(objExpr, update.key);
+    const removedProps = [];
     let oldValueString = '';
     if (prop) {
         oldValueString = recast.print(prop.value).code;
@@ -198,21 +218,40 @@ const updateEffectPropsAst = ({ input, sequenceNodePath, effectIndex, update, })
             objExpr.properties.push(b.objectProperty(b.identifier(update.key), newValueExpr));
         }
     }
+    const fieldSchema = schema[update.key];
+    if (fieldSchema && fieldSchema.type === 'enum') {
+        const propsToDelete = no_react_1.NoReactInternals.findPropsToDelete({
+            schema,
+            key: update.key,
+            value: update.value,
+        });
+        for (const propToDelete of propsToDelete) {
+            const removed = removeObjectProperty({
+                objExpr,
+                propertyName: propToDelete,
+            });
+            if (removed) {
+                removedProps.push(removed);
+            }
+        }
+    }
     const logLine = (_j = (_h = (_c = call.loc) === null || _c === void 0 ? void 0 : _c.start.line) !== null && _h !== void 0 ? _h : (_d = jsx.loc) === null || _d === void 0 ? void 0 : _d.start.line) !== null && _j !== void 0 ? _j : 1;
     return {
         serialized: (0, parse_ast_1.serializeAst)(ast),
         oldValueString,
         logLine,
         effectCallee,
+        removedProps,
     };
 };
 exports.updateEffectPropsAst = updateEffectPropsAst;
-const updateEffectProps = async ({ input, sequenceNodePath, effectIndex, update, prettierConfigOverride, }) => {
-    const { serialized, oldValueString, logLine, effectCallee } = (0, exports.updateEffectPropsAst)({
+const updateEffectProps = async ({ input, sequenceNodePath, effectIndex, update, schema, prettierConfigOverride, }) => {
+    const { serialized, oldValueString, logLine, effectCallee, removedProps } = (0, exports.updateEffectPropsAst)({
         input,
         sequenceNodePath,
         effectIndex,
         update,
+        schema,
     });
     const { output, formatted } = await (0, format_file_content_1.formatFileContent)({
         input: serialized,
@@ -224,6 +263,7 @@ const updateEffectProps = async ({ input, sequenceNodePath, effectIndex, update,
         formatted,
         logLine,
         effectCallee,
+        removedProps,
     };
 };
 exports.updateEffectProps = updateEffectProps;

package/dist/preview-server/routes/save-effect-props.js

@@ -28,7 +28,7 @@ const saveEffectPropsHandler = ({ input: { fileName, sequenceNodePath, effectInd
     }
     const fileContents = (0, node_fs_1.readFileSync)(absolutePath, 'utf-8');
     const parsedDefault = defaultValue !== null ? JSON.parse(defaultValue) : null;
-    const { output, oldValueString, formatted, logLine, effectCallee } = await (0, update_effect_props_1.updateEffectProps)({
+    const { output, oldValueString, formatted, logLine, effectCallee, removedProps, } = await (0, update_effect_props_1.updateEffectProps)({
         input: fileContents,
         sequenceNodePath: sequenceNodePath.nodePath,
         effectIndex,
@@ -37,11 +37,16 @@ const saveEffectPropsHandler = ({ input: { fileName, sequenceNodePath, effectInd
             value: JSON.parse(value),
             defaultValue: parsedDefault,
         },
+        schema,
     });
     const defaultValueString = parsedDefault !== null ? JSON.stringify(parsedDefault) : null;
     const normalizedOld = (0, log_update_1.normalizeQuotes)(oldValueString);
     const normalizedNew = (0, log_update_1.normalizeQuotes)(value);
     const normalizedDefault = defaultValueString !== null ? (0, log_update_1.normalizeQuotes)(defaultValueString) : null;
+    const normalizedRemovedProps = removedProps.map((prop) => ({
+        ...prop,
+        valueString: (0, log_update_1.normalizeQuotes)(prop.valueString),
+    }));
     const undoPropChange = (0, format_effect_prop_change_1.formatEffectPropChange)({
         effectName: effectCallee,
         key,
@@ -49,7 +54,7 @@ const saveEffectPropsHandler = ({ input: { fileName, sequenceNodePath, effectInd
         newValueString: normalizedOld,
         defaultValueString: normalizedDefault,
         removedProps: [],
-        addedProps: [],
+        addedProps: normalizedRemovedProps,
     });
     const redoPropChange = (0, format_effect_prop_change_1.formatEffectPropChange)({
         effectName: effectCallee,
@@ -57,7 +62,7 @@ const saveEffectPropsHandler = ({ input: { fileName, sequenceNodePath, effectInd
         oldValueString: normalizedOld,
         newValueString: normalizedNew,
         defaultValueString: normalizedDefault,
-        removedProps: [],
+        removedProps: normalizedRemovedProps,
         addedProps: [],
     });
     (0, undo_stack_1.pushToUndoStack)({
@@ -86,7 +91,7 @@ const saveEffectPropsHandler = ({ input: { fileName, sequenceNodePath, effectInd
         defaultValueString,
         formatted,
         logLevel,
-        removedProps: [],
+        removedProps,
         addedProps: [],
     });
     (0, undo_stack_1.printUndoHint)(logLevel);

package/package.json

@@ -3,7 +3,7 @@
 		"url": "https://github.com/remotion-dev/remotion/tree/main/packages/studio-server"
 	},
 	"name": "@remotion/studio-server",
-	"version": "4.0.466",
+	"version": "4.0.467",
 	"description": "Run a Remotion Studio with a server backend",
 	"main": "dist",
 	"scripts": {
@@ -27,11 +27,11 @@
 		"@babel/parser": "7.24.1",
 		"semver": "7.5.3",
 		"prettier": "3.8.1",
-		"remotion": "4.0.466",
+		"remotion": "4.0.467",
 		"recast": "0.23.11",
-		"@remotion/bundler": "4.0.466",
-		"@remotion/renderer": "4.0.466",
-		"@remotion/studio-shared": "4.0.466",
+		"@remotion/bundler": "4.0.467",
+		"@remotion/renderer": "4.0.467",
+		"@remotion/studio-shared": "4.0.467",
 		"memfs": "3.4.3",
 		"open": "8.4.2"
 	},
@@ -39,7 +39,7 @@
 		"ast-types": "0.16.1",
 		"react": "19.2.3",
 		"@types/semver": "7.5.3",
-		"@remotion/eslint-config-internal": "4.0.466",
+		"@remotion/eslint-config-internal": "4.0.467",
 		"eslint": "9.19.0",
 		"@types/node": "20.12.14",
 		"@typescript/native-preview": "7.0.0-dev.20260217.1"