@remoteoss/json-schema-form 0.4.3-beta.0 → 0.4.4-beta.0

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+#### 0.4.4-beta.0 (2023-08-30)
+
+##### Chores
+
+* **fieldset:**  ignore values not matching the field type ([#44](https://github.com/remoteoss/json-schema-form/pull/44)) ([f0af54e5](https://github.com/remoteoss/json-schema-form/commit/f0af54e5d425fb78524ab150bb31629d00369a61))
+
 #### 0.4.3-beta.0 (2023-08-09)
 
 ##### Bug fixes

package/dist/index.cjs

@@ -1,8 +1,8 @@
 
 /*!
  Copyright (c) 2023 Remote Technology, Inc.
- NPM Package: @remoteoss/json-schema-form@0.4.3-beta.0
- Generated: Wed, 09 Aug 2023 08:39:30 GMT
+ NPM Package: @remoteoss/json-schema-form@0.4.4-beta.0
+ Generated: Wed, 30 Aug 2023 17:33:30 GMT
 
  MIT License
 
@@ -749,7 +749,16 @@ function getPrefillSubFieldValues(field, defaultValues, parentFieldKeyPath) {
       initialValue[field.name] = subFieldValues;
     }
   } else {
-    initialValue = getPrefillValues([field], initialValue);
+    if (typeof initialValue !== "object") {
+      console.warn(
+        `Field "${parentFieldKeyPath}"'s value is "${initialValue}", but should be type object.`
+      );
+      initialValue = getPrefillValues([field], {
+        // TODO nested fieldsets are not handled
+      });
+    } else {
+      initialValue = getPrefillValues([field], initialValue);
+    }
   }
   return initialValue;
 }

package/dist/index.js

@@ -1,8 +1,8 @@
 
 /*!
  Copyright (c) 2023 Remote Technology, Inc.
- NPM Package: @remoteoss/json-schema-form@0.4.3-beta.0
- Generated: Wed, 09 Aug 2023 08:39:30 GMT
+ NPM Package: @remoteoss/json-schema-form@0.4.4-beta.0
+ Generated: Wed, 30 Aug 2023 17:33:30 GMT
 
  MIT License
 
@@ -713,7 +713,16 @@ function getPrefillSubFieldValues(field, defaultValues, parentFieldKeyPath) {
       initialValue[field.name] = subFieldValues;
     }
   } else {
-    initialValue = getPrefillValues([field], initialValue);
+    if (typeof initialValue !== "object") {
+      console.warn(
+        `Field "${parentFieldKeyPath}"'s value is "${initialValue}", but should be type object.`
+      );
+      initialValue = getPrefillValues([field], {
+        // TODO nested fieldsets are not handled
+      });
+    } else {
+      initialValue = getPrefillValues([field], initialValue);
+    }
   }
   return initialValue;
 }

package/dist/standalone.js

@@ -1,8 +1,8 @@
 
 /*!
  Copyright (c) 2023 Remote Technology, Inc.
- NPM Package: @remoteoss/json-schema-form@0.4.3-beta.0
- Generated: Wed, 09 Aug 2023 08:39:30 GMT
+ NPM Package: @remoteoss/json-schema-form@0.4.4-beta.0
+ Generated: Wed, 30 Aug 2023 17:33:30 GMT
 
  MIT License
 
@@ -11689,7 +11689,16 @@ function getPrefillSubFieldValues(field, defaultValues, parentFieldKeyPath) {
       initialValue[field.name] = subFieldValues;
     }
   } else {
-    initialValue = getPrefillValues([field], initialValue);
+    if (typeof initialValue !== "object") {
+      console.warn(
+        `Field "${parentFieldKeyPath}"'s value is "${initialValue}", but should be type object.`
+      );
+      initialValue = getPrefillValues([field], {
+        // TODO nested fieldsets are not handled
+      });
+    } else {
+      initialValue = getPrefillValues([field], initialValue);
+    }
   }
   return initialValue;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remoteoss/json-schema-form",
-  "version": "0.4.3-beta.0",
+  "version": "0.4.4-beta.0",
   "description": "Headless UI form powered by JSON Schemas",
   "author": "Remote.com <engineering@remote.com> (https://remote.com/)",
   "license": "MIT",

package/src/tests/createHeadlessForm.test.js

@@ -18,6 +18,7 @@ import {
   schemaInputTypeSelectMultipleDeprecated,
   schemaInputTypeSelectMultiple,
   schemaInputTypeSelectMultipleOptional,
+  schemaInputTypeFieldset,
   schemaInputTypeNumber,
   schemaInputTypeNumberZeroMaximum,
   schemaInputTypeDate,
@@ -92,12 +93,15 @@ const getField = (fields, name, ...subNames) => {
 };
 
 beforeEach(() => {
+  jest.spyOn(console, 'warn').mockImplementation(() => {});
   jest.spyOn(console, 'error').mockImplementation(() => {});
 });
 
 afterEach(() => {
   expect(console.error).not.toHaveBeenCalled();
   console.error.mockRestore();
+  expect(console.warn).not.toHaveBeenCalled();
+  console.warn.mockRestore();
 });
 
 describe('createHeadlessForm', () => {
@@ -3446,6 +3450,27 @@ describe('createHeadlessForm', () => {
           ],
         });
       });
+
+      it('should ignore initial values that do not match the field type (eg string vs object)', () => {
+        const result = createHeadlessForm(schemaInputTypeFieldset, {
+          initialValues: {
+            a_fieldset: 'foo', // should be an object instead of string
+          },
+        });
+
+        // It returns fields without errors
+        expect(result.fields).toBeDefined();
+        expect(result.fields[0].fields[0].name).toBe('id_number');
+        expect(result.fields[0].fields[1].name).toBe('tabs');
+
+        // Warn about those missmatched values
+        expect(console.warn).toHaveBeenCalledWith(
+          `Field "a_fieldset"'s value is "foo", but should be type object.`
+        );
+        console.warn.mockClear();
+
+        expect(console.error).not.toHaveBeenCalled();
+      });
     });
   });
 

package/src/tests/helpers.js

@@ -1020,12 +1020,12 @@ export const schemaInputTypeFileWithSkippable = JSONSchemaBuilder()
   })
   .build();
 
-export const schemaInputTypeFieldset = JSONSchemaBuilder()
-  .addInput({
+export const schemaInputTypeFieldset = {
+  properties: {
     a_fieldset: mockFieldset,
-  })
-  .setRequiredFields(['a_fieldset'])
-  .build();
+  },
+  required: ['a_fieldset'],
+};
 
 export const schemaInputTypeFocusedFieldset = JSONSchemaBuilder()
   .addInput({