@remnic/plugin-codex 9.51.0 → 9.52.0

package/.codex-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "remnic",
   "description": "Universal memory for AI agents — automatic recall, observation, and cross-agent knowledge sharing",
-  "version": "9.51.0",
+  "version": "9.52.0",
   "author": {
     "name": "Joshua Warren",
     "url": "https://github.com/joshuaswarren"

package/README.md

@@ -31,7 +31,7 @@ The package is **data + one small runtime materializer** (no runtime JS beyond t
 | File / dir | Purpose |
 |---|---|
 | `.codex-plugin/plugin.json` | Plugin manifest |
-| `hooks/hooks.json` + `hooks/bin/remnic-codex-hook.{cjs,sh,ps1}` | Codex session-lifecycle hooks (recall, observe, session-end, **pre-compact LCM flush**). A single cross-platform Node.js runner (`.cjs`) with thin POSIX (`.sh`) and Windows PowerShell (`.ps1`) launchers; `hooks.json` wires each event with both `command` and `commandWindows` so hooks work on macOS, Linux, and Windows. |
+| `hooks/hooks.json` + `hooks/bin/remnic-codex-hook.{cjs,sh,ps1}` | Codex session hooks for recall, observe, session end, and pre-compact LCM flush. `hooks.json` invokes the POSIX launcher through `sh`, so hooks still run when an install path does not preserve its executable mode. Windows uses the PowerShell launcher. |
 | `skills/` | `remnic-recall`, `remnic-remember`, `remnic-search`, `remnic-status`, `remnic-entities`, `remnic-memory-workflow` — invocable from Codex chats |
 | `memories_extensions/remnic/` | Codex phase-2 consolidation instructions — tells the Codex compactor sub-agent to treat Remnic's on-disk Markdown as an authoritative local memory source when it builds `MEMORY.md`. Local-only (no MCP, no network); runtime recall/observe still flow through the hooks above. |
 | `.mcp.json` | MCP server config pointing Codex at `http://localhost:4318/mcp` |
@@ -132,10 +132,10 @@ the foreground path reads it.
 
 Codex does not run non-managed command hooks until a human reviews and trusts
 them. The first time these hooks are enabled, Codex prints a startup warning
-directing you to run `/hooks` in the CLI; review the four Remnic entries
-(SessionStart / UserPromptSubmit / Stop / PreCompact) and approve them. Codex
-records trust against the current hook hash, so updates to `hooks.json` will
-re-trigger a review.
+directing you to run `/hooks` in the CLI. Review the five Remnic entries
+(SessionStart, PostToolUse, UserPromptSubmit, Stop, and PreCompact), then
+approve them. Codex records trust against the current hook hash, so updates
+to `hooks.json` will trigger a new review.
 
 For fleet / headless automation there is no non-interactive trust CLI today;
 pick one of:

package/hooks/bin/remnic-codex-hook.test.cjs

@@ -351,26 +351,25 @@ test("unknown event fails open with continue", async () => {
 
 // ── #1443 review fixes ──────────────────────────────────────────────────────
 
-test("hooks.json: every event resolves via ${PLUGIN_ROOT} and uses powershell (#1443 review)", () => {
+const POSIX_HOOK_EVENTS = Object.freeze({
+  SessionStart: "session-start",
+  PostToolUse: "post-tool-observe",
+  UserPromptSubmit: "user-prompt-recall",
+  Stop: "session-end",
+  PreCompact: "pre-compact",
+});
+
+test("hooks.json: every POSIX event invokes the correct launcher event through sh", () => {
   const cfg = JSON.parse(
     fs.readFileSync(path.join(__dirname, "..", "hooks.json"), "utf8"),
   );
-  for (const event of ["SessionStart", "PostToolUse", "UserPromptSubmit", "Stop", "PreCompact"]) {
+  for (const [event, runnerEvent] of Object.entries(POSIX_HOOK_EVENTS)) {
     for (const matcher of cfg.hooks[event]) {
       for (const hook of matcher.hooks) {
-        // Codex runs plugin hooks from the session cwd via sh -lc / cmd /C and
-        // substitutes ${PLUGIN_ROOT} (openai/codex discovery.rs + command_runner.rs),
-        // so the path must be PLUGIN_ROOT-relative AND quoted — an unquoted path
-        // would word-split on a plugin root containing spaces (e.g.
-        // C:\Users\Jane Doe).
-        assert.ok(
-          hook.command.startsWith('"${PLUGIN_ROOT}/hooks/bin/'),
-          `${event}.command must resolve via a quoted \${PLUGIN_ROOT}, got: ${hook.command}`,
-        );
-        assert.match(
+        assert.equal(
           hook.command,
-          /^"\$\{PLUGIN_ROOT\}\/hooks\/bin\/remnic-codex-hook\.sh"\s/,
-          `${event}.command path must be wrapped in double quotes`,
+          `sh "\${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh" ${runnerEvent}`,
+          `${event}.command must invoke the matching runner event through sh`,
         );
         assert.ok(hook.commandWindows, `${event} must declare commandWindows`);
         assert.match(
@@ -378,8 +377,6 @@ test("hooks.json: every event resolves via ${PLUGIN_ROOT} and uses powershell (#
           /-File "\$\{PLUGIN_ROOT\}\\hooks\\bin\\remnic-codex-hook\.ps1"\s/,
           `${event}.commandWindows must pass a quoted \${PLUGIN_ROOT} -File path`,
         );
-        // Use `powershell` not `pwsh` so stock Windows 10/11 works without
-        // PowerShell 7 installed (#1443 review).
         assert.match(
           hook.commandWindows,
           /^powershell\b/,
@@ -390,6 +387,67 @@ test("hooks.json: every event resolves via ${PLUGIN_ROOT} and uses powershell (#
   }
 });
 
+test(
+  "hooks.json: every POSIX command runs a packaged launcher without executable mode",
+  { skip: process.platform === "win32" },
+  async () => {
+    const home = mkHome();
+    try {
+      const pluginRoot = path.join(home, "plugin root");
+      const binDir = path.join(pluginRoot, "hooks", "bin");
+      fs.mkdirSync(binDir, { recursive: true });
+      for (const file of ["remnic-codex-hook.sh", "remnic-codex-hook.cjs"]) {
+        fs.copyFileSync(path.join(__dirname, file), path.join(binDir, file));
+      }
+      fs.chmodSync(path.join(binDir, "remnic-codex-hook.sh"), 0o644);
+
+      const cfg = JSON.parse(
+        fs.readFileSync(path.join(__dirname, "..", "hooks.json"), "utf8"),
+      );
+      const runCommand = (command, sessionId) => new Promise((resolve, reject) => {
+        const child = spawn("sh", ["-c", command], {
+          env: {
+            ...process.env,
+            HOME: home,
+            USERPROFILE: home,
+            XDG_STATE_HOME: path.join(home, "state"),
+            PLUGIN_ROOT: pluginRoot,
+            REMNIC_CODEX_MATERIALIZE: "0",
+            OPENCLAW_REMNIC_ACCESS_TOKEN: "",
+            OPENCLAW_ENGRAM_ACCESS_TOKEN: "",
+            REMNIC_AUTH_TOKEN: "",
+            ENGRAM_AUTH_TOKEN: "",
+            REMNIC_HOOK_TOKEN: "",
+            REMNIC_DAEMON_URL: "",
+            ENGRAM_DAEMON_URL: "",
+          },
+          stdio: ["pipe", "pipe", "pipe"],
+        });
+        let stdout = "";
+        let stderr = "";
+        child.stdout.on("data", (data) => {
+          stdout += data;
+        });
+        child.stderr.on("data", (data) => {
+          stderr += data;
+        });
+        child.stdin.end(JSON.stringify({ session_id: sessionId, cwd: home }));
+        child.on("error", reject);
+        child.on("close", (exitCode) => resolve({ exitCode, stdout, stderr }));
+      });
+
+      for (const [event, runnerEvent] of Object.entries(POSIX_HOOK_EVENTS)) {
+        const command = cfg.hooks[event][0].hooks[0].command;
+        const result = await runCommand(command, `${runnerEvent}-mode-test`);
+        assert.equal(result.exitCode, 0, `${event}: ${result.stderr}`);
+        assert.equal(JSON.parse(result.stdout).continue, true, event);
+      }
+    } finally {
+      fs.rmSync(home, { recursive: true, force: true });
+    }
+  },
+);
+
 test("runner source: remnic→engram fallthrough is PATH-gated and Windows-shim aware (#1443 review)", () => {
   const src = fs.readFileSync(path.join(__dirname, "remnic-codex-hook.cjs"), "utf8");
   // Both the migration and daemon-start loops pre-check PATH with onPath()

package/hooks/hooks.json

@@ -6,7 +6,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "\"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" session-start",
+            "command": "sh \"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" session-start",
             "commandWindows": "powershell -NoProfile -ExecutionPolicy Bypass -File \"${PLUGIN_ROOT}\\hooks\\bin\\remnic-codex-hook.ps1\" session-start",
             "timeout": 45
           }
@@ -19,7 +19,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "\"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" post-tool-observe",
+            "command": "sh \"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" post-tool-observe",
             "commandWindows": "powershell -NoProfile -ExecutionPolicy Bypass -File \"${PLUGIN_ROOT}\\hooks\\bin\\remnic-codex-hook.ps1\" post-tool-observe",
             "timeout": 10
           }
@@ -32,7 +32,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "\"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" user-prompt-recall",
+            "command": "sh \"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" user-prompt-recall",
             "commandWindows": "powershell -NoProfile -ExecutionPolicy Bypass -File \"${PLUGIN_ROOT}\\hooks\\bin\\remnic-codex-hook.ps1\" user-prompt-recall",
             "timeout": 20
           }
@@ -45,7 +45,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "\"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" session-end",
+            "command": "sh \"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" session-end",
             "commandWindows": "powershell -NoProfile -ExecutionPolicy Bypass -File \"${PLUGIN_ROOT}\\hooks\\bin\\remnic-codex-hook.ps1\" session-end",
             "timeout": 30
           }
@@ -58,7 +58,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "\"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" pre-compact",
+            "command": "sh \"${PLUGIN_ROOT}/hooks/bin/remnic-codex-hook.sh\" pre-compact",
             "commandWindows": "powershell -NoProfile -ExecutionPolicy Bypass -File \"${PLUGIN_ROOT}\\hooks\\bin\\remnic-codex-hook.ps1\" pre-compact",
             "timeout": 90
           }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remnic/plugin-codex",
-  "version": "9.51.0",
+  "version": "9.52.0",
   "description": "Remnic memory plugin for Codex CLI — hooks, skills, MCP integration",
   "type": "module",
   "license": "MIT",
@@ -30,6 +30,6 @@
     ".mcp.json"
   ],
   "dependencies": {
-    "@remnic/core": "^9.51.0"
+    "@remnic/core": "^9.52.0"
   }
 }