@remnic/core 9.6.1 → 9.6.2

package/src/access-service.ts

@@ -180,7 +180,7 @@ import type {
   EntityFile,
   MemoryFile,
   MemoryActionOutcome,
-  CodingContext,
+  CodingContext, SourceConnectorProvenance,
   MemoryActionType,
   MemoryLifecycleEvent,
   MemoryStatus,
@@ -1019,7 +1019,7 @@ export interface EngramAccessObserveMessage {
   sourceFormat?: MessagePartSourceFormat;
 }
 
-export interface EngramAccessObserveRequest {
+export interface EngramAccessObserveRequest extends SourceConnectorProvenance {
   sessionKey: string;
   messages: EngramAccessObserveMessage[];
   namespace?: string;
@@ -2961,6 +2961,7 @@ export class EngramAccessService {
         entityRef: request.entityRef,
         ttl: request.ttl,
         sourceReason: request.sourceReason,
+        sourceConnector: request.sourceConnector,
       },
       skip: request.dryRun === true,
     });
@@ -2997,6 +2998,7 @@ export class EngramAccessService {
         entityRef: request.entityRef,
         ttl: request.ttl,
         sourceReason: request.sourceReason,
+        sourceConnector: request.sourceConnector,
       },
       skip: request.dryRun === true,
     });
@@ -3061,6 +3063,7 @@ export class EngramAccessService {
   async codegraphTool(
     request: CodegraphSurfaceRequest,
     authenticatedPrincipal?: string,
+    sourceConnector?: string,
   ): Promise<CodegraphSurfaceResponse> {
     const principal = authenticatedPrincipal ?? "default";
     const memoryDir = this.orchestrator.config.memoryDir;
@@ -3097,7 +3100,7 @@ export class EngramAccessService {
         throw new EngramAccessInputError(msg);
       },
       delegateDecisionRecord: async (decisionRequest) => {
-        return this.codingDecision(decisionRequest, authenticatedPrincipal);
+        return this.codingDecision(decisionRequest, authenticatedPrincipal, sourceConnector);
       },
       buildArchitectureCard: async (repoRoot) => {
         return buildArchitectureCard(repoRoot, {
@@ -3125,6 +3128,7 @@ export class EngramAccessService {
   async codingDecision(
     request: DecisionSurfaceRequest,
     authenticatedPrincipal?: string,
+    sourceConnector?: string,
   ): Promise<DecisionSurfaceResponse> {
     return handleCodingDecision(request, {
       codingKnowledge: this.orchestrator.config.codingKnowledge,
@@ -3146,6 +3150,7 @@ export class EngramAccessService {
         return Object.assign(storage, { namespace: ns });
       },
       throwInputError: (msg) => { throw new EngramAccessInputError(msg); },
+      sourceConnector,
     });
   }
 
@@ -3171,6 +3176,7 @@ export class EngramAccessService {
   async codingArchitecture(
     request: ArchitectureSurfaceRequest,
     authenticatedPrincipal?: string,
+    sourceConnector?: string,
   ): Promise<ArchitectureSurfaceResponse> {
     const resolvedConfig = this.orchestrator.config;
     return handleCodingArchitecture(request, {
@@ -3205,6 +3211,7 @@ export class EngramAccessService {
         createVersion,
       ),
       throwInputError: (msg) => { throw new EngramAccessInputError(msg); },
+      sourceConnector,
     });
   }
 
@@ -4056,6 +4063,7 @@ export class EngramAccessService {
         cwd: request.cwd,
         projectTag: request.projectTag,
         effectiveCodingContext: effectiveCodingContext ?? null,
+        sourceConnector: request.sourceConnector,
       },
       beforeExecute: hooks?.enforceWriteQuota,
       execute: () => this.runObserve(request),

package/src/admin/admin-surfaces.ts

@@ -782,6 +782,7 @@ export interface PromotionStorageProvider {
        * back to its origin (matches the runtime extraction pipeline).
        */
       lineage: string[];
+      sourceConnector?: string;
     }
   ): Promise<string>;
 }
@@ -918,6 +919,7 @@ export async function promoteMemory(options: PromoteMemoryOptions): Promise<Memo
         actor: options.actor,
         validAt: sourceMemory.frontmatter.valid_at,
         lineage: [options.sourceMemoryId],
+        ...(sourceMemory.frontmatter.sourceConnector ? { sourceConnector: sourceMemory.frontmatter.sourceConnector } : {}),
       });
       target.promoted = true;
       target.promotedMemoryId = promotedId;

package/src/buffer.ts

@@ -632,6 +632,7 @@ export class SmartBuffer {
           if (typeof t.persistProcessedFingerprint === "boolean") {
             copy.persistProcessedFingerprint = t.persistProcessedFingerprint;
           }
+          if (typeof t.sourceConnector === "string") copy.sourceConnector = t.sourceConnector;
           return copy;
         });
       }
@@ -791,6 +792,9 @@ function copyBufferTurn(turn: BufferTurn): BufferTurn {
   if (typeof turn.persistProcessedFingerprint === "boolean") {
     copy.persistProcessedFingerprint = turn.persistProcessedFingerprint;
   }
+  if (typeof turn.sourceConnector === "string") {
+    copy.sourceConnector = turn.sourceConnector;
+  }
   return copy;
 }
 
@@ -804,7 +808,8 @@ function bufferTurnsEqual(left: BufferTurn | undefined, right: BufferTurn): bool
     left.logicalSessionKey === right.logicalSessionKey &&
     left.providerThreadId === right.providerThreadId &&
     left.turnFingerprint === right.turnFingerprint &&
-    left.persistProcessedFingerprint === right.persistProcessedFingerprint
+    left.persistProcessedFingerprint === right.persistProcessedFingerprint &&
+    left.sourceConnector === right.sourceConnector
   );
 }
 

package/src/bulk-import/types.ts

@@ -3,6 +3,7 @@
 // ---------------------------------------------------------------------------
 
 import { parseIsoOffsetTimestamp } from "../utils/iso-timestamp.js";
+import type { SourceConnectorProvenance } from "../types.js";
 
 export interface BulkImportSource {
   turns: ImportTurn[];
@@ -14,7 +15,7 @@ export interface BulkImportSource {
   };
 }
 
-export interface ImportTurn {
+export interface ImportTurn extends SourceConnectorProvenance {
   role: "user" | "assistant" | "other";
   content: string;
   timestamp: string;

package/src/coding/architecture-surfaces.test.ts

@@ -95,13 +95,13 @@ function makeCardMemory(overrides: {
 interface StubStorage extends ArchitectureSurfaceStorage {
   memories: MemoryFile[];
   written: Array<{ category: string; content: string; options: Record<string, unknown> }>;
-  updated: Array<{ id: string; content: string }>;
+  updated: Array<{ id: string; content: string; options: Record<string, unknown> }>;
 }
 
 function makeStubStorage(initialMemories: MemoryFile[] = []): StubStorage {
   const allMemories: MemoryFile[] = [...initialMemories];
   const written: Array<{ category: string; content: string; options: Record<string, unknown> }> = [];
-  const updated: Array<{ id: string; content: string }> = [];
+  const updated: Array<{ id: string; content: string; options: Record<string, unknown> }> = [];
   return {
     dir: "/synthetic/memory",
     namespace: "default",
@@ -119,10 +119,17 @@ function makeStubStorage(initialMemories: MemoryFile[] = []): StubStorage {
       });
       return { id: id, tombstoneBlocked: false };
     },
-    async updateMemory(id, newContent) {
-      updated.push({ id, content: newContent });
+    async updateMemory(id, newContent, options) {
+      updated.push({ id, content: newContent, options: options ?? {} });
       const m = allMemories.find((mem) => mem.frontmatter.id === id);
-      if (m) m.content = newContent;
+      if (m) {
+        m.content = newContent;
+        // Apply sourceConnector backfill to the in-memory frontmatter so
+        // tests can verify the caller's intent matches what reaches storage.
+        if (options?.sourceConnector) {
+          (m.frontmatter as unknown as Record<string, unknown>).sourceConnector = options.sourceConnector;
+        }
+      }
       return !!m;
     },
   };
@@ -603,3 +610,70 @@ test("MCP surface: remnic.coding_architecture alias dispatches identically", asy
   assert.equal(calls.length, 1, "service.codingArchitecture called exactly once via alias");
   assert.equal(calls[0]?.subcommand, "get");
 });
+
+// ──────────────────────────────────────────────────────────────────────────
+// Regression: sourceConnector provenance through updateMemory (codex finding)
+// ──────────────────────────────────────────────────────────────────────────
+
+test("refresh: updateMemory backfills sourceConnector when connector provided", async () => {
+  // Seed an existing card WITHOUT sourceConnector (pre-provenance card).
+  const storage = makeStubStorage([
+    makeCardMemory({
+      content: "# Old card — pre-provenance",
+      frontmatter: { id: "old-card" },
+    }),
+  ]);
+  const ctx = makeContext({
+    resolveStorage: async () => storage,
+    sourceConnector: "chatgpt",
+  });
+  await handleCodingArchitecture({ subcommand: "refresh", sessionKey: "s1" }, ctx);
+  // updateMemory must have been called with sourceConnector in the options.
+  assert.equal(storage.updated.length, 1, "updateMemory called once");
+  assert.equal(
+    storage.updated[0]!.options.sourceConnector,
+    "chatgpt",
+    "sourceConnector must reach updateMemory options",
+  );
+});
+
+test("refresh: updateMemory omits sourceConnector when no connector in context", async () => {
+  // Existing card, no connector in the context — updateMemory must still
+  // succeed without breaking frontmatter.
+  const storage = makeStubStorage([
+    makeCardMemory({
+      content: "# Existing card",
+      frontmatter: { id: "existing-card" },
+    }),
+  ]);
+  const ctx = makeContext({ resolveStorage: async () => storage });
+  await handleCodingArchitecture({ subcommand: "refresh", sessionKey: "s1" }, ctx);
+  assert.equal(storage.updated.length, 1, "updateMemory called once");
+  assert.equal(
+    storage.updated[0]!.options.sourceConnector,
+    undefined,
+    "no sourceConnector when context has none",
+  );
+});
+
+test("refresh: updateMemory retains existing sourceConnector via frontmatter spread", async () => {
+  // Existing card already HAS sourceConnector — updateMemory's frontmatter
+  // spread preserves it even when the refresh call doesn't pass it again.
+  const storage = makeStubStorage([
+    makeCardMemory({
+      content: "# Card with connector",
+      frontmatter: { id: "connector-card", sourceConnector: "openclaw" },
+    }),
+  ]);
+  const ctx = makeContext({ resolveStorage: async () => storage });
+  const result = await handleCodingArchitecture({ subcommand: "refresh", sessionKey: "s1" }, ctx);
+  if (result.subcommand !== "refresh") return;
+  assert.equal(result.refreshed, true);
+  // The card memory in storage must still have its sourceConnector.
+  const card = storage.memories.find((m) => m.frontmatter.id === "connector-card");
+  assert.equal(
+    card?.frontmatter.sourceConnector,
+    "openclaw",
+    "existing sourceConnector preserved through updateMemory",
+  );
+});

package/src/coding/architecture-surfaces.ts

@@ -158,12 +158,13 @@ export interface ArchitectureSurfaceStorage {
       source?: string;
       status?: MemoryStatus;
       structuredAttributes?: Record<string, string>;
+      sourceConnector?: string;
     },
   ): Promise<MemoryWriteResult>;
   updateMemory(
     id: string,
     newContent: string,
-    options?: { supersedes?: string; lineage?: string[]; actor?: string },
+    options?: { supersedes?: string; lineage?: string[]; actor?: string; sourceConnector?: string },
   ): Promise<boolean>;
 }
 
@@ -205,6 +206,8 @@ export interface ArchitectureSurfaceContext {
   versioning: ArchitectureVersioningHook;
   /** Throw the surface-appropriate input-validation error. */
   throwInputError(message: string): never;
+  /** Server-resolved connector identity for provenance. */
+  readonly sourceConnector?: string;
 }
 
 // ──────────────────────────────────────────────────────────────────────────
@@ -311,6 +314,7 @@ async function architectureRefresh(
     await ctx.versioning.snapshotIfExists(existing);
     const updated = await storage.updateMemory(existing.frontmatter.id, cardContent, {
       actor: "coding-architecture-refresh",
+      ...(ctx.sourceConnector ? { sourceConnector: ctx.sourceConnector } : {}),
     });
     if (!updated) {
       log.warn(
@@ -320,6 +324,7 @@ async function architectureRefresh(
         confidence: 1.0,
         tags,
         source: "coding-architecture",
+        ...(ctx.sourceConnector ? { sourceConnector: ctx.sourceConnector } : {}),
         structuredAttributes: { cardKind: ARCHITECTURE_CARD_KIND },
       });
       log.info(
@@ -344,6 +349,7 @@ async function architectureRefresh(
     confidence: 1.0,
     tags,
     source: "coding-architecture",
+    ...(ctx.sourceConnector ? { sourceConnector: ctx.sourceConnector } : {}),
     structuredAttributes: { cardKind: ARCHITECTURE_CARD_KIND },
   });
   log.info(

package/src/coding/decision-surfaces.test.ts

@@ -73,6 +73,7 @@ function makeMockService(
     codingDecision(
       req: DecisionSurfaceRequest,
       _authenticatedPrincipal?: string,
+      _sourceConnector?: string,
     ): Promise<DecisionSurfaceResponse> {
       calls.push(req);
       return Promise.resolve(response);

package/src/coding/decision-surfaces.ts

@@ -208,6 +208,8 @@ export interface DecisionSurfaceContext {
   resolveStorage(request: DecisionSurfaceRequest): Promise<DecisionSurfaceStorage>;
   /** Throw the surface-appropriate input-validation error. */
   throwInputError(message: string): never;
+  /** Server-resolved connector identity for provenance stamping. */
+  readonly sourceConnector?: string;
 }
 
 /**
@@ -358,6 +360,7 @@ async function decisionRecord(
     //     persist inactive decision statuses in frontmatter).
     structuredAttributes: { decisionStatus: status },
     status: isActive ? undefined : "archived",
+    ...(ctx.sourceConnector ? { sourceConnector: ctx.sourceConnector } : {}),
   });
   log.info(
     `access-write op=coding_decision/record memoryId=${memoryId} status=${status}`,
@@ -419,6 +422,7 @@ async function decisionSupersede(
       // the replacement so list/get projection and QMD indexing see the
       // authoritative marker (review: supersede omits decisionStatus attrs).
       structuredAttributes: { decisionStatus: "accepted" },
+      ...(ctx.sourceConnector ? { sourceConnector: ctx.sourceConnector } : {}),
     },
   );
   if (replacementBlocked) {