@remnic/core 9.45.4 → 9.46.0

package/src/meetings/memory-gen.ts

@@ -28,6 +28,7 @@ import {
   type MeetingsDayFactGenResult,
 } from "./memory-generator.js";
 import { computeTrustScore, decideSmart, type TrustEvidence } from "../wearables/trust.js";
+import { isHighImpactPersonalFact } from "../ambient-provenance.js";
 import { describeErrorForOperator } from "../wearables/errors.js";
 import type { MeetingRecord, MeetingsConfig } from "./types.js";
 
@@ -61,7 +62,10 @@ export function composeMeetingEpisodeContent(record: MeetingRecord): string {
 /**
  * Write the deterministic episode memory for one meeting. Idempotent: skips
  * when an identical episode already exists. Returns true when a new episode was
- * written. The episode is `active` (a recall anchor, not a trust-gated claim).
+ * written. The episode is `active` (a recall anchor, not a trust-gated claim)
+ * UNLESS its provider-derived title is itself a personal claim — that title
+ * comes from the same ambient audio the summary layer already guards, so it
+ * gets the same treatment rather than riding in on the anchor (#2294).
  */
 export async function writeMeetingEpisodeMemory(
   record: MeetingRecord,
@@ -92,10 +96,23 @@ export async function writeMeetingEpisodeMemory(
   if (envelope.salvageNotes.length > 0) {
     log.warn(`meeting episode write salvaged invalid fields: ${envelope.salvageNotes.join("; ")}`);
   }
+  // Two reasons an episode is not a trusted anchor. (1) Only the title is
+  // provider-derived, so the classifier reads the TITLE alone — never our own
+  // deterministic rendering of id, clock, attendees, and sources. (2) An
+  // `audio` detection is a heuristic over speech alone with no corroborating
+  // app span, so fifteen minutes of television with two voices produces an
+  // episode asserting a meeting happened, with the show's speakers listed as
+  // attendees. `app+audio` and `provider` records carry that corroboration and
+  // stay active (#2294).
+  const titleIsPersonalClaim =
+    record.title !== undefined &&
+    record.title.length > 0 &&
+    isHighImpactPersonalFact({ category: "fact", content: record.title });
+  const uncorroboratedDetection = record.detectionSource === "audio";
   await writer.writeSealedMemory(envelope, {
     importance: scoreImportance(content, "moment", [MEETING_SOURCE_PREFIX]),
     contentHashSource: content,
-    status: "active",
+    status: titleIsPersonalClaim || uncorroboratedDetection ? "pending_review" : "active",
     memoryKind: "episode",
   });
   return true;
@@ -241,14 +258,22 @@ function resolveMeetingFactOutcome(
   config: MeetingsConfig,
   trust: number,
   judgeVerdict: "accept" | "reject" | "defer" | undefined,
+  claim: { category: string; content: string },
 ): "active" | "review" | "drop" {
   if (config.summaryMode === "review") {
     return judgeVerdict === "reject" ? "drop" : "review";
   }
-  return decideSmart(trust, judgeVerdict, {
-    autoApproveTrust: config.autoApproveTrust,
-    reviewTrust: config.reviewTrust,
-  }).outcome;
+  // A meeting transcript is the same always-on capture audio a wearable
+  // records, so it carries the same contamination risk — and the extractor
+  // hands decisions and commitments a fixed 0.8 confidence, which clears the
+  // default band on a judge accept alone. A high-impact personal claim tops
+  // out in the review queue here too (#2294).
+  return decideSmart(
+    trust,
+    judgeVerdict,
+    { autoApproveTrust: config.autoApproveTrust, reviewTrust: config.reviewTrust },
+    { capAtReview: isHighImpactPersonalFact(claim) },
+  ).outcome;
 }
 
 /**
@@ -321,7 +346,7 @@ export async function generateMeetingSummaryFacts(
       judgeVerdict,
       evidence,
     });
-    const outcome = resolveMeetingFactOutcome(config, trust, judgeVerdict);
+    const outcome = resolveMeetingFactOutcome(config, trust, judgeVerdict, candidate);
     if (outcome === "drop") {
       result.dropped++;
       continue;
@@ -353,7 +378,10 @@ export async function generateMeetingSummaryFacts(
         sourceTrust: config.sourceTrust,
         evidence,
       });
-      const outcome = resolveMeetingFactOutcome(config, summaryTrust, undefined);
+      const outcome = resolveMeetingFactOutcome(config, summaryTrust, undefined, {
+        category: "fact",
+        content: summaryText,
+      });
       if (outcome === "drop") {
         result.dropped++;
       } else {

package/src/meetings/summary-extractor.ts

@@ -16,6 +16,7 @@
  */
 
 import { getVerdictKind, type JudgeBatchResult, type JudgeCandidate } from "../extraction-judge.js";
+import { AMBIENT_CAPTURE_PROMPT_RULE } from "../ambient-provenance.js";
 import { log } from "../logger.js";
 import type {
   MeetingFactCandidate,
@@ -38,7 +39,7 @@ export interface MeetingSummaryChatClient {
   ): Promise<{ content: string } | null>;
 }
 
-const SUMMARY_SYSTEM_PROMPT = `You are a meeting scribe extracting DURABLE memory from a meeting transcript and its on-screen context.
+export const SUMMARY_SYSTEM_PROMPT = `You are a meeting scribe extracting DURABLE memory from a meeting transcript and its on-screen context.
 
 Return ONLY a single JSON object, no prose, no code fences, in exactly this shape:
 {
@@ -52,7 +53,8 @@ Rules:
 - decisions: concrete choices the group made. Omit hypotheticals and discussion that led nowhere.
 - commitments: owner-bearing action items only. If there is no clear owner, omit it.
 - openQuestions: genuinely unresolved questions, not rhetorical asides.
-- Prefer fewer, higher-quality items. Use [] for any empty list. Never invent content the transcript does not support.`;
+- Prefer fewer, higher-quality items. Use [] for any empty list. Never invent content the transcript does not support.
+${AMBIENT_CAPTURE_PROMPT_RULE}`;
 
 const DECISION_CONFIDENCE = 0.8;
 const COMMITMENT_CONFIDENCE = 0.8;

package/src/memory-snapshot.ts

@@ -0,0 +1,15 @@
+import type { MemoryFile } from "./types.js";
+
+function sortSnapshotObject(_key: string, candidate: unknown): unknown {
+  if (candidate === null || typeof candidate !== "object" || Array.isArray(candidate)) return candidate;
+  return Object.keys(candidate)
+    .sort()
+    .reduce<Record<string, unknown>>((sorted, key) => {
+      sorted[key] = (candidate as Record<string, unknown>)[key];
+      return sorted;
+    }, {});
+}
+
+export function createMemorySnapshot(memory: MemoryFile): string {
+  return JSON.stringify([memory.frontmatter, memory.content], sortSnapshotObject);
+}

package/src/orchestration/recall-internal.ts

@@ -102,6 +102,7 @@ import {
   type RecallResultPartitionSink,
 } from "./recall-rerank-coordinator.js";
 import type { RecallInternalDeps } from "./recall-internal-deps.js";
+import { resolveCompositeProfileStorage } from "./recall-profile-storage.js";
 
 export class RecallInternalCoordinator {
   constructor(
@@ -686,154 +687,10 @@ export class RecallInternalCoordinator {
     const profileStorages = await Promise.all(
       profileStorageNamespaces.map((namespace) => this.deps.storageRouter.storageFor(namespace)),
     );
-    const emptyProfileStorage = new Proxy(
-      { dir: path.join(this.deps.config.memoryDir, ".empty-scope-profile") } as any,
-      {
-        get(target, prop: string | symbol) {
-          if (prop in target) return target[prop];
-          if (prop === "readProfile") return async () => "";
-          if (
-            prop === "readQuestions" ||
-            prop === "listEntityNames" ||
-            prop === "readContinuityIncidents"
-          )
-            return async () => [];
-          if (
-            prop === "readIdentityAnchor" ||
-            prop === "readIdentityImprovementLoops"
-          )
-            return async () => "";
-          if (prop === "readEntity" || prop === "readMemoryByPath")
-            return async () => null;
-          return async () => [];
-        },
-      },
-    );
-    const profileStorage =
-      profileStorages.length <= 1
-        ? profileStorages[0] ?? emptyProfileStorage
-        : new Proxy(profileStorages[0] as any, {
-            get(target, prop: string | symbol) {
-              if (prop === "readProfile") {
-                return async () => {
-                  for (const storage of profileStorages) {
-                    const profile = await storage.readProfile();
-                    if (profile.trim().length > 0) return profile;
-                  }
-                  return "";
-                };
-              }
-              if (prop === "readQuestions") {
-                return async (...args: any[]) => {
-                  const merged: any[] = [];
-                  const seen = new Set<string>();
-                  const priorityOf = (question: any): number => {
-                    const priority = Number(question?.priority ?? 0);
-                    return Number.isFinite(priority) ? priority : 0;
-                  };
-                  for (const storage of profileStorages) {
-                    const questions = await (storage.readQuestions as any)(...args);
-                    for (const question of questions) {
-                      const key = typeof question === "string" ? question : JSON.stringify(question);
-                      if (seen.has(key)) continue;
-                      seen.add(key);
-                      merged.push(question);
-                    }
-                  }
-                  return merged.sort(
-                    (left, right) =>
-                      priorityOf(right) - priorityOf(left) ||
-                      String(left?.id ?? "").localeCompare(String(right?.id ?? "")),
-                  );
-                };
-              }
-              if (prop === "readIdentityAnchor") {
-                return async () => {
-                  for (const storage of profileStorages) {
-                    const anchor = (await storage.readIdentityAnchor()) ?? "";
-                    if (anchor.trim().length > 0) return anchor;
-                  }
-                  return "";
-                };
-              }
-              if (prop === "readIdentityImprovementLoops") {
-                return async () => {
-                  const sections: string[] = [];
-                  const seen = new Set<string>();
-                  for (const storage of profileStorages) {
-                    const loops = ((await storage.readIdentityImprovementLoops()) ?? "").trim();
-                    if (!loops || seen.has(loops)) continue;
-                    seen.add(loops);
-                    sections.push(loops);
-                  }
-                  return sections.join("\n\n");
-                };
-              }
-              if (prop === "readContinuityIncidents") {
-                return async (...args: any[]) => {
-                  const limit = typeof args[0] === "number" && Number.isFinite(args[0]) ? Math.max(0, args[0]) : undefined;
-                  const incidents: any[] = [];
-                  const seen = new Set<string>();
-                  const incidentTime = (incident: any): number => {
-                    const raw = incident?.updatedAt ?? incident?.openedAt ?? incident?.createdAt;
-                    const parsed = typeof raw === "string" ? Date.parse(raw) : Number.NaN;
-                    return Number.isFinite(parsed) ? parsed : 0;
-                  };
-                  for (const storage of profileStorages) {
-                    for (const incident of await (storage.readContinuityIncidents as any)(...args)) {
-                      const key = JSON.stringify(incident);
-                      if (seen.has(key)) continue;
-                      seen.add(key);
-                      incidents.push(incident);
-                    }
-                  }
-                  incidents.sort(
-                    (left, right) =>
-                      incidentTime(right) - incidentTime(left) ||
-                      String(left?.id ?? "").localeCompare(String(right?.id ?? "")),
-                  );
-                  return limit === undefined ? incidents : incidents.slice(0, limit);
-                };
-              }
-              if (prop === "listEntityNames") {
-                return async (...args: any[]) => {
-                  const names = new Set<string>();
-                  for (const storage of profileStorages) {
-                    for (const name of await (storage.listEntityNames as any)(...args)) names.add(name);
-                  }
-                  return [...names];
-                };
-              }
-              if (prop === "readEntity" || prop === "readMemoryByPath") {
-                return async (...args: any[]) => {
-                  for (const storage of profileStorages) {
-                    const value = await (storage as any)[prop](...args);
-                    if (value) return value;
-                  }
-                  return null;
-                };
-              }
-              if (prop === "readAllMemories") {
-                return async (...args: any[]) => {
-                  const memories: any[] = [];
-                  const seen = new Set<string>();
-                  for (const storage of profileStorages) {
-                    for (const memory of await (storage.readAllMemories as any)(...args)) {
-                      const key = String(memory?.path ?? memory?.frontmatter?.id ?? JSON.stringify(memory));
-                      if (seen.has(key)) continue;
-                      seen.add(key);
-                      memories.push(memory);
-                    }
-                  }
-                  return memories;
-                };
-              }
-              return target[prop];
-            },
-          });
-    const profileStorageDirs = Array.from(
-      new Set(profileStorages.map((storage) => storage.dir).filter((dir): dir is string => typeof dir === "string" && dir.length > 0)),
-    );
+    const { profileStorage, profileStorageDirs } = resolveCompositeProfileStorage({
+      profileStorages,
+      memoryDir: this.deps.config.memoryDir,
+    });
 
     // --- Phase 1: Launch ALL independent data fetches in parallel ---
     throwIfRecallAborted(options.abortSignal);

package/src/orchestration/recall-profile-storage.ts

@@ -0,0 +1,194 @@
+/**
+ * Composite profile storage proxy for recall orchestration — extracted from
+ * recall-internal.ts (issue #1526, seam 18).
+ */
+
+import path from "node:path";
+import type { StorageManager } from "../index.js";
+
+export interface CompositeProfileStorageOptions {
+  profileStorages: StorageManager[];
+  memoryDir: string;
+}
+
+export interface CompositeProfileStorageResult {
+  profileStorage: StorageManager;
+  profileStorageDirs: string[];
+}
+
+/**
+ * Creates a composite profile storage proxy over multiple namespace storage instances.
+ * When multiple storages exist, methods aggregate results across all instances.
+ * When storages is empty, returns a safe empty fallback storage.
+ */
+export function resolveCompositeProfileStorage(
+  options: CompositeProfileStorageOptions,
+): CompositeProfileStorageResult {
+  const { profileStorages, memoryDir } = options;
+
+  const emptyProfileStorage = new Proxy(
+    { dir: path.join(memoryDir, ".empty-scope-profile") } as unknown as StorageManager,
+    {
+      get(target, prop: string | symbol) {
+        if (prop in target) return Reflect.get(target, prop);
+        if (prop === "readProfile") return async () => "";
+        if (
+          prop === "readQuestions" ||
+          prop === "listEntityNames" ||
+          prop === "readContinuityIncidents"
+        )
+          return async () => [];
+        if (
+          prop === "readIdentityAnchor" ||
+          prop === "readIdentityImprovementLoops"
+        )
+          return async () => "";
+        if (prop === "readEntity" || prop === "readMemoryByPath")
+          return async () => null;
+        return async () => [];
+      },
+    },
+  );
+
+  const profileStorage =
+    profileStorages.length <= 1
+      ? profileStorages[0] ?? emptyProfileStorage
+      : new Proxy(profileStorages[0] as StorageManager, {
+          get(target, prop: string | symbol) {
+            if (prop === "readProfile") {
+              return async () => {
+                for (const storage of profileStorages) {
+                  const profile = await storage.readProfile();
+                  if (profile.trim().length > 0) return profile;
+                }
+                return "";
+              };
+            }
+            if (prop === "readQuestions") {
+              return async (...args: unknown[]) => {
+                const merged: unknown[] = [];
+                const seen = new Set<string>();
+                const priorityOf = (question: unknown): number => {
+                  const priority = Number((question as Record<string, unknown>)?.priority ?? 0);
+                  return Number.isFinite(priority) ? priority : 0;
+                };
+                for (const storage of profileStorages) {
+                  const readFn = (storage as unknown as Record<string, (...a: unknown[]) => Promise<unknown[]>>).readQuestions;
+                  const questions = await readFn.call(storage, ...args);
+                  for (const question of questions) {
+                    const key = typeof question === "string" ? question : JSON.stringify(question);
+                    if (seen.has(key)) continue;
+                    seen.add(key);
+                    merged.push(question);
+                  }
+                }
+                return merged.sort(
+                  (left, right) =>
+                    priorityOf(right) - priorityOf(left) ||
+                    String((left as Record<string, unknown>)?.id ?? "").localeCompare(String((right as Record<string, unknown>)?.id ?? "")),
+                );
+              };
+            }
+            if (prop === "readIdentityAnchor") {
+              return async () => {
+                for (const storage of profileStorages) {
+                  const anchor = (await storage.readIdentityAnchor()) ?? "";
+                  if (anchor.trim().length > 0) return anchor;
+                }
+                return "";
+              };
+            }
+            if (prop === "readIdentityImprovementLoops") {
+              return async () => {
+                const sections: string[] = [];
+                const seen = new Set<string>();
+                for (const storage of profileStorages) {
+                  const loops = ((await storage.readIdentityImprovementLoops()) ?? "").trim();
+                  if (!loops || seen.has(loops)) continue;
+                  seen.add(loops);
+                  sections.push(loops);
+                }
+                return sections.join("\n\n");
+              };
+            }
+            if (prop === "readContinuityIncidents") {
+              return async (...args: unknown[]) => {
+                const limit = typeof args[0] === "number" && Number.isFinite(args[0]) ? Math.max(0, args[0]) : undefined;
+                const incidents: unknown[] = [];
+                const seen = new Set<string>();
+                const incidentTime = (incident: unknown): number => {
+                  const incObj = incident as Record<string, unknown>;
+                  const raw = incObj?.updatedAt ?? incObj?.openedAt ?? incObj?.createdAt;
+                  const parsed = typeof raw === "string" ? Date.parse(raw) : Number.NaN;
+                  return Number.isFinite(parsed) ? parsed : 0;
+                };
+                for (const storage of profileStorages) {
+                  const readFn = (storage as unknown as Record<string, (...a: unknown[]) => Promise<unknown[]>>).readContinuityIncidents;
+                  for (const incident of await readFn.call(storage, ...args)) {
+                    const key = JSON.stringify(incident);
+                    if (seen.has(key)) continue;
+                    seen.add(key);
+                    incidents.push(incident);
+                  }
+                }
+                incidents.sort(
+                  (left, right) =>
+                    incidentTime(right) - incidentTime(left) ||
+                    String((left as Record<string, unknown>)?.id ?? "").localeCompare(String((right as Record<string, unknown>)?.id ?? "")),
+                );
+                return limit === undefined ? incidents : incidents.slice(0, limit);
+              };
+            }
+            if (prop === "listEntityNames") {
+              return async (...args: unknown[]) => {
+                const names = new Set<string>();
+                for (const storage of profileStorages) {
+                  const listFn = (storage as unknown as Record<string, (...a: unknown[]) => Promise<string[]>>).listEntityNames;
+                  for (const name of await listFn.call(storage, ...args)) names.add(name);
+                }
+                return [...names];
+              };
+            }
+            if (prop === "readEntity" || prop === "readMemoryByPath") {
+              return async (...args: unknown[]) => {
+                for (const storage of profileStorages) {
+                  const methodFn = (storage as unknown as Record<string, (...a: unknown[]) => Promise<unknown>>)[prop as string];
+                  if (methodFn) {
+                    const value = await methodFn.call(storage, ...args);
+                    if (value) return value;
+                  }
+                }
+                return null;
+              };
+            }
+            if (prop === "readAllMemories") {
+              return async (...args: unknown[]) => {
+                const memories: unknown[] = [];
+                const seen = new Set<string>();
+                for (const storage of profileStorages) {
+                  const readFn = (storage as unknown as Record<string, (...a: unknown[]) => Promise<unknown[]>>).readAllMemories;
+                  for (const memory of await readFn.call(storage, ...args)) {
+                    const memObj = memory as Record<string, unknown>;
+                    const key = String(memObj?.path ?? (memObj?.frontmatter as Record<string, unknown>)?.id ?? JSON.stringify(memory));
+                    if (seen.has(key)) continue;
+                    seen.add(key);
+                    memories.push(memory);
+                  }
+                }
+                return memories;
+              };
+            }
+            return Reflect.get(target, prop);
+          },
+        });
+
+  const profileStorageDirs = Array.from(
+    new Set(
+      profileStorages
+        .map((storage) => storage.dir)
+        .filter((dir): dir is string => typeof dir === "string" && dir.length > 0),
+    ),
+  );
+
+  return { profileStorage, profileStorageDirs };
+}