@remnic/core 9.3.693 → 9.3.695

package/src/coding/coding-knowledge-config.ts

@@ -32,6 +32,8 @@ export const CODING_KNOWLEDGE_DEFAULTS = Object.freeze({
   architectureCardLlmSummary: false,
   structuralProvider: "none",
   structuralProviderCommand: "",
+  codegraphTools: false,
+  codegraphDbDir: "",
 } satisfies Record<keyof CodingKnowledgeConfig, boolean | string>);
 
 const VALID_STRUCTURAL_PROVIDERS = ["none", "subprocess", "native"] as const;
@@ -63,6 +65,11 @@ export function parseCodingKnowledgeConfig(raw: unknown): CodingKnowledgeConfig
       typeof record.structuralProviderCommand === "string"
         ? record.structuralProviderCommand.trim()
         : "",
+    codegraphTools: readStrictBool(record.codegraphTools, "codegraphTools", /* default */ false),
+    codegraphDbDir:
+      typeof record.codegraphDbDir === "string"
+        ? record.codegraphDbDir.trim()
+        : "",
   };
 }
 

package/src/coding/decision-surfaces.test.ts

@@ -41,6 +41,8 @@ const GATE_OFF_CONFIG: CodingKnowledgeConfig = {
   architectureCardLlmSummary: false,
   structuralProvider: "none",
   structuralProviderCommand: "",
+  codegraphTools: false,
+  codegraphDbDir: "",
 };
 
 const GATE_ON_CONFIG: CodingKnowledgeConfig = {

package/src/coding/session-delta-surfaces.test.ts

@@ -41,6 +41,8 @@ const DEFAULT_CONFIG: CodingKnowledgeConfig = {
   architectureCardLlmSummary: false,
   structuralProvider: "none",
   structuralProviderCommand: "",
+  codegraphTools: false,
+  codegraphDbDir: "",
 };
 
 const CODING_CONTEXT: CodingContext = {

package/src/config.test.ts

@@ -1329,6 +1329,8 @@ test("parseConfig codingKnowledge: defaults match the documented contract (issue
     architectureCardLlmSummary: false,
     structuralProvider: "none",
     structuralProviderCommand: "",
+    codegraphTools: false,
+    codegraphDbDir: "",
   });
 });
 
@@ -2032,3 +2034,19 @@ test("parseConfig provenance.enabled honors REMNIC_/ENGRAM_ env fallback (issue
     else delete process.env.ENGRAM_PROVENANCE_ENABLED;
   }
 });
+
+test("parseConfig rejects a present-but-non-string extractionFaithfulnessGate (safety gate must not silently disable, #1576 Ob4RQ)", () => {
+  assert.equal(parseConfig({}).extractionFaithfulnessGate, "off");
+  assert.equal(parseConfig({ extractionFaithfulnessGate: null }).extractionFaithfulnessGate, "off");
+  assert.equal(parseConfig({ extractionFaithfulnessGate: "enforce" }).extractionFaithfulnessGate, "enforce");
+  assert.equal(parseConfig({ extractionFaithfulnessGate: "ENFORCE" }).extractionFaithfulnessGate, "enforce");
+  for (const bad of [true, 1, {}, ["enforce"]] as unknown[]) {
+    assert.throws(
+      () => parseConfig({ extractionFaithfulnessGate: bad } as Record<string, unknown>),
+      /extractionFaithfulnessGate must be one of/,
+      `present non-string ${JSON.stringify(bad)} must reject, not default to off`,
+    );
+  }
+  // A present-but-unknown string still rejects (pre-existing behavior preserved).
+  assert.throws(() => parseConfig({ extractionFaithfulnessGate: "on" }), /extractionFaithfulnessGate must be one of/);
+});

package/src/config.ts

@@ -2909,6 +2909,36 @@ export function parseConfig(
     collectJudgeTrainingPairs: coerceBool(cfg.collectJudgeTrainingPairs) === true,
     judgeTrainingDir:
       typeof cfg.judgeTrainingDir === "string" ? cfg.judgeTrainingDir : "",
+    // Extraction faithfulness gate (issue #1576). Entailment-verification of
+    // extracted facts against verified source spans (#1575). Default "off"
+    // (rule 39: byte-identical pre-feature pipeline). Invalid values are
+    // rejected listing valid options (rule 51).
+    extractionFaithfulnessGate: (() => {
+      const v = cfg.extractionFaithfulnessGate;
+      if (v === undefined || v === null) return "off";
+      // Present-but-invalid (true/1/{}) must reject, not silently disable the gate (Ob4RQ).
+      const raw = typeof v === "string" ? v.trim().toLowerCase() : v;
+      if (raw === "off" || raw === "shadow" || raw === "enforce") return raw;
+      throw new Error(
+        `extractionFaithfulnessGate must be one of "off" | "shadow" | "enforce" (got ${JSON.stringify(v)})`,
+      );
+    })(),
+    extractionFaithfulnessModel:
+      typeof cfg.extractionFaithfulnessModel === "string"
+        ? cfg.extractionFaithfulnessModel
+        : "",
+    // Numeric knobs go through coerceNumber so CLI operators can pass
+    // --config extractionFaithfulnessTimeoutMs=4000 without the string
+    // silently dropping to the default. Matches the coercion contract applied
+    // to other numeric config keys (CLAUDE.md rule #28 / gotcha #36).
+    extractionFaithfulnessContextChars: (() => {
+      const n = coerceNumber(cfg.extractionFaithfulnessContextChars);
+      return n !== undefined && n > 0 ? Math.min(Math.round(n), 4000) : 400;
+    })(),
+    extractionFaithfulnessTimeoutMs: (() => {
+      const n = coerceNumber(cfg.extractionFaithfulnessTimeoutMs);
+      return n !== undefined && n > 0 ? Math.min(Math.round(n), 60_000) : 8000;
+    })(),
     // Inline source attribution (issue #369). Opt-in to preserve
     // backwards compatibility with existing downstream consumers.
     inlineSourceAttributionEnabled: cfg.inlineSourceAttributionEnabled === true,

package/src/console/state.ts

@@ -59,6 +59,12 @@ export interface ConsoleStateOrchestratorLike {
    * version read from disk.
    */
   getConsoleDaemonInfo?: () => ConsoleDaemonInfo;
+  /**
+   * Optional faithfulness gate distribution (issue #1576). Returns the
+   * per-orchestrator running counters when the gate is active, or undefined
+   * when the gate is off (so the snapshot omits the block).
+   */
+  getConsoleFaithfulnessDistribution?: () => ConsoleFaithfulnessDistribution | undefined;
 }
 
 export interface ConsoleBufferState {
@@ -120,6 +126,18 @@ export interface ConsoleDaemonInfo {
   version: string;
 }
 
+/**
+ * Faithfulness gate verdict distribution (issue #1576). Surfaced via
+ * console_state so `remnic doctor` can render how the gate is performing.
+ */
+export interface ConsoleFaithfulnessDistribution {
+  entailed: number;
+  contradicted: number;
+  unsupported: number;
+  unchecked: number;
+  skippedNoSpan: number;
+}
+
 export interface ConsoleStateSnapshot {
   /** ISO-8601 capture timestamp. */
   capturedAt: string;
@@ -129,6 +147,8 @@ export interface ConsoleStateSnapshot {
   maintenanceLedgerTail: ConsoleMaintenanceLedgerEvent[];
   qmdProbe: ConsoleQmdProbeState;
   daemon: ConsoleDaemonInfo;
+  /** Faithfulness gate distribution (issue #1576). Absent when the gate is off. */
+  faithfulness?: ConsoleFaithfulnessDistribution;
   /**
    * Subsystem read errors. One entry per failed reader keyed by
    * subsystem name (e.g. `"bufferState: ..."`). An empty array means
@@ -163,6 +183,17 @@ export async function gatherConsoleState(
   const qmdProbe = readQmdProbe(orchestrator, errors);
   const daemon = readDaemonInfo(orchestrator, errors);
 
+  // Faithfulness gate distribution (issue #1576). Optional — absent when
+  // the gate is off or the orchestrator does not expose the accessor.
+  let faithfulness: ConsoleFaithfulnessDistribution | undefined;
+  try {
+    if (typeof orchestrator.getConsoleFaithfulnessDistribution === "function") {
+      faithfulness = orchestrator.getConsoleFaithfulnessDistribution();
+    }
+  } catch (err) {
+    errors.push(`faithfulness: ${describeError(err)}`);
+  }
+
   return {
     capturedAt,
     bufferState,
@@ -171,6 +202,7 @@ export async function gatherConsoleState(
     maintenanceLedgerTail,
     qmdProbe,
     daemon,
+    ...(faithfulness ? { faithfulness } : {}),
     errors,
   };
 }