@remnic/core 9.3.692 → 9.3.694

package/src/coding/session-delta-surfaces.ts

@@ -0,0 +1,325 @@
+/**
+ * Session-delta surface contract + handler (issue #1548 Track A PR 4).
+ *
+ * The single shared implementation behind the MCP, HTTP, and CLI
+ * session-delta surfaces. All three transports dispatch through the
+ * `coding_delta` boundary operation, which calls {@link handleCodingDelta}
+ * via the service delegate.
+ *
+ * Gate (rule 39): `codingKnowledge.enabled + sessionDelta + coding
+ * context` — one predicate, identical on every surface. The tools/list
+ * visibility gate checks conditions 1–2 only (config-level).
+ *
+ * Persistence (rule 25): the new last-seen-head marker is written AFTER
+ * the delta is computed from the old one. State writes use temp-file-then-
+ * rename (rule 54) via the pure module's `writeLastSeenState`.
+ *
+ * Subcommand: `get` — computes the delta against the persisted last-seen
+ * head and updates the marker in the same call (so the NEXT session sees
+ * this one as the baseline). Read-only semantically, but it mutates the
+ * state file: it is therefore NOT counted against the write-quota (the
+ * state file is operator-side bookkeeping, not user memory content — the
+ * same way `calibration.ts` writes are uncounted).
+ */
+import type {
+  CodingKnowledgeConfig,
+  CodingContext,
+} from "../types.js";
+import {
+  computeSessionDelta,
+  readLastSeenState,
+  writeLastSeenState,
+  resolveSlice,
+  sessionDeltaStatePath,
+  type GitLogSlice,
+  type LastSeenState,
+  type ResolveSliceResult,
+  type SessionDeltaGitInvoker,
+  type SessionDeltaResult,
+} from "./session-delta.js";
+import { log } from "../logger.js";
+
+// ──────────────────────────────────────────────────────────────────────────
+// Subcommands
+// ──────────────────────────────────────────────────────────────────────────
+
+export const DELTA_SUBCOMMANDS = ["get"] as const;
+
+export type DeltaSubcommand = (typeof DELTA_SUBCOMMANDS)[number];
+
+const SUBCOMMAND_VALUES = DELTA_SUBCOMMANDS as readonly string[];
+
+/** Type guard — narrows an unknown subcommand string. */
+export function isDeltaSubcommand(value: unknown): value is DeltaSubcommand {
+  return typeof value === "string" && SUBCOMMAND_VALUES.includes(value);
+}
+
+/** Human-readable subcommand list for error messages (rule 51). */
+export function formatDeltaSubcommands(): string {
+  return DELTA_SUBCOMMANDS.join(", ");
+}
+
+// ──────────────────────────────────────────────────────────────────────────
+// Gate predicates — rule 39: one predicate, identical on every surface
+// ──────────────────────────────────────────────────────────────────────────
+
+/**
+ * The single session-delta surface gate. Returns `true` only when:
+ *  1. `codingKnowledge.enabled` is true,
+ *  2. `codingKnowledge.sessionDelta` is true,
+ *  3. a coding context is attached (so a repo root is available).
+ */
+export function isSessionDeltaSurfaceEnabled(
+  config: CodingKnowledgeConfig,
+  codingContext: CodingContext | null | undefined,
+): boolean {
+  return (
+    config.enabled === true &&
+    config.sessionDelta === true &&
+    codingContext !== null &&
+    codingContext !== undefined
+  );
+}
+
+/**
+ * Config-only visibility gate — used by the MCP constructor to decide
+ * whether to advertise `engram.coding_delta` in `tools/list`. When this
+ * returns `false` the tools array is byte-identical to pre-feature (rule 39).
+ */
+export function isSessionDeltaSurfaceVisible(
+  config: CodingKnowledgeConfig,
+): boolean {
+  return config.enabled === true && config.sessionDelta === true;
+}
+
+// ──────────────────────────────────────────────────────────────────────────
+// Surface request / response shapes
+// ──────────────────────────────────────────────────────────────────────────
+
+/** Canonical surface request — one shape for all three transports. */
+export interface DeltaSurfaceRequest {
+  subcommand: DeltaSubcommand;
+  sessionKey?: string;
+  namespace?: string;
+}
+
+/**
+ * Surface response. Mirrors {@link SessionDeltaResult} but flattened for
+ * transport: every outcome carries `nextState` so callers can observe the
+ * new marker even on failure (the head still advanced).
+ */
+export type DeltaSurfaceResponse =
+  | {
+      subcommand: "get";
+      ok: true;
+      /** A real delta was computed. */
+      kind: "changed";
+      delta: {
+        commits: ReadonlyArray<{ sha: string; subject: string }>;
+        touchedFiles: readonly string[];
+        summaryLine: string;
+      };
+      nextState: LastSeenState;
+    }
+  | {
+      subcommand: "get";
+      ok: true;
+      /** Prior head equals current — no changes. */
+      kind: "unchanged";
+      nextState: LastSeenState;
+    }
+  | {
+      subcommand: "get";
+      ok: true;
+      /** No prior state — first session for this namespace. */
+      kind: "first_run";
+      nextState: LastSeenState;
+    }
+  | {
+      subcommand: "get";
+      /**
+       * Delta unavailable. `code` is one of `unreachable_head` (force-push/
+       * rebase erased the prior head) or `git_failed` (invoker error). The
+       * state file is still advanced when `nextState` is present.
+       */
+      ok: false;
+      code: "unreachable_head" | "git_failed";
+      detail: string;
+      nextState?: LastSeenState;
+    };
+
+// ──────────────────────────────────────────────────────────────────────────
+// Storage contract — narrow; the handler needs the memoryDir + namespace only
+// ──────────────────────────────────────────────────────────────────────────
+
+/**
+ * The resolved namespace context the handler needs. The service produces
+ * this through the SAME coding-scoped read path as the other coding surfaces.
+ */
+export interface DeltaSurfaceStorage {
+  /** The orchestrator's memoryDir — base for the state file path. */
+  readonly memoryDir: string;
+  /** The resolved coding-scoped namespace — basis for the state filename. */
+  readonly namespace: string;
+}
+
+/**
+ * Dependencies the handler borrows from the service. The service constructs
+ * this context per call; the handler never touches the orchestrator directly.
+ */
+export interface DeltaSurfaceContext {
+  readonly codingKnowledge: CodingKnowledgeConfig;
+  getCodingContext(sessionKey: string): CodingContext | null;
+  /** Resolve storage (memoryDir + namespace) via the coding-scoped read path. */
+  resolveStorage(request: DeltaSurfaceRequest): Promise<DeltaSurfaceStorage>;
+  /** Git invoker — drives `rev-parse` + `log`. Defaults to a real invoker. */
+  gitInvoker: SessionDeltaGitInvoker;
+  /** Throw the surface-appropriate input-validation error. */
+  throwInputError(message: string): never;
+}
+
+// ──────────────────────────────────────────────────────────────────────────
+// Handler — the single shared implementation behind all three surfaces
+// ──────────────────────────────────────────────────────────────────────────
+
+/**
+ * The single shared implementation behind the MCP, HTTP, and CLI
+ * session-delta surfaces.
+ *
+ * Order of operations (rule 25 — do not destroy the old marker before the
+ * new state is useful):
+ *   1. Read the persisted last-seen-head.
+ *   2. Resolve the current repo slice via the git invoker.
+ *   3. Compute the delta from the OLD state + current slice.
+ *   4. Persist the NEW state (temp-file-then-rename).
+ *   5. Return the result.
+ */
+export async function handleCodingDelta(
+  request: DeltaSurfaceRequest,
+  ctx: DeltaSurfaceContext,
+): Promise<DeltaSurfaceResponse> {
+  const codingContext = request.sessionKey
+    ? ctx.getCodingContext(request.sessionKey)
+    : null;
+  if (
+    codingContext === null ||
+    !isSessionDeltaSurfaceEnabled(ctx.codingKnowledge, codingContext)
+  ) {
+    ctx.throwInputError(
+      "coding_delta requires codingKnowledge.enabled, codingKnowledge.sessionDelta, and an attached coding context",
+    );
+  }
+  // `get` is the only subcommand today; the switch keeps the shape forward-
+  // compatible if `refresh`/`reset` land later.
+  switch (request.subcommand) {
+    case "get":
+      return deltaGet(request, ctx, codingContext);
+  }
+}
+
+// ──────────────────────────────────────────────────────────────────────────
+// Subcommand handler
+// ──────────────────────────────────────────────────────────────────────────
+
+async function deltaGet(
+  request: DeltaSurfaceRequest,
+  ctx: DeltaSurfaceContext,
+  codingContext: CodingContext,
+): Promise<DeltaSurfaceResponse> {
+  const storage = await ctx.resolveStorage(request);
+  const statePath = sessionDeltaStatePath(storage.memoryDir, storage.namespace);
+
+  // 1. Read prior state. Absent/empty/malformed → null → first_run.
+  const lastSeen = await readLastSeenState(statePath);
+
+  // 2. Resolve the current repo slice. `rootPath` is the repo root the
+  //    coding context was resolved from; it MUST exist for a delta to make
+  //    sense. Fall back to `projectId` only as a path hint — refresh is the
+  //    caller's responsibility (the gate already required a context).
+  const repoRoot = codingContext.rootPath ?? codingContext.projectId;
+  const sliceResult: ResolveSliceResult = resolveSlice(
+    repoRoot,
+    lastSeen?.head ?? null,
+    ctx.gitInvoker,
+  );
+
+  // 3. Git failure → tagged failure, but advance the state file when we
+  //    could at least read the current head (so the next call has a chance).
+  if (!sliceResult.ok) {
+    log.warn(
+      `coding_delta/get: slice resolution failed (code=${sliceResult.code}): ${sliceResult.detail}`,
+    );
+    // Best-effort: still try to advance the state file if the head was readable.
+    // On `no_head` we cannot write anything sensible — leave the prior marker.
+    return {
+      subcommand: "get",
+      ok: false,
+      code: "git_failed",
+      detail: sliceResult.detail,
+    };
+  }
+
+  // 4. Compute the delta from the OLD state + the slice.
+  const result: SessionDeltaResult = computeSessionDelta(lastSeen, sliceResult.slice);
+
+  // 5. Persist the new state (rule 25 + rule 54). Failures here are logged
+  //    but do NOT fail the operation — the delta was computed; the next
+  //    session may re-derive it. A write failure surfaces in doctor/xray.
+  let nextState: LastSeenState | null = null;
+  if (result.ok) {
+    nextState = result.nextState;
+  } else if (result.code === "unreachable_head") {
+    nextState = result.nextState;
+  }
+  if (nextState) {
+    try {
+      await writeLastSeenState(statePath, nextState);
+    } catch (err) {
+      log.warn(
+        `coding_delta/get: state write failed for ${statePath}: ${err instanceof Error ? err.message : String(err)}`,
+      );
+    }
+  }
+
+  // 6. Map to the surface response shape.
+  if (!result.ok) {
+    if (result.code === "unreachable_head") {
+      return {
+        subcommand: "get",
+        ok: false,
+        code: result.code,
+        detail: result.detail,
+        nextState: result.nextState,
+      };
+    }
+    return {
+      subcommand: "get",
+      ok: false,
+      code: result.code,
+      detail: result.detail,
+    };
+  }
+  switch (result.kind) {
+    case "first_run":
+      return { subcommand: "get", ok: true, kind: "first_run", nextState: result.nextState };
+    case "unchanged":
+      return { subcommand: "get", ok: true, kind: "unchanged", nextState: result.nextState };
+    case "changed":
+      return {
+        subcommand: "get",
+        ok: true,
+        kind: "changed",
+        delta: {
+          commits: result.delta.commits,
+          touchedFiles: result.delta.touchedFiles,
+          summaryLine: result.delta.summaryLine,
+        },
+        nextState: result.nextState,
+      };
+  }
+}
+
+// Exported for the surface's storage-adapter glue so the service delegate
+// can build the narrow {@link DeltaSurfaceStorage} without re-importing the
+// path helper from the pure module.
+export { sessionDeltaStatePath, type GitLogSlice };