@remnic/core 9.3.688 → 9.3.690

package/src/access-cli.test.ts

@@ -522,3 +522,43 @@ test("access-cli rejects adjacent option-looking values", async () => {
 
   assert.match(output, /missing required option: --content/);
 });
+
+// ──────────────────────────────────────────────────────────────────────────
+// architecture command — wired through the boundary operation (#1548 PR3)
+// ──────────────────────────────────────────────────────────────────────────
+
+test("access-cli architecture is a known command (unknown options rejected, not unsupported-command)", async () => {
+  const output = await captureRunCliFailure(["architecture", "--typo", "x"]);
+  assert.match(output, /unknown option: --typo/);
+});
+
+test("access-cli architecture accepts its documented value options", async () => {
+  // Valid option spellings parse cleanly; the invocation only fails once it
+  // reaches the runtime (no OpenClaw config here), proving the options were
+  // accepted by parseArgs rather than rejected as unknown.
+  const output = await captureRunCliFailure([
+    "architecture",
+    "--subcommand",
+    "get",
+    "--session-key",
+    "s1",
+    "--namespace",
+    "ns",
+    "--project-tag",
+    "myproj",
+  ]);
+  assert.doesNotMatch(output, /unknown option/);
+  assert.doesNotMatch(output, /unsupported command/);
+});
+
+test("access-cli usage lists the architecture command and its options", async () => {
+  const output = await captureRunCliFailure(["architecture", "--typo"]);
+  assert.match(output, /engram-access architecture \[options\]/);
+  assert.match(output, /Architecture options:/);
+  assert.match(output, /--subcommand <get\|refresh>/);
+});
+
+test("access-cli still rejects truly unknown commands as unsupported", async () => {
+  const output = await captureRunCliFailure(["bogus-command"]);
+  assert.match(output, /unsupported command/);
+});

package/src/access-cli.ts

@@ -15,7 +15,7 @@ import { projectTagProjectId } from "./coding/coding-namespace.js";
 
 const OPENCLAW_REMNIC_PLUGIN_IDS = ["openclaw-remnic", "openclaw-engram"] as const;
 
-type CommandName = "browse" | "store" | "decision";
+type CommandName = "browse" | "store" | "decision" | "architecture";
 
 type ParsedArgs = {
   command: CommandName;
@@ -137,6 +137,7 @@ function usage(): string {
     "  engram-access browse [options]",
     "  engram-access store [options]",
     "  engram-access decision [options]",
+    "  engram-access architecture [options]",
     "",
     "Browse options:",
     "  --namespace <name>",
@@ -176,6 +177,14 @@ function usage(): string {
     "  --entity-ref <ref> (repeatable)",
     "  --project-tag <tag> (attach coding context for this invocation)",
     "  --supersedes-id <id> (alias for --id on supersede)",
+    "",
+    "Architecture options:",
+    "  --subcommand <get|refresh>",
+    "  --namespace <name>",
+    "  --session-key <key>",
+    "  --principal <principal>",
+    "  --project-tag <tag> (attach coding context for this invocation)",
+    "  --repo-root <path> (repo to scan for refresh; defaults to the current directory)",
   ].join("\n");
 }
 
@@ -228,6 +237,17 @@ const COMMAND_SPECS: Record<CommandName, CommandSpec> = {
     ]),
     flagOptions: new Set(),
   },
+  architecture: {
+    valueOptions: new Set([
+      "subcommand",
+      "namespace",
+      "session-key",
+      "principal",
+      "project-tag",
+      "repo-root",
+    ]),
+    flagOptions: new Set(),
+  },
 };
 const BROWSE_SORT_VALUES = Object.freeze([
   "updated_desc",
@@ -238,9 +258,19 @@ const BROWSE_SORT_VALUES = Object.freeze([
 
 type BrowseSort = (typeof BROWSE_SORT_VALUES)[number];
 
+/**
+ * Type guard for {@link CommandName}. Enumerating the union (rather than a
+ * bare `value in COMMAND_SPECS`) is what lets TypeScript NARROW the string
+ * to `CommandName` — the `in` operator alone yields TS2322 on the
+ * `command: commandRaw` assignment below (codex review P2).
+ */
+function isCommandName(value: string): value is CommandName {
+  return value === "browse" || value === "store" || value === "decision" || value === "architecture";
+}
+
 function parseArgs(argv: string[]): ParsedArgs {
   const [commandRaw, ...rest] = argv;
-  if (commandRaw !== "browse" && commandRaw !== "store" && commandRaw !== "decision") {
+  if (!isCommandName(commandRaw)) {
     throw new UsageError("unsupported-command");
   }
   const spec = COMMAND_SPECS[commandRaw];
@@ -552,6 +582,60 @@ async function runDecision(args: ParsedArgs, preferredId?: string): Promise<void
   console.log(JSON.stringify(output.result, null, 2));
 }
 
+/**
+ * Architecture-card surface (issue #1548 Track A PR 3). Dispatches through
+ * the same `coding_architecture` operation as the MCP tool and HTTP route —
+ * one validation boundary, three transports.
+ */
+async function runArchitecture(args: ParsedArgs, preferredId?: string): Promise<void> {
+  const subcommand = requireOption(args, "subcommand");
+  const { config, service } = buildRuntime(preferredId);
+  // Same coding-context attachment as runDecision (review P2): the CLI's
+  // fresh Orchestrator has an empty session coding-context map, so attach
+  // a context BEFORE dispatching when --project-tag + --session-key are
+  // given, so the gate passes and writes resolve to the right namespace.
+  const projectTag = getLastOption(args, "project-tag");
+  const sessionKey = getLastOption(args, "session-key");
+  if (sessionKey && sessionKey.trim().length > 0) {
+    // refresh scans codingContext.rootPath, so it must be a REAL checkout
+    // path. Default to the CWD (or an explicit --repo-root) so a one-shot
+    // CLI refresh scans the caller's repo, not a non-existent tag path.
+    const repoRoot = expandOptionalPath(getLastOption(args, "repo-root")) ?? process.cwd();
+    // --project-tag supplies the context id (namespace); when absent, derive
+    // a default from the repo-root basename so refresh works with just
+    // --session-key + --repo-root (codex review).
+    const projectId =
+      projectTag && projectTag.trim().length > 0
+        ? projectTagProjectId(projectTag.trim())
+        : projectTagProjectId(path.basename(repoRoot));
+    service.setCodingContext({
+      sessionKey,
+      codingContext: {
+        projectId,
+        branch: null,
+        rootPath: repoRoot,
+        defaultBranch: null,
+      },
+    });
+  }
+  const op = getOperation("coding_architecture");
+  if (!op) {
+    throw new Error("access-boundary: operation not registered: coding_architecture");
+  }
+  const output = (await op.run(
+    {
+      subcommand,
+      namespace: getLastOption(args, "namespace"),
+      sessionKey,
+    },
+    {
+      service,
+      authenticatedPrincipal: getLastOption(args, "principal") ?? config.agentAccessHttp.principal,
+    },
+  )) as { result: unknown };
+  console.log(JSON.stringify(output.result, null, 2));
+}
+
 export async function main(
   argv: string[] = process.argv.slice(2),
   options: AccessCliOptions = {},
@@ -565,6 +649,10 @@ export async function main(
     await runDecision(args, options.preferredId);
     return;
   }
+  if (args.command === "architecture") {
+    await runArchitecture(args, options.preferredId);
+    return;
+  }
   await runStore(args, options.preferredId);
 }
 

package/src/access-http.ts

@@ -316,6 +316,7 @@ export class EngramAccessHttpServer {
       citationsAutoDetect: options.citationsAutoDetect,
       emitLegacyTools: options.emitLegacyTools,
       codingDecisionVisible: this.service.decisionRecordSurfaceVisible,
+      architectureCardVisible: this.service.architectureCardSurfaceVisible,
     });
   }
 
@@ -1361,6 +1362,30 @@ export class EngramAccessHttpServer {
       return;
     }
 
+    if (req.method === "POST" && pathname === "/engram/v1/coding/architecture") {
+      // Migrated through the access boundary (issue #1525/#1548 PR3):
+      // refresh persists the card, so it is gated by the 30/min write quota;
+      // get is a pure read and stays uncounted.
+      const body = await this.readJsonBody(req);
+      const isWriteSubcommand = body.subcommand === "refresh";
+      if (isWriteSubcommand) {
+        this.ensureWriteRateLimitAvailable();
+      }
+      const op = getOperation("coding_architecture");
+      if (!op) {
+        throw new EngramAccessInputError("access-boundary: operation not registered: coding_architecture");
+      }
+      const output = (await op.run(body, {
+        service: this.service,
+        authenticatedPrincipal: this.resolveRequestPrincipal(req),
+      })) as { result: unknown };
+      if (isWriteSubcommand) {
+        this.recordWriteRateLimitHit();
+      }
+      this.respondJson(res, 200, output.result);
+      return;
+    }
+
     if (req.method === "POST" && pathname === "/engram/v1/suggestions") {
       const body = await this.readValidatedBody(req, "suggestionSubmit");
       const request = {
@@ -2213,13 +2238,16 @@ export class EngramAccessHttpServer {
       typeof toolArgs === "object" &&
       !Array.isArray(toolArgs) &&
       (toolArgs as { dryRun?: unknown }).dryRun === true;
+    const toolArgsSubcommand =
+      toolArgs !== null && typeof toolArgs === "object" && !Array.isArray(toolArgs) && "subcommand" in toolArgs
+        ? toolArgs.subcommand
+        : undefined;
     const codingDecisionWrite =
       (toolName === "engram.coding_decision" || toolName === "remnic.coding_decision") &&
-      toolArgs !== null &&
-      typeof toolArgs === "object" &&
-      !Array.isArray(toolArgs) &&
-      ((toolArgs as { subcommand?: unknown }).subcommand === "record" ||
-        (toolArgs as { subcommand?: unknown }).subcommand === "supersede");
+      (toolArgsSubcommand === "record" || toolArgsSubcommand === "supersede");
+    const codingArchitectureWrite =
+      (toolName === "engram.coding_architecture" || toolName === "remnic.coding_architecture") &&
+      toolArgsSubcommand === "refresh";
     const isMcpWrite =
       request.method === "tools/call" &&
       (
@@ -2248,7 +2276,8 @@ export class EngramAccessHttpServer {
             toolName === "remnic.memory_action_apply"
           )
         ) ||
-        codingDecisionWrite
+        codingDecisionWrite ||
+        codingArchitectureWrite
       );
     if (isMcpWrite) {
       this.ensureWriteRateLimitAvailable();

package/src/access-mcp.ts

@@ -110,6 +110,7 @@ const MCP_MIGRATED_OPERATIONS: Readonly<Record<string, OperationName>> = {
   "engram.memory_search": "memory_search",
   "engram.memory_store": "memory_store",
   "engram.coding_decision": "coding_decision",
+  "engram.coding_architecture": "coding_architecture",
 };
 
 function resolveChatGptInspectorRecallSessionKey(
@@ -324,6 +325,12 @@ export class EngramMcpServer {
    * pre-feature.
    */
   private readonly codingDecisionVisible: boolean;
+  /**
+   * Whether the `coding_architecture` tool should appear in `tools/list`.
+   * Gated on `codingKnowledge.enabled && codingKnowledge.architectureCard`
+   * (issue #1548 Track A PR 3, rule 39).
+   */
+  private readonly architectureCardVisible: boolean;
 
   constructor(
     private readonly service: EngramAccessService,
@@ -333,12 +340,14 @@ export class EngramMcpServer {
       citationsAutoDetect?: boolean;
       emitLegacyTools?: boolean;
       codingDecisionVisible?: boolean;
+      architectureCardVisible?: boolean;
     } = {},
   ) {
     this.citationsEnabled = options.citationsEnabled === true;
     this.citationsAutoDetect = options.citationsAutoDetect !== false;
     this.emitLegacyTools = options.emitLegacyTools !== false;
     this.codingDecisionVisible = options.codingDecisionVisible === true;
+    this.architectureCardVisible = options.architectureCardVisible === true;
     this.authenticatedPrincipal =
       options.principal?.trim() ||
       readEnvVar("OPENCLAW_ENGRAM_ACCESS_PRINCIPAL")?.trim() ||
@@ -1999,6 +2008,31 @@ export class EngramMcpServer {
       );
       this.tools = [...this.tools, ...codingDecisionTools];
     }
+    if (this.architectureCardVisible) {
+      const architectureTools = withToolAliases(
+        {
+          name: "engram.coding_architecture",
+          description:
+            "Get or refresh the architecture card for the session's coding namespace (issue #1548 Track A PR 3). Subcommands: get, refresh.",
+          inputSchema: {
+            type: "object",
+            properties: {
+              subcommand: {
+                type: "string",
+                enum: ["get", "refresh"],
+                description: "Which architecture-card operation to run.",
+              },
+              sessionKey: { type: "string", description: "Session identifier whose coding context scopes the operation." },
+              namespace: { type: "string", description: "Optional explicit namespace (overrides coding-context overlay)." },
+            },
+            required: ["subcommand"],
+            additionalProperties: false,
+          },
+        },
+        this.emitLegacyTools,
+      );
+      this.tools = [...this.tools, ...architectureTools];
+    }
   }
 
   /** Get clientInfo for a specific MCP session. Returns undefined for non-MCP requests. */

package/src/access-operations.ts

@@ -25,6 +25,10 @@ import {
   type DecisionSurfaceRequest,
   type DecisionSurfaceResponse,
 } from "./coding/decision-surfaces.js";
+import {
+  type ArchitectureSurfaceRequest,
+  type ArchitectureSurfaceResponse,
+} from "./coding/architecture-surfaces.js";
 
 // ---------------------------------------------------------------------------
 // memory_get — fetch one memory by id
@@ -206,6 +210,46 @@ export const codingDecisionOperation = defineOperation<
   },
 });
 
+// ---------------------------------------------------------------------------
+// coding_architecture — architecture-card surfaces (issue #1548 Track A PR 3)
+// ---------------------------------------------------------------------------
+
+const codingArchitectureSchema = z.preprocess(
+  (data) => {
+    if (data !== null && typeof data === "object" && !Array.isArray(data)) {
+      const obj = data as Record<string, unknown>;
+      const cleaned: Record<string, unknown> = {};
+      for (const [key, value] of Object.entries(obj)) {
+        if (value !== null) cleaned[key] = value;
+      }
+      return cleaned;
+    }
+    return data;
+  },
+  z.object({
+    subcommand: z.enum(["get", "refresh"]),
+    sessionKey: z.string().optional(),
+    namespace: z.string().optional(),
+  }),
+);
+
+export type CodingArchitectureInput = ArchitectureSurfaceRequest;
+export type CodingArchitectureOutput = { result: ArchitectureSurfaceResponse };
+
+export const codingArchitectureOperation = defineOperation<
+  CodingArchitectureInput,
+  CodingArchitectureOutput
+>({
+  name: "coding_architecture",
+  description:
+    "Get or refresh the architecture card for the session's coding namespace (issue #1548 Track A PR 3).",
+  schema: codingArchitectureSchema as z.ZodType<CodingArchitectureInput>,
+  handler: async (input, ctx) => {
+    const result = await ctx.service.codingArchitecture(input, ctx.authenticatedPrincipal);
+    return { result };
+  },
+});
+
 // ---------------------------------------------------------------------------
 // Surface registration map — what each transport calls the pilot ops
 // ---------------------------------------------------------------------------
@@ -220,4 +264,5 @@ export const REGISTERED_OPERATIONS = [
   memorySearchOperation.spec.name,
   memoryStoreOperation.spec.name,
   codingDecisionOperation.spec.name,
+  codingArchitectureOperation.spec.name,
 ] as const;

package/src/access-service.ts

@@ -19,6 +19,16 @@ import {
   type DecisionSurfaceRequest,
   type DecisionSurfaceResponse,
 } from "./coding/decision-surfaces.js";
+import {
+  handleCodingArchitecture,
+  type ArchitectureSurfaceRequest,
+  type ArchitectureSurfaceResponse,
+  type ArchitectureSurfaceStorage,
+  createArchitectureVersioningHook,
+  ARCHITECTURE_CARD_TAG,
+} from "./coding/architecture-surfaces.js";
+import { buildArchitectureCard, createArchitectureCardSummariser } from "./coding/architecture-card.js";
+import { createVersion } from "./page-versioning.js";
 import { WorkStorage } from "./work/storage.js";
 import {
   exportWorkBoardMarkdown,
@@ -4485,6 +4495,56 @@ export class EngramAccessService {
     });
   }
 
+  /** Whether the coding_architecture tool should appear in tools/list (rule 39). */
+  get architectureCardSurfaceVisible(): boolean {
+    return this.orchestrator.config.codingKnowledge?.enabled === true
+      && this.orchestrator.config.codingKnowledge?.architectureCard === true;
+  }
+  /**
+   * Thin delegate — handler logic in coding/architecture-surfaces.ts (#1548 PR3).
+   * All three surfaces (MCP/HTTP/CLI) arrive here via the boundary operation.
+   * Namespace resolution uses the SAME coding-scoped path as decision records.
+   */
+  async codingArchitecture(
+    request: ArchitectureSurfaceRequest,
+    authenticatedPrincipal?: string,
+  ): Promise<ArchitectureSurfaceResponse> {
+    const resolvedConfig = this.orchestrator.config;
+    return handleCodingArchitecture(request, {
+      codingKnowledge: this.orchestrator.config.codingKnowledge,
+      getCodingContext: (sk) => this.orchestrator.getCodingContextForSession(sk),
+      resolveStorage: async (req) => {
+        const isWrite = req.subcommand === "refresh";
+        const ns = isWrite
+          ? await this.resolveCodingScopedWriteNamespace({
+              namespace: req.namespace,
+              sessionKey: req.sessionKey,
+              authenticatedPrincipal,
+            })
+        : await this.resolveCodingScopedReadableNamespace({
+            namespace: req.namespace,
+            sessionKey: req.sessionKey,
+            authenticatedPrincipal,
+          });
+        const storage = await this.orchestrator.getStorage(ns);
+        return Object.assign(storage, { namespace: ns }) as ArchitectureSurfaceStorage;
+      },
+      buildCard: async (repoRoot) => buildArchitectureCard(repoRoot, {
+        llmSummary: this.orchestrator.config.codingKnowledge?.architectureCardLlmSummary === true,
+        summariser: createArchitectureCardSummariser(this.fallbackLlmRef ?? this.localLlmRef),
+      }),
+      versioning: createArchitectureVersioningHook(
+        resolvedConfig.versioningEnabled === true,
+        resolvedConfig.versioningMaxPerPage,
+        resolvedConfig.versioningSidecarDir,
+        resolvedConfig.memoryDir,
+        (p) => nodeFs.readFile(p, "utf-8"),
+        createVersion,
+      ),
+      throwInputError: (msg) => { throw new EngramAccessInputError(msg); },
+    });
+  }
+
   async memoryBrowse(
     request: EngramAccessMemoryBrowseRequest = {},
   ): Promise<EngramAccessMemoryBrowseResponse> {

package/src/access-surface-catalog.test.ts

@@ -67,7 +67,7 @@ function shortToolName(advertised: string): string {
 /** Spin up a server with emitLegacyTools=true and read the deduped short names. */
 async function liveMcpToolShortNames(): Promise<ReadonlySet<string>> {
   const stub = { briefingEnabled: true } as unknown as EngramAccessService;
-  const server = new EngramMcpServer(stub, { emitLegacyTools: true, codingDecisionVisible: true });
+  const server = new EngramMcpServer(stub, { emitLegacyTools: true, codingDecisionVisible: true, architectureCardVisible: true });
   const response = await server.handleRequest({ jsonrpc: "2.0", id: 1, method: "tools/list" });
   const result = (response as { result?: { tools?: Array<{ name: string }> } }).result;
   const names = new Set<string>();

package/src/access-surface-catalog.ts

@@ -73,6 +73,7 @@ export const MCP_TOOLS: readonly McpToolEntry[] = [
   { tool: "memory_timeline", operation: null },
   { tool: "memory_store", operation: "memory_store" },
   { tool: "coding_decision", operation: "coding_decision" },
+  { tool: "coding_architecture", operation: "coding_architecture" },
   { tool: "suggestion_submit", operation: null },
   { tool: "entity_get", operation: null },
   { tool: "review_queue_list", operation: null },
@@ -170,6 +171,7 @@ export const HTTP_ROUTES: readonly HttpRouteEntry[] = [
   { method: "GET", pathname: "/engram/v1/lcm/status", operation: null },
   { method: "POST", pathname: "/engram/v1/memories", operation: "memory_store" },
   { method: "POST", pathname: "/engram/v1/coding/decisions", operation: "coding_decision" },
+  { method: "POST", pathname: "/engram/v1/coding/architecture", operation: "coding_architecture" },
   { method: "POST", pathname: "/engram/v1/suggestions", operation: null },
   { method: "GET", pathname: "/engram/v1/memories", operation: null },
   { method: "GET", pathname: "/engram/v1/memories/:id", operation: "memory_get" },

package/src/cli.ts

@@ -57,6 +57,7 @@ import {
 } from "./maintenance/rebuild-memory-projection.js";
 import { rebuildObservations } from "./maintenance/rebuild-observations.js";
 import { migrateObservations } from "./maintenance/migrate-observations.js";
+import { formatNamespaceMaintenanceHealthText } from "./maintenance/namespace-maintenance-fanout.js";
 import {
   listNamespaces,
   runNamespaceMigration,
@@ -2801,6 +2802,7 @@ export async function runAccessMcpServeCliCommand(
       principal: options.principal,
       emitLegacyTools: options.emitLegacyTools,
       codingDecisionVisible: service.decisionRecordSurfaceVisible,
+      architectureCardVisible: service.architectureCardSurfaceVisible,
     });
   await server.runStdio(options.stdin ?? process.stdin, options.stdout ?? process.stdout);
   return { ok: true };
@@ -4292,6 +4294,22 @@ export function registerCli(
           }
         });
 
+      namespacesCmd
+        .command("maintenance")
+        .description(
+          "Show per-namespace maintenance status (issue #1500). Reports which namespaces were maintained, skipped, or failed for each standard job.",
+        )
+        .option("--json", "Emit machine-readable JSON only")
+        .action(async (...args: unknown[]) => {
+          const options = (args[0] ?? {}) as Record<string, unknown>;
+          const summary = await orchestrator.readNamespaceMaintenanceHealth();
+          if (reportHasMachineReadableOutput(options)) {
+            console.log(JSON.stringify(summary, null, 2));
+          } else {
+            console.log(formatNamespaceMaintenanceHealthText(summary));
+          }
+        });
+
       cmd
         .command("export")
         .description("Export Remnic memory to JSON, Markdown bundle, or SQLite")