@remnic/core 9.3.642 → 9.3.643

package/src/access-mcp.ts

@@ -715,6 +715,11 @@ export class EngramMcpServer {
               description:
                 "Optional current user-context scopes, such as repo, work, personal, client, or private.",
             },
+            allowUnverifiedPreview: {
+              type: "boolean",
+              description:
+                "If true, the inspector may show recalled preview text when X-ray provenance is missing or unavailable. Explicitly blocked memories remain redacted.",
+            },
           },
           required: ["query"],
           additionalProperties: false,
@@ -2608,6 +2613,17 @@ export class EngramMcpServer {
         if (currentContextScopes !== undefined) {
           input.currentContextScopes = currentContextScopes;
         }
+        if (
+          args.allowUnverifiedPreview !== undefined &&
+          args.allowUnverifiedPreview !== null
+        ) {
+          if (typeof args.allowUnverifiedPreview !== "boolean") {
+            throw new EngramAccessInputError(
+              "allowUnverifiedPreview must be a boolean",
+            );
+          }
+          input.allowUnverifiedPreview = args.allowUnverifiedPreview;
+        }
         const recallSessionKey = resolveChatGptInspectorRecallSessionKey(
           input.sessionKey,
           effectivePrincipal,

package/src/mcp-memory-inspector-app.ts

@@ -18,6 +18,7 @@ export interface RemnicChatGptMemoryInspectorInput {
   sessionKey?: string;
   namespace?: string;
   currentContextScopes?: string[];
+  allowUnverifiedPreview?: boolean;
 }
 
 export interface RemnicChatGptMemoryCard {
@@ -115,21 +116,42 @@ export function buildChatGptMemoryInspectorResult(
   actionConfidence: ActionConfidenceResult,
 ): RemnicChatGptMemoryInspectorResult {
   const xrayUnavailable = xray === null;
-  const matchXrayResult = buildXrayResultMatcher(xray);
+  const allowUnverifiedPreview = input.allowUnverifiedPreview === true;
+  const matchXrayResult = buildXrayResultMatcher(xray, recall.results);
   const matchedXrayResults = recall.results.map(matchXrayResult);
+  const hasBlockedSameId = buildBlockedSameIdMatcher(xray);
 
   const memories = recall.results.slice(0, 8).map((summary) => {
     const xrayResult = matchXrayResult(summary);
     const provenance = xrayResult?.provenance;
-    const unverified = !xrayUnavailable && provenance === undefined;
-    const blocked = provenance?.safety === "blocked";
+    const blockedByAmbiguousSameId = !xrayUnavailable
+      && xrayResult === undefined
+      && hasBlockedSameId(summary.id);
+    const blocked = provenance?.safety === "blocked" || blockedByAmbiguousSameId;
+    const unverified = !xrayUnavailable && provenance === undefined && !blockedByAmbiguousSameId;
     const preview = xrayUnavailable
-      ? "Preview withheld: X-ray provenance was unavailable for this recall."
-      : unverified
-        ? "Preview withheld: X-ray provenance was missing for this memory."
+      ? allowUnverifiedPreview
+        ? summary.preview
+        : "Preview withheld: X-ray provenance was unavailable for this recall."
       : blocked
         ? "Preview withheld: this memory is blocked in the current context."
-        : summary.preview;
+        : unverified
+          ? allowUnverifiedPreview
+            ? summary.preview
+            : "Preview withheld: X-ray provenance was missing for this memory."
+          : summary.preview;
+    const fallbackSafety = blockedByAmbiguousSameId
+      ? "blocked"
+      : xrayUnavailable || unverified
+        ? allowUnverifiedPreview
+          ? "requires-review"
+          : "blocked"
+        : undefined;
+    const fallbackSafetyReason = xrayUnavailable
+      ? "X-ray provenance was unavailable for this recall."
+      : blockedByAmbiguousSameId
+        ? "An unmatched X-ray row with this memory id was blocked."
+      : "X-ray provenance was missing for this memory.";
     return {
       id: summary.id,
       path: summary.path,
@@ -144,25 +166,43 @@ export function buildChatGptMemoryInspectorResult(
       confidence: provenance?.confidence,
       stale: provenance?.stale,
       corrected: provenance?.corrected,
-      safeToUse: provenance?.safeToUse ?? (unverified ? false : undefined),
-      safety: provenance?.safety ?? (unverified ? "blocked" : undefined),
+      safeToUse: provenance?.safeToUse
+        ?? (xrayUnavailable || unverified || blockedByAmbiguousSameId ? false : undefined),
+      safety: provenance?.safety ?? fallbackSafety,
       safetyReasons: provenance?.safetyReasons
-        ?? (unverified ? ["X-ray provenance was missing for this memory."] : []),
+        ?? (
+          xrayUnavailable || unverified || blockedByAmbiguousSameId
+            ? [fallbackSafetyReason]
+            : []
+        ),
       userContextScopes: provenance?.userContextScopes ?? [],
     };
   });
   const blockedCount = matchedXrayResults
     .filter((result) => result?.provenance?.safety === "blocked")
     .length;
+  const ambiguousBlockedCount = recall.results
+    .filter((summary, index) =>
+      matchedXrayResults[index] === undefined && hasBlockedSameId(summary.id)
+    )
+    .length;
   const missingProvenanceCount = xrayUnavailable
     ? 0
     : matchedXrayResults
-      .filter((result) => result?.provenance === undefined)
+      .filter((result, index) =>
+        result?.provenance === undefined
+        && !(result === undefined && hasBlockedSameId(recall.results[index]?.id ?? ""))
+      )
     .length;
+  const totalBlockedCount = blockedCount + ambiguousBlockedCount;
   const safeRecallPreview = xrayUnavailable
-    ? "Recall preview withheld: X-ray provenance was unavailable, so memory safety could not be verified."
-    : blockedCount > 0 || missingProvenanceCount > 0
-      ? formatUnsafeRecallPreview(blockedCount, missingProvenanceCount)
+    ? allowUnverifiedPreview
+      ? `Unverified recall preview: X-ray provenance was unavailable, so memory safety could not be verified.\n\n${truncate(recall.context, 1_500)}`
+      : "Recall preview withheld: X-ray provenance was unavailable, so memory safety could not be verified."
+    : totalBlockedCount > 0 || missingProvenanceCount > 0
+      ? totalBlockedCount > 0 || !allowUnverifiedPreview
+        ? formatUnsafeRecallPreview(totalBlockedCount, missingProvenanceCount)
+        : `Unverified recall preview: ${missingProvenanceCount} retrieved ${memoryNoun(missingProvenanceCount)} ${isAre(missingProvenanceCount)} missing X-ray provenance.\n\n${truncate(recall.context, 1_500)}`
       : truncate(recall.context, 1_500);
 
   const primaryMemoryId = memories[0]?.id ?? "<memory-id>";
@@ -372,7 +412,7 @@ function buildRecallProvenances(
   if (xray === null) {
     return recall.results.map(missingRecallProvenance);
   }
-  const matchXrayResult = buildXrayResultMatcher(xray);
+  const matchXrayResult = buildXrayResultMatcher(xray, recall.results);
   return recall.results.map((summary) => {
     const result = matchXrayResult(summary);
     if (result === undefined) {
@@ -384,21 +424,43 @@ function buildRecallProvenances(
 
 function buildXrayResultMatcher(
   xray: RecallXraySnapshot | null,
+  recallResults: EngramAccessRecallResponse["results"],
 ): (summary: EngramAccessRecallResponse["results"][number]) => RecallXrayResult | undefined {
   const xrayById = new Map<string, RecallXrayResult>();
+  const xrayIdCounts = new Map<string, number>();
+  const recallIdCounts = new Map<string, number>();
   const xrayByPath = new Map<string, RecallXrayResult>();
+  for (const summary of recallResults) {
+    recallIdCounts.set(summary.id, (recallIdCounts.get(summary.id) ?? 0) + 1);
+  }
   for (const result of xray?.results ?? []) {
     xrayById.set(result.memoryId, result);
+    xrayIdCounts.set(result.memoryId, (xrayIdCounts.get(result.memoryId) ?? 0) + 1);
     xrayByPath.set(result.path, result);
   }
   return (summary) => {
     if (summary.path) {
-      return xrayByPath.get(summary.path);
+      const pathMatch = xrayByPath.get(summary.path);
+      if (pathMatch) return pathMatch;
     }
-    return xrayById.get(summary.id);
+    return xrayIdCounts.get(summary.id) === 1 && recallIdCounts.get(summary.id) === 1
+      ? xrayById.get(summary.id)
+      : undefined;
   };
 }
 
+function buildBlockedSameIdMatcher(
+  xray: RecallXraySnapshot | null,
+): (memoryId: string) => boolean {
+  const blockedIds = new Set<string>();
+  for (const result of xray?.results ?? []) {
+    if (result.provenance?.safety === "blocked") {
+      blockedIds.add(result.memoryId);
+    }
+  }
+  return (memoryId) => blockedIds.has(memoryId);
+}
+
 function missingProvenance(result: RecallXrayResult): RetrievedMemoryProvenance {
   return {
     source: "unknown",