@remnic/core 10.0.94 → 10.0.95

package/dist/{chunk-RUTN5MMC.js → chunk-LS7PT3YD.js}

@@ -2,7 +2,7 @@ import {
   ExtractionDrain,
   TurnIngestionCoordinator,
   shouldSkipImplicitExtraction
-} from "./chunk-D5S6RL32.js";
+} from "./chunk-DDATG2SF.js";
 import {
   headerConnector,
   renderExtractionConversation,
@@ -447,4 +447,4 @@ export {
   ClaimBufferStorage,
   BufferDrainRunner
 };
-//# sourceMappingURL=chunk-RUTN5MMC.js.map
+//# sourceMappingURL=chunk-LS7PT3YD.js.map

package/dist/cli.js

@@ -91,7 +91,7 @@ import {
   runWorkProductStatusCliCommand,
   runWorkProjectCliCommand,
   runWorkTaskCliCommand
-} from "./chunk-D5S6RL32.js";
+} from "./chunk-DDATG2SF.js";
 import "./chunk-B3DR2JBZ.js";
 import "./chunk-6P7U3HWG.js";
 import "./chunk-H4CKS5B2.js";

package/dist/explicit-capture.js

@@ -8,7 +8,7 @@ import {
   shouldSkipImplicitExtraction,
   stripInlineExplicitCaptureNotes,
   validateExplicitCaptureInput
-} from "./chunk-D5S6RL32.js";
+} from "./chunk-DDATG2SF.js";
 import "./chunk-B3DR2JBZ.js";
 import "./chunk-6P7U3HWG.js";
 import "./chunk-H4CKS5B2.js";

package/dist/index.js

@@ -259,7 +259,7 @@ import {
   writeManifest,
   writeMeetingEpisodeMemory,
   writeTimelineState
-} from "./chunk-D5S6RL32.js";
+} from "./chunk-DDATG2SF.js";
 import {
   WEARABLE_SOURCE_PREFIX,
   WearablesInputError,

package/dist/orchestration/backlog-scheduler.js

@@ -1,7 +1,7 @@
 import {
   BufferDrainRunner
-} from "../chunk-RUTN5MMC.js";
-import "../chunk-D5S6RL32.js";
+} from "../chunk-LS7PT3YD.js";
+import "../chunk-DDATG2SF.js";
 import "../chunk-B3DR2JBZ.js";
 import "../chunk-6P7U3HWG.js";
 import "../chunk-H4CKS5B2.js";

package/dist/orchestration/buffer-drain-runner.js

@@ -1,8 +1,8 @@
 import {
   BufferDrainRunner,
   ClaimBufferStorage
-} from "../chunk-RUTN5MMC.js";
-import "../chunk-D5S6RL32.js";
+} from "../chunk-LS7PT3YD.js";
+import "../chunk-DDATG2SF.js";
 import "../chunk-B3DR2JBZ.js";
 import "../chunk-6P7U3HWG.js";
 import "../chunk-H4CKS5B2.js";

package/dist/orchestration/extraction-persist-failure.d.ts

@@ -1,3 +1,4 @@
+type FinalizeCommittedWrites = (scheduleQmd: boolean) => Promise<void>;
 /**
  * Fail a persistence pass after a durable write rejected (#3227, same
  * contract as the entity write path from #3228). Earlier writes in the batch
@@ -5,5 +6,28 @@
  * original error is then rethrown so the run leaves its input retryable
  * instead of recording the fingerprint and clearing the source turns.
  */
-export declare function rethrowAfterCommittedWriteFinalization(finalizeCommittedWrites: (scheduleQmd: boolean) => Promise<void>, cause: unknown, outputKind: string): Promise<never>;
+export declare function rethrowAfterCommittedWriteFinalization(finalizeCommittedWrites: FinalizeCommittedWrites, cause: unknown, outputKind: string): Promise<never>;
+/**
+ * Batch-end finalization for one persistExtraction pass (#3288).
+ *
+ * `bind` wraps the pass's finalizer so it runs at most once. The success
+ * tail, the per-branch catch sites and the pass boundary can all reach it,
+ * and a second run would append the same behavior signals again.
+ *
+ * `run` is the pass boundary. A throw from a branch with no catch site of its
+ * own (a chunked-parent post-write step, the semantic-merge post effects, the
+ * profile or question write) still finalizes the writes already committed
+ * before the original error propagates. When a catch site or the success tail
+ * already ran the finalizer, the boundary only rethrows. Nothing is durable
+ * before the finalizer is bound, so an earlier throw propagates as is.
+ */
+export declare class CommittedWriteFinalization {
+    private finalizer;
+    private started;
+    bind(finalize: FinalizeCommittedWrites): FinalizeCommittedWrites;
+    run<T>(pass: () => Promise<T>): Promise<T>;
+}
+/** A pass method's parameter list without its leading CommittedWriteFinalization. */
+export type ArgsAfterFinalization<Params> = Params extends [CommittedWriteFinalization, ...infer Rest] ? Rest : never;
+export {};
 //# sourceMappingURL=extraction-persist-failure.d.ts.map

package/dist/orchestration/extraction-persist-failure.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"extraction-persist-failure.d.ts","sourceRoot":"","sources":["../../src/orchestration/extraction-persist-failure.ts"],"names":[],"mappings":"AAEA;;;;;;GAMG;AACH,wBAAsB,sCAAsC,CAC1D,uBAAuB,EAAE,CAAC,WAAW,EAAE,OAAO,KAAK,OAAO,CAAC,IAAI,CAAC,EAChE,KAAK,EAAE,OAAO,EACd,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC,KAAK,CAAC,CAKhB"}
+{"version":3,"file":"extraction-persist-failure.d.ts","sourceRoot":"","sources":["../../src/orchestration/extraction-persist-failure.ts"],"names":[],"mappings":"AAEA,KAAK,uBAAuB,GAAG,CAAC,WAAW,EAAE,OAAO,KAAK,OAAO,CAAC,IAAI,CAAC,CAAC;AAEvE;;;;;;GAMG;AACH,wBAAsB,sCAAsC,CAC1D,uBAAuB,EAAE,uBAAuB,EAChD,KAAK,EAAE,OAAO,EACd,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC,KAAK,CAAC,CAKhB;AAED;;;;;;;;;;;;;GAaG;AACH,qBAAa,0BAA0B;IACrC,OAAO,CAAC,SAAS,CAAsC;IACvD,OAAO,CAAC,OAAO,CAA4B;IAE3C,IAAI,CAAC,QAAQ,EAAE,uBAAuB,GAAG,uBAAuB;IAK1D,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,OAAO,CAAC,CAAC,CAAC,GAAG,OAAO,CAAC,CAAC,CAAC;CAQjD;AAED,qFAAqF;AACrF,MAAM,MAAM,qBAAqB,CAAC,MAAM,IAAI,MAAM,SAAS,CAAC,0BAA0B,EAAE,GAAG,MAAM,IAAI,CAAC,GAAG,IAAI,GAAG,KAAK,CAAC"}

package/dist/orchestration/extraction-persist.d.ts

@@ -1,8 +1,4 @@
-import { type ExtractionSourceContext } from "./extraction-origin-context.js";
-import { type StorageManager } from "../index.js";
-import { type GraphConstructionCapabilitySet, type MemoryLifecycleCapabilitySet } from "../capabilities.js";
-import type { ResolvedScopeProfilePlan } from "../namespaces/scope-profiles.js";
-import type { ExtractionResult } from "../types.js";
+import { type ArgsAfterFinalization } from "./extraction-persist-failure.js";
 import type { ExtractionPersistDeps } from "./extraction-persist-deps.js";
 /** One extraction run's persist outcome: per-run values, no shared side channels (#1526). */
 export interface ExtractionPersistResult {
@@ -18,6 +14,7 @@ export declare class ExtractionPersistCoordinator {
     constructor(deps: ExtractionPersistDeps);
     private get config();
     private get dependencyPropagationDelivery();
-    persistExtraction(result: ExtractionResult, storage: StorageManager, threadIdForExtraction?: string | null, sourceContext?: ExtractionSourceContext, baseNamespace?: string, scopeProfileWritePlan?: ResolvedScopeProfilePlan | null, sourceText?: string, graphCaps?: GraphConstructionCapabilitySet, lifecycleCaps?: MemoryLifecycleCapabilitySet): Promise<ExtractionPersistResult>;
+    persistExtraction(...args: ArgsAfterFinalization<Parameters<ExtractionPersistCoordinator["persistExtractionPass"]>>): Promise<ExtractionPersistResult>;
+    private persistExtractionPass;
 }
 //# sourceMappingURL=extraction-persist.d.ts.map

package/dist/orchestration/extraction-persist.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"extraction-persist.d.ts","sourceRoot":"","sources":["../../src/orchestration/extraction-persist.ts"],"names":[],"mappings":"AAAA,OAAO,EAA4B,KAAK,uBAAuB,EAAE,MAAM,gCAAgC,CAAC;AAkBxG,OAAO,EAA6C,KAAK,cAAc,EAAE,MAAM,aAAa,CAAC;AAM7F,OAAO,EAUgE,KAAK,8BAA8B,EACxG,KAAK,4BAA4B,EAClC,MAAM,oBAAoB,CAAC;AAqD5B,OAAO,KAAK,EAAE,wBAAwB,EAAE,MAAM,iCAAiC,CAAC;AAGhF,OAAO,KAAK,EAEV,gBAAgB,EAQjB,MAAM,aAAa,CAAC;AAWrB,OAAO,KAAK,EAAE,qBAAqB,EAAE,MAAM,8BAA8B,CAAC;AAmB1E,6FAA6F;AAC7F,MAAM,WAAW,uBAAuB;IACtC,YAAY,EAAE,MAAM,EAAE,CAAC;IACvB,cAAc,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACpC,4EAA4E;IAC5E,aAAa,EAAE,MAAM,CAAC;IACtB,kFAAkF;IAClF,gBAAgB,EAAE,MAAM,EAAE,CAAC;CAC5B;AAED,qBAAa,4BAA4B;IAErC,OAAO,CAAC,QAAQ,CAAC,IAAI;gBAAJ,IAAI,EAAE,qBAAqB;IAE9C,OAAO,KAAK,MAAM,GAEjB;IACD,OAAO,KAAK,6BAA6B,GAGxC;IAEK,iBAAiB,CACrB,MAAM,EAAE,gBAAgB,EACxB,OAAO,EAAE,cAAc,EACvB,qBAAqB,CAAC,EAAE,MAAM,GAAG,IAAI,EACrC,aAAa,CAAC,EAAE,uBAAuB,EACvC,aAAa,CAAC,EAAE,MAAM,EACtB,qBAAqB,CAAC,EAAE,wBAAwB,GAAG,IAAI,EACvD,UAAU,CAAC,EAAE,MAAM,EACnB,SAAS,GAAE,8BAAuF,EAClG,aAAa,GAAE,4BAAmF,GACjG,OAAO,CAAC,uBAAuB,CAAC;CAswFpC"}
+{"version":3,"file":"extraction-persist.d.ts","sourceRoot":"","sources":["../../src/orchestration/extraction-persist.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,KAAK,qBAAqB,EAAsE,MAAM,iCAAiC,CAAC;AA8GjJ,OAAO,KAAK,EAAE,qBAAqB,EAAE,MAAM,8BAA8B,CAAC;AAmB1E,6FAA6F;AAC7F,MAAM,WAAW,uBAAuB;IACtC,YAAY,EAAE,MAAM,EAAE,CAAC;IACvB,cAAc,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACpC,4EAA4E;IAC5E,aAAa,EAAE,MAAM,CAAC;IACtB,kFAAkF;IAClF,gBAAgB,EAAE,MAAM,EAAE,CAAC;CAC5B;AAED,qBAAa,4BAA4B;IAErC,OAAO,CAAC,QAAQ,CAAC,IAAI;gBAAJ,IAAI,EAAE,qBAAqB;IAE9C,OAAO,KAAK,MAAM,GAEjB;IACD,OAAO,KAAK,6BAA6B,GAGxC;IAED,iBAAiB,CAAC,GAAG,IAAI,EAAE,qBAAqB,CAAC,UAAU,CAAC,4BAA4B,CAAC,uBAAuB,CAAC,CAAC,CAAC,GAAG,OAAO,CAAC,uBAAuB,CAAC;YAKxI,qBAAqB;CAmxFpC"}

package/dist/orchestrator.js

@@ -6,7 +6,7 @@ import {
   mergeGraphExpandedResults,
   qmdStartupCollectionChecksWithTimeout,
   resolveEffectiveIdentityInjectionMode
-} from "./chunk-D5S6RL32.js";
+} from "./chunk-DDATG2SF.js";
 import "./chunk-B3DR2JBZ.js";
 import "./chunk-6P7U3HWG.js";
 import "./chunk-H4CKS5B2.js";

package/dist/recall-navigation.js

@@ -1,6 +1,6 @@
 import {
   runRecallNavigation
-} from "./chunk-D5S6RL32.js";
+} from "./chunk-DDATG2SF.js";
 import "./chunk-B3DR2JBZ.js";
 import "./chunk-6P7U3HWG.js";
 import "./chunk-H4CKS5B2.js";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remnic/core",
-  "version": "10.0.94",
+  "version": "10.0.95",
   "description": "Framework-agnostic Remnic memory engine — orchestrator, storage, extraction, search, trust zones",
   "type": "module",
   "main": "dist/index.js",
@@ -3386,7 +3386,7 @@
     "core"
   ],
   "peerDependencies": {
-    "@remnic/coding-graph": "^10.0.94"
+    "@remnic/coding-graph": "^10.0.95"
   },
   "peerDependenciesMeta": {
     "@remnic/coding-graph": {

package/src/orchestration/extraction-persist-failure.test.ts

@@ -0,0 +1,90 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import { CommittedWriteFinalization } from "./extraction-persist-failure.js";
+
+function recordingFinalizer() {
+  const calls: boolean[] = [];
+  return {
+    calls,
+    finalize: async (scheduleQmd: boolean) => {
+      calls.push(scheduleQmd);
+    },
+  };
+}
+
+test("#3288: the bound finalizer runs once across the success tail and catch sites", async () => {
+  const finalization = new CommittedWriteFinalization();
+  const { calls, finalize } = recordingFinalizer();
+  const once = finalization.bind(finalize);
+
+  const value = await finalization.run(async () => {
+    await once(true);
+    await once(false);
+    return "persisted";
+  });
+
+  assert.equal(value, "persisted");
+  assert.deepEqual(calls, [true], "a second caller reuses the first run instead of finalizing again");
+});
+
+test("#3288: the pass boundary finalizes with QMD scheduling, then rethrows the original error", async () => {
+  const finalization = new CommittedWriteFinalization();
+  const { calls, finalize } = recordingFinalizer();
+  const cause = new Error("branch without its own catch site");
+
+  await assert.rejects(
+    finalization.run(async () => {
+      finalization.bind(finalize);
+      throw cause;
+    }),
+    (error: Error) => error === cause,
+  );
+  assert.deepEqual(calls, [true]);
+});
+
+test("#3288: the pass boundary does not finalize again after a catch site already did", async () => {
+  const finalization = new CommittedWriteFinalization();
+  const { calls, finalize } = recordingFinalizer();
+  const cause = new Error("catch site rethrow");
+
+  await assert.rejects(
+    finalization.run(async () => {
+      const once = finalization.bind(finalize);
+      await once(true);
+      throw cause;
+    }),
+    (error: Error) => error === cause,
+  );
+  assert.deepEqual(calls, [true]);
+});
+
+test("#3288: a throw before the finalizer is bound propagates without finalizing", async () => {
+  const finalization = new CommittedWriteFinalization();
+  const cause = new Error("failed before any write");
+
+  await assert.rejects(
+    finalization.run(async () => {
+      throw cause;
+    }),
+    (error: Error) => error === cause,
+  );
+});
+
+test("#3288: a failing finalizer does not mask the original error", async () => {
+  const finalization = new CommittedWriteFinalization();
+  const cause = new Error("branch failure");
+  let attempts = 0;
+
+  await assert.rejects(
+    finalization.run(async () => {
+      finalization.bind(async () => {
+        attempts += 1;
+        throw new Error("finalization failure");
+      });
+      throw cause;
+    }),
+    (error: Error) => error === cause,
+  );
+  assert.equal(attempts, 1);
+});

package/src/orchestration/extraction-persist-failure.ts

@@ -1,5 +1,7 @@
 import { log } from "../logger.js";
 
+type FinalizeCommittedWrites = (scheduleQmd: boolean) => Promise<void>;
+
 /**
  * Fail a persistence pass after a durable write rejected (#3227, same
  * contract as the entity write path from #3228). Earlier writes in the batch
@@ -8,7 +10,7 @@ import { log } from "../logger.js";
  * instead of recording the fingerprint and clearing the source turns.
  */
 export async function rethrowAfterCommittedWriteFinalization(
-  finalizeCommittedWrites: (scheduleQmd: boolean) => Promise<void>,
+  finalizeCommittedWrites: FinalizeCommittedWrites,
   cause: unknown,
   outputKind: string,
 ): Promise<never> {
@@ -17,3 +19,39 @@ export async function rethrowAfterCommittedWriteFinalization(
   );
   throw cause;
 }
+
+/**
+ * Batch-end finalization for one persistExtraction pass (#3288).
+ *
+ * `bind` wraps the pass's finalizer so it runs at most once. The success
+ * tail, the per-branch catch sites and the pass boundary can all reach it,
+ * and a second run would append the same behavior signals again.
+ *
+ * `run` is the pass boundary. A throw from a branch with no catch site of its
+ * own (a chunked-parent post-write step, the semantic-merge post effects, the
+ * profile or question write) still finalizes the writes already committed
+ * before the original error propagates. When a catch site or the success tail
+ * already ran the finalizer, the boundary only rethrows. Nothing is durable
+ * before the finalizer is bound, so an earlier throw propagates as is.
+ */
+export class CommittedWriteFinalization {
+  private finalizer: FinalizeCommittedWrites | undefined;
+  private started: Promise<void> | undefined;
+
+  bind(finalize: FinalizeCommittedWrites): FinalizeCommittedWrites {
+    this.finalizer = (scheduleQmd) => (this.started ??= finalize(scheduleQmd));
+    return this.finalizer;
+  }
+
+  async run<T>(pass: () => Promise<T>): Promise<T> {
+    try {
+      return await pass();
+    } catch (err) {
+      if (!this.finalizer || this.started) throw err;
+      return rethrowAfterCommittedWriteFinalization(this.finalizer, err, "persist pass");
+    }
+  }
+}
+
+/** A pass method's parameter list without its leading CommittedWriteFinalization. */
+export type ArgsAfterFinalization<Params> = Params extends [CommittedWriteFinalization, ...infer Rest] ? Rest : never;

package/src/orchestration/extraction-persist.ts

@@ -1,7 +1,7 @@
 import { classifyExtractionOrigin, type ExtractionSourceContext } from "./extraction-origin-context.js";
 import { confirmActiveFactDuplicate, persistUnderFactDedupWindow } from "./fact-dedup-window.js";
 import { writePromotionUnderFactDedupWindow } from "./promotion-dedup-window.js";
-import { rethrowAfterCommittedWriteFinalization } from "./extraction-persist-failure.js";
+import { type ArgsAfterFinalization, CommittedWriteFinalization, rethrowAfterCommittedWriteFinalization } from "./extraction-persist-failure.js";
 import { evaluateInjectionScreen, screenEntityForIndex, screenPersistStrings } from "./extraction-injection-gate.js";
 /**
  * Extraction persistence coordinator (issue #1526, seam 16).
@@ -152,7 +152,13 @@ export class ExtractionPersistCoordinator {
     return this.deps.getDependencyPropagationDelivery();
   }
 
-  async persistExtraction(
+  persistExtraction(...args: ArgsAfterFinalization<Parameters<ExtractionPersistCoordinator["persistExtractionPass"]>>): Promise<ExtractionPersistResult> {
+    const finalization = new CommittedWriteFinalization(); // #3288: one batch-end finalization boundary per pass
+    return finalization.run(() => this.persistExtractionPass(finalization, ...args));
+  }
+
+  private async persistExtractionPass(
+    finalization: CommittedWriteFinalization,
     result: ExtractionResult,
     storage: StorageManager,
     threadIdForExtraction?: string | null,
@@ -1125,7 +1131,7 @@ export class ExtractionPersistCoordinator {
       0,
       this.deps.config.extractionMaxProfileUpdatesPerRun,
     );
-    const finalizeCommittedWrites = async (scheduleQmd: boolean): Promise<void> => {
+    const finalizeCommittedWrites = finalization.bind(async (scheduleQmd: boolean): Promise<void> => {
       await finalizeExtractionCommittedWrites({
         saveContentHashIndexes: () => this.deps.saveContentHashIndexes(),
         behaviorSignalsByStorage: behaviorSignalsByStorage.values(),
@@ -1150,7 +1156,7 @@ export class ExtractionPersistCoordinator {
         requestQmdMaintenance: () => this.deps.requestQmdMaintenance(),
         scheduleQmd,
       });
-    };
+    });
 
     if (
       facts.length < result.facts.length ||
@@ -2211,6 +2217,24 @@ export class ExtractionPersistCoordinator {
           const tombstoneBlocked = parentWrite.tombstoneBlocked;
           const postWriteGuard =
             faithfulnessEnforceStatus === "pending_review" || tombstoneBlocked;
+          // #3288: the parent is durable now. Track it before any post-write step
+          // that can throw (non-chunked rule, #3231); a retry exact-dedupes it.
+          trackBehaviorSignals(
+            targetStorage,
+            buildBehaviorSignalsForMemory({
+              memoryId: parentId,
+              category: writeCategory,
+              content: fact.content,
+              namespace: this.deps.storageDirNamespace(targetStorage.dir),
+              confidence: fact.confidence,
+              source: "extraction",
+            }),
+          );
+          trackPersistedId(targetStorage, parentId, {
+            pendingReview: postWriteGuard,
+            category: writeCategory,
+            harmonicFact,
+          });
           // #1645: defer contradiction auto-resolve until tombstone status is
           // known (see applyDeferredContradictionResolve).
           const contradictionOutcome = await this.deps.applyDeferredContradictionResolve(
@@ -2306,11 +2330,6 @@ export class ExtractionPersistCoordinator {
           log.debug(
             `chunked memory ${parentId} into ${chunkResult.chunks.length} chunks`,
           );
-          trackPersistedId(targetStorage, parentId, {
-            pendingReview: postWriteGuard,
-            category: writeCategory,
-            harmonicFact,
-          });
           await anchorSnapshots.replace(targetStorage, parentId, writeCategory, memoryPathById);
           // #1576 (cursor Medium): keep pending_review ids out of threadEpisodeIdsForGraph — else later active facts build thread-predecessor edges to an unfaithful memory.
           if (
@@ -2490,17 +2509,6 @@ export class ExtractionPersistCoordinator {
           } finally {
             // #1522: the catalog write touch lives in the storage chokepoint.
           }
-          trackBehaviorSignals(
-            targetStorage,
-            buildBehaviorSignalsForMemory({
-              memoryId: parentId,
-              category: writeCategory,
-              content: fact.content,
-              namespace: this.deps.storageDirNamespace(targetStorage.dir),
-              confidence: fact.confidence,
-              source: "extraction",
-            }),
-          );
           continue; // Skip the normal write below
         }
       }
@@ -2967,7 +2975,7 @@ export class ExtractionPersistCoordinator {
     }
 
     // Shared batch-end finalization (hash, behavior, harmonic, temporal).
-    // Failure paths call the same helper with scheduleQmd=true (#3231).
+    // Failure paths call it with scheduleQmd=true (#3231); it runs once per pass (#3288).
     await finalizeCommittedWrites(false);
 
     const dedupSuffix = `${dedupedCount > 0 ? ` (${dedupedCount} deduped)` : ""}${semanticMergedCount > 0 ? ` (${semanticMergedCount} merged)` : ""}`;