@remix-run/router 1.8.0-pre.0 → 1.9.0-pre.0

package/dist/router.umd.js

@@ -1,5 +1,5 @@
 /**
- * @remix-run/router v1.8.0-pre.0
+ * @remix-run/router v1.9.0-pre.0
  *
  * Copyright (c) Remix Software Inc.
  *
@@ -629,6 +629,10 @@
    * Route action function signature
    */
 
+  /**
+   * Arguments passed to shouldRevalidate function
+   */
+
   /**
    * Route shouldRevalidate function signature.  This runs after any submission
    * (navigation or fetcher), so we flatten the navigation/fetcher submission
@@ -1467,7 +1471,7 @@
    * @private
    * Utility class we use to hold auto-unwrapped 4xx/5xx Response bodies
    */
-  class ErrorResponse {
+  class ErrorResponseImpl {
     constructor(status, statusText, data, internal) {
       if (internal === void 0) {
         internal = false;
@@ -1484,6 +1488,9 @@
     }
   }
 
+  // We don't want the class exported since usage of it at runtime is an
+  // implementation detail, but we do want to export the shape so folks can
+  // build their own abstractions around instances via isRouteErrorResponse()
   /**
    * Check if the given error is an ErrorResponse generated from a 4xx/5xx
    * Response thrown from an action/loader
@@ -2468,8 +2475,7 @@
             fetchers: new Map(state.fetchers)
           });
           return startRedirectNavigation(state, actionResult, {
-            submission,
-            isFetchActionRedirect: true
+            fetcherSubmission: submission
           });
         }
       }
@@ -2684,18 +2690,15 @@
     async function startRedirectNavigation(state, redirect, _temp) {
       let {
         submission,
-        replace,
-        isFetchActionRedirect
+        fetcherSubmission,
+        replace
       } = _temp === void 0 ? {} : _temp;
       if (redirect.revalidate) {
         isRevalidationRequired = true;
       }
-      let redirectLocation = createLocation(state.location, redirect.location, // TODO: This can be removed once we get rid of useTransition in Remix v2
-      _extends({
+      let redirectLocation = createLocation(state.location, redirect.location, {
         _isRedirect: true
-      }, isFetchActionRedirect ? {
-        _isFetchActionRedirect: true
-      } : {}));
+      });
       invariant(redirectLocation, "Expected a location on the redirect navigation");
       if (isBrowser) {
         let isDocumentReload = false;
@@ -2727,11 +2730,19 @@
 
       // Use the incoming submission if provided, fallback on the active one in
       // state.navigation
-      let activeSubmission = submission || getSubmissionFromNavigation(state.navigation);
+      let {
+        formMethod,
+        formAction,
+        formEncType
+      } = state.navigation;
+      if (!submission && !fetcherSubmission && formMethod && formAction && formEncType) {
+        submission = getSubmissionFromNavigation(state.navigation);
+      }
 
       // If this was a 307/308 submission we want to preserve the HTTP method and
       // re-submit the GET/POST/PUT/PATCH/DELETE as a submission navigation to the
       // redirected location
+      let activeSubmission = submission || fetcherSubmission;
       if (redirectPreserveMethodStatusCodes.has(redirect.status) && activeSubmission && isMutationMethod(activeSubmission.formMethod)) {
         await startNavigation(redirectHistoryAction, redirectLocation, {
           submission: _extends({}, activeSubmission, {
@@ -2740,20 +2751,14 @@
           // Preserve this flag across redirects
           preventScrollReset: pendingPreventScrollReset
         });
-      } else if (isFetchActionRedirect) {
-        // For a fetch action redirect, we kick off a new loading navigation
-        // without the fetcher submission, but we send it along for shouldRevalidate
-        await startNavigation(redirectHistoryAction, redirectLocation, {
-          overrideNavigation: getLoadingNavigation(redirectLocation),
-          fetcherSubmission: activeSubmission,
-          // Preserve this flag across redirects
-          preventScrollReset: pendingPreventScrollReset
-        });
       } else {
-        // If we have a submission, we will preserve it through the redirect navigation
-        let overrideNavigation = getLoadingNavigation(redirectLocation, activeSubmission);
+        // If we have a navigation submission, we will preserve it through the
+        // redirect navigation
+        let overrideNavigation = getLoadingNavigation(redirectLocation, submission);
         await startNavigation(redirectHistoryAction, redirectLocation, {
           overrideNavigation,
+          // Send fetcher submissions through for shouldRevalidate
+          fetcherSubmission,
           // Preserve this flag across redirects
           preventScrollReset: pendingPreventScrollReset
         });
@@ -3272,7 +3277,7 @@
         });
         if (request.signal.aborted) {
           let method = isRouteRequest ? "queryRoute" : "query";
-          throw new Error(method + "() call aborted");
+          throw new Error(method + "() call aborted: " + request.method + " " + request.url);
         }
       }
       if (isRedirectResult(result)) {
@@ -3391,7 +3396,7 @@
       }))]);
       if (request.signal.aborted) {
         let method = isRouteRequest ? "queryRoute" : "query";
-        throw new Error(method + "() call aborted");
+        throw new Error(method + "() call aborted: " + request.method + " " + request.url);
       }
 
       // Process and commit output from loaders
@@ -3848,7 +3853,17 @@
       if (match.route.lazy) {
         if (handler) {
           // Run statically defined handler in parallel with lazy()
-          let values = await Promise.all([runHandler(handler), loadLazyRouteModule(match.route, mapRouteProperties, manifest)]);
+          let handlerError;
+          let values = await Promise.all([
+          // If the handler throws, don't let it immediately bubble out,
+          // since we need to let the lazy() execution finish so we know if this
+          // route has a boundary that can handle the error
+          runHandler(handler).catch(e => {
+            handlerError = e;
+          }), loadLazyRouteModule(match.route, mapRouteProperties, manifest)]);
+          if (handlerError) {
+            throw handlerError;
+          }
           result = values[0];
         } else {
           // Load lazy route module, then run any returned handler
@@ -3956,7 +3971,7 @@
       if (resultType === ResultType.error) {
         return {
           type: resultType,
-          error: new ErrorResponse(status, result.statusText, data),
+          error: new ErrorResponseImpl(status, result.statusText, data),
           headers: result.headers
         };
       }
@@ -4235,7 +4250,7 @@
         errorMessage = "Invalid request method \"" + method.toUpperCase() + "\"";
       }
     }
-    return new ErrorResponse(status || 500, statusText, new Error(errorMessage), true);
+    return new ErrorResponseImpl(status || 500, statusText, new Error(errorMessage), true);
   }
 
   // Find any returned redirect errors, starting from the lowest match
@@ -4483,8 +4498,7 @@
         formData: submission.formData,
         json: submission.json,
         text: submission.text,
-        data,
-        " _hasFetcherDoneAnything ": true
+        data
       };
       return fetcher;
     } else {
@@ -4496,8 +4510,7 @@
         formData: undefined,
         json: undefined,
         text: undefined,
-        data,
-        " _hasFetcherDoneAnything ": true
+        data
       };
       return fetcher;
     }
@@ -4511,8 +4524,7 @@
       formData: submission.formData,
       json: submission.json,
       text: submission.text,
-      data: existingFetcher ? existingFetcher.data : undefined,
-      " _hasFetcherDoneAnything ": true
+      data: existingFetcher ? existingFetcher.data : undefined
     };
     return fetcher;
   }
@@ -4525,8 +4537,7 @@
       formData: undefined,
       json: undefined,
       text: undefined,
-      data,
-      " _hasFetcherDoneAnything ": true
+      data
     };
     return fetcher;
   }
@@ -4534,12 +4545,12 @@
 
   exports.AbortedDeferredError = AbortedDeferredError;
   exports.Action = Action;
-  exports.ErrorResponse = ErrorResponse;
   exports.IDLE_BLOCKER = IDLE_BLOCKER;
   exports.IDLE_FETCHER = IDLE_FETCHER;
   exports.IDLE_NAVIGATION = IDLE_NAVIGATION;
   exports.UNSAFE_DEFERRED_SYMBOL = UNSAFE_DEFERRED_SYMBOL;
   exports.UNSAFE_DeferredData = DeferredData;
+  exports.UNSAFE_ErrorResponseImpl = ErrorResponseImpl;
   exports.UNSAFE_convertRoutesToDataRoutes = convertRoutesToDataRoutes;
   exports.UNSAFE_getPathContributingMatches = getPathContributingMatches;
   exports.UNSAFE_invariant = invariant;