@remix-run/router 1.0.3-pre.0 → 1.0.3-pre.1

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # `@remix-run/router`
 
+## 1.0.3-pre.1
+
+### Patch Changes
+
+- fix `createURL` in local file execution in Firefox ([#9464](https://github.com/remix-run/react-router/pull/9464))
+- make url-encoding history-aware ([#9496](https://github.com/remix-run/react-router/pull/9496))
+
 ## 1.0.3-pre.0
 
 ### Patch Changes

package/dist/history.d.ts

@@ -106,6 +106,14 @@ export interface History {
      * @param to - The destination URL
      */
     createHref(to: To): string;
+    /**
+     * Encode a location the same way window.history would do (no-op for memory
+     * history) so we ensure our PUSH/REPLAC e navigations for data routers
+     * behave the same as POP
+     *
+     * @param location The incoming location from router.navigate()
+     */
+    encodeLocation(location: Location): Location;
     /**
      * Pushes a new location onto the history stack, increasing its length by one.
      * If there were any entries in the stack after the current one, they are
@@ -218,6 +226,7 @@ export declare function createPath({ pathname, search, hash, }: Partial<Path>):
  * Parses a string URL path into its separate pathname, search, and hash components.
  */
 export declare function parsePath(path: string): Partial<Path>;
+export declare function createURL(location: Location | string): URL;
 export interface UrlHistory extends History {
 }
 export declare type UrlHistoryOptions = {

package/dist/router.cjs.js

@@ -1,5 +1,5 @@
 /**
- * @remix-run/router v1.0.3-pre.0
+ * @remix-run/router v1.0.3-pre.1
  *
  * Copyright (c) Remix Software Inc.
  *
@@ -113,6 +113,10 @@ function createMemoryHistory(options) {
       return typeof to === "string" ? to : createPath(to);
     },
 
+    encodeLocation(location) {
+      return location;
+    },
+
     push(to, state) {
       action = exports.Action.Push;
       let nextLocation = createMemoryLocation(to, state);
@@ -370,6 +374,14 @@ function parsePath(path) {
 
   return parsedPath;
 }
+function createURL(location) {
+  // window.location.origin is "null" (the literal string value) in Firefox
+  // under certain conditions, notably when serving from a local HTML file
+  // See https://bugzilla.mozilla.org/show_bug.cgi?id=878297
+  let base = typeof window !== "undefined" && typeof window.location !== "undefined" && window.location.origin !== "null" ? window.location.origin : "unknown://unknown";
+  let href = typeof location === "string" ? location : createPath(location);
+  return new URL(href, base);
+}
 
 function getUrlBasedHistory(getLocation, createHref, validateLocation, options) {
   if (options === void 0) {
@@ -460,6 +472,16 @@ function getUrlBasedHistory(getLocation, createHref, validateLocation, options)
       return createHref(window, to);
     },
 
+    encodeLocation(location) {
+      // Encode a Location the same way window.location would
+      let url = createURL(createPath(location));
+      return _extends({}, location, {
+        pathname: url.pathname,
+        search: url.search,
+        hash: url.hash
+      });
+    },
+
     push,
     replace,
 
@@ -548,9 +570,12 @@ function matchRoutes(routes, locationArg, basename) {
   let matches = null;
 
   for (let i = 0; matches == null && i < branches.length; ++i) {
-    matches = matchRouteBranch(branches[i], // incoming pathnames are always encoded from either window.location or
-    // from route.navigate, but we want to match against the unencoded paths
-    // in the route definitions
+    matches = matchRouteBranch(branches[i], // Incoming pathnames are generally encoded from either window.location
+    // or from router.navigate, but we want to match against the unencoded
+    // paths in the route definitions.  Memory router locations won't be
+    // encoded here but there also shouldn't be anything to decode so this
+    // should be a safe operation.  This avoids needing matchRoutes to be
+    // history-aware.
     safelyDecodeURI(pathname));
   }
 
@@ -1482,12 +1507,7 @@ function createRouter(init) {
     // the same encoding we'd get from a history.pushState/window.location read
     // without having to touch history
 
-    let url = createURL(createPath(location));
-    location = _extends({}, location, {
-      pathname: url.pathname,
-      search: url.search,
-      hash: url.hash
-    });
+    location = init.history.encodeLocation(location);
     let historyAction = (opts && opts.replace) === true || submission != null ? exports.Action.Replace : exports.Action.Push;
     let preventScrollReset = opts && "preventScrollReset" in opts ? opts.preventScrollReset === true : undefined;
     return await startNavigation(historyAction, location, {
@@ -2560,8 +2580,6 @@ function unstable_createStaticHandler(routes) {
     let result;
 
     if (!actionMatch.route.action) {
-      let href = createServerHref(new URL(request.url));
-
       if (isRouteRequest) {
         throw createRouterErrorResponse(null, {
           status: 405,
@@ -2569,7 +2587,7 @@ function unstable_createStaticHandler(routes) {
         });
       }
 
-      result = getMethodNotAllowedResult(href);
+      result = getMethodNotAllowedResult(request.url);
     } else {
       result = await callLoaderOrAction("action", request, actionMatch, matches, undefined, // Basename not currently supported in static handlers
       true, isRouteRequest);
@@ -2753,7 +2771,7 @@ function normalizeNavigateOptions(to, opts, isFetcher) {
       path,
       submission: {
         formMethod: opts.formMethod,
-        formAction: createServerHref(parsePath(path)),
+        formAction: stripHashFromPath(path),
         formEncType: opts && opts.formEncType || "application/x-www-form-urlencoded",
         formData: opts.formData
       }
@@ -3033,7 +3051,7 @@ async function callLoaderOrAction(type, request, match, matches, basename, isSta
 }
 
 function createRequest(location, signal, submission) {
-  let url = createURL(location).toString();
+  let url = createURL(stripHashFromPath(location)).toString();
   let init = {
     signal
   };
@@ -3226,7 +3244,7 @@ function getMethodNotAllowedMatches(routes) {
 }
 
 function getMethodNotAllowedResult(path) {
-  let href = typeof path === "string" ? path : createServerHref(path);
+  let href = typeof path === "string" ? path : createPath(path);
   console.warn("You're trying to submit to a route that does not have an action.  To " + "fix this, please add an `action` function to the route for " + ("[" + href + "]"));
   return {
     type: ResultType.error,
@@ -3243,11 +3261,13 @@ function findRedirect(results) {
       return result;
     }
   }
-} // Create an href to represent a "server" URL without the hash
-
+}
 
-function createServerHref(location) {
-  return (location.pathname || "") + (location.search || "");
+function stripHashFromPath(path) {
+  let parsedPath = typeof path === "string" ? parsePath(path) : path;
+  return createPath(_extends({}, parsedPath, {
+    hash: ""
+  }));
 }
 
 function isHashChangeOnly(a, b) {
@@ -3365,12 +3385,6 @@ function getTargetMatch(matches, location) {
 
   let pathMatches = getPathContributingMatches(matches);
   return pathMatches[pathMatches.length - 1];
-}
-
-function createURL(location) {
-  let base = typeof window !== "undefined" && typeof window.location !== "undefined" ? window.location.origin : "unknown://unknown";
-  let href = typeof location === "string" ? location : createServerHref(location);
-  return new URL(href, base);
 } //#endregion
 
 exports.AbortedDeferredError = AbortedDeferredError;