@remit/web-client 0.0.39 → 0.0.41

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/web-client",
-  "version": "0.0.39",
+  "version": "0.0.41",
   "type": "module",
   "description": "Remit web client, published as composable primitives — the app shell, auth shells, and runtime config. A distributor imports what it composes and bundles it.",
   "exports": {

package/src/components/mail/MailSidebarAdapter.tsx

@@ -128,6 +128,7 @@ function useSelectedNavId(): string {
 	const location = useLocation();
 	const params = useParams({ strict: false }) as { mailboxId?: string };
 
+	if (location.pathname.startsWith("/settings")) return "settings";
 	if (location.pathname.startsWith("/mail/outbox")) return "outbox";
 	if (location.pathname.startsWith("/mail/flagged")) return "flagged";
 	if (params.mailboxId) return params.mailboxId;
@@ -271,6 +272,19 @@ export function MailSidebarAdapter({
 				</Link>
 			);
 		}
+		if (navId === "settings") {
+			return (
+				<Link
+					to="/settings/accounts"
+					onClick={() => onClick?.()}
+					className={className}
+					aria-label={ariaLabel}
+					title={title}
+				>
+					{children}
+				</Link>
+			);
+		}
 		return (
 			<Link
 				to="/mail/$mailboxId"

package/src/components/mail/MailboxPane.tsx

@@ -99,6 +99,7 @@ import {
 	buildConversationTarget,
 	type ConversationTarget,
 } from "@/lib/conversation-target";
+import { dedupeThreadMessages } from "@/lib/dedupe-thread-messages";
 import { readIntelligencePref } from "@/lib/intelligence-pref";
 import { useMailContext } from "@/lib/mail-context";
 import { isRescueCandidate } from "@/lib/rescue-candidates";
@@ -370,7 +371,9 @@ function MailboxPaneProvider({
 		});
 
 	const rawThreads = dropDeletedThreads(
-		threadsData?.pages.flatMap((page) => page.items ?? []) ?? [],
+		dedupeThreadMessages(
+			threadsData?.pages.flatMap((page) => page.items ?? []) ?? [],
+		),
 	);
 
 	const [filterCategory, setFilterCategory] = useState("all");

package/src/lib/dedupe-thread-messages.test.ts

@@ -0,0 +1,78 @@
+import assert from "node:assert";
+import { describe, test } from "node:test";
+import type { RemitImapThreadMessageResponse } from "@remit/api-http-client/types.gen.ts";
+import { dedupeThreadMessages } from "./dedupe-thread-messages.js";
+
+function threadMessage(
+	overrides: Partial<RemitImapThreadMessageResponse> = {},
+): RemitImapThreadMessageResponse {
+	return {
+		threadId: "t1",
+		threadMessageId: "tm1",
+		messageId: "m1",
+		accountConfigId: "cfg_1",
+		mailboxId: "mb1",
+		fromName: "Sender",
+		fromEmail: "sender@example.com",
+		subject: "Subject",
+		snippet: "Snippet",
+		sentDate: 1767225600,
+		isRead: false,
+		isDeleted: false,
+		hasAttachment: false,
+		hasStars: false,
+		star: "none",
+		senderTrust: "unknown",
+		createdAt: 0,
+		updatedAt: 0,
+		...overrides,
+	};
+}
+
+describe("dedupeThreadMessages (#166)", () => {
+	test("collapses an overlapping page to one row per threadMessageId", () => {
+		const pageOne = [
+			threadMessage({ threadMessageId: "tm1", messageId: "m1" }),
+			threadMessage({ threadMessageId: "tm2", messageId: "m2" }),
+		];
+		const pageTwo = [
+			threadMessage({ threadMessageId: "tm2", messageId: "m2" }),
+			threadMessage({ threadMessageId: "tm3", messageId: "m3" }),
+		];
+
+		const got = dedupeThreadMessages([...pageOne, ...pageTwo]);
+
+		assert.deepStrictEqual(
+			got.map((item) => item.threadMessageId),
+			["tm1", "tm2", "tm3"],
+		);
+	});
+
+	test("keeps the first occurrence's data when duplicates disagree", () => {
+		const items = [
+			threadMessage({ threadMessageId: "tm1", isRead: false }),
+			threadMessage({ threadMessageId: "tm1", isRead: true }),
+		];
+
+		const got = dedupeThreadMessages(items);
+
+		assert.equal(got.length, 1);
+		assert.equal(got[0].isRead, false);
+	});
+
+	test("leaves non-overlapping pages unaffected", () => {
+		const items = [
+			threadMessage({ threadMessageId: "tm1", messageId: "m1" }),
+			threadMessage({ threadMessageId: "tm2", messageId: "m2" }),
+			threadMessage({ threadMessageId: "tm3", messageId: "m3" }),
+		];
+
+		const got = dedupeThreadMessages(items);
+
+		assert.deepStrictEqual(got, items);
+	});
+
+	test("returns an empty array for empty input", () => {
+		assert.deepStrictEqual(dedupeThreadMessages([]), []);
+	});
+});

package/src/lib/dedupe-thread-messages.ts

@@ -0,0 +1,26 @@
+import type { RemitImapThreadMessageResponse } from "@remit/api-http-client/types.gen.ts";
+
+/**
+ * Pure helper: collapse a flattened list of thread messages to one row per
+ * `threadMessageId`, keeping the first occurrence.
+ *
+ * Belt-and-braces guard for issue #166. The web client appends every fetched
+ * page as-is and relies on the keyset cursor never handing back an overlapping
+ * page. `threadMessageId` is unique per message, so two rows sharing one are
+ * the same message — dropping the later row removes a duplicate, never a
+ * distinct result. Applied where pages are flattened into the list, so every
+ * consumer of the list sees a clean array and no render site has to remember
+ * to dedupe.
+ */
+export const dedupeThreadMessages = (
+	items: RemitImapThreadMessageResponse[],
+): RemitImapThreadMessageResponse[] => {
+	const seen = new Set<string>();
+	const deduped: RemitImapThreadMessageResponse[] = [];
+	for (const item of items) {
+		if (seen.has(item.threadMessageId)) continue;
+		seen.add(item.threadMessageId);
+		deduped.push(item);
+	}
+	return deduped;
+};