@remit/web-client 0.0.324 → 0.0.326

package/src/lib/organize/filter-run.test.ts

@@ -1,79 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import { type FilterRunReading, filterRunStatus } from "./filter-run";
-
-const reading = (over: Partial<FilterRunReading> = {}): FilterRunReading => ({
-	progress: {
-		state: undefined,
-		matchedCount: 0,
-		appliedCount: 0,
-		failedCount: 0,
-		errorMessage: "",
-	},
-	failure: undefined,
-	isStarting: false,
-	isRunning: false,
-	isDone: false,
-	...over,
-});
-
-describe("filterRunStatus (#1354)", () => {
-	it("is nothing before a run", () => {
-		assert.equal(filterRunStatus(reading()), undefined);
-	});
-
-	it("is queuing while the request is out, then running", () => {
-		assert.deepEqual(filterRunStatus(reading({ isStarting: true })), {
-			kind: "queuing",
-		});
-		assert.deepEqual(filterRunStatus(reading({ isRunning: true })), {
-			kind: "running",
-		});
-	});
-
-	it("is a failure carrying the worker's reason when the job failed", () => {
-		const status = filterRunStatus(
-			reading({
-				isDone: true,
-				progress: {
-					state: "Failed",
-					matchedCount: 0,
-					appliedCount: 0,
-					failedCount: 0,
-					errorMessage: "This filter is turned off or has expired.",
-				},
-			}),
-		);
-		assert.equal(status?.kind, "failed");
-		assert.match(
-			String(status?.kind === "failed" && (status.error as Error).message),
-			/turned off/,
-		);
-	});
-
-	it("is a failure when the request itself failed", () => {
-		const error = new Error("offline");
-		assert.deepEqual(
-			filterRunStatus(reading({ failure: { kind: "startFailed", error } })),
-			{ kind: "failed", error },
-		);
-	});
-
-	it("is done with the counts of a completed job", () => {
-		assert.deepEqual(
-			filterRunStatus(
-				reading({
-					isDone: true,
-					progress: {
-						state: "Complete",
-						matchedCount: 4,
-						appliedCount: 3,
-						failedCount: 1,
-						errorMessage: "",
-					},
-				}),
-			),
-			{ kind: "done", matched: 4, applied: 3 },
-		);
-	});
-});

package/src/lib/organize/filter-run.ts

@@ -1,48 +0,0 @@
-import type {
-	OrganizeJobFailure,
-	OrganizeJobProgress,
-} from "@/hooks/useOrganizeJob";
-
-/** Where a Run now stands, as the filter's row says it. */
-export type FilterRunStatus =
-	| { kind: "queuing" }
-	| { kind: "running" }
-	| { kind: "done"; matched: number; applied: number }
-	| { kind: "failed"; error: unknown };
-
-export interface FilterRunReading {
-	progress: OrganizeJobProgress;
-	failure: OrganizeJobFailure | undefined;
-	isStarting: boolean;
-	isRunning: boolean;
-	isDone: boolean;
-}
-
-/**
- * The row's status for the job a Run now started. A job the worker failed —
- * a filter turned off since, or deleted — is a failure like a refused start,
- * never a lingering "running".
- */
-export const filterRunStatus = (
-	reading: FilterRunReading,
-): FilterRunStatus | undefined => {
-	if (reading.failure) return { kind: "failed", error: reading.failure.error };
-	if (reading.isStarting) return { kind: "queuing" };
-	if (reading.isDone) {
-		if (reading.progress.state === "Failed") {
-			return {
-				kind: "failed",
-				error: new Error(
-					reading.progress.errorMessage || "The run over the inbox failed.",
-				),
-			};
-		}
-		return {
-			kind: "done",
-			matched: reading.progress.matchedCount,
-			applied: reading.progress.appliedCount,
-		};
-	}
-	if (reading.isRunning) return { kind: "running" };
-	return undefined;
-};

package/src/lib/organize/filter-status.test.ts

@@ -1,120 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import {
-	filterDisplayStatus,
-	formatExpiresAt,
-	pickedDateToExpiresAt,
-} from "./filter-status";
-
-const NOW = Date.parse("2026-07-12T12:00:00Z");
-
-describe("filterDisplayStatus", () => {
-	it("marks a disabled filter Disabled (#1103)", () => {
-		assert.equal(
-			filterDisplayStatus({ scope: "Standing", state: "Disabled" }, NOW),
-			"Disabled",
-		);
-	});
-
-	it("marks a disabled temporary filter past its date Expired", () => {
-		assert.equal(
-			filterDisplayStatus(
-				{
-					scope: "Temporary",
-					state: "Disabled",
-					expiresAt: "2020-01-01T00:00:00Z",
-				},
-				NOW,
-			),
-			"Expired",
-		);
-	});
-
-	it("treats a Standing filter as always Active", () => {
-		assert.equal(
-			filterDisplayStatus({ scope: "Standing", state: "Active" }, NOW),
-			"Active",
-		);
-	});
-
-	it("treats a Temporary filter past its expiresAt as Expired even when state still caches Active (RFC 034 Decision 1.2)", () => {
-		assert.equal(
-			filterDisplayStatus(
-				{
-					scope: "Temporary",
-					state: "Active",
-					expiresAt: "2026-07-10T00:00:00Z",
-				},
-				NOW,
-			),
-			"Expired",
-		);
-	});
-
-	it("treats a Temporary filter before its expiresAt as Active", () => {
-		assert.equal(
-			filterDisplayStatus(
-				{
-					scope: "Temporary",
-					state: "Active",
-					expiresAt: "2026-07-20T00:00:00Z",
-				},
-				NOW,
-			),
-			"Active",
-		);
-	});
-
-	it("honors a state the server already flipped to Expired", () => {
-		assert.equal(
-			filterDisplayStatus(
-				{
-					scope: "Temporary",
-					state: "Expired",
-					expiresAt: "2026-07-20T00:00:00Z",
-				},
-				NOW,
-			),
-			"Expired",
-		);
-	});
-});
-
-describe("formatExpiresAt", () => {
-	it("returns undefined for a missing value", () => {
-		assert.equal(formatExpiresAt(undefined), undefined);
-	});
-
-	it("returns undefined for an unparseable value", () => {
-		assert.equal(formatExpiresAt("not-a-date"), undefined);
-	});
-
-	it("renders a parseable date", () => {
-		assert.equal(typeof formatExpiresAt("2026-07-16T23:59:59+02:00"), "string");
-	});
-});
-
-describe("pickedDateToExpiresAt", () => {
-	it("returns undefined for empty input", () => {
-		assert.equal(pickedDateToExpiresAt(""), undefined);
-	});
-
-	it("returns undefined for a non date-only string", () => {
-		assert.equal(pickedDateToExpiresAt("2026/07/16"), undefined);
-	});
-
-	it("produces an ISO 8601 timestamp with a zone offset at end of the picked day", () => {
-		const utcReference = new Date("2026-07-12T12:00:00Z");
-		const result = pickedDateToExpiresAt("2026-07-16", utcReference);
-		assert.equal(result, "2026-07-16T23:59:59+00:00");
-	});
-
-	it("round-trips back to the same calendar day it was expiring on", () => {
-		const iso = pickedDateToExpiresAt(
-			"2026-07-16",
-			new Date("2026-07-12T12:00:00Z"),
-		);
-		assert.ok(iso);
-		assert.equal(new Date(Date.parse(iso)).getUTCDate(), 16);
-	});
-});

package/src/lib/organize/filter-status.ts

@@ -1,115 +0,0 @@
-import type { RemitImapFilterResponse } from "@remit/api-http-client/types.gen.ts";
-
-export type FilterDisplayStatus = "Active" | "Expired" | "Disabled";
-
-export type FilterDisabledReason = RemitImapFilterResponse["disabledReason"];
-
-/**
- * The displayed Active/Expired status of a filter.
- *
- * RFC 034 Decision 1.2: `expiresAt` is the source of truth, `state` is only a
- * lazily-patched cache. A `Temporary` filter whose `expiresAt` is in the past
- * is Expired the instant that comparison is made, even if the server has not
- * yet patched `state` to `Expired`. So the client compares `expiresAt` against
- * `now` directly and also honors a `state` the server already flipped.
- *
- * An `Expired` filter is never hidden — it stays listed so the user can see
- * what it was and when it stopped (RFC 034 Decision 1.2, "stops on its own").
- */
-export const filterDisplayStatus = (
-	filter: Pick<RemitImapFilterResponse, "scope" | "expiresAt" | "state">,
-	now: number,
-): FilterDisplayStatus => {
-	if (filter.state === "Expired") return "Expired";
-	const running = filter.state === "Disabled" ? "Disabled" : "Active";
-	if (filter.scope !== "Temporary") return running;
-	if (!filter.expiresAt) return running;
-
-	const expiresAtMs = Date.parse(filter.expiresAt);
-	if (Number.isNaN(expiresAtMs)) return running;
-	return expiresAtMs <= now ? "Expired" : running;
-};
-
-const DISABLED_REASON_COPY: Record<
-	Exclude<FilterDisabledReason, "None">,
-	string
-> = {
-	UserDisabled: "Turned off. Turn it on to run it on new mail again.",
-	AwaitingFolder:
-		"Off until its folder exists on the mail server. It turns on by itself once the folder is created.",
-	FolderCreateFailed:
-		"Off: the mail server refused to create its folder. Pick another folder in the rule, then turn it on.",
-	FolderMissing:
-		"Off: the folder it moves mail into no longer exists. Pick another folder in the rule, then turn it on.",
-};
-
-export const disabledReasonCopy = (
-	filter: Pick<RemitImapFilterResponse, "disabledReason" | "actionMailboxId">,
-): string | undefined => {
-	if (filter.disabledReason === "None") return undefined;
-	const folderless =
-		filter.disabledReason === "AwaitingFolder" ||
-		filter.disabledReason === "FolderCreateFailed";
-	if (folderless && filter.actionMailboxId !== "None") {
-		return DISABLED_REASON_COPY.UserDisabled;
-	}
-	return DISABLED_REASON_COPY[filter.disabledReason];
-};
-
-/**
- * Human-readable rendering of an expiry timestamp, e.g. "Jul 16, 2026".
- * Returns `undefined` for an absent or unparseable value so a standing filter
- * (no `expiresAt`) renders nothing.
- */
-export const formatExpiresAt = (
-	expiresAt: string | undefined,
-): string | undefined => {
-	if (!expiresAt) return undefined;
-	const ms = Date.parse(expiresAt);
-	if (Number.isNaN(ms)) return undefined;
-	return new Date(ms).toLocaleDateString(undefined, {
-		year: "numeric",
-		month: "short",
-		day: "numeric",
-	});
-};
-
-/**
- * Turn a plain picked calendar date (`YYYY-MM-DD`, from a native date input)
- * into an ISO 8601 timestamp with the local zone offset, at end of that day —
- * the filter is meant to stay active through the whole picked day (RFC 034
- * Decision 1.1, a zoned civil date). Returns `undefined` for empty input.
- */
-export const pickedDateToExpiresAt = (
-	pickedDate: string,
-	referenceDate: Date = new Date(),
-): string | undefined => {
-	if (!pickedDate) return undefined;
-	const match = /^(\d{4})-(\d{2})-(\d{2})$/.exec(pickedDate);
-	if (!match) return undefined;
-
-	const [, year, month, day] = match;
-	const local = new Date(
-		Number(year),
-		Number(month) - 1,
-		Number(day),
-		23,
-		59,
-		59,
-		0,
-	);
-	if (Number.isNaN(local.getTime())) return undefined;
-
-	const offsetMinutes = -referenceDate.getTimezoneOffset();
-	const sign = offsetMinutes >= 0 ? "+" : "-";
-	const abs = Math.abs(offsetMinutes);
-	const offHours = String(Math.floor(abs / 60)).padStart(2, "0");
-	const offMins = String(abs % 60).padStart(2, "0");
-
-	const pad = (value: number) => String(value).padStart(2, "0");
-	return (
-		`${local.getFullYear()}-${pad(local.getMonth() + 1)}-${pad(local.getDate())}` +
-		`T${pad(local.getHours())}:${pad(local.getMinutes())}:${pad(local.getSeconds())}` +
-		`${sign}${offHours}:${offMins}`
-	);
-};

package/src/lib/organize/label-delete-copy.test.ts

@@ -1,21 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import { deleteLabelConfirmCopy } from "./label-delete-copy";
-
-describe("deleteLabelConfirmCopy", () => {
-	it("names the label with no blast-radius note when no filter uses it", () => {
-		const copy = deleteLabelConfirmCopy("Receipts", 0);
-		assert.equal(copy.title, 'Delete the "Receipts" label?');
-		assert.equal(copy.description, undefined);
-	});
-
-	it("names exactly one filter in the singular", () => {
-		const copy = deleteLabelConfirmCopy("Receipts", 1);
-		assert.match(copy.description ?? "", /1 filter that applies it/);
-	});
-
-	it("names several filters in the plural", () => {
-		const copy = deleteLabelConfirmCopy("Receipts", 3);
-		assert.match(copy.description ?? "", /3 filters that apply it/);
-	});
-});

package/src/lib/organize/label-delete-copy.ts

@@ -1,22 +0,0 @@
-/**
- * The delete-confirmation copy for a label (issue #26). Deleting a label
- * cascades in both directions server-side — every filter whose action applies
- * it is deleted outright, never left dangling — so the confirmation names the
- * filter count up front rather than surprising the user after the fact. The
- * API itself never blocks the delete; the confirmation is the only gate.
- */
-export const deleteLabelConfirmCopy = (
-	labelName: string,
-	filterCount: number,
-): { title: string; description?: string } => {
-	if (filterCount === 0) {
-		return { title: `Delete the "${labelName}" label?` };
-	}
-	const filterNoun = filterCount === 1 ? "filter" : "filters";
-	return {
-		title: `Delete the "${labelName}" label?`,
-		description: `This also deletes ${filterCount} ${filterNoun} that ${
-			filterCount === 1 ? "applies" : "apply"
-		} it — they can't be recovered.`,
-	};
-};

package/src/lib/organize/organize-model.test.ts

@@ -1,209 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import type { RuleClause } from "@remit/ui";
-import {
-	buildCreateFilterInput,
-	buildOrganizeInput,
-	buildWizardDraft,
-	hasCommittableAction,
-	NO_ACTION,
-	type OrganizeDraft,
-	organizeScopeFor,
-} from "./organize-model";
-
-const baseDraft = (overrides: Partial<OrganizeDraft> = {}): OrganizeDraft => ({
-	matchOperator: "And",
-	literalClauses: [],
-	...overrides,
-});
-
-describe("hasCommittableAction", () => {
-	it("is false when neither a move nor a label is chosen — a keep-in-place draft has nothing to commit", () => {
-		assert.equal(hasCommittableAction(baseDraft()), false);
-	});
-
-	it("is false for the None sentinel on both actions", () => {
-		assert.equal(
-			hasCommittableAction(
-				baseDraft({ moveMailboxId: NO_ACTION, labelId: NO_ACTION }),
-			),
-			false,
-		);
-	});
-
-	it("is true once a real destination mailbox is chosen", () => {
-		assert.equal(
-			hasCommittableAction(baseDraft({ moveMailboxId: "mbx-1" })),
-			true,
-		);
-	});
-
-	it("is true once a real label is chosen, with no move target (issue #26)", () => {
-		assert.equal(hasCommittableAction(baseDraft({ labelId: "lbl-1" })), true);
-	});
-
-	it("is true when both a move and a label are chosen", () => {
-		assert.equal(
-			hasCommittableAction(
-				baseDraft({ moveMailboxId: "mbx-1", labelId: "lbl-1" }),
-			),
-			true,
-		);
-	});
-});
-
-describe("buildOrganizeInput", () => {
-	it("defaults both actions to None when neither is set", () => {
-		const input = buildOrganizeInput(baseDraft());
-		assert.equal(input.actionMailboxId, NO_ACTION);
-		assert.equal(input.actionLabelId, NO_ACTION);
-		assert.equal(input.matchOperator, "And");
-		assert.deepEqual(input.literalClauses, []);
-	});
-
-	it("carries the move and label actions independently (issue #26)", () => {
-		const input = buildOrganizeInput(
-			baseDraft({ moveMailboxId: "mbx-9", labelId: "lbl-9" }),
-		);
-		assert.equal(input.actionMailboxId, "mbx-9");
-		assert.equal(input.actionLabelId, "lbl-9");
-	});
-});
-
-describe("buildCreateFilterInput", () => {
-	it("builds a Standing filter with no expiresAt", () => {
-		const input = buildCreateFilterInput(
-			baseDraft({ moveMailboxId: "mbx-2" }),
-			"standing",
-			"Travel",
-		);
-		assert.equal(input.scope, "Standing");
-		assert.equal("expiresAt" in input, false);
-		assert.equal(input.name, "Travel");
-		assert.equal(input.actionMailboxId, "mbx-2");
-		assert.equal(input.actionLabelId, NO_ACTION);
-	});
-
-	it("builds a Temporary filter that carries expiresAt", () => {
-		const input = buildCreateFilterInput(
-			baseDraft({
-				moveMailboxId: "mbx-2",
-				expiresAt: "2026-07-16T23:59:59+02:00",
-			}),
-			"temporary",
-			"Trip",
-		);
-		assert.equal(input.scope, "Temporary");
-		assert.equal(input.expiresAt, "2026-07-16T23:59:59+02:00");
-	});
-
-	it("never sends a client-side ttl — the server derives it from expiresAt", () => {
-		const input = buildCreateFilterInput(
-			baseDraft({
-				moveMailboxId: "mbx-2",
-				expiresAt: "2026-07-16T23:59:59+02:00",
-			}),
-			"temporary",
-			"Trip",
-		);
-		assert.equal("ttl" in input, false);
-	});
-
-	it("carries a label action (issue #26)", () => {
-		const input = buildCreateFilterInput(
-			baseDraft({ labelId: "lbl-1" }),
-			"standing",
-			"Receipts",
-		);
-		assert.equal(input.actionLabelId, "lbl-1");
-	});
-});
-
-describe("organizeScopeFor", () => {
-	it("reads the ticked list at scope once as just-these", () => {
-		assert.equal(organizeScopeFor({ mode: "selected" }), "just-these");
-		assert.equal(
-			organizeScopeFor({ mode: "selected", ruleScope: "once" }),
-			"just-these",
-		);
-	});
-
-	it("reads the properties door at scope once as all-like-these", () => {
-		assert.equal(organizeScopeFor({ mode: "properties" }), "all-like-these");
-		assert.equal(
-			organizeScopeFor({ mode: "properties", ruleScope: "once" }),
-			"all-like-these",
-		);
-	});
-
-	it("reads the two persisting scopes off the scope answer alone", () => {
-		for (const mode of ["selected", "properties"] as const) {
-			assert.equal(
-				organizeScopeFor({ mode, ruleScope: "standing" }),
-				"standing",
-			);
-			assert.equal(organizeScopeFor({ mode, ruleScope: "until" }), "temporary");
-		}
-	});
-});
-
-describe("buildWizardDraft", () => {
-	const clauses: RuleClause[] = [
-		{ id: "c1", field: "From", value: "noreply@booking.com" },
-	];
-
-	it("turns the until scope's civil date into a zoned expiresAt", () => {
-		const draft = buildWizardDraft({
-			mode: "properties",
-			ruleScope: "until",
-			clauses,
-			matchOperator: "any",
-			moveMailboxId: "mbx-2",
-			until: "2026-09-30",
-		});
-		assert.match(
-			draft.expiresAt ?? "",
-			/^2026-09-30T23:59:59[+-]\d{2}:\d{2}$/,
-			"the day the rule stops on becomes an instant with an offset",
-		);
-	});
-
-	it("carries no expiry for the scopes that never expire", () => {
-		for (const ruleScope of ["once", "standing"] as const) {
-			const draft = buildWizardDraft({
-				mode: "properties",
-				ruleScope,
-				clauses,
-				matchOperator: "all",
-				until: "2026-09-30",
-			});
-			assert.equal(draft.expiresAt, undefined);
-		}
-	});
-
-	it("maps the wizard's operator onto the API's", () => {
-		assert.equal(
-			buildWizardDraft({ mode: "properties", clauses, matchOperator: "all" })
-				.matchOperator,
-			"And",
-		);
-		assert.equal(
-			buildWizardDraft({ mode: "properties", clauses, matchOperator: "any" })
-				.matchOperator,
-			"Or",
-		);
-	});
-
-	it("sends the clause field and value, and nothing the chip carries besides", () => {
-		const draft = buildWizardDraft({
-			mode: "properties",
-			clauses: [
-				{ id: "c1", field: "Subject", value: "receipt", derived: true },
-			],
-			matchOperator: "all",
-		});
-		assert.deepEqual(draft.literalClauses, [
-			{ field: "Subject", value: "receipt" },
-		]);
-	});
-});