@remit/web-client 0.0.275 → 0.0.277

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/web-client",
-  "version": "0.0.275",
+  "version": "0.0.277",
   "type": "module",
   "description": "Remit web client, published as composable primitives — the app shell, auth shells, and runtime config. A distributor imports what it composes and bundles it.",
   "exports": {

package/src/components/mail/MailSidebarAdapter.tsx

@@ -10,7 +10,7 @@ import type {
 import type { NavAccount, NavLinkComponent, NavMailboxRole } from "@remit/ui";
 import { NavSidebar } from "@remit/ui";
 import { useQueries, useQuery, useQueryClient } from "@tanstack/react-query";
-import { useCallback, useMemo, useState } from "react";
+import { useCallback, useMemo } from "react";
 import { useTranslation } from "react-i18next";
 import {
 	buildMailboxRoleMap,
@@ -19,12 +19,7 @@ import {
 } from "@/lib/folder-roles";
 import { useMailContext } from "@/lib/mail-context";
 import { isOutboxListRow } from "@/lib/outbox-status";
-import {
-	loadSavedSearches,
-	removeSavedSearch,
-	saveSearch,
-} from "@/lib/saved-searches";
-import { NavLink, useSearchEverything, useSelectedNavId } from "@/routing";
+import { NavLink, useSelectedNavId } from "@/routing";
 
 interface MailSidebarAdapterProps {
 	accounts: RemitImapAccountResponse[];
@@ -123,10 +118,8 @@ export function MailSidebarAdapter({
 	variant = "desktop",
 }: MailSidebarAdapterProps) {
 	const queryClient = useQueryClient();
-	const searchEverything = useSearchEverything();
 	const selectedNavId = useSelectedNavId();
-	const { searchInput, onSearchChange } = useMailContext();
-	const [savedSearches, setSavedSearches] = useState(loadSavedSearches);
+	const { onSearchChange } = useMailContext();
 	const { t } = useTranslation("mail", { useSuspense: false });
 	const translator: Translator = useCallback(
 		(key, fallback) => t(key, { defaultValue: fallback }),
@@ -311,37 +304,6 @@ export function MailSidebarAdapter({
 		onMailboxSelect?.();
 	};
 
-	// Saved searches (#428 follow-up, local-only MVP — see
-	// doc/design/flows/06-search.md). A saved query is the raw typed text; the
-	// existing token parser re-derives its chips on reselect, so there's nothing
-	// else to persist.
-	const trimmedSearchInput = searchInput.trim();
-	const saveableQuery =
-		trimmedSearchInput.length > 0 && !savedSearches.includes(trimmedSearchInput)
-			? trimmedSearchInput
-			: undefined;
-
-	const handleSaveCurrentSearch = useCallback(() => {
-		if (!saveableQuery) return;
-		setSavedSearches(saveSearch(saveableQuery));
-	}, [saveableQuery]);
-
-	const handleRemoveSavedSearch = useCallback((query: string) => {
-		setSavedSearches(removeSavedSearch(query));
-	}, []);
-
-	// Running a saved search re-uses the daily brief as the search surface (the
-	// cross-account default view) — the same destination the search field
-	// itself lands results in once a query is active.
-	const handleSelectSavedSearch = useCallback(
-		(query: string) => {
-			onSearchChange(query);
-			searchEverything(query);
-			onMailboxSelect?.();
-		},
-		[onSearchChange, searchEverything, onMailboxSelect],
-	);
-
 	return (
 		<NavSidebar
 			accounts={navAccounts}
@@ -350,11 +312,6 @@ export function MailSidebarAdapter({
 			linkComponent={linkComponent}
 			calendarNav="shown"
 			variant={variant}
-			savedSearches={savedSearches}
-			saveableQuery={saveableQuery}
-			onSaveCurrentSearch={handleSaveCurrentSearch}
-			onSelectSavedSearch={handleSelectSavedSearch}
-			onRemoveSavedSearch={handleRemoveSavedSearch}
 		/>
 	);
 }

package/src/lib/search-view.test.ts

@@ -38,7 +38,7 @@ describe("searchInputForView", () => {
 		);
 	});
 
-	it("seeds from the destination's own query (deep link, saved search)", () => {
+	it("seeds from the destination's own query (deep link)", () => {
 		assert.equal(
 			searchInputForView(
 				"/mail/$mailboxId:inbox-1",

package/src/routes/settings/-senders-remove-flag.render.test.ts

@@ -0,0 +1,105 @@
+// biome-ignore lint/style/useFilenamingConvention: TanStack Router convention
+/**
+ * Issue #615: the remove control in Settings > Senders sent `{ flags: {
+ * [group]: null } }`. The server's openapi-backend validator doesn't honour
+ * `nullable: true` on the `allOf`-wrapped flag schema TypeSpec emits for
+ * `TrustedFlag | null`, so it rejects the null form as invalid — the same gap
+ * `useToggleTrusted` already works around by sending `{ value: false }`
+ * instead of `null`. This mock server enforces that same rejection, so the
+ * pre-fix `null` body surfaces as a failed mutation (the row never clears)
+ * rather than a silently accepted no-op.
+ */
+
+import assert from "node:assert/strict";
+import { afterEach, describe, it } from "node:test";
+import type { RemitImapAddressResponse } from "@remit/api-http-client/types.gen.ts";
+import { createElement } from "react";
+import { createDomHarness, type DomHarness } from "@/test-support/dom";
+import {
+	type HttpCall,
+	type HttpMock,
+	httpError,
+	mockFetch,
+} from "@/test-support/http";
+import { SearchGroupPane } from "./senders";
+
+const ADDRESS_ID = "addr-1";
+
+let harness: DomHarness | undefined;
+let http: HttpMock | undefined;
+let mutedFlag: { value: boolean; setAt: number } | undefined;
+
+afterEach(() => {
+	harness?.close();
+	harness = undefined;
+	http?.restore();
+	http = undefined;
+	mutedFlag = undefined;
+});
+
+const address = (): RemitImapAddressResponse =>
+	({
+		addressId: ADDRESS_ID,
+		displayName: "Alex Rivera",
+		normalizedEmail: "alex@example.com",
+		flags: mutedFlag ? { muted: mutedFlag } : {},
+	}) as RemitImapAddressResponse;
+
+const readFlagsPatch = (call: HttpCall): unknown => {
+	const body = call.body as { flags?: Record<string, unknown> } | undefined;
+	return body?.flags?.muted;
+};
+
+const respond = (call: HttpCall): unknown => {
+	if (call.method === "GET" && call.path === "/addresses/search") {
+		return { items: [address()] };
+	}
+	if (call.method === "PATCH" && call.path === `/addresses/${ADDRESS_ID}`) {
+		const patch = readFlagsPatch(call);
+		if (patch === null) {
+			return httpError(400, "flags.muted: nullable removal is not accepted");
+		}
+		mutedFlag = patch as { value: boolean; setAt: number };
+		return address();
+	}
+	return {};
+};
+
+const mount = async (): Promise<void> => {
+	mutedFlag = { value: true, setAt: 1_700_000_000_000 };
+	http = mockFetch(respond);
+	harness = createDomHarness();
+	harness.renderApp(
+		createElement(SearchGroupPane, { group: "muted", query: "alex" }),
+	);
+	await harness.waitFor(
+		() => harness?.text().includes("alex@example.com") ?? false,
+	);
+};
+
+describe("removing a sender flag (#615)", () => {
+	it("sends a request body the server accepts, and the flag clears from the list", async () => {
+		await mount();
+		if (!harness) throw new Error("nothing mounted");
+
+		harness.click(harness.byLabel("Remove muted flag"));
+
+		await harness.waitFor(
+			() => !(harness?.text().includes("alex@example.com") ?? true),
+			"the unmuted sender to drop out of the muted list",
+		);
+
+		const patches = (http?.calls ?? []).filter(
+			(call) =>
+				call.method === "PATCH" && call.path === `/addresses/${ADDRESS_ID}`,
+		);
+		assert.equal(patches.length, 1);
+		const sentFlag = readFlagsPatch(patches[0]) as
+			| { value: boolean; setAt: number }
+			| null
+			| undefined;
+		assert.notEqual(sentFlag, null, "the server rejects a null flag removal");
+		assert.equal(sentFlag?.value, false);
+		assert.equal(typeof sentFlag?.setAt, "number");
+	});
+});

package/src/routes/settings/senders.tsx

@@ -174,7 +174,7 @@ function VipGroupPane({
 /* Muted / Blocked groups: search-based (backend gap noted)           */
 /* ------------------------------------------------------------------ */
 
-function SearchGroupPane({
+export function SearchGroupPane({
 	group,
 	query,
 	onCount,
@@ -303,7 +303,9 @@ function SearchGroupPane({
 										setRetryId(a.addressId);
 										removeMutation.mutate({
 											path: { addressId: a.addressId },
-											body: { flags: { [group]: null } },
+											body: {
+												flags: { [group]: { value: false, setAt: Date.now() } },
+											},
 										});
 									}}
 								>
@@ -321,7 +323,9 @@ function SearchGroupPane({
 										setRetryId(a.addressId);
 										removeMutation.mutate({
 											path: { addressId: a.addressId },
-											body: { flags: { [group]: null } },
+											body: {
+												flags: { [group]: { value: false, setAt: Date.now() } },
+											},
 										});
 									}}
 								/>

package/src/routing/search-mirror-convergence.render.test.ts

@@ -184,7 +184,7 @@ describe("an address that drifts from the settled query", () => {
 	});
 
 	it("does not fight a query arriving mid-debounce", async () => {
-		// A deep link or a saved search lands while the field is still catching
+		// A deep link lands while the field is still catching
 		// up. The committed query is the previous one, so the mirror has nothing
 		// settled to write and must not strip what just arrived.
 		const router = buildRouter(`${LIST_PATH}?q=receipts`);

package/src/routing/search-navigation.ts

@@ -5,10 +5,9 @@ import { useCallback } from "react";
  * Search everything, carrying the query.
  *
  * "Everything" is the daily brief — the cross-account view whose scope is
- * nothing — so dropping the scope chip and running a saved search are the same
- * movement, and both are a navigation rather than an edit of the query text:
- * the chip mirrors the route (see `lib/search-scope.ts`), so editing the text
- * would leave the chip up and the list still narrowed.
+ * nothing — so dropping the scope chip is a navigation rather than an edit of
+ * the query text: the chip mirrors the route (see `lib/search-scope.ts`), so
+ * editing the text would leave the chip up and the list still narrowed.
  */
 export function useSearchEverything(): (query: string) => void {
 	const navigate = useNavigate();

package/src/lib/saved-searches.test.ts

@@ -1,80 +0,0 @@
-import assert from "node:assert";
-import { beforeEach, describe, test } from "node:test";
-import {
-	isSearchSaved,
-	loadSavedSearches,
-	removeSavedSearch,
-	saveSearch,
-} from "./saved-searches.js";
-
-function installMemoryStorage(): void {
-	const store = new Map<string, string>();
-	globalThis.localStorage = {
-		getItem: (k: string) => store.get(k) ?? null,
-		setItem: (k: string, v: string) => void store.set(k, v),
-		removeItem: (k: string) => void store.delete(k),
-		clear: () => store.clear(),
-		key: () => null,
-		length: 0,
-	} as Storage;
-}
-
-describe("saved-searches", () => {
-	beforeEach(installMemoryStorage);
-
-	test("starts empty", () => {
-		assert.deepEqual(loadSavedSearches(), []);
-	});
-
-	test("saves and loads a query", () => {
-		assert.deepEqual(saveSearch("from:alice has:attachment"), [
-			"from:alice has:attachment",
-		]);
-		assert.deepEqual(loadSavedSearches(), ["from:alice has:attachment"]);
-	});
-
-	test("most recent save first, deduplicated", () => {
-		saveSearch("alice");
-		saveSearch("bob");
-		assert.deepEqual(saveSearch("alice"), ["alice", "bob"]);
-	});
-
-	test("ignores blank queries", () => {
-		saveSearch("alice");
-		assert.deepEqual(saveSearch("   "), ["alice"]);
-	});
-
-	test("trims before storing", () => {
-		assert.deepEqual(saveSearch("  bob  "), ["bob"]);
-	});
-
-	test("survives corrupt storage", () => {
-		globalThis.localStorage.setItem("remit.savedSearches", "{not json");
-		assert.deepEqual(loadSavedSearches(), []);
-	});
-
-	test("removeSavedSearch drops the exact query", () => {
-		saveSearch("alice");
-		saveSearch("bob");
-		assert.deepEqual(removeSavedSearch("alice"), ["bob"]);
-		assert.deepEqual(loadSavedSearches(), ["bob"]);
-	});
-
-	test("removeSavedSearch is a no-op for a query that isn't saved", () => {
-		saveSearch("alice");
-		assert.deepEqual(removeSavedSearch("nonexistent"), ["alice"]);
-	});
-
-	test("isSearchSaved reflects the persisted set, trimmed", () => {
-		saveSearch("alice");
-		assert.equal(isSearchSaved("alice"), true);
-		assert.equal(isSearchSaved("  alice  "), true);
-		assert.equal(isSearchSaved("bob"), false);
-	});
-
-	test("caps at MAX_SAVED entries", () => {
-		for (let i = 0; i < 30; i++) saveSearch(`query-${i}`);
-		assert.equal(loadSavedSearches().length, 25);
-		assert.deepEqual(loadSavedSearches()[0], "query-29");
-	});
-});

package/src/lib/saved-searches.ts

@@ -1,52 +0,0 @@
-/**
- * Saved searches for the mail search bar, persisted in localStorage (#428
- * follow-up, local-only MVP — see doc/design/flows/06-search.md; no backend
- * preference storage yet). Mirrors `recent-searches.ts`: a query already
- * carries its filter chips (`parseSearchTokens` re-derives them), so saving
- * the raw query text is enough to reproduce the full search. Best-effort:
- * storage failures (private mode, quota) degrade to an empty list rather than
- * crashing the search surface.
- */
-const SAVED_SEARCHES_KEY = "remit.savedSearches";
-const MAX_SAVED = 25;
-
-export function loadSavedSearches(): string[] {
-	try {
-		const raw = localStorage.getItem(SAVED_SEARCHES_KEY);
-		if (!raw) return [];
-		const parsed: unknown = JSON.parse(raw);
-		if (!Array.isArray(parsed)) return [];
-		return parsed.filter((q): q is string => typeof q === "string");
-	} catch {
-		return [];
-	}
-}
-
-export function saveSearch(query: string): string[] {
-	const trimmed = query.trim();
-	if (!trimmed) return loadSavedSearches();
-	const next = [
-		trimmed,
-		...loadSavedSearches().filter((q) => q !== trimmed),
-	].slice(0, MAX_SAVED);
-	try {
-		localStorage.setItem(SAVED_SEARCHES_KEY, JSON.stringify(next));
-	} catch {
-		return next;
-	}
-	return next;
-}
-
-export function removeSavedSearch(query: string): string[] {
-	const next = loadSavedSearches().filter((q) => q !== query);
-	try {
-		localStorage.setItem(SAVED_SEARCHES_KEY, JSON.stringify(next));
-	} catch {
-		return next;
-	}
-	return next;
-}
-
-export function isSearchSaved(query: string): boolean {
-	return loadSavedSearches().includes(query.trim());
-}