@remit/web-client 0.0.236 → 0.0.238

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/web-client",
-  "version": "0.0.236",
+  "version": "0.0.238",
   "type": "module",
   "description": "Remit web client, published as composable primitives — the app shell, auth shells, and runtime config. A distributor imports what it composes and bundles it.",
   "exports": {

package/src/components/mail/IntelligencePane.test.ts

@@ -36,6 +36,7 @@ describe("resolveSimilarState — fail-fast on similar-messages search", () => {
 				similarError: new Error("500"),
 				similarErrorIsFatal: true,
 				isSimilarLoading: false,
+				semanticEnabled: true,
 			}),
 			"ready",
 		);
@@ -47,6 +48,7 @@ describe("resolveSimilarState — fail-fast on similar-messages search", () => {
 				similarError: new Error("404"),
 				similarErrorIsFatal: false,
 				isSimilarLoading: false,
+				semanticEnabled: true,
 			}),
 			"error",
 		);
@@ -58,6 +60,7 @@ describe("resolveSimilarState — fail-fast on similar-messages search", () => {
 				similarError: null,
 				similarErrorIsFatal: false,
 				isSimilarLoading: false,
+				semanticEnabled: true,
 			}),
 			"ready",
 		);
@@ -69,8 +72,39 @@ describe("resolveSimilarState — fail-fast on similar-messages search", () => {
 				similarError: null,
 				similarErrorIsFatal: false,
 				isSimilarLoading: true,
+				semanticEnabled: true,
 			}),
 			"loading",
 		);
 	});
 });
+
+// Off is a property of the deployment, and it leads: nothing was embedded, so
+// there was no query, and the section states the setting instead of an empty
+// list (#1068). `undefined` is the config read still in flight, which is not
+// an answer.
+describe("resolveSimilarState — semantic search off on this instance", () => {
+	test("off wins over every runtime state", () => {
+		assert.equal(
+			resolveSimilarState({
+				similarError: new Error("404"),
+				similarErrorIsFatal: false,
+				isSimilarLoading: true,
+				semanticEnabled: false,
+			}),
+			"off",
+		);
+	});
+
+	test("a config read still in flight is not an off state", () => {
+		assert.equal(
+			resolveSimilarState({
+				similarError: null,
+				similarErrorIsFatal: false,
+				isSimilarLoading: false,
+				semanticEnabled: undefined,
+			}),
+			"ready",
+		);
+	});
+});

package/src/components/mail/IntelligencePane.tsx

@@ -82,6 +82,11 @@ export const resolveSpamAction = (thread: {
 /**
  * Decide the "Similar messages" section state from the semantic-search query.
  *
+ * An instance with semantic search off leads, before any error or in-flight
+ * state: nothing is embedded, no query was sent, and the section states the
+ * setting (#1068). Only `false` counts — the config read has not answered yet
+ * while it is `undefined`, and an off state shown then would be a guess.
+ *
  * The fail-fast rule: a fatal first-party 5xx must NEVER degrade to the benign
  * grey "Similarity search unavailable" label — it escalates to the global red
  * overlay instead, so this returns `"ready"` for it (the section then renders
@@ -93,8 +98,15 @@ export const resolveSimilarState = (input: {
 	similarError: unknown;
 	similarErrorIsFatal: boolean;
 	isSimilarLoading: boolean;
+	semanticEnabled: boolean | undefined;
 }): SimilarState => {
-	const { similarError, similarErrorIsFatal, isSimilarLoading } = input;
+	const {
+		similarError,
+		similarErrorIsFatal,
+		isSimilarLoading,
+		semanticEnabled,
+	} = input;
+	if (semanticEnabled === false) return "off";
 	if (similarError && !similarErrorIsFatal) return "error";
 	if (isSimilarLoading) return "loading";
 	return "ready";
@@ -228,6 +240,7 @@ function WiredPanel({
 		isSimilarLoading,
 		similarError,
 		similarErrorIsFatal,
+		semanticEnabled,
 	} = useIntelligenceData(thread, mailboxId);
 	const [reclassifyOpen, setReclassifyOpen] = useState(false);
 	const senderEmail = thread.fromEmail ?? undefined;
@@ -336,6 +349,7 @@ function WiredPanel({
 		similarError,
 		similarErrorIsFatal,
 		isSimilarLoading,
+		semanticEnabled,
 	});
 
 	return (

package/src/components/mail/SelectionWizardHost.tsx

@@ -49,6 +49,7 @@ import { useOrganizeJob } from "@/hooks/useOrganizeJob";
 import { useOrganizeWiden } from "@/hooks/useOrganizeWiden";
 import { useRulePreview } from "@/hooks/useRulePreview";
 import { useSelectedSubjects } from "@/hooks/useSelectedSubjects";
+import { useSemanticSearchEnabled } from "@/hooks/useSemanticSearchEnabled";
 import type {
 	BulkActionProgress,
 	BulkActionTarget,
@@ -563,7 +564,12 @@ function SelectionWizardSession({
 	// unavailable while the user is already holding it. The fallback is taken then
 	// rather than left as a door that counts nothing: the property step says, in
 	// so many words, that these are the senders it substituted (#477 3.6).
-	const semanticUnavailable = widen.semanticUnavailable || widen.isError;
+	// Off is a deployment setting, not a probe result, and it reaches the door the
+	// same way the runtime failure does: dimmed, pressable, and falling back to
+	// the senders. Only the copy differs (#1068).
+	const semanticOff = useSemanticSearchEnabled() === false;
+	const semanticUnavailable =
+		semanticOff || widen.semanticUnavailable || widen.isError;
 	// Only while the door is the screen: the probe re-fires when the anchor
 	// changes under a background refetch, and a late answer that moved the step
 	// from Review would push an entry the wizard does not own and leave the count
@@ -1001,6 +1007,7 @@ function SelectionWizardSession({
 				accountId: wizardScope.accountId,
 				onModeChange: changeMode,
 				semanticUnavailable,
+				semanticOff,
 				semanticErrorDetail:
 					widen.error instanceof Error ? widen.error.message : undefined,
 				semanticFallbackTaken,

package/src/components/mail/intelligence-semantic-off.render.test.ts

@@ -0,0 +1,128 @@
+/**
+ * "Similar messages" on an instance with semantic search off (#1068).
+ *
+ * Off is a deployment setting, and the client learns it from the config read
+ * every surface already makes. Before this the section rendered nothing at all,
+ * which reads as a sender nothing resembles — the one thing an operator who
+ * has not turned semantic search on cannot tell from the truth.
+ *
+ * Drives the real chain: `useIntelligenceData` reads `GET /config`, the state
+ * resolver turns `semanticSearchEnabled: false` into the off state, and the
+ * real `IntelligencePanel` renders it. Both halves are asserted — the copy the
+ * operator acts on, and that no semantic query is sent at all.
+ */
+
+import assert from "node:assert/strict";
+import { afterEach, describe, it } from "node:test";
+import { IntelligencePanel } from "@remit/ui";
+import { createElement } from "react";
+import { useIntelligenceData } from "@/hooks/useIntelligenceData";
+import { createDomHarness, type DomHarness } from "@/test-support/dom";
+import {
+	makeAccount,
+	makeConfig,
+	makeThreadMessage,
+} from "@/test-support/fixtures";
+import { type HttpMock, mockFetch } from "@/test-support/http";
+import { resolveSimilarState } from "./IntelligencePane";
+
+const thread = makeThreadMessage({ messageId: "msg-1" });
+
+const SimilarHarness = () => {
+	const {
+		data,
+		isSimilarLoading,
+		similarError,
+		similarErrorIsFatal,
+		semanticEnabled,
+	} = useIntelligenceData(thread, "mbx-inbox");
+	if (!data) return null;
+	return createElement(IntelligencePanel, {
+		data,
+		similarState: resolveSimilarState({
+			similarError,
+			similarErrorIsFatal,
+			isSimilarLoading,
+			semanticEnabled,
+		}),
+	});
+};
+
+const respond =
+	(semanticSearchEnabled: boolean) => (call: { path: string }) => {
+		if (call.path.endsWith("/config")) {
+			return makeConfig([makeAccount({ accountId: "acc-1" })], {
+				semanticSearchEnabled,
+			});
+		}
+		if (call.path.endsWith("/addresses/search")) return { items: [] };
+		return { items: [] };
+	};
+
+let harness: DomHarness | undefined;
+let http: HttpMock;
+
+const waitFor = async (
+	predicate: () => boolean,
+	timeoutMs = 2000,
+): Promise<void> => {
+	if (!harness) throw new Error("nothing mounted");
+	const deadline = Date.now() + timeoutMs;
+	while (!predicate()) {
+		if (Date.now() > deadline) {
+			throw new Error(
+				`waitFor: condition never became true within ${timeoutMs}ms`,
+			);
+		}
+		await harness.flush();
+		await harness.wait(5);
+	}
+};
+
+afterEach(() => {
+	harness?.close();
+	harness = undefined;
+	http.restore();
+});
+
+describe("the Similar messages section on an instance with semantic search off", () => {
+	it("states the setting, what turning it on buys, and the command", async () => {
+		http = mockFetch(respond(false));
+		harness = createDomHarness();
+		harness.renderApp(createElement(SimilarHarness));
+
+		await waitFor(
+			() => harness?.text().includes("Semantic search is off") === true,
+		);
+
+		const text = harness.text();
+		assert.match(text, /Semantic search is off on this instance/);
+		assert.match(text, /Organize/);
+		assert.match(text, /filters/);
+		assert.match(text, /remit semantic on/);
+	});
+
+	it("sends no semantic query, because an empty answer is the same as no match", async () => {
+		http = mockFetch(respond(false));
+		harness = createDomHarness();
+		harness.renderApp(createElement(SimilarHarness));
+
+		await waitFor(
+			() => harness?.text().includes("Semantic search is off") === true,
+		);
+		await harness.wait(30);
+		await harness.flush();
+
+		assert.deepEqual(http.to("/search/semantic"), []);
+	});
+
+	it("says none of it while the instance has semantic search on", async () => {
+		http = mockFetch(respond(true));
+		harness = createDomHarness();
+		harness.renderApp(createElement(SimilarHarness));
+
+		await waitFor(() => http.to("/search/semantic").length > 0);
+
+		assert.doesNotMatch(harness.text(), /Semantic search is off/);
+	});
+});

package/src/hooks/useIntelligenceData.ts

@@ -18,6 +18,7 @@ import type {
 import { isThreadCategory } from "@remit/ui";
 import { useQuery } from "@tanstack/react-query";
 import { useMemo } from "react";
+import { useSemanticSearchEnabled } from "@/hooks/useSemanticSearchEnabled";
 import { isServerError } from "@/lib/error-classifier";
 import { formatDate, formatEmailDate } from "@/lib/format";
 import {
@@ -291,6 +292,12 @@ export interface UseIntelligenceDataResult {
 	 * error or an empty result keeps the panel quiet.
 	 */
 	similarErrorIsFatal: boolean;
+	/**
+	 * False on an instance with semantic search off (#1068): nothing is embedded,
+	 * so the query is never sent and the section states the setting instead of
+	 * rendering an empty list. `undefined` until the config read answers.
+	 */
+	semanticEnabled: boolean | undefined;
 	/**
 	 * True when the address lookup failed with a fatal first-party 5xx. The panel
 	 * must not silently render the sender's flags (VIP/muted/blocked) as absent —
@@ -342,6 +349,7 @@ export function useIntelligenceData(
 	);
 
 	// --- Semantic search: similar messages ---
+	const semanticEnabled = useSemanticSearchEnabled();
 	const semanticQuery = [subject, senderEmail].filter(Boolean).join(" ");
 	const {
 		data: semanticResult,
@@ -351,7 +359,13 @@ export function useIntelligenceData(
 		...semanticSearchOperationsSemanticSearchOptions({
 			query: { query: semanticQuery, limit: 5 },
 		}),
-		enabled: Boolean(thread && semanticQuery.length > 3),
+		// Waits for the config read rather than racing it. An off instance answers
+		// this query with an empty list, which the panel cannot tell from a sender
+		// nothing resembles, so the request is not worth sending on the chance the
+		// instance turns out to be on. `undefined` is that read still in flight;
+		// it is cached process-wide and every other surface already made it.
+		enabled:
+			Boolean(thread && semanticQuery.length > 3) && semanticEnabled === true,
 		staleTime: 60_000,
 		// A non-fatal failure (e.g. 404, no index yet) is acceptable — the sidebar
 		// degrades gracefully. A 5xx is NOT acceptable: it escalates globally and
@@ -397,6 +411,7 @@ export function useIntelligenceData(
 		isSimilarLoading,
 		similarError,
 		similarErrorIsFatal: isServerError(similarError),
+		semanticEnabled,
 		addressErrorIsFatal: isServerError(addressError),
 		addressId: address?.addressId,
 		address,

package/src/hooks/useSemanticSearchEnabled.ts

@@ -0,0 +1,23 @@
+import { configOperationsGetConfigOptions } from "@remit/api-http-client/@tanstack/react-query.gen.ts";
+import { useQuery } from "@tanstack/react-query";
+
+/**
+ * Whether this instance stores message vectors (#1068).
+ *
+ * A property of the deployment, so it rides the config read every surface
+ * already makes rather than a probe of its own: the semantic surfaces need the
+ * answer before they have a query to send, and an empty semantic result is
+ * indistinguishable from a mailbox with nothing similar in it.
+ *
+ * `undefined` while the config is in flight, and for a server that predates the
+ * field. Callers must therefore branch on `=== false`, so an instance whose
+ * answer has not arrived shows what it showed before rather than an off state
+ * it may not be in.
+ */
+export const useSemanticSearchEnabled = (): boolean | undefined => {
+	const { data } = useQuery({
+		...configOperationsGetConfigOptions(),
+		staleTime: Infinity,
+	});
+	return data?.semanticSearchEnabled;
+};

package/src/index.css

@@ -4,6 +4,13 @@
    the .dark ancestor scope used everywhere in this app. */
 @import "@remit/ui/tokens.css";
 
+/* The structural sheet the calendar grid's engine needs, which the kit ships
+   beside the component and every app that mounts it has to ask for. Without it
+   the week and day grids collapse into a stack and draw no events at all: the
+   engine lays its columns out against this sheet, and a column with no
+   geometry has nowhere to put an occurrence. */
+@import "@remit/ui/calendar.css";
+
 /* Tailwind v4 content scanning: name every source Tailwind must inspect for
    utility class usage. Automatic detection is rooted at the Vite root, which
    for the distributor harness build is a throwaway directory holding only the

package/src/test-support/fixtures.ts

@@ -87,6 +87,7 @@ export const makeThreadMessage = (
 
 export const makeConfig = (
 	accounts: RemitImapAccountResponse[],
+	overrides: Partial<RemitImapConfigDescriptionResponse> = {},
 ): RemitImapConfigDescriptionResponse => ({
 	accountConfig: {
 		accountConfigId: "cfg-1",
@@ -96,4 +97,6 @@ export const makeConfig = (
 		updatedAt: 0,
 	},
 	accounts,
+	semanticSearchEnabled: true,
+	...overrides,
 });