@remit/web-client 0.0.227 → 0.0.228

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/web-client",
-  "version": "0.0.227",
+  "version": "0.0.228",
   "type": "module",
   "description": "Remit web client, published as composable primitives — the app shell, auth shells, and runtime config. A distributor imports what it composes and bundles it.",
   "exports": {

package/src/components/ui/ErrorBanner.stories.tsx

@@ -95,6 +95,35 @@ export const WithActionLink: Story = {
 	},
 };
 
+/**
+ * A delete refused because the message is still being moved on the mail server
+ * (#845). Transient: the same press works once the move confirms, so the copy
+ * says so rather than sending the user off to report a bug.
+ */
+export const PlacementInFlight: Story = {
+	args: {
+		severity: "warning",
+		title: "Couldn't delete this message yet",
+		detail:
+			"It is still being moved on the mail server. Try again in a moment.",
+		action: { label: "Report an issue", href: REPORT_URL },
+	},
+};
+
+/**
+ * The same refusal after the move gave up without confirming. Waiting will
+ * never clear this one, so the remedy is a resync instead.
+ */
+export const PlacementUnverified: Story = {
+	args: {
+		severity: "warning",
+		title: "Couldn't delete 4 messages yet",
+		detail:
+			"An earlier move never finished, so where this message sits is unknown. Sync the folder, then delete it again.",
+		action: { label: "Report an issue", href: REPORT_URL },
+	},
+};
+
 /** The action link on the dark theme. */
 export const WithActionLinkDark: Story = {
 	name: "With Action Link (dark)",

package/src/components/ui/placement-refusal.test.ts

@@ -0,0 +1,72 @@
+import assert from "node:assert/strict";
+import { describe, it } from "node:test";
+import {
+	isPlacementRefusal,
+	placementRefusalBanner,
+} from "./placement-refusal.js";
+
+const refusal = (reason: string) => ({
+	message: "Message 4f1 was not acted on: its folder and uid do not name...",
+	code: "message_placement_unsettled",
+	details: { accountId: "acc-1", messageId: "msg-1", reason },
+});
+
+describe("isPlacementRefusal", () => {
+	it("reads the reason and the message off the coded body", () => {
+		assert.deepEqual(isPlacementRefusal(refusal("in_flight")), {
+			reason: "in_flight",
+			messageId: "msg-1",
+		});
+	});
+
+	it("ignores every other failure", () => {
+		assert.equal(isPlacementRefusal(undefined), undefined);
+		assert.equal(isPlacementRefusal(new Error("network")), undefined);
+		assert.equal(
+			isPlacementRefusal({ ...refusal("in_flight"), code: "other" }),
+			undefined,
+		);
+		assert.equal(isPlacementRefusal(refusal("something_else")), undefined);
+	});
+
+	it("does not match on the message text alone", () => {
+		assert.equal(
+			isPlacementRefusal(new Error("an earlier move has not settled")),
+			undefined,
+		);
+	});
+});
+
+describe("placementRefusalBanner", () => {
+	it("tells an in-flight move to wait", () => {
+		const banner = placementRefusalBanner(
+			{ reason: "in_flight", messageId: "msg-1" },
+			1,
+		);
+		assert.equal(banner.severity, "warning");
+		assert.match(banner.detail ?? "", /try again in a moment/i);
+	});
+
+	it("tells an abandoned move to resync, not to wait", () => {
+		const banner = placementRefusalBanner(
+			{ reason: "unverified", messageId: "msg-1" },
+			1,
+		);
+		assert.match(banner.detail ?? "", /sync the folder/i);
+		assert.doesNotMatch(banner.detail ?? "", /try again in a moment/i);
+	});
+
+	it("counts the selection in the title", () => {
+		assert.match(
+			placementRefusalBanner({ reason: "in_flight", messageId: "m" }, 4).title,
+			/4 messages/,
+		);
+	});
+
+	it("never repeats the server's uuid at the user", () => {
+		for (const reason of ["in_flight", "unverified"] as const) {
+			const banner = placementRefusalBanner({ reason, messageId: "msg-1" }, 1);
+			assert.doesNotMatch(`${banner.title} ${banner.detail}`, /msg-1/);
+		}
+	});
+});

package/src/components/ui/placement-refusal.ts

@@ -0,0 +1,66 @@
+/**
+ * The coded 409 a delete is refused with when the message's folder and uid do
+ * not name the same message (#845). Read the `code`, never the message: the
+ * server's sentence names a uuid and no remedy, and a message-string match
+ * would start firing on an unrelated conflict the moment the copy changes.
+ */
+import type { ApiError } from "@remit/api-http-client/types.gen.ts";
+import type { PushErrorInput } from "@/components/ui/error-banners";
+
+/**
+ * `in_flight` clears on its own once the mail server confirms the move;
+ * `unverified` does not, because the move gave up without confirming and
+ * nothing routine repairs the row.
+ */
+export type PlacementRefusalReason = "in_flight" | "unverified";
+
+export interface PlacementRefusal {
+	reason: PlacementRefusalReason;
+	messageId: string;
+}
+
+const REASONS: ReadonlySet<string> = new Set<PlacementRefusalReason>([
+	"in_flight",
+	"unverified",
+]);
+
+const stringAt = (
+	details: ApiError["details"],
+	key: string,
+): string | undefined => {
+	const value = details?.[key];
+	return typeof value === "string" ? value : undefined;
+};
+
+export const isPlacementRefusal = (
+	error: unknown,
+): PlacementRefusal | undefined => {
+	if (typeof error !== "object" || error === null) return undefined;
+	const body = error as Partial<ApiError>;
+	if (body.code !== "message_placement_unsettled") return undefined;
+	const { details } = body;
+	if (typeof details !== "object" || details === null) return undefined;
+	const reason = stringAt(details, "reason");
+	const messageId = stringAt(details, "messageId");
+	if (!reason || !REASONS.has(reason) || !messageId) return undefined;
+	return { reason: reason as PlacementRefusalReason, messageId };
+};
+
+/**
+ * The banner copy. Both reasons say what happened and what to do; neither is a
+ * dead end, and neither repeats the server's uuid at the user.
+ */
+export const placementRefusalBanner = (
+	refusal: PlacementRefusal,
+	count: number,
+): PushErrorInput => ({
+	severity: "warning",
+	title:
+		count > 1
+			? `Couldn't delete ${count} messages yet`
+			: "Couldn't delete this message yet",
+	detail:
+		refusal.reason === "in_flight"
+			? "It is still being moved on the mail server. Try again in a moment."
+			: "An earlier move never finished, so where this message sits is unknown. Sync the folder, then delete it again.",
+});

package/src/hooks/useDeleteMessages.ts

@@ -10,6 +10,10 @@ import { useRoleAppointmentPrompt } from "@/components/mail/RoleAppointmentPromp
 import { useErrorBanners } from "@/components/ui/ErrorBannerProvider";
 import { formatErrorDetail } from "@/components/ui/error-banners";
 import { isFolderRoleRefusal } from "@/components/ui/folder-role-refusal";
+import {
+	isPlacementRefusal,
+	placementRefusalBanner,
+} from "@/components/ui/placement-refusal";
 import { resolveMailboxesForMessages } from "@/hooks/useMarkAsRead";
 import { runChunkedMutation } from "@/lib/bulk-actions";
 import {
@@ -175,6 +179,11 @@ export const useDeleteMessages = ({
 				return;
 			}
 			const count = vars.body.messageIds?.length ?? 0;
+			const placement = isPlacementRefusal(err);
+			if (placement) {
+				pushError(placementRefusalBanner(placement, count));
+				return;
+			}
 			pushError({
 				title:
 					count > 1