@remit/web-client 0.0.148 → 0.0.149

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/web-client",
-  "version": "0.0.148",
+  "version": "0.0.149",
   "type": "module",
   "description": "Remit web client, published as composable primitives — the app shell, auth shells, and runtime config. A distributor imports what it composes and bundles it.",
   "exports": {

package/src/components/mail/IntelligencePane.render.test.ts

@@ -33,7 +33,7 @@ const baseData: IntelligenceData = {
 		dkimDomain: "example.com",
 		summary: "This message was signed by example.com.",
 	},
-	category: { value: "Personal" },
+	category: { value: "personal" },
 	similar: [],
 };
 

package/src/hooks/useIntelligenceData.test.ts

@@ -6,6 +6,7 @@ import type {
 } from "@remit/api-http-client/types.gen.ts";
 import {
 	buildAuthenticityIntel,
+	buildCategoryIntel,
 	buildSenderIntel,
 } from "./useIntelligenceData.js";
 
@@ -49,6 +50,45 @@ function makeAddress(
 	} as RemitImapAddressResponse;
 }
 
+// The generated union has a member for every category this build knows, so a
+// value outside it cannot be written as one — which is the whole point: it
+// arrives as JSON from a server that classifies into more than this client can.
+function threadCategorizedAs(category: string): RemitImapThreadMessageResponse {
+	return { ...makeThread(), category } as RemitImapThreadMessageResponse;
+}
+
+describe("buildCategoryIntel", () => {
+	test("carries a category the client knows through unchanged", () => {
+		const result = buildCategoryIntel(
+			makeThread({ category: "newsletter" }),
+			undefined,
+		);
+		assert.equal(result.value, "newsletter");
+	});
+
+	test("falls back to personal when the row carries no category", () => {
+		const result = buildCategoryIntel(makeThread(), undefined);
+		assert.equal(result.value, "personal");
+	});
+
+	test("resolves a category the client does not know to uncategorized", () => {
+		const result = buildCategoryIntel(
+			threadCategorizedAs("invoice"),
+			undefined,
+		);
+		assert.equal(result.value, "uncategorized");
+	});
+
+	test("marks the category overridden when the sender carries a different one", () => {
+		const thread = makeThread({ category: "personal" });
+		const address = makeAddress({
+			flags: { category: { value: "newsletter" } },
+		} as Partial<RemitImapAddressResponse>);
+		assert.equal(buildCategoryIntel(thread, address).overridden, true);
+		assert.equal(buildCategoryIntel(thread, undefined).overridden, false);
+	});
+});
+
 describe("buildSenderIntel", () => {
 	describe("counter wiring — counters present", () => {
 		test("surfaces inboundCount from address", () => {

package/src/hooks/useIntelligenceData.ts

@@ -15,6 +15,7 @@ import type {
 	SenderIntel,
 	SimilarMessageIntel,
 } from "@remit/ui";
+import { isThreadCategory } from "@remit/ui";
 import { useQuery } from "@tanstack/react-query";
 import { useMemo } from "react";
 import { isServerError } from "@/lib/error-classifier";
@@ -56,6 +57,28 @@ const NO_SIGNAL_SUMMARY =
 const UNREADABLE_SENDER_SUMMARY =
 	"We couldn't read this sender's address, so we can't confirm who really sent this message.";
 
+/**
+ * Build category intel from the thread message and address lookup.
+ *
+ * The row's category is a string the API chose, so it is narrowed rather than
+ * asserted: a value this build has no entry for — a category a newer server
+ * classifies into — resolves to `uncategorized`, which is the taxonomy's own
+ * name for "no classification this client can act on" and renders a readable
+ * neutral chip. Asserting instead would leave the chip with no tone at all.
+ */
+export function buildCategoryIntel(
+	thread: RemitImapThreadMessageResponse,
+	address: RemitImapAddressResponse | undefined,
+): IntelligenceData["category"] {
+	const served = thread.category ?? "personal";
+	return {
+		value: isThreadCategory(served) ? served : "uncategorized",
+		overridden:
+			address?.flags?.category?.value != null &&
+			address.flags.category.value !== thread.category,
+	};
+}
+
 /**
  * Build sender intel from the thread message and address lookup.
  *
@@ -357,12 +380,7 @@ export function useIntelligenceData(
 
 		const authenticity = buildAuthenticityIntel(thread, similar.length);
 
-		const category = {
-			value: thread.category ?? "personal",
-			overridden:
-				address?.flags?.category?.value != null &&
-				address.flags.category.value !== thread.category,
-		};
+		const category = buildCategoryIntel(thread, address);
 
 		const flags = buildSenderFlags(address);