@remit/web-client 0.0.11 → 0.0.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/web-client",
-  "version": "0.0.11",
+  "version": "0.0.12",
   "type": "module",
   "description": "Remit web client, published as composable primitives — the app shell, auth shells, and runtime config. A distributor imports what it composes and bundles it.",
   "exports": {

package/src/lib/brief.test.ts

@@ -145,11 +145,26 @@ describe("groupBriefSections", () => {
 
 	// --- Fallback to personal ---
 
-	test("missing category falls back to personal", () => {
+	test("missing category lands in its own Unclassified section", () => {
+		// Never folded into Personal: unclassified mail is work the classifier
+		// has not done, and hiding it inside Personal is what made issue #45
+		// look like a working classifier with a huge personal inbox.
 		const r = row({ id: "1" });
 		const sections = groupBriefSections([r]);
 		assert.strictEqual(sections.length, 1);
-		assert.strictEqual(sections[0].id, "personal");
+		assert.strictEqual(sections[0].id, "uncategorized");
+	});
+
+	test("uncategorized rows do not inflate the personal section", () => {
+		const sections = groupBriefSections([
+			row({ id: "1", category: "personal" }),
+			row({ id: "2", category: "uncategorized" }),
+			row({ id: "3", category: "uncategorized" }),
+		]);
+		const personal = sections.find((s) => s.id === "personal");
+		const unclassified = sections.find((s) => s.id === "uncategorized");
+		assert.strictEqual(personal?.threads.length, 1);
+		assert.strictEqual(unclassified?.threads.length, 2);
 	});
 
 	// --- Starred is a row marker, not a section (Flagged lives in the nav) ---

package/src/lib/brief.ts

@@ -10,9 +10,12 @@
  *  4. Marketing
  *  5. Social
  *  6. Automated
+ *  7. Unclassified
  *
  * Each row lands in the section for its category; a row with no category counts
- * as `personal` (the classifier's own fallback). Starred mail is not a section —
+ * as `uncategorized`, which is its own section rather than being folded into
+ * Personal — unclassified mail is missing work, not a decision (issue #45).
+ * Starred mail is not a section —
  * the star is a per-row marker, so a starred message stays in its category.
  *
  * Sender trust (vip/wellknown) no longer sections the brief — the signal is
@@ -87,6 +90,11 @@ const CATEGORY_SECTIONS: ReadonlyArray<{
 	{ id: "marketing", label: "Marketing", category: MessageCategory.marketing },
 	{ id: "social", label: "Social", category: MessageCategory.social },
 	{ id: "automated", label: "Automated", category: MessageCategory.automated },
+	{
+		id: "uncategorized",
+		label: "Unclassified",
+		category: MessageCategory.uncategorized,
+	},
 ];
 
 /**
@@ -104,9 +112,9 @@ export function groupBriefSections(rows: ThreadRowData[]): ThreadSection[] {
 	);
 
 	for (const row of rows) {
-		const category = row.category ?? MessageCategory.personal;
+		const category = row.category ?? MessageCategory.uncategorized;
 		const bucket =
-			byCategory.get(category) ?? byCategory.get(MessageCategory.personal);
+			byCategory.get(category) ?? byCategory.get(MessageCategory.uncategorized);
 		bucket?.push(row);
 	}
 

package/src/lib/display-category.test.ts

@@ -0,0 +1,29 @@
+import assert from "node:assert/strict";
+import { describe, test } from "node:test";
+import { toDisplayCategory } from "./display-category.js";
+
+describe("toDisplayCategory", () => {
+	test("shows an unclassified message as unclassified, not personal", () => {
+		// Collapsing `uncategorized` into `personal` made "the classifier never
+		// ran" indistinguishable from "the classifier decided this is personal"
+		// (issue #45).
+		assert.strictEqual(toDisplayCategory("uncategorized"), "uncategorized");
+	});
+
+	test("treats a row with no category as unclassified", () => {
+		assert.strictEqual(toDisplayCategory(undefined), "uncategorized");
+	});
+
+	test("passes every classified category through unchanged", () => {
+		for (const category of [
+			"personal",
+			"newsletter",
+			"marketing",
+			"automated",
+			"transactional",
+			"social",
+		] as const) {
+			assert.strictEqual(toDisplayCategory(category), category);
+		}
+	});
+});

package/src/lib/display-category.ts

@@ -5,16 +5,18 @@ import type { ThreadCategory } from "@remit/ui";
  * Map an API message category to a kit display category.
  *
  * The API category is total (RFC 032 Tier 2) and carries `uncategorized` for
- * messages that are metadata-synced but not yet body-classified. The kit's
- * display unions (`ThreadCategory`, `EmailRenderCategory`, badge `MessageCategory`)
- * have no `uncategorized` member — there is nothing to show for "not yet
- * classified", so it collapses to `personal`, the classifier's own fallback and
- * the display default that never renders a badge. Pre-migration rows that still
- * read `undefined` collapse the same way.
+ * messages that are metadata-synced but not yet body-classified. That state is
+ * shown as itself, not collapsed into `personal`: collapsing made an
+ * unclassified message identical on screen to one the classifier positively
+ * decided was personal, so a classification gap read as a large personal inbox
+ * rather than as missing work (issue #45).
+ *
+ * Pre-migration rows that read `undefined` carry no category either, so they
+ * map to `uncategorized` the same way.
  */
 export function toDisplayCategory(
 	category: RemitImapMessageCategory | undefined,
 ): ThreadCategory {
-	if (category === undefined || category === "uncategorized") return "personal";
+	if (category === undefined) return "uncategorized";
 	return category;
 }