@remit/ui 0.0.72 → 0.0.73

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/ui",
-  "version": "0.0.72",
+  "version": "0.0.73",
   "type": "module",
   "files": [
     "src"

package/src/components/selection-wizard.render.test.ts

@@ -582,6 +582,25 @@ describe("RunStepBody", () => {
 		assert.match(html, /Nothing has changed\./);
 	});
 
+	// A poll that could not be read is not a run that never started (#526): the
+	// screen keeps the counts it has and says what it cannot see.
+	it("keeps a run that is going when its progress could not be read", () => {
+		const html = renderToString(
+			createElement(RunStepBody, {
+				...runProps,
+				state: "statusUnknown",
+				scope: "once",
+				matched: 1284,
+				applied: 40,
+			}),
+		);
+		assert.match(html, /progress unknown/);
+		assert.match(html, /carries on either way/);
+		assert.match(html, /role="progressbar"/);
+		assert.doesNotMatch(html, /Nothing has changed/);
+		assert.doesNotMatch(html, /never started/);
+	});
+
 	it("says a filter saved with nothing to back-apply is live", () => {
 		const html = renderToString(
 			createElement(RunStepBody, {
@@ -620,6 +639,18 @@ describe("RunFooter", () => {
 		assert.match(html, /Not now/);
 	});
 
+	it("offers another look, not another run, when the progress could not be read", () => {
+		const html = renderToString(
+			createElement(RunFooter, {
+				...runProps,
+				state: "statusUnknown",
+				scope: "once",
+			}),
+		);
+		assert.match(html, /Check again/);
+		assert.match(html, /Close/);
+	});
+
 	it("offers only a way out once there is nothing outstanding", () => {
 		const html = renderToString(createElement(RunFooter, runProps));
 		assert.match(html, /Done/);

package/src/lib/wizard-steps.test.ts

@@ -477,6 +477,7 @@ describe("runCopy", () => {
 			"backApplyComplete",
 			"backApplyFailed",
 			"backApplyStartFailed",
+			"statusUnknown",
 			"filterSaved",
 			"runStopped",
 			"commitFailed",
@@ -539,6 +540,25 @@ describe("runCopy", () => {
 		assert.equal(started.showProgress, false);
 	});
 
+	it("keeps a run that is going when its progress could not be read", () => {
+		// A poll that failed says nothing about the job behind it (#526), so the
+		// screen never claims the action never started, and the way out of it is a
+		// second look rather than a second run.
+		const once = outcome("statusUnknown", "once");
+		assert.equal(once.title, "Moving — progress unknown");
+		assert.match(once.detail, /carries on either way/);
+		assert.doesNotMatch(once.detail, /Nothing has changed/);
+		assert.equal(once.tone, "warning");
+		assert.equal(once.retryLabel, "Check again");
+		assert.equal(once.screenTitle, "Move");
+
+		const standing = outcome("statusUnknown", "standing");
+		assert.match(standing.title, /Rule saved/);
+		assert.doesNotMatch(standing.detail, /never started/);
+		assert.match(standing.detail, /keeps working on new mail/);
+		assert.equal(standing.retryLabel, "Check again");
+	});
+
 	it("says a filter saved with nothing to back-apply is still live", () => {
 		const saved = outcome("filterSaved", "standing");
 		assert.equal(saved.title, "Filter saved");
@@ -559,6 +579,8 @@ describe("runCopy", () => {
 		assert.equal(outcome("backApplyRunning", "standing").showProgress, true);
 		assert.equal(outcome("backApplyComplete", "once").showProgress, true);
 		assert.equal(outcome("backApplyFailed", "once").showProgress, true);
+		// The last counts read are still the last counts read.
+		assert.equal(outcome("statusUnknown", "once").showProgress, true);
 	});
 
 	it("names the failure list in the verb's own past tense", () => {

package/src/lib/wizard-steps.ts

@@ -301,6 +301,7 @@ export type RunState =
 	| "backApplyComplete"
 	| "backApplyFailed"
 	| "backApplyStartFailed"
+	| "statusUnknown"
 	| "filterSaved"
 	| "runStopped"
 	| "commitFailed";
@@ -374,7 +375,10 @@ export const runCopy = ({
 	const { label, present, past } = verbCopy(verb);
 	const done = past.toLowerCase();
 	const standing = scope === "standing" || scope === "until";
-	const inFlight = state === "saving" || state === "backApplyRunning";
+	const inFlight =
+		state === "saving" ||
+		state === "backApplyRunning" ||
+		state === "statusUnknown";
 	const shared = {
 		// A create that failed did not finish, so the header does not say it did.
 		screenTitle: inFlight || state === "commitFailed" ? label : "Done",
@@ -382,6 +386,7 @@ export const runCopy = ({
 			state === "backApplyRunning" ||
 			state === "backApplyComplete" ||
 			state === "backApplyFailed" ||
+			state === "statusUnknown" ||
 			state === "runStopped",
 		failureListLabel: `Not ${done}`,
 	};
@@ -407,6 +412,20 @@ export const runCopy = ({
 			cancelLabel: "Stop the run",
 		};
 	}
+	if (state === "statusUnknown") {
+		return {
+			...shared,
+			title: standing
+				? "Rule saved. Its progress over your existing mail is unknown"
+				: `${present} — progress unknown`,
+			detail: standing
+				? "The connection dropped, so the bar shows the last that was read. The pass runs on the mail server, and the rule keeps working on new mail either way. This keeps checking."
+				: "The connection dropped, so the bar shows the last that was read. The run is on the mail server and carries on either way. This keeps checking.",
+			tone: "warning",
+			dismissLabel: "Close",
+			retryLabel: "Check again",
+		};
+	}
 	if (state === "backApplyComplete") {
 		return {
 			...shared,