@remit/mailbox-service 0.0.54 → 0.0.56

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/mailbox-service",
-  "version": "0.0.54",
+  "version": "0.0.56",
   "type": "module",
   "main": "src/index.ts",
   "types": "src/index.ts",

package/src/message-sync-address-spoof.test.ts

@@ -1,16 +1,3 @@
-/**
- * Harvesting takes the display name straight off the envelope, and a sender
- * chooses that string. A 2021 spam message reached this account's INBOX with
- * `matthijs@ischen.nl <aramirez@secresaludguaviare.gov.co>`: the account's own
- * address as the label on a stranger's. It was stored, autocomplete offered it
- * back when the account holder typed his own address, and a private reply left
- * the instance (issue #826).
- *
- * The name lands in three columns on this one save — the address book, the
- * envelope the message header renders, and the sender label the message list
- * shows and search indexes — so all three are asserted here.
- */
-
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
 import type {
@@ -50,10 +37,6 @@ interface Saved {
 	threadMessages: CreateThreadMessageInput[];
 }
 
-/**
- * Drive the real save path so the stored value is the one the write path
- * produces, not one a test handed to a private method.
- */
 const harvest = async (envelope: Partial<ImapEnvelope>): Promise<Saved> => {
 	const saved: Saved = {
 		addresses: [],
@@ -149,12 +132,6 @@ describe("harvesting an envelope display name", () => {
 		);
 	});
 
-	/**
-	 * The incident with one word prepended. An anchored guard reads this as an
-	 * ordinary name and stores it, and autocomplete then ties it with the real
-	 * address on the term `matthijs` and breaks the tie on correspondence. The
-	 * word itself is not the lie, so it survives the address being removed.
-	 */
 	it("keeps what a name says besides the address it claims", async () => {
 		const input = await onlyAddress({
 			from: [{ ...spoof, name: "Matthijs <matthijs@ischen.nl>" }],

package/src/outbox-queue.ts

@@ -256,10 +256,14 @@ export class OutboxQueueService {
 			outboxMessageId,
 			"act",
 		);
+		// `unfiled` is discardable: the message was delivered but never landed in
+		// a Sent folder, so this row is the only copy the user has and dismissing
+		// it is their acknowledgement.
 		if (
 			existing.status !== OutboxMessageStatus.draft &&
 			existing.status !== OutboxMessageStatus.failed &&
-			existing.status !== OutboxMessageStatus.blocked
+			existing.status !== OutboxMessageStatus.blocked &&
+			existing.status !== OutboxMessageStatus.unfiled
 		) {
 			throw new ConflictError(
 				`This message is already ${existing.status} and can no longer be discarded. Open the Outbox to see where it stands.`,