@remit/mailbox-service 0.0.111 → 0.0.113

package/src/filters/filter-config.test.ts

@@ -1,229 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import type {
-	FilterItem,
-	IFilterAnchorRepository,
-	IFilterRepository,
-	IMessageLabelRepository,
-} from "@remit/data-ports";
-import { FilterMatchOperator, FilterState } from "@remit/domain-enums";
-import { _resetEmbeddingCapabilityForTest } from "@remit/search-service/capability";
-import type { PlacementMoveService } from "../placement-move.js";
-import { buildFilterConfig, type FilterConfigDeps } from "./filter-config.js";
-import { type FilterMessage, NO_ACTION } from "./match.js";
-import { _resetMessageEmbedderForTest } from "./message-embedder.js";
-import { FilterPipeline, type MessageEmbedder } from "./pipeline.js";
-
-const anchorOnlyFilter = (destinationMailboxId: string): FilterItem =>
-	({
-		filterId: "flt-semantic",
-		accountConfigId: "cfg-1",
-		name: "receipts",
-		scope: "Standing",
-		state: FilterState.Active,
-		hasAnchor: true,
-		ruleChangedAt: 1,
-		matchOperator: FilterMatchOperator.Or,
-		literalClauses: [],
-		actionLabelId: NO_ACTION,
-		actionMailboxId: destinationMailboxId,
-		createdAt: 1,
-		updatedAt: 1,
-	}) as unknown as FilterItem;
-
-const CURRENT_MODEL = "test-model@3";
-
-const repos = (filter: FilterItem): FilterConfigDeps => ({
-	filterService: {
-		listByAccountAndState: async () => [filter],
-		refreshExpiry: async (f: FilterItem) => f,
-	} as unknown as IFilterRepository,
-	filterAnchorService: {
-		get: async () => ({
-			anchorEmbedding: [1, 0, 0],
-			anchorEmbeddingId: CURRENT_MODEL,
-		}),
-	} as unknown as IFilterAnchorRepository,
-	messageLabelService: {} as unknown as IMessageLabelRepository,
-	placementMoveService: {} as unknown as PlacementMoveService,
-});
-
-const message: FilterMessage = {
-	from: "billing@stripe.com",
-	fromName: "Stripe",
-	subject: "Your receipt",
-	text: "Thanks for your payment",
-	listId: "",
-};
-
-describe("buildFilterConfig", () => {
-	it("returns undefined without a placement mover — no move path, filters stay off", () => {
-		const deps = repos(anchorOnlyFilter("mbx-archive"));
-		deps.placementMoveService = undefined;
-
-		assert.equal(buildFilterConfig(deps), undefined);
-	});
-
-	it("wires an embedder into the config", () => {
-		const config = buildFilterConfig(repos(anchorOnlyFilter("mbx-archive")));
-
-		assert.ok(config);
-		assert.ok(config.embedder);
-	});
-
-	it("lights up a semantic anchor-only filter on the body-sync pass", async () => {
-		let embedCalls = 0;
-		const embedder: MessageEmbedder = {
-			embed: async () => {
-				embedCalls += 1;
-				return [1, 0, 0];
-			},
-			embeddingId: CURRENT_MODEL,
-		};
-		const config = buildFilterConfig(
-			repos(anchorOnlyFilter("mbx-archive")),
-			embedder,
-		);
-		assert.ok(config);
-
-		const decision = await new FilterPipeline(config, {
-			info: () => {},
-		}).evaluate("cfg-1", "m-1", message);
-
-		assert.deepEqual(decision.move, {
-			destinationMailboxId: "mbx-archive",
-			filterId: "flt-semantic",
-		});
-		assert.equal(embedCalls, 1);
-	});
-
-	it("does not match when the message embedding diverges from the anchor", async () => {
-		const embedder: MessageEmbedder = {
-			embed: async () => [0, 1, 0],
-			embeddingId: CURRENT_MODEL,
-		};
-		const config = buildFilterConfig(
-			repos(anchorOnlyFilter("mbx-archive")),
-			embedder,
-		);
-		assert.ok(config);
-
-		const decision = await new FilterPipeline(config, {
-			info: () => {},
-		}).evaluate("cfg-1", "m-2", message);
-
-		assert.equal(decision.move, undefined);
-	});
-});
-
-// An instance with semantic search off (issue #1068). `off` selects an embedder
-// that throws by design, and the throw lands in the pipeline's per-filter catch:
-// one error-level `filter_anchor_match_failed` for every semantic filter on
-// every message it syncs. The pipeline already has a designed skip for a
-// missing embedder, so the config passes none.
-describe("buildFilterConfig with semantic search off", () => {
-	const withProviderOff = async (body: () => Promise<void>): Promise<void> => {
-		const previous = process.env.SEARCH_EMBEDDING_PROVIDER;
-		process.env.SEARCH_EMBEDDING_PROVIDER = "off";
-		_resetMessageEmbedderForTest();
-		try {
-			await body();
-		} finally {
-			if (previous === undefined) {
-				delete process.env.SEARCH_EMBEDDING_PROVIDER;
-			} else {
-				process.env.SEARCH_EMBEDDING_PROVIDER = previous;
-			}
-			_resetMessageEmbedderForTest();
-		}
-	};
-
-	it("wires no embedder", async () => {
-		await withProviderOff(async () => {
-			const config = buildFilterConfig(repos(anchorOnlyFilter("mbx-archive")));
-
-			assert.ok(config);
-			assert.equal(config.embedder, undefined);
-		});
-	});
-
-	it("skips the semantic filter without logging an error", async () => {
-		await withProviderOff(async () => {
-			const config = buildFilterConfig(repos(anchorOnlyFilter("mbx-archive")));
-			assert.ok(config);
-
-			const errors: unknown[] = [];
-			const decision = await new FilterPipeline(config, {
-				info: () => {},
-				debug: () => {},
-				warn: () => {},
-				error: (fields) => errors.push(fields.alert),
-			}).evaluate("cfg-1", "m-off", message);
-
-			assert.deepEqual(decision.labels, []);
-			assert.equal(decision.move, undefined);
-			assert.deepEqual(errors, []);
-		});
-	});
-});
-
-// The self-host `local` profile asks for the Transformers.js embedder, but the
-// backend and imap-worker images ship without `@huggingface/transformers`
-// (npm-scripts/docker-bundle.mjs). The first embed throws ERR_MODULE_NOT_FOUND,
-// which is the same capability absence `off` states and must take the same
-// designed skip — not an error-level `filter_anchor_match_failed` per semantic
-// filter per message on a user-facing GET.
-describe("buildFilterConfig when this deployment carries no embedder", () => {
-	const moduleNotFound = (): Error =>
-		Object.assign(
-			new Error("Cannot find package '@huggingface/transformers'"),
-			{ code: "ERR_MODULE_NOT_FOUND" },
-		);
-
-	it("skips the semantic filter, logs no error, and stops wiring an embedder", async () => {
-		const previous = process.env.SEARCH_EMBEDDING_PROVIDER;
-		process.env.SEARCH_EMBEDDING_PROVIDER = "local";
-		_resetMessageEmbedderForTest();
-		_resetEmbeddingCapabilityForTest();
-
-		try {
-			const unavailable: MessageEmbedder = {
-				embed: async () => {
-					throw moduleNotFound();
-				},
-				embeddingId: CURRENT_MODEL,
-			};
-			const config = buildFilterConfig(
-				repos(anchorOnlyFilter("mbx-archive")),
-				unavailable,
-			);
-			assert.ok(config);
-
-			const errors: unknown[] = [];
-			const decision = await new FilterPipeline(config, {
-				info: () => {},
-				debug: () => {},
-				warn: () => {},
-				error: (fields) => errors.push(fields.alert),
-			}).evaluate("cfg-1", "m-local", message);
-
-			assert.deepEqual(decision.labels, []);
-			assert.equal(decision.move, undefined);
-			assert.deepEqual(errors, []);
-
-			// Probed once, not per filter or per message: every later config on this
-			// process wires no embedder at all, so nothing else attempts the embed.
-			const next = buildFilterConfig(repos(anchorOnlyFilter("mbx-archive")));
-			assert.ok(next);
-			assert.equal(next.embedder, undefined);
-		} finally {
-			if (previous === undefined) {
-				delete process.env.SEARCH_EMBEDDING_PROVIDER;
-			} else {
-				process.env.SEARCH_EMBEDDING_PROVIDER = previous;
-			}
-			_resetMessageEmbedderForTest();
-			_resetEmbeddingCapabilityForTest();
-		}
-	});
-});

package/src/filters/filter-config.ts

@@ -1,69 +0,0 @@
-import type {
-	IFilterAnchorRepository,
-	IFilterRepository,
-	IMessageLabelRepository,
-} from "@remit/data-ports";
-import { isEmbeddingCapabilityUnavailable } from "@remit/search-service/capability";
-import {
-	EMBEDDING_PROVIDER_OFF,
-	readEmbeddingProviderFromEnv,
-} from "@remit/search-service/from-env";
-import type { PlacementMoveService } from "../placement-move.js";
-import { getMessageEmbedder } from "./message-embedder.js";
-import type { FilterConfig, MessageEmbedder } from "./pipeline.js";
-
-export interface FilterConfigDeps {
-	filterService: IFilterRepository;
-	filterAnchorService: IFilterAnchorRepository;
-	messageLabelService: IMessageLabelRepository;
-	placementMoveService?: PlacementMoveService;
-}
-
-/**
- * The env-selected embedder, or none on an instance that cannot embed.
- *
- * `off` embeds nothing by design, and its embedder says so by throwing
- * (EmbeddingDisabledError). The pipeline has a designed skip for a *missing*
- * embedder — semantic filters are passed over and logged at debug — but a
- * present embedder that throws lands in the per-filter catch instead, which is
- * an error-level `filter_anchor_match_failed` for every semantic filter on
- * every synced message. Same outcome, a log nobody can read.
- *
- * `local` on the self-host profiles reaches the same place by a different road:
- * the backend and imap-worker images ship without `@huggingface/transformers`,
- * so the first embed throws ERR_MODULE_NOT_FOUND. The pipeline classifies that
- * one throw through `@remit/search-service/capability` and remembers it, and
- * from then on the config here wires no embedder either — one probe per process,
- * not one per filter per message.
- */
-const embedderFromEnv = (): MessageEmbedder | undefined =>
-	readEmbeddingProviderFromEnv() === EMBEDDING_PROVIDER_OFF ||
-	isEmbeddingCapabilityUnavailable()
-		? undefined
-		: getMessageEmbedder();
-
-/**
- * Assemble the filter config a body-materializing pass runs (RFC 034), shared by
- * the imap-worker's sync path and the backend's read-path backfill so both embed
- * under the same model that produced the anchors — a semantic (anchor-only)
- * filter is evaluated on either path instead of silently skipped.
- *
- * Absent the placement mover there is no move path, so filters stay off — a
- * matched filter's actions reuse the same enqueue plumbing the placement mover
- * owns.
- */
-export const buildFilterConfig = (
-	deps: FilterConfigDeps,
-	embedder?: MessageEmbedder,
-): FilterConfig | undefined => {
-	const { placementMoveService } = deps;
-	if (!placementMoveService) return undefined;
-	const resolved = embedder ?? embedderFromEnv();
-	return {
-		filterService: deps.filterService,
-		filterAnchorService: deps.filterAnchorService,
-		messageLabelService: deps.messageLabelService,
-		placementMoveService,
-		...(resolved ? { embedder: resolved } : {}),
-	};
-};

package/src/filters/list-id.test.ts

@@ -1,50 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import { simpleParser } from "mailparser";
-import { extractListId, normalizeListId } from "./list-id.js";
-
-const parse = async (lines: string[]) =>
-	simpleParser(Buffer.from(lines.join("\r\n")));
-
-describe("normalizeListId", () => {
-	it("extracts the bracketed identifier and folds case", () => {
-		assert.equal(
-			normalizeListId("Weekly News <Weekly.News.Example.COM>"),
-			"weekly.news.example.com",
-		);
-	});
-
-	it("keeps a bare value and folds case", () => {
-		assert.equal(
-			normalizeListId("  Weekly.News.Example.COM  "),
-			"weekly.news.example.com",
-		);
-	});
-
-	it("normalizes an empty value to the empty string", () => {
-		assert.equal(normalizeListId("   "), "");
-	});
-});
-
-describe("extractListId", () => {
-	it("reads and normalizes a List-Id header", async () => {
-		const parsed = await parse([
-			"From: list@example.com",
-			"Subject: hi",
-			"List-Id: Weekly News <weekly.news.example.com>",
-			"",
-			"body",
-		]);
-		assert.equal(extractListId(parsed), "weekly.news.example.com");
-	});
-
-	it("returns the empty string when there is no List-Id header", async () => {
-		const parsed = await parse([
-			"From: alice@example.com",
-			"Subject: hi",
-			"",
-			"body",
-		]);
-		assert.equal(extractListId(parsed), "");
-	});
-});