@remit/mailbox-service 0.0.110 → 0.0.112

package/src/sync-warning.test.ts

@@ -0,0 +1,213 @@
+import assert from "node:assert/strict";
+import { afterEach, beforeEach, describe, it } from "node:test";
+import type {
+	AccountItem,
+	ISyncWarningRepository,
+	MailboxItem,
+} from "@remit/data-ports";
+import { BodySyncService } from "./body-sync.js";
+import { MessageSyncService } from "./message-sync.js";
+import { SyncWarningService } from "./sync-warning.js";
+import {
+	eml,
+	type FakeImapConnection,
+	FakeImapServer,
+} from "./test-helpers/fake-imap.js";
+import {
+	messageAtUid,
+	openStore,
+	type Store,
+	seedAccount,
+	seedMailbox,
+	silentLog,
+	syncFolder,
+} from "./test-helpers/test-store.js";
+
+let store: Store;
+let imap: FakeImapServer;
+let connection: FakeImapConnection;
+let account: AccountItem;
+let inbox: MailboxItem;
+
+beforeEach(async () => {
+	store = await openStore();
+	imap = new FakeImapServer();
+	account = await seedAccount(store);
+	inbox = await seedMailbox(store, account, "INBOX");
+	imap.addFolder("INBOX");
+	connection = imap.connection();
+});
+
+afterEach(async () => {
+	await store.close();
+});
+
+const syncHeaders = (
+	syncWarnings: ISyncWarningRepository = store.syncWarning,
+) =>
+	new MessageSyncService(
+		{ getConnection: () => connection, close: async () => {} },
+		store.mailbox,
+		store.mailboxSpecialUse,
+		store.message,
+		store.envelope,
+		store.address,
+		store.threadMessage,
+		new SyncWarningService(syncWarnings),
+		silentLog,
+		store.flagPush,
+		store.messageFlag,
+	).syncMessages(inbox.mailboxId, account.accountId, account.accountConfigId);
+
+const syncBody = (messageId: string, source: FakeImapConnection) =>
+	new BodySyncService(
+		store.message,
+		store.storage(),
+		store.threadMessage,
+		store.address,
+		store.envelope,
+		new SyncWarningService(store.syncWarning),
+		silentLog,
+	).syncBodies(
+		[messageId],
+		account.accountId,
+		account.accountConfigId,
+		{
+			mailboxId: inbox.mailboxId,
+			fullPath: "INBOX",
+			placement: "inbox",
+			uidValidity: inbox.uidValidity,
+		},
+		async () => source,
+	);
+
+const warnings = async () =>
+	(await store.syncWarning.listByMailboxId(inbox.mailboxId)).map(
+		({ uid, stage, attempts }) => ({ uid, stage, attempts }),
+	);
+
+const servedUidValidity = async (): Promise<number> =>
+	(await imap.connection().openBox("INBOX")).uidvalidity;
+
+const plant = (uid: number, uidValidity: number) =>
+	store.syncWarning.recordFailures([
+		{
+			accountConfigId: account.accountConfigId,
+			accountId: account.accountId,
+			mailboxId: inbox.mailboxId,
+			uidValidity,
+			uid,
+			stage: "Header",
+		},
+	]);
+
+const dropEnvelopes = () => {
+	const fetch = connection.fetchMessages;
+	connection.fetchMessages = async (uids) =>
+		(await fetch(uids)).map((row) => ({ ...row, envelope: undefined }));
+	return () => {
+		connection.fetchMessages = fetch;
+	};
+};
+
+describe("a message whose headers fail to sync", () => {
+	it("keeps one warning that counts every failed round", async () => {
+		const uid = imap.deliver("INBOX", eml({ "Message-ID": "<a@example.com>" }));
+		dropEnvelopes();
+
+		for (let round = 0; round < 3; round++) await syncHeaders();
+
+		assert.deepEqual(await warnings(), [{ uid, stage: "Header", attempts: 3 }]);
+	});
+
+	it("drops the warning once the message syncs", async () => {
+		imap.deliver("INBOX", eml({ "Message-ID": "<a@example.com>" }));
+		const restore = dropEnvelopes();
+		await syncHeaders();
+		restore();
+
+		await syncHeaders();
+
+		assert.deepEqual(await warnings(), []);
+	});
+
+	it("fails the round when the warning cannot be written", async () => {
+		imap.deliver("INBOX", eml({ "Message-ID": "<a@example.com>" }));
+		dropEnvelopes();
+		const failing: ISyncWarningRepository = {
+			...store.syncWarning,
+			recordFailures: async () => {
+				throw new Error("database is locked");
+			},
+		};
+
+		await assert.rejects(syncHeaders(failing), /database is locked/);
+	});
+
+	it("drops a warning from an earlier UIDVALIDITY", async () => {
+		imap.deliver("INBOX", eml({ "Message-ID": "<a@example.com>" }));
+		const uidValidity = await servedUidValidity();
+		await plant(1, uidValidity + 1);
+
+		await syncHeaders();
+
+		assert.deepEqual(await warnings(), []);
+	});
+
+	it("drops a warning for a uid the server no longer lists", async () => {
+		const uidValidity = await servedUidValidity();
+		await plant(40217, uidValidity);
+
+		await syncHeaders();
+
+		assert.deepEqual(await warnings(), []);
+	});
+
+	it("goes with its mailbox", async () => {
+		imap.deliver("INBOX", eml({ "Message-ID": "<a@example.com>" }));
+		dropEnvelopes();
+		await syncHeaders();
+
+		await store.mailbox.delete(account.accountId, inbox.mailboxId);
+
+		assert.deepEqual(await warnings(), []);
+	});
+});
+
+describe("a message whose body fails to sync", () => {
+	it("drops the warning once a header round finds the message gone from the server", async () => {
+		const uid = imap.deliver("INBOX", eml({ "Message-ID": "<c@example.com>" }));
+		await syncFolder(store, account, inbox, imap);
+		const { messageId } = await messageAtUid(store, inbox, uid);
+		const silent = imap.connection();
+		silent.fetchMessageBodies = async function* () {
+			yield* [];
+		};
+		for (let round = 0; round < 3; round++) await syncBody(messageId, silent);
+		assert.deepEqual(await warnings(), [{ uid, stage: "Body", attempts: 3 }]);
+
+		imap.expunge("INBOX", uid);
+		await syncHeaders();
+
+		assert.deepEqual(await warnings(), []);
+	});
+
+	it("keeps one warning per failed round and drops it once the body is stored", async () => {
+		const uid = imap.deliver("INBOX", eml({ "Message-ID": "<b@example.com>" }));
+		await syncFolder(store, account, inbox, imap);
+		const { messageId } = await messageAtUid(store, inbox, uid);
+		const silent = imap.connection();
+		silent.fetchMessageBodies = async function* () {
+			yield* [];
+		};
+
+		for (let round = 0; round < 3; round++) await syncBody(messageId, silent);
+
+		assert.deepEqual(await warnings(), [{ uid, stage: "Body", attempts: 3 }]);
+
+		const result = await syncBody(messageId, imap.connection());
+
+		assert.deepEqual(result.failedMessageIds, []);
+		assert.deepEqual(await warnings(), []);
+	});
+});

package/src/sync-warning.ts

@@ -0,0 +1,56 @@
+import type {
+	ISyncWarningRepository,
+	SyncWarningItem,
+	SyncWarningKey,
+} from "@remit/data-ports";
+
+export type SyncWarningContext = Omit<SyncWarningKey, "uid" | "stage">;
+
+export type ServerUids =
+	| { kind: "Listed"; uids: readonly number[] }
+	| { kind: "OnRequest"; list: () => Promise<readonly number[]> }
+	| { kind: "Unlisted" };
+
+export interface SyncWarningRound {
+	failedUids: readonly number[];
+	syncedUids: readonly number[];
+	serverUids: ServerUids;
+}
+
+const listedUids = async (
+	serverUids: ServerUids,
+	recordedCount: number,
+): Promise<Set<number> | undefined> => {
+	if (serverUids.kind === "Listed") return new Set(serverUids.uids);
+	if (serverUids.kind === "OnRequest" && recordedCount > 0) {
+		return new Set(await serverUids.list());
+	}
+	return undefined;
+};
+
+export class SyncWarningService {
+	constructor(private readonly repository: ISyncWarningRepository) {}
+
+	async settle(
+		context: SyncWarningContext,
+		stage: SyncWarningItem["stage"],
+		round: SyncWarningRound,
+	): Promise<void> {
+		await this.repository.recordFailures(
+			[...new Set(round.failedUids)].map((uid) => ({ ...context, uid, stage })),
+		);
+
+		const recorded = await this.repository.listByMailboxId(context.mailboxId);
+		const synced = new Set(round.syncedUids);
+		const listed = await listedUids(round.serverUids, recorded.length);
+		const cleared = recorded
+			.filter(
+				(row) =>
+					(listed !== undefined && !listed.has(row.uid)) ||
+					(row.stage === stage &&
+						(row.uidValidity !== context.uidValidity || synced.has(row.uid))),
+			)
+			.map((row) => row.syncWarningId);
+		await this.repository.deleteMany(cleared);
+	}
+}