@remit/mailbox-service 0.0.104 → 0.0.105

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/mailbox-service",
-  "version": "0.0.104",
+  "version": "0.0.105",
   "type": "module",
   "main": "src/index.ts",
   "types": "src/index.ts",

package/src/index.ts

@@ -219,6 +219,8 @@ export {
 	FolderRenameSettleError,
 	isMailboxAbsentUpstream,
 	isMailboxPresentUpstream,
+	isMailboxRefusedUpstream,
+	upstreamFailureReason,
 } from "./mailbox-upstream.js";
 export {
 	denormalizeMessageCategory,

package/src/mailbox-delete-intent.test.ts

@@ -227,7 +227,7 @@ describe("MailboxManagementService.failDelete", () => {
 		]);
 		const service = new MailboxManagementService(repo);
 
-		await service.failDelete("acc-1", "mbx-1");
+		await service.failDelete("acc-1", "mbx-1", "Permission denied");
 
 		assert.equal(byId.get("mbx-1")?.syncStatus, MailboxSyncStatus.failed);
 		assert.equal(byId.get("mbx-1")?.fullPath, "Receipts");
@@ -239,7 +239,7 @@ describe("MailboxManagementService.failDelete", () => {
 		const service = new MailboxManagementService(repo);
 
 		await assert.rejects(
-			service.failDelete("acc-1", "mbx-1"),
+			service.failDelete("acc-1", "mbx-1", "Permission denied"),
 			(error: unknown) => (error as Error).name === "NotFoundError",
 		);
 	});

package/src/mailbox-management.ts

@@ -598,6 +598,7 @@ export class MailboxManagementService {
 		mailboxId: string,
 		oldPath: string,
 		newPath: string,
+		reason: string,
 	): Promise<void> => {
 		const root = await this.mailboxService
 			.get(accountId, mailboxId)
@@ -643,6 +644,7 @@ export class MailboxManagementService {
 					from: [MailboxSyncStatus.pending],
 					wherePendingPath: row.pendingPath,
 					to: MailboxSyncStatus.failed,
+					set: { syncFailureReason: reason },
 				},
 			);
 			this.log.info(
@@ -811,10 +813,15 @@ export class MailboxManagementService {
 	 * target is written, which is how the client tells a failed delete from a
 	 * failed rename.
 	 */
-	failDelete = async (accountId: string, mailboxId: string): Promise<void> => {
+	failDelete = async (
+		accountId: string,
+		mailboxId: string,
+		reason: string,
+	): Promise<void> => {
 		const failed = await this.mailboxService.transition(accountId, mailboxId, {
 			from: [MailboxSyncStatus.deleting],
 			to: MailboxSyncStatus.failed,
+			set: { syncFailureReason: reason },
 		});
 		if (!failed) throw new NotFoundError(`Mailbox not found: ${mailboxId}`);
 		this.log.info(

package/src/mailbox-rename-subtree.test.ts

@@ -361,7 +361,13 @@ describe("MailboxManagementService.syncRename — rows it must not claim", () =>
 		]);
 		const service = new MailboxManagementService(repo);
 
-		await service.failRename("acc-1", "mbx-parent", "Work", "Projects");
+		await service.failRename(
+			"acc-1",
+			"mbx-parent",
+			"Work",
+			"Projects",
+			"Permission denied",
+		);
 
 		assert.equal(rowOf("mbx-parent")?.syncStatus, MailboxSyncStatus.failed);
 		assert.equal(rowOf("mbx-other")?.syncStatus, MailboxSyncStatus.pending);
@@ -572,7 +578,13 @@ describe("MailboxManagementService.failRename", () => {
 		]);
 		const service = new MailboxManagementService(repo);
 
-		await service.failRename("acc-1", "mbx-parent", "Work", "Projects");
+		await service.failRename(
+			"acc-1",
+			"mbx-parent",
+			"Work",
+			"Projects",
+			"Permission denied",
+		);
 
 		for (const [id, path, target] of [
 			["mbx-parent", "Work", "Projects"],
@@ -593,7 +605,13 @@ describe("MailboxManagementService.failRename", () => {
 		const service = new MailboxManagementService(repo);
 
 		await assert.rejects(
-			service.failRename("acc-1", "mbx-parent", "Work", "Projects"),
+			service.failRename(
+				"acc-1",
+				"mbx-parent",
+				"Work",
+				"Projects",
+				"Permission denied",
+			),
 			(error: unknown) => (error as Error).name === "NotFoundError",
 		);
 	});
@@ -606,7 +624,13 @@ describe("MailboxManagementService.failRename", () => {
 		const service = new MailboxManagementService(repo);
 
 		await assert.doesNotReject(
-			service.failRename("acc-1", "mbx-parent", "Work", "Projects"),
+			service.failRename(
+				"acc-1",
+				"mbx-parent",
+				"Work",
+				"Projects",
+				"Permission denied",
+			),
 		);
 	});
 
@@ -627,7 +651,13 @@ describe("MailboxManagementService.failRename", () => {
 			/not ready/,
 		);
 
-		await service.failRename("acc-1", "mbx-parent", "Work", "Projects");
+		await service.failRename(
+			"acc-1",
+			"mbx-parent",
+			"Work",
+			"Projects",
+			"Permission denied",
+		);
 		assert.equal(rowOf("mbx-parent")?.syncStatus, MailboxSyncStatus.failed);
 		assert.equal(rowOf("mbx-parent")?.fullPath, "Work");
 	});

package/src/mailbox-upstream.ts

@@ -36,6 +36,18 @@ export const isMailboxPresentUpstream = (error: unknown): boolean => {
 	return /already exists/i.test(saidByServer(error));
 };
 
+const PERMANENT_REFUSALS = new Set(["NOPERM", "CANNOT"]);
+
+export const isMailboxRefusedUpstream = (error: unknown): boolean =>
+	error instanceof Error &&
+	PERMANENT_REFUSALS.has(stringField(error, "serverResponseCode"));
+
+export const upstreamFailureReason = (error: unknown): string => {
+	const serverText = stringField(error, "responseText").trim();
+	if (serverText.length > 0) return serverText;
+	return error instanceof Error ? error.message : String(error);
+};
+
 /**
  * Something after the server RENAME failed — the local settle, not the
  * mutation. The rename landed, so this is never a refused rename: marking the