@remit/imap-worker 0.0.81 → 0.0.82

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/imap-worker",
-  "version": "0.0.81",
+  "version": "0.0.82",
   "type": "module",
   "main": "dist/index.js",
   "exports": {

package/src/handlers/mailbox-management.test.ts

@@ -711,6 +711,23 @@ describe("processMailboxManagement — a tagged NO the server means as success (
 		assert.equal(called("mailbox.transition").length, 0);
 	});
 
+	it("marks failed and acks when the server refuses the DELETE with NOPERM", async () => {
+		recordDeleteIntent();
+		h.connection.deleteMailbox = async () => {
+			throw Object.assign(new Error("Command failed"), {
+				serverResponseCode: "NOPERM",
+				responseText: "Permission denied",
+			});
+		};
+
+		await assert.doesNotReject(
+			processMailboxManagement(deleteEvent, noopLogger, deps()),
+		);
+		assert.equal(lastSettle().to, "failed");
+		assert.equal(lastSettle().set?.syncFailureReason, "Permission denied");
+		assert.equal(called("mailbox.deleteMailboxWithMail").length, 0);
+	});
+
 	it("still marks failed and rethrows when the server fails for any other reason", async () => {
 		recordDeleteIntent();
 		h.connection.deleteMailbox = async () => {
@@ -747,6 +764,21 @@ describe("processMailboxManagement — a tagged NO the server means as success (
 		assert.equal(lastSettle().to, "synced");
 	});
 
+	it("marks failed with the server's reason and acks when a CREATE is refused", async () => {
+		h.connection.createMailbox = async () => {
+			throw Object.assign(new Error("Command failed"), {
+				serverResponseCode: "NOPERM",
+				responseText: "Permission denied",
+			});
+		};
+
+		await assert.doesNotReject(
+			processMailboxManagement(createEvent, noopLogger, deps()),
+		);
+		assert.equal(lastSettle().to, "failed");
+		assert.equal(lastSettle().set?.syncFailureReason, "Permission denied");
+	});
+
 	it("still marks failed and rethrows when a CREATE fails for any other reason", async () => {
 		h.connection.createMailbox = async () => {
 			throw Object.assign(new Error("Command failed"), {
@@ -781,6 +813,25 @@ describe("processMailboxManagement — a tagged NO the server means as success (
 		]);
 	});
 
+	it("marks failed with the server's reason and acks when a RENAME is refused", async () => {
+		recordRenameIntent();
+		h.connection.renameMailbox = async () => {
+			throw Object.assign(new Error("Command failed"), {
+				serverResponseCode: "CANNOT",
+				responseText: "Can't rename mailbox with its children",
+			});
+		};
+
+		await assert.doesNotReject(
+			processMailboxManagement(renameEvent, noopLogger, deps()),
+		);
+		assert.equal(lastSettle().to, "failed");
+		assert.equal(
+			lastSettle().set?.syncFailureReason,
+			"Can't rename mailbox with its children",
+		);
+	});
+
 	it("still refuses the intent and rethrows when a RENAME fails for any other reason", async () => {
 		recordRenameIntent();
 		h.connection.renameMailbox = async () => {

package/src/handlers/mailbox-management.ts

@@ -9,7 +9,9 @@ import {
 	FolderRenameSettleError,
 	isMailboxAbsentUpstream,
 	isMailboxPresentUpstream,
+	isMailboxRefusedUpstream,
 	MailboxManagementService,
+	upstreamFailureReason,
 } from "@remit/mailbox-service";
 import { isAccountDeleted } from "../account-check.js";
 import { createConnectionScopeWithCredentials } from "../connection-scope.js";
@@ -47,12 +49,13 @@ const recordCreateOutcome = async (
 	accountId: string,
 	mailboxId: string,
 	to: (typeof MailboxSyncStatus)[keyof typeof MailboxSyncStatus],
+	syncFailureReason = "",
 ): Promise<void> => {
 	const written = await mailboxService.transition(accountId, mailboxId, {
 		from: [MailboxSyncStatus.pending],
 		wherePendingPath: null,
 		to,
-		set: {},
+		set: { syncFailureReason },
 	});
 	if (!written) throw new NotFoundError(`Mailbox not found: ${mailboxId}`);
 };
@@ -167,7 +170,15 @@ const handleCreate = async (
 								accountId,
 								mailboxId,
 								MailboxSyncStatus.failed,
+								upstreamFailureReason(error),
 							);
+							if (isMailboxRefusedUpstream(error)) {
+								log.error(
+									{ accountId, mailboxId, path, intent: "create", error },
+									"Mail server refused the create",
+								);
+								return;
+							}
 							throw error;
 						}
 					})
@@ -333,7 +344,22 @@ const handleRename = async (
 							mailboxId,
 							oldPath,
 							newPath,
+							upstreamFailureReason(error),
 						);
+						if (isMailboxRefusedUpstream(error)) {
+							log.error(
+								{
+									accountId,
+									mailboxId,
+									oldPath,
+									newPath,
+									intent: "rename",
+									error,
+								},
+								"Mail server refused the rename",
+							);
+							return;
+						}
 						throw error;
 					})
 					.finally(() => scope.disconnect());
@@ -431,7 +457,11 @@ const handleDelete = async (
 							// worker's backstop is unreachable from it; if something else
 							// reaches it, the honest outcome is `failed`, not `synced` —
 							// the folder was never deleted and nothing was undone.
-							await managementService.failDelete(accountId, mailboxId);
+							await managementService.failDelete(
+								accountId,
+								mailboxId,
+								upstreamFailureReason(error),
+							);
 							if (
 								error instanceof Error &&
 								error.message.includes("Cannot delete INBOX")
@@ -443,6 +473,13 @@ const handleDelete = async (
 								// Don't rethrow — no retry can make this succeed.
 								return;
 							}
+							if (isMailboxRefusedUpstream(error)) {
+								log.error(
+									{ accountId, mailboxId, path, intent: "delete", error },
+									"Mail server refused the delete",
+								);
+								return;
+							}
 							throw error;
 						}
 					})