@remit/imap-worker 0.0.70 → 0.0.72

package/src/handlers/mailbox-management.test.ts

@@ -1,6 +1,6 @@
 import assert from "node:assert/strict";
 import { beforeEach, describe, it } from "node:test";
-import type { Logger } from "@remit/logger-lambda";
+import { noopLogger } from "@remit/logger-lambda/noop-logger";
 import type {
 	MailboxCreateEvent,
 	MailboxDeleteEvent,
@@ -11,16 +11,6 @@ import {
 	processMailboxManagement,
 } from "./mailbox-management.js";
 
-const noopLog = {
-	info: () => {},
-	warn: () => {},
-	error: () => {},
-	debug: () => {},
-	fatal: () => {},
-	trace: () => {},
-	child: () => noopLog,
-} as unknown as Logger;
-
 interface Call {
 	method: string;
 	args: unknown[];
@@ -163,7 +153,7 @@ describe("processMailboxManagement — MAILBOX_CREATE", () => {
 	});
 
 	it("creates the folder and writes back the server's UIDVALIDITY and counts", async () => {
-		await processMailboxManagement(createEvent, noopLog, deps());
+		await processMailboxManagement(createEvent, noopLogger, deps());
 
 		assert.equal(called("connection.createMailbox")[0]?.args[0], "Archive");
 		assert.deepEqual(lastUpdate(), {
@@ -176,13 +166,13 @@ describe("processMailboxManagement — MAILBOX_CREATE", () => {
 	});
 
 	it("subscribes only when the event asks for it", async () => {
-		await processMailboxManagement(createEvent, noopLog, deps());
+		await processMailboxManagement(createEvent, noopLogger, deps());
 		assert.equal(called("connection.subscribeMailbox").length, 0);
 
 		h = fresh();
 		await processMailboxManagement(
 			{ ...createEvent, subscribe: true },
-			noopLog,
+			noopLogger,
 			deps(),
 		);
 		assert.equal(called("connection.subscribeMailbox")[0]?.args[0], "Archive");
@@ -191,7 +181,7 @@ describe("processMailboxManagement — MAILBOX_CREATE", () => {
 	it("still marks the mailbox synced when the server does not list the new folder", async () => {
 		h.connection.listMailboxes = async () => [];
 
-		await processMailboxManagement(createEvent, noopLog, deps());
+		await processMailboxManagement(createEvent, noopLogger, deps());
 
 		assert.deepEqual(lastUpdate(), { syncStatus: "synced" });
 	});
@@ -201,7 +191,7 @@ describe("processMailboxManagement — MAILBOX_CREATE", () => {
 			throw new Error("Mailbox already exists");
 		};
 
-		await processMailboxManagement(createEvent, noopLog, deps());
+		await processMailboxManagement(createEvent, noopLogger, deps());
 
 		assert.deepEqual(lastUpdate(), { syncStatus: "synced" });
 	});
@@ -212,7 +202,7 @@ describe("processMailboxManagement — MAILBOX_CREATE", () => {
 		};
 
 		await assert.rejects(
-			processMailboxManagement(createEvent, noopLog, deps()),
+			processMailboxManagement(createEvent, noopLogger, deps()),
 			/server exploded/,
 		);
 
@@ -225,7 +215,7 @@ describe("processMailboxManagement — MAILBOX_CREATE", () => {
 		// create is moot and must not poison the account's FIFO.
 		h.mailboxUpdateError = notFoundError();
 
-		await processMailboxManagement(createEvent, noopLog, deps());
+		await processMailboxManagement(createEvent, noopLogger, deps());
 
 		assert.equal(h.disconnectCount, 1, "the scope is still disconnected");
 	});
@@ -237,7 +227,7 @@ describe("processMailboxManagement — MAILBOX_CREATE", () => {
 			deletedAt: Date.now(),
 		};
 
-		await processMailboxManagement(createEvent, noopLog, deps());
+		await processMailboxManagement(createEvent, noopLogger, deps());
 
 		assert.equal(called("connection.createMailbox").length, 0);
 	});
@@ -246,7 +236,7 @@ describe("processMailboxManagement — MAILBOX_CREATE", () => {
 		h.account = null;
 
 		await assert.rejects(
-			processMailboxManagement(createEvent, noopLog, deps()),
+			processMailboxManagement(createEvent, noopLogger, deps()),
 			/not found/,
 		);
 	});
@@ -258,7 +248,7 @@ describe("processMailboxManagement — MAILBOX_RENAME", () => {
 	});
 
 	it("renames on the server and clears the pending oldPath", async () => {
-		await processMailboxManagement(renameEvent, noopLog, deps());
+		await processMailboxManagement(renameEvent, noopLogger, deps());
 
 		assert.deepEqual(called("connection.renameMailbox")[0]?.args, [
 			"Archive",
@@ -275,7 +265,7 @@ describe("processMailboxManagement — MAILBOX_RENAME", () => {
 			throw new Error("Mailbox not found");
 		};
 
-		await processMailboxManagement(renameEvent, noopLog, deps());
+		await processMailboxManagement(renameEvent, noopLogger, deps());
 
 		assert.deepEqual(called("mailbox.delete")[0]?.args, ["acc-1", "mbx-1"]);
 		assert.equal(called("mailbox.update").length, 0);
@@ -287,7 +277,7 @@ describe("processMailboxManagement — MAILBOX_RENAME", () => {
 		};
 		h.mailboxUpdateError = notFoundError();
 
-		await processMailboxManagement(renameEvent, noopLog, deps());
+		await processMailboxManagement(renameEvent, noopLogger, deps());
 
 		assert.equal(h.disconnectCount, 1, "the scope is still disconnected");
 	});
@@ -298,7 +288,7 @@ describe("processMailboxManagement — MAILBOX_RENAME", () => {
 		};
 
 		await assert.rejects(
-			processMailboxManagement(renameEvent, noopLog, deps()),
+			processMailboxManagement(renameEvent, noopLogger, deps()),
 			/server exploded/,
 		);
 
@@ -316,7 +306,7 @@ describe("processMailboxManagement — MAILBOX_DELETE", () => {
 	});
 
 	it("deletes on the server and drops the local row", async () => {
-		await processMailboxManagement(deleteEvent, noopLog, deps());
+		await processMailboxManagement(deleteEvent, noopLogger, deps());
 
 		assert.equal(called("connection.deleteMailbox")[0]?.args[0], "Archive");
 		assert.deepEqual(called("mailbox.delete")[0]?.args, ["acc-1", "mbx-1"]);
@@ -327,7 +317,7 @@ describe("processMailboxManagement — MAILBOX_DELETE", () => {
 			throw new Error("Mailbox not found");
 		};
 
-		await processMailboxManagement(deleteEvent, noopLog, deps());
+		await processMailboxManagement(deleteEvent, noopLogger, deps());
 
 		assert.equal(called("mailbox.delete").length, 1);
 	});
@@ -337,7 +327,7 @@ describe("processMailboxManagement — MAILBOX_DELETE", () => {
 			throw new Error("Cannot delete INBOX");
 		};
 
-		await processMailboxManagement(deleteEvent, noopLog, deps());
+		await processMailboxManagement(deleteEvent, noopLogger, deps());
 
 		assert.deepEqual(lastUpdate(), { syncStatus: "synced" });
 		assert.equal(called("mailbox.delete").length, 0);
@@ -349,7 +339,7 @@ describe("processMailboxManagement — MAILBOX_DELETE", () => {
 		};
 
 		await assert.rejects(
-			processMailboxManagement(deleteEvent, noopLog, deps()),
+			processMailboxManagement(deleteEvent, noopLogger, deps()),
 			/server exploded/,
 		);
 
@@ -362,7 +352,7 @@ describe("processMailboxManagement — MAILBOX_DELETE", () => {
 		};
 		h.mailboxUpdateError = notFoundError();
 
-		await processMailboxManagement(deleteEvent, noopLog, deps());
+		await processMailboxManagement(deleteEvent, noopLogger, deps());
 
 		assert.equal(h.disconnectCount, 1, "the scope is still disconnected");
 	});
@@ -388,7 +378,7 @@ describe("processMailboxManagement — a tagged NO the server means as success (
 		};
 
 		await assert.doesNotReject(
-			processMailboxManagement(deleteEvent, noopLog, deps()),
+			processMailboxManagement(deleteEvent, noopLogger, deps()),
 		);
 		assert.deepEqual(called("mailbox.delete")[0]?.args, ["acc-1", "mbx-1"]);
 		assert.equal(called("mailbox.update").length, 0);
@@ -403,7 +393,7 @@ describe("processMailboxManagement — a tagged NO the server means as success (
 		};
 
 		await assert.rejects(
-			processMailboxManagement(deleteEvent, noopLog, deps()),
+			processMailboxManagement(deleteEvent, noopLogger, deps()),
 			/Command failed/,
 		);
 		assert.deepEqual(lastUpdate(), { syncStatus: "failed" });
@@ -424,7 +414,7 @@ describe("processMailboxManagement — a tagged NO the server means as success (
 		};
 
 		await assert.doesNotReject(
-			processMailboxManagement(createEvent, noopLog, deps()),
+			processMailboxManagement(createEvent, noopLogger, deps()),
 		);
 		assert.deepEqual(lastUpdate(), { syncStatus: "synced" });
 	});
@@ -438,7 +428,7 @@ describe("processMailboxManagement — a tagged NO the server means as success (
 		};
 
 		await assert.rejects(
-			processMailboxManagement(createEvent, noopLog, deps()),
+			processMailboxManagement(createEvent, noopLogger, deps()),
 			/Command failed/,
 		);
 		assert.deepEqual(lastUpdate(), { syncStatus: "failed" });
@@ -453,7 +443,7 @@ describe("processMailboxManagement — a tagged NO the server means as success (
 		};
 
 		await assert.doesNotReject(
-			processMailboxManagement(renameEvent, noopLog, deps()),
+			processMailboxManagement(renameEvent, noopLogger, deps()),
 		);
 		assert.deepEqual(called("mailbox.delete")[0]?.args, ["acc-1", "mbx-1"]);
 	});
@@ -467,7 +457,7 @@ describe("processMailboxManagement — a tagged NO the server means as success (
 		};
 
 		await assert.rejects(
-			processMailboxManagement(renameEvent, noopLog, deps()),
+			processMailboxManagement(renameEvent, noopLogger, deps()),
 			/Command failed/,
 		);
 		assert.equal(lastUpdate()?.syncStatus, "failed");

package/src/handlers/message-copy.test.ts

@@ -1,19 +1,9 @@
 import assert from "node:assert/strict";
 import { beforeEach, describe, it } from "node:test";
-import type { Logger } from "@remit/logger-lambda";
+import { noopLogger } from "@remit/logger-lambda/noop-logger";
 import type { MessageCopyEvent } from "../events.js";
 import { handleMessageCopy, type MessageCopyDeps } from "./message-copy.js";
 
-const noopLog = {
-	info: () => {},
-	warn: () => {},
-	error: () => {},
-	debug: () => {},
-	fatal: () => {},
-	trace: () => {},
-	child: () => noopLog,
-} as unknown as Logger;
-
 interface Call {
 	method: string;
 	args: unknown[];
@@ -194,7 +184,7 @@ describe("handleMessageCopy", () => {
 	});
 
 	it("writes the new UID, marks the copy synced, and updates the thread row", async () => {
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.deepEqual(called("message.updateUid")[0]?.args, [
 			"new-msg",
@@ -214,7 +204,7 @@ describe("handleMessageCopy", () => {
 		h.connection.copyMessages = async () => ({ uidMap: new Map() });
 		h.destinationHolds = [42];
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.ok(askedTheDestination(), "the destination was asked for the copy");
 		assert.deepEqual(called("message.updateUid")[0]?.args, [
@@ -240,7 +230,7 @@ describe("handleMessageCopy", () => {
 		h.connection.copyMessages = async () => ({ uidMap: new Map() });
 		h.destinationHolds = [12, 42];
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.deepEqual(called("message.updateUid")[0]?.args, [
 			"new-msg",
@@ -253,7 +243,7 @@ describe("handleMessageCopy", () => {
 		h.connection.copyMessages = async () => ({ uidMap: new Map() });
 		h.destinationHolds = [];
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.ok(askedTheDestination());
 		assert.equal(called("message.delete")[0]?.args[0], "new-msg");
@@ -269,7 +259,7 @@ describe("handleMessageCopy", () => {
 		};
 		h.copyRow = { ...unsettledCopyRow(), messageIdHeader: undefined };
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.equal(copies, 1, "the COPY is issued once");
 		assert.equal(called("search").length, 0, "there is nothing to ask with");
@@ -285,7 +275,7 @@ describe("handleMessageCopy", () => {
 	it("never copies twice when a redelivered copy already landed", async () => {
 		h.destinationHolds = [42];
 
-		await handleMessageCopy(event, noopLog, 2, deps());
+		await handleMessageCopy(event, noopLogger, 2, deps());
 
 		assert.equal(called("copyMessages").length, 0);
 		assert.deepEqual(called("message.updateUid")[0]?.args, [
@@ -305,10 +295,10 @@ describe("handleMessageCopy", () => {
 		};
 
 		await assert.rejects(
-			handleMessageCopy(event, noopLog, 1, deps()),
+			handleMessageCopy(event, noopLogger, 1, deps()),
 			/connection reset/,
 		);
-		await handleMessageCopy(event, noopLog, 2, deps());
+		await handleMessageCopy(event, noopLogger, 2, deps());
 
 		assert.equal(copies, 1, "the redelivery issues no second COPY");
 		assert.equal(called("search").length, 0);
@@ -324,7 +314,7 @@ describe("handleMessageCopy", () => {
 			syncStatus: "synced",
 		};
 
-		await handleMessageCopy(event, noopLog, 2, deps());
+		await handleMessageCopy(event, noopLogger, 2, deps());
 
 		assert.equal(h.getConnectionCount, 0);
 		assert.equal(called("copyMessages").length, 0);
@@ -333,7 +323,7 @@ describe("handleMessageCopy", () => {
 	it("acks when the copy row no longer exists", async () => {
 		h.copyRow = null;
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.equal(h.getConnectionCount, 0);
 		assert.equal(called("message.update").length, 0);
@@ -346,7 +336,7 @@ describe("handleMessageCopy", () => {
 			deletedAt: Date.now(),
 		};
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.equal(h.getConnectionCount, 0);
 	});
@@ -355,7 +345,7 @@ describe("handleMessageCopy", () => {
 		h.account = null;
 
 		await assert.rejects(
-			handleMessageCopy(event, noopLog, 1, deps()),
+			handleMessageCopy(event, noopLogger, 1, deps()),
 			/not found/,
 		);
 	});
@@ -363,7 +353,7 @@ describe("handleMessageCopy", () => {
 	it("acks terminally without connecting when the source mailbox was deleted", async () => {
 		h.mailboxError = notFoundError();
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.equal(h.getConnectionCount, 0);
 		assert.equal(called("message.updateUid").length, 0);
@@ -382,7 +372,7 @@ describe("handleMessageCopy", () => {
 			cursorState: "rebuilding",
 		};
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.equal(h.getConnectionCount, 0);
 		assert.equal(called("message.updateUid").length, 0);
@@ -405,7 +395,7 @@ describe("handleMessageCopy", () => {
 		};
 		h.destinationHolds = [42];
 
-		await handleMessageCopy(event, noopLog, 2, deps());
+		await handleMessageCopy(event, noopLogger, 2, deps());
 
 		assert.ok(askedTheDestination(), "the destination was asked for the copy");
 		assert.deepEqual(called("message.updateUid")[0]?.args, [
@@ -429,7 +419,7 @@ describe("handleMessageCopy", () => {
 		};
 		h.copyRow = { ...unsettledCopyRow(), messageIdHeader: undefined };
 
-		await handleMessageCopy(event, noopLog, 2, deps());
+		await handleMessageCopy(event, noopLogger, 2, deps());
 
 		assert.equal(
 			called("message.delete").length,
@@ -453,7 +443,7 @@ describe("handleMessageCopy", () => {
 			cursorState: "rebuilding",
 		};
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.deepEqual(
 			called("emitEvent").map((c) => c.args[0]),
@@ -472,7 +462,7 @@ describe("handleMessageCopy", () => {
 		};
 		h.destinationHolds = [];
 
-		await handleMessageCopy(event, noopLog, 2, deps());
+		await handleMessageCopy(event, noopLogger, 2, deps());
 
 		assert.ok(askedTheDestination());
 		assert.deepEqual(called("message.delete")[0]?.args, ["new-msg"]);
@@ -481,7 +471,7 @@ describe("handleMessageCopy", () => {
 	it("reconciles the optimistic copy row away when openBox trips a UIDVALIDITY mismatch", async () => {
 		h.connection.openBox = async () => ({ uidvalidity: 999 });
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		assert.equal(
 			(called("mailbox.update")[0]?.args[2] as { cursorState?: string })
@@ -500,7 +490,7 @@ describe("handleMessageCopy", () => {
 		};
 
 		await assert.rejects(
-			handleMessageCopy(event, noopLog, 1, deps()),
+			handleMessageCopy(event, noopLogger, 1, deps()),
 			/TRYCREATE/,
 		);
 
@@ -513,7 +503,7 @@ describe("handleMessageCopy", () => {
 			throw new Error("NONEXISTENT source message");
 		};
 
-		await handleMessageCopy(event, noopLog, 1, deps());
+		await handleMessageCopy(event, noopLogger, 1, deps());
 
 		const update = called("message.update")[0];
 		assert.equal((update?.args[1] as { status?: string })?.status, "deleted");
@@ -526,7 +516,7 @@ describe("handleMessageCopy", () => {
 		};
 
 		await assert.rejects(
-			handleMessageCopy(event, noopLog, 1, deps()),
+			handleMessageCopy(event, noopLogger, 1, deps()),
 			/server exploded/,
 		);
 
@@ -548,7 +538,7 @@ describe("handleMessageCopy", () => {
 			return asked === 1 ? [] : [42];
 		};
 
-		await handleMessageCopy(event, noopLog, 3, deps());
+		await handleMessageCopy(event, noopLogger, 3, deps());
 
 		assert.deepEqual(called("message.updateUid")[0]?.args, [
 			"new-msg",
@@ -563,7 +553,7 @@ describe("handleMessageCopy", () => {
 		};
 		h.destinationHolds = [];
 
-		await handleMessageCopy(event, noopLog, 3, deps());
+		await handleMessageCopy(event, noopLogger, 3, deps());
 
 		assert.equal(called("message.delete")[0]?.args[0], "new-msg");
 		assert.equal(called("threadMessage.deleteMany").length, 1);