@remit/imap-worker 0.0.60 → 0.0.61

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/imap-worker",
-  "version": "0.0.60",
+  "version": "0.0.61",
   "type": "module",
   "main": "dist/index.js",
   "exports": {

package/src/filter-config.test.ts

@@ -15,6 +15,7 @@ import {
 	type PlacementMoveService,
 } from "@remit/mailbox-service";
 import { buildFilterConfig, type FilterConfigDeps } from "./filter-config.js";
+import { _resetMessageEmbedderForTest } from "./message-embedder.js";
 
 const anchorOnlyFilter = (destinationMailboxId: string): FilterItem =>
 	({
@@ -117,3 +118,54 @@ describe("buildFilterConfig", () => {
 		assert.equal(decision.move, undefined);
 	});
 });
+
+// An instance with semantic search off (issue #1068). `off` selects an embedder
+// that throws by design, and the throw lands in the pipeline's per-filter catch:
+// one error-level `filter_anchor_match_failed` for every semantic filter on
+// every message it syncs. The pipeline already has a designed skip for a
+// missing embedder, so the config passes none.
+describe("buildFilterConfig with semantic search off", () => {
+	const withProviderOff = async (body: () => Promise<void>): Promise<void> => {
+		const previous = process.env.SEARCH_EMBEDDING_PROVIDER;
+		process.env.SEARCH_EMBEDDING_PROVIDER = "off";
+		_resetMessageEmbedderForTest();
+		try {
+			await body();
+		} finally {
+			if (previous === undefined) {
+				delete process.env.SEARCH_EMBEDDING_PROVIDER;
+			} else {
+				process.env.SEARCH_EMBEDDING_PROVIDER = previous;
+			}
+			_resetMessageEmbedderForTest();
+		}
+	};
+
+	it("wires no embedder", async () => {
+		await withProviderOff(async () => {
+			const config = buildFilterConfig(repos(anchorOnlyFilter("mbx-archive")));
+
+			assert.ok(config);
+			assert.equal(config.embedder, undefined);
+		});
+	});
+
+	it("skips the semantic filter without logging an error", async () => {
+		await withProviderOff(async () => {
+			const config = buildFilterConfig(repos(anchorOnlyFilter("mbx-archive")));
+			assert.ok(config);
+
+			const errors: unknown[] = [];
+			const decision = await new FilterPipeline(config, {
+				info: () => {},
+				debug: () => {},
+				warn: () => {},
+				error: (fields) => errors.push(fields.alert),
+			}).evaluate("cfg-1", "m-off", message);
+
+			assert.deepEqual(decision.labels, []);
+			assert.equal(decision.move, undefined);
+			assert.deepEqual(errors, []);
+		});
+	});
+});

package/src/filter-config.ts

@@ -8,6 +8,10 @@ import type {
 	MessageEmbedder,
 	PlacementMoveService,
 } from "@remit/mailbox-service";
+import {
+	EMBEDDING_PROVIDER_OFF,
+	readEmbeddingProviderFromEnv,
+} from "@remit/search-service/from-env";
 import { getMessageEmbedder } from "./message-embedder.js";
 
 export interface FilterConfigDeps {
@@ -17,6 +21,21 @@ export interface FilterConfigDeps {
 	placementMoveService?: PlacementMoveService;
 }
 
+/**
+ * The env-selected embedder, or none on an instance with semantic search off.
+ *
+ * `off` embeds nothing by design, and its embedder says so by throwing
+ * (EmbeddingDisabledError). The pipeline has a designed skip for a *missing*
+ * embedder — semantic filters are passed over and logged at debug — but a
+ * present embedder that throws lands in the per-filter catch instead, which is
+ * an error-level `filter_anchor_match_failed` for every semantic filter on
+ * every synced message. Same outcome, a log nobody can read.
+ */
+const embedderFromEnv = (): MessageEmbedder | undefined =>
+	readEmbeddingProviderFromEnv() === EMBEDDING_PROVIDER_OFF
+		? undefined
+		: getMessageEmbedder();
+
 /**
  * Assemble the index-time filter config the body-sync pass runs (RFC 034). The
  * embedder is provisioned from env exactly as the backend read-path and
@@ -33,11 +52,12 @@ export const buildFilterConfig = (
 ): FilterConfig | undefined => {
 	const { placementMoveService } = deps;
 	if (!placementMoveService) return undefined;
+	const resolved = embedder ?? embedderFromEnv();
 	return {
 		filterService: deps.filterService,
 		filterAnchorService: deps.filterAnchorService,
 		messageLabelService: deps.messageLabelService,
 		placementMoveService,
-		embedder: embedder ?? getMessageEmbedder(),
+		...(resolved ? { embedder: resolved } : {}),
 	};
 };