@remit/imap-worker 0.0.30 → 0.0.32

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/imap-worker",
-  "version": "0.0.30",
+  "version": "0.0.32",
   "type": "module",
   "main": "dist/index.js",
   "exports": {

package/src/handlers/flag-push.test.ts

@@ -1,6 +1,6 @@
 import assert from "node:assert/strict";
-import { afterEach, describe, it, mock } from "node:test";
-import { getClient } from "@remit/backend/client";
+import { afterEach, before, describe, it, mock } from "node:test";
+import { getClient, type RemitClient, setClient } from "@remit/backend/client";
 import type { Logger } from "@remit/logger-lambda";
 import type { FlagPushEvent } from "../events.js";
 import {
@@ -58,6 +58,21 @@ describe("handleFlagPush — deleted mailbox is terminal (#287/#289)", () => {
 		flagName,
 	} as FlagPushEvent;
 
+	// The client is supplied by injection (`setClient`), so these tests register
+	// the repositories they then mock rather than reaching a composition.
+	before(() => {
+		setClient({
+			account: { get: async () => undefined },
+			message: { get: async () => undefined },
+			mailbox: { get: async () => undefined },
+			flagPush: {
+				find: async () => undefined,
+				updateState: async () => undefined,
+				delete: async () => undefined,
+			},
+		} as unknown as RemitClient);
+	});
+
 	afterEach(() => mock.restoreAll());
 
 	it("drops the orphaned marker and acks without pushing when the mailbox is gone", async () => {

package/src/handlers/mailbox-management.test.ts

@@ -106,6 +106,10 @@ const deps = (): MailboxManagementDeps =>
 					h.calls.push({ method: "mailbox.update", args });
 					if (h.mailboxUpdateError) throw h.mailboxUpdateError;
 				},
+				findByPathPrefix: async (...args: unknown[]) => {
+					h.calls.push({ method: "mailbox.findByPathPrefix", args });
+					return [];
+				},
 				delete: record("mailbox.delete"),
 			},
 			secrets: {},

package/src/handlers/mailbox-management.ts

@@ -70,15 +70,18 @@ const isMailboxPresentUpstream = (error: unknown): boolean => {
  * Pinned invariant for the whole-chain terminal guards below.
  *
  * Each handler wraps its `MailboxManagementService.sync*` chain in a try/catch
- * that treats a NotFoundError as terminal (ack with a WARN, issue #289). That
- * is only sound because `syncCreate` / `syncRename` / `syncDelete` — and their
- * error-recovery branches here — touch nothing but the single target mailbox
- * row via `mailboxService.get/update/delete(accountId, mailboxId)`. So the only
- * row a NotFoundError can refer to is that target, and its absence can only mean
- * the user deleted the folder mid-sync — never an unrelated missing entity that
- * should have been retried. If a sync method ever reads or writes a second
- * entity, narrow these catches (match the mailboxId / re-check existence) before
- * a NotFoundError from elsewhere is silently acked.
+ * that treats a NotFoundError as terminal (ack with a WARN, issue #289). That is
+ * only sound while the sole row a NotFoundError can refer to is the target
+ * mailbox, so its absence can only mean the user deleted the folder mid-sync —
+ * never an unrelated missing entity that should have been retried.
+ *
+ * `syncCreate` and `syncDelete` hold to that by touching nothing but the target
+ * row. `syncRename` also writes the renamed subtree's descendant rows, and keeps
+ * the invariant by absorbing their NotFoundErrors itself: a descendant deleted
+ * mid-settle never reaches these catches. Any sync method that reads or writes a
+ * second entity owes the same, or these catches must be narrowed (match the
+ * mailboxId / re-check existence) before a NotFoundError from elsewhere is
+ * silently acked.
  */
 
 /**

package/src/handlers/message-move.test.ts

@@ -1,6 +1,6 @@
 import assert from "node:assert";
-import { afterEach, describe, it, mock } from "node:test";
-import { getClient } from "@remit/backend/client";
+import { afterEach, before, describe, it, mock } from "node:test";
+import { getClient, type RemitClient, setClient } from "@remit/backend/client";
 import type { AccountItem, ThreadMessageItem } from "@remit/data-ports";
 import type { Logger } from "@remit/logger-lambda";
 import type { MessageMoveEvent } from "../events.js";
@@ -219,6 +219,17 @@ describe("handleMessageMove — deleted mailbox is terminal (#287/#289)", () =>
 		timestamp: 1700000000000,
 	} as MessageMoveEvent;
 
+	// The client is supplied by injection (`setClient`), so these tests register
+	// the repositories they then mock rather than reaching a composition.
+	before(() => {
+		setClient({
+			account: { get: async () => undefined },
+			mailbox: { get: async () => undefined },
+			message: { updateUid: async () => undefined },
+			secrets: { decrypt: async () => undefined },
+		} as unknown as RemitClient);
+	});
+
 	afterEach(() => mock.restoreAll());
 
 	it("acks without connecting when the source mailbox was deleted", async () => {

package/src/handlers/placement-move-push.test.ts

@@ -1,6 +1,6 @@
 import assert from "node:assert/strict";
-import { afterEach, describe, it, mock } from "node:test";
-import { getClient } from "@remit/backend/client";
+import { afterEach, before, describe, it, mock } from "node:test";
+import { getClient, type RemitClient, setClient } from "@remit/backend/client";
 import type { Logger } from "@remit/logger-lambda";
 import type { IImapConnection } from "@remit/mailbox-service";
 import type { PlacementMovePushEvent } from "../events.js";
@@ -295,6 +295,21 @@ describe("handlePlacementMovePush — deleted mailbox is terminal (#287/#289)",
 		timestamp: 1700000000000,
 	};
 
+	// The client is supplied by injection (`setClient`), so these tests register
+	// the repositories they then mock rather than reaching a composition.
+	before(() => {
+		setClient({
+			account: { get: async () => undefined },
+			message: { get: async () => undefined },
+			mailbox: { get: async () => undefined },
+			placementMove: {
+				find: async () => undefined,
+				updateState: async () => undefined,
+				delete: async () => undefined,
+			},
+		} as unknown as RemitClient);
+	});
+
 	afterEach(() => mock.restoreAll());
 
 	it("drops the marker and acks without pushing when a mailbox is gone", async () => {

package/src/handlers/sync-message-body.test.ts

@@ -221,10 +221,8 @@ describe("syncMessageBody — DLQ propagation (integrated, #1270)", () => {
 	const cappedMailbox = (): MailboxItem =>
 		({ fullPath: "INBOX" }) as unknown as MailboxItem;
 
-	// On the DynamoDB path (main repo, DATA_BACKEND unset) the client is injected
-	// by the composition root; register a client whose repositories these tests
-	// then mock. On the relational path (reader, DATA_BACKEND=postgres) getClient
-	// builds its own client and this injection is inert.
+	// The client is supplied by injection (`setClient`), so these tests register
+	// the repositories they then mock rather than reaching a composition.
 	before(() => {
 		setClient({
 			account: { get: async () => cappedAccount() },