@remit/imap-worker 0.0.18 → 0.0.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/imap-worker",
-  "version": "0.0.18",
+  "version": "0.0.19",
   "type": "module",
   "main": "dist/index.js",
   "exports": {

package/src/e2e-processor-shim.ts

@@ -14,6 +14,7 @@ import type {
 	SQSHandler,
 } from "aws-lambda";
 import { env } from "expect-env";
+import { receiveVisibilitySeconds } from "./e2e-processor-visibility.js";
 import { handler } from "./index.js";
 
 /**
@@ -150,7 +151,13 @@ if (cluster.isPrimary) {
 					QueueUrl: queueUrl,
 					MaxNumberOfMessages: maxMessages,
 					WaitTimeSeconds: waitTime,
-					VisibilityTimeout: 300,
+					// A failed message is left un-deleted and only redelivers when this
+					// window lapses; on the per-account FIFO sync queues that window is
+					// also how long a single failure head-of-line blocks the account's
+					// whole pipeline (#290). Keep it short for FIFO, long for the
+					// standard queues whose slower work needs it. See
+					// `receiveVisibilitySeconds`.
+					VisibilityTimeout: receiveVisibilitySeconds(queueUrl),
 					MessageSystemAttributeNames: ["ApproximateReceiveCount"],
 				}),
 			);

package/src/e2e-processor-visibility.test.ts

@@ -0,0 +1,43 @@
+import assert from "node:assert/strict";
+import { describe, it } from "node:test";
+import {
+	FIFO_RECEIVE_VISIBILITY_SECONDS,
+	receiveVisibilitySeconds,
+	STANDARD_RECEIVE_VISIBILITY_SECONDS,
+} from "./e2e-processor-visibility.js";
+
+describe("receiveVisibilitySeconds", () => {
+	it("gives the per-account FIFO sync queues a short window so a failure unblocks fast", () => {
+		for (const url of [
+			"http://localhost:9324/000/remit-mailboxes.fifo",
+			"http://localhost:9324/000/remit-messages.fifo",
+			"http://localhost:9324/000/remit-flags.fifo",
+		]) {
+			assert.equal(
+				receiveVisibilitySeconds(url),
+				FIFO_RECEIVE_VISIBILITY_SECONDS,
+			);
+		}
+	});
+
+	it("keeps the long window for the standard body and management queues", () => {
+		for (const url of [
+			"http://localhost:9324/000/remit-body",
+			"http://localhost:9324/000/remit-mailbox-mgmt",
+			"http://localhost:9324/000/remit-message-mgmt",
+			"http://localhost:9324/000/remit-search-index",
+		]) {
+			assert.equal(
+				receiveVisibilitySeconds(url),
+				STANDARD_RECEIVE_VISIBILITY_SECONDS,
+			);
+		}
+	});
+
+	it("keeps the FIFO window short enough to unblock within a spec's seed budget, above a sync round's own duration", () => {
+		assert.ok(FIFO_RECEIVE_VISIBILITY_SECONDS > 0);
+		assert.ok(
+			FIFO_RECEIVE_VISIBILITY_SECONDS < STANDARD_RECEIVE_VISIBILITY_SECONDS,
+		);
+	});
+});

package/src/e2e-processor-visibility.ts

@@ -0,0 +1,27 @@
+/**
+ * Receive-time visibility (seconds) the e2e drainer requests for a queue.
+ *
+ * A message the handler reports as failed is left un-deleted and only
+ * redelivers once its visibility lapses. The sync queues are per-account FIFO
+ * (`MessageGroupId = accountId`): while one message sits invisible, every later
+ * message in its group is held back too. So the visibility window a failed sync
+ * event sits out is also the window the whole account's sync pipeline stalls —
+ * and at a multi-minute window that stall swallows a spec's entire seed-and-wait
+ * budget when a transient IMAP hiccup fails one event mid-run, which is the
+ * recurring e2e-dev flake (#290).
+ *
+ * FIFO sync queues therefore get a short window: a transient failure costs one
+ * brief retry instead of a minutes-long group stall, and the handlers on these
+ * queues (a mailbox LIST, a header SEARCH/FETCH) finish well inside it — a rare
+ * slow round redelivers harmlessly, since the mailbox lock makes a concurrent
+ * re-run a no-op. The standard queues (body sync's ranged FETCH of up to 200
+ * message bodies, the management queues) keep the longer window their slower,
+ * non-FIFO work needs and where a redelivery blocks nothing but itself.
+ */
+export const FIFO_RECEIVE_VISIBILITY_SECONDS = 30;
+export const STANDARD_RECEIVE_VISIBILITY_SECONDS = 300;
+
+export const receiveVisibilitySeconds = (queueUrl: string): number =>
+	queueUrl.endsWith(".fifo")
+		? FIFO_RECEIVE_VISIBILITY_SECONDS
+		: STANDARD_RECEIVE_VISIBILITY_SECONDS;