@remit/drizzle-service 0.0.99 → 0.0.101

package/src/repos/filter-anchor-transaction.test.ts

@@ -1,136 +0,0 @@
-import assert from "node:assert";
-import { after, before, describe, test } from "node:test";
-import { FilterScope } from "@remit/domain-enums";
-import { NotFoundError } from "../error.js";
-import { createTestDb, randomId, type TestDb } from "../test-db.js";
-import { FilterRepo } from "./filter.js";
-import { FilterAnchorRepo } from "./filter-anchor.js";
-import { DrizzleFilterAnchorTransaction } from "./filter-anchor-transaction.js";
-
-describe("DrizzleFilterAnchorTransaction", () => {
-	let db: TestDb;
-	let close: () => Promise<void>;
-	let transaction: DrizzleFilterAnchorTransaction;
-	let filterRepo: FilterRepo;
-	let filterAnchorRepo: FilterAnchorRepo;
-
-	before(async () => {
-		({ db, close } = await createTestDb());
-		transaction = new DrizzleFilterAnchorTransaction(db as never);
-		filterRepo = new FilterRepo(db as never);
-		filterAnchorRepo = new FilterAnchorRepo(db as never);
-	});
-
-	after(async () => {
-		await close();
-	});
-
-	test("creates the Filter and its FilterAnchor together", async () => {
-		const accountConfigId = randomId();
-
-		const filter = await transaction.createWithAnchor(
-			{
-				accountConfigId,
-				name: "Booking confirmations",
-				scope: FilterScope.Standing,
-				hasAnchor: true,
-			},
-			{
-				accountConfigId,
-				anchorMessageId: randomId(),
-				anchorEmbedding: [0.1, 0.2, 0.3],
-				anchorEmbeddingId: "amazon.titan-embed-text-v2:0@1024",
-				anchorSourceText: "Your booking is confirmed",
-			},
-		);
-
-		assert.equal(filter.hasAnchor, true);
-		const anchor = await filterAnchorRepo.get(accountConfigId, filter.filterId);
-		assert.ok(anchor, "the FilterAnchor row must exist");
-		assert.equal(anchor?.anchorSourceText, "Your booking is confirmed");
-	});
-
-	test("creates a purely-literal Filter when anchor is null", async () => {
-		const accountConfigId = randomId();
-
-		const filter = await transaction.createWithAnchor(
-			{
-				accountConfigId,
-				name: "From billing",
-				scope: FilterScope.Standing,
-				hasAnchor: false,
-			},
-			null,
-		);
-
-		assert.equal(filter.hasAnchor, false);
-		const anchor = await filterAnchorRepo.get(accountConfigId, filter.filterId);
-		assert.equal(anchor, null);
-	});
-
-	test("rolls back the Filter row when the FilterAnchor write fails (#351)", async () => {
-		const accountConfigId = randomId();
-
-		await assert.rejects(() =>
-			transaction.createWithAnchor(
-				{
-					accountConfigId,
-					name: "Broken anchor",
-					scope: FilterScope.Standing,
-					hasAnchor: true,
-				},
-				{
-					accountConfigId,
-					anchorMessageId: randomId(),
-					anchorEmbedding: [0.1, 0.2, 0.3],
-					anchorEmbeddingId: "amazon.titan-embed-text-v2:0@1024",
-					// A NOT NULL column at the DB level — simulates a real write
-					// failure on the second half of the pair (network blip,
-					// transient error), the exact case #351 leaves broken today.
-					anchorSourceText: null as unknown as string,
-				},
-			),
-		);
-
-		const filters = await filterRepo.listByAccountConfig(accountConfigId);
-		assert.equal(
-			filters.length,
-			0,
-			"the Filter row must not survive when its anchor write fails",
-		);
-	});
-
-	test("the caller never sees a Filter row with hasAnchor: true and no anchor (#351)", async () => {
-		const accountConfigId = randomId();
-
-		await assert.rejects(() =>
-			transaction.createWithAnchor(
-				{
-					accountConfigId,
-					name: "Broken anchor 2",
-					scope: FilterScope.Standing,
-					hasAnchor: true,
-				},
-				{
-					accountConfigId,
-					anchorMessageId: randomId(),
-					anchorEmbedding: [0.1, 0.2, 0.3],
-					anchorEmbeddingId: "amazon.titan-embed-text-v2:0@1024",
-					anchorSourceText: null as unknown as string,
-				},
-			),
-		);
-
-		const filters = await filterRepo.listByAccountConfig(accountConfigId);
-		const orphan = filters.find((f) => f.hasAnchor);
-		assert.equal(
-			orphan,
-			undefined,
-			"no Filter with hasAnchor: true may exist without a FilterAnchor row",
-		);
-	});
-
-	test("get on a never-created filter still throws NotFoundError (sanity)", async () => {
-		await assert.rejects(filterRepo.get(randomId(), randomId()), NotFoundError);
-	});
-});

package/src/repos/filter-anchor-transaction.ts

@@ -1,45 +0,0 @@
-import type {
-	CreateFilterAnchorInput,
-	CreateFilterInput,
-	FilterItem,
-	IFilterAnchorTransaction,
-} from "@remit/data-ports";
-import type { Db } from "../db.js";
-import { runInTransaction } from "../tx.js";
-import { FilterRepo } from "./filter.js";
-import { FilterAnchorRepo } from "./filter-anchor.js";
-
-type DB = Db<Record<string, unknown>>;
-
-/**
- * Runs the `Filter` create and its optional `FilterAnchor` write in one
- * transaction (#351): a failure on either side rolls back both, so a
- * `Filter` row can never persist with `hasAnchor: true` and no matching
- * `FilterAnchor` row, and a `FilterAnchor` write failure surfaces as a
- * failed create request rather than a silently-broken filter.
- */
-export class DrizzleFilterAnchorTransaction
-	implements IFilterAnchorTransaction
-{
-	constructor(private db: DB) {}
-
-	createWithAnchor(
-		filterInput: CreateFilterInput,
-		anchorInput: Omit<CreateFilterAnchorInput, "filterId"> | null,
-	): Promise<FilterItem> {
-		return runInTransaction(this.db, async (tx) => {
-			const filterRepo = new FilterRepo(tx as never);
-			const filter = await filterRepo.create(filterInput);
-
-			if (anchorInput) {
-				const filterAnchorRepo = new FilterAnchorRepo(tx as never);
-				await filterAnchorRepo.put({
-					...anchorInput,
-					filterId: filter.filterId,
-				});
-			}
-
-			return filter;
-		});
-	}
-}

package/src/repos/filter-anchor.test.ts

@@ -1,131 +0,0 @@
-import assert from "node:assert";
-import { after, before, describe, test } from "node:test";
-import { createTestDb, randomId, type TestDb } from "../test-db.js";
-import { FilterAnchorRepo } from "./filter-anchor.js";
-
-describe("FilterAnchorRepo", () => {
-	let db: TestDb;
-	let close: () => Promise<void>;
-	let repo: FilterAnchorRepo;
-
-	before(async () => {
-		({ db, close } = await createTestDb());
-		repo = new FilterAnchorRepo(db as never);
-	});
-
-	after(async () => {
-		await close();
-	});
-
-	test("put creates the row and round-trips the anchor vector", async () => {
-		const accountConfigId = randomId();
-		const filterId = randomId();
-		const anchorMessageId = randomId();
-		const anchorEmbedding = [0.1, -0.2, 0.3, 0];
-
-		const anchor = await repo.put({
-			accountConfigId,
-			filterId,
-			anchorEmbedding,
-			anchorEmbeddingId: "amazon.titan-embed-text-v2:0@1024",
-			anchorSourceText: "Your booking is confirmed for...",
-			anchorMessageId,
-		});
-
-		assert.deepEqual(anchor.anchorEmbedding, anchorEmbedding);
-		assert.equal(anchor.anchorMessageId, anchorMessageId);
-	});
-
-	test("get returns null when no anchor exists for the filter", async () => {
-		const anchor = await repo.get(randomId(), randomId());
-		assert.equal(anchor, null);
-	});
-
-	test("put upserts — a re-embed migration overwrites the existing row", async () => {
-		const accountConfigId = randomId();
-		const filterId = randomId();
-		const anchorMessageId = randomId();
-
-		await repo.put({
-			accountConfigId,
-			filterId,
-			anchorEmbedding: [1, 2, 3],
-			anchorEmbeddingId: "amazon.titan-embed-text-v2:0@1024",
-			anchorSourceText: "original",
-			anchorMessageId,
-		});
-
-		const migrated = await repo.put({
-			accountConfigId,
-			filterId,
-			anchorEmbedding: [4, 5, 6],
-			anchorEmbeddingId: "amazon.titan-embed-text-v3:0@1536",
-			anchorSourceText: "original",
-			anchorMessageId,
-		});
-
-		assert.deepEqual(migrated.anchorEmbedding, [4, 5, 6]);
-		assert.equal(
-			migrated.anchorEmbeddingId,
-			"amazon.titan-embed-text-v3:0@1536",
-		);
-
-		const reread = await repo.get(accountConfigId, filterId);
-		assert.deepEqual(reread?.anchorEmbedding, [4, 5, 6]);
-	});
-
-	test("listByAccountConfig returns every anchor for the account config", async () => {
-		const accountConfigId = randomId();
-		const filterIdA = randomId();
-		const filterIdB = randomId();
-		const otherConfigId = randomId();
-		const otherFilterId = randomId();
-
-		await repo.put({
-			accountConfigId,
-			filterId: filterIdA,
-			anchorEmbedding: [1, 2, 3],
-			anchorEmbeddingId: "amazon.titan-embed-text-v2:0@1024",
-			anchorSourceText: "a",
-			anchorMessageId: randomId(),
-		});
-		await repo.put({
-			accountConfigId,
-			filterId: filterIdB,
-			anchorEmbedding: [4, 5, 6],
-			anchorEmbeddingId: "amazon.titan-embed-text-v2:0@1024",
-			anchorSourceText: "b",
-			anchorMessageId: randomId(),
-		});
-		await repo.put({
-			accountConfigId: otherConfigId,
-			filterId: otherFilterId,
-			anchorEmbedding: [7, 8, 9],
-			anchorEmbeddingId: "amazon.titan-embed-text-v2:0@1024",
-			anchorSourceText: "other",
-			anchorMessageId: randomId(),
-		});
-
-		const anchors = await repo.listByAccountConfig(accountConfigId);
-		const filterIds = anchors.map((a) => a.filterId).sort();
-		assert.deepEqual(filterIds, [filterIdA, filterIdB].sort());
-	});
-
-	test("delete removes the row", async () => {
-		const accountConfigId = randomId();
-		const filterId = randomId();
-
-		await repo.put({
-			accountConfigId,
-			filterId,
-			anchorEmbedding: [1],
-			anchorEmbeddingId: "amazon.titan-embed-text-v2:0@1024",
-			anchorSourceText: "text",
-			anchorMessageId: randomId(),
-		});
-
-		await repo.delete(accountConfigId, filterId);
-
-		assert.equal(await repo.get(accountConfigId, filterId), null);
-	});
-});

package/src/repos/filter-anchor.ts

@@ -1,105 +0,0 @@
-import type {
-	CreateFilterAnchorInput,
-	FilterAnchorItem,
-	IFilterAnchorRepository,
-} from "@remit/data-ports";
-import { and, eq } from "drizzle-orm";
-import type { Db } from "../db.js";
-import { filterAnchorTable } from "../schema.js";
-
-type DB = Db<Record<string, unknown>>;
-
-function rowToFilterAnchor(
-	row: typeof filterAnchorTable.$inferSelect,
-): FilterAnchorItem {
-	return {
-		accountConfigId: row.accountConfigId,
-		filterId: row.filterId,
-		anchorEmbedding: row.anchorEmbedding as number[],
-		anchorEmbeddingId: row.anchorEmbeddingId,
-		anchorSourceText: row.anchorSourceText,
-		anchorMessageId: row.anchorMessageId,
-		createdAt: row.createdAt,
-		updatedAt: row.updatedAt,
-	};
-}
-
-/**
- * Relational counterpart to `FilterAnchorService` (remit-electrodb-service). The
- * anchor vector is persisted inline on the row (RFC 034 Decision 2.1/2.3); the
- * vector store's per-message chunk vectors are read only by the search
- * service when it builds the anchor, never re-derived here at match time.
- */
-export class FilterAnchorRepo implements IFilterAnchorRepository {
-	constructor(private db: DB) {}
-
-	/**
-	 * Upsert — a filter's anchor is (re)computed once at save time (RFC 034
-	 * Decision 2.1) and again only by an explicit re-embed migration
-	 * (Decision 2.4).
-	 */
-	async put(input: CreateFilterAnchorInput): Promise<FilterAnchorItem> {
-		const now = Date.now();
-		const [row] = await this.db
-			.insert(filterAnchorTable)
-			.values({
-				accountConfigId: input.accountConfigId,
-				filterId: input.filterId,
-				anchorEmbedding: input.anchorEmbedding,
-				anchorEmbeddingId: input.anchorEmbeddingId,
-				anchorSourceText: input.anchorSourceText,
-				anchorMessageId: input.anchorMessageId,
-				createdAt: now,
-				updatedAt: now,
-			})
-			.onConflictDoUpdate({
-				target: [filterAnchorTable.accountConfigId, filterAnchorTable.filterId],
-				set: {
-					anchorEmbedding: input.anchorEmbedding,
-					anchorEmbeddingId: input.anchorEmbeddingId,
-					anchorSourceText: input.anchorSourceText,
-					anchorMessageId: input.anchorMessageId,
-					updatedAt: now,
-				},
-			})
-			.returning();
-		return rowToFilterAnchor(row);
-	}
-
-	async get(
-		accountConfigId: string,
-		filterId: string,
-	): Promise<FilterAnchorItem | null> {
-		const [row] = await this.db
-			.select()
-			.from(filterAnchorTable)
-			.where(
-				and(
-					eq(filterAnchorTable.accountConfigId, accountConfigId),
-					eq(filterAnchorTable.filterId, filterId),
-				),
-			);
-		return row ? rowToFilterAnchor(row) : null;
-	}
-
-	async listByAccountConfig(
-		accountConfigId: string,
-	): Promise<FilterAnchorItem[]> {
-		const rows = await this.db
-			.select()
-			.from(filterAnchorTable)
-			.where(eq(filterAnchorTable.accountConfigId, accountConfigId));
-		return rows.map(rowToFilterAnchor);
-	}
-
-	async delete(accountConfigId: string, filterId: string): Promise<void> {
-		await this.db
-			.delete(filterAnchorTable)
-			.where(
-				and(
-					eq(filterAnchorTable.accountConfigId, accountConfigId),
-					eq(filterAnchorTable.filterId, filterId),
-				),
-			);
-	}
-}

package/src/repos/i4-mailbox-special-use.structure.test.ts

@@ -1,27 +0,0 @@
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { describe, it } from "node:test";
-
-/**
- * The path a stale appointment last pointed at is a display-only sibling row
- * (`FolderRoleAppointmentLabel`, #887). "Never read by resolution" is meant to
- * be structural rather than a habit: this repository composes one setting name
- * and has no way to reach the other. Read the source to prove it, because the
- * guarantee is about what the file cannot do, not about what any one call
- * returns.
- */
-describe("MailboxSpecialUseRepo and the appointment label row", () => {
-	const source = readFileSync(
-		new URL("./i4-mailbox-special-use.ts", import.meta.url),
-		"utf8",
-	);
-
-	it("never names the label setting", () => {
-		assert.equal(source.includes("FolderRoleAppointmentLabel"), false);
-	});
-
-	it("composes the appointment name in exactly one place", () => {
-		const uses = source.split("composeFolderRoleAppointmentName(").length - 1;
-		assert.equal(uses, 1);
-	});
-});

package/src/repos/message-placement-backfill.sqlite.test.ts

@@ -1,190 +0,0 @@
-/**
- * The two data migrations this release carries, against a database written by
- * the build before it.
- *
- * Both exist because a predicate changed meaning under rows already on disk.
- * `carriesForeignUid` reads `originalUid` without consulting `status`, so a
- * settled row that a pre-#1217 build left one on answers "this uid belongs to
- * another folder" forever — and Empty Trash refuses to remove it after the
- * server copy is gone (reader#1230). And the give-up signal moved from
- * `active` + `failed` to its own value, so an abandoned delete written before
- * the upgrade would go quiet: the row stays where it was handed back and the
- * user is told nothing.
- *
- * Applied through the shipped journal rather than a schema pushed from the
- * table objects, because a data migration that never runs is exactly the
- * failure being pinned.
- */
-
-import assert from "node:assert/strict";
-import { after, before, describe, test } from "node:test";
-import Database from "better-sqlite3";
-import {
-	applyMigration,
-	migrationJournal,
-} from "../test-shipped-sqlite-schema.js";
-
-const STALE_ORIGINAL_UID = "msg-stale-original-uid";
-const IN_FLIGHT = "msg-in-flight";
-const GAVE_UP = "msg-gave-up";
-const RETRYING_DELETE = "msg-retrying-delete";
-
-/** The migration that clears a settled row's stale `original_uid`. */
-const ORIGINAL_UID_BACKFILL = 24;
-
-/** The migration that carries an abandoned delete onto the give-up value. */
-const GIVE_UP_BACKFILL = 25;
-
-interface MessageRow {
-	message_id: string;
-	status: string;
-	sync_status: string;
-	abandoned_mutation: string;
-	original_uid: number | null;
-	original_mailbox_id: string | null;
-}
-
-describe("the placement backfills carry a pre-upgrade database forward", () => {
-	let sqlite: Database.Database;
-
-	const rowFor = (messageId: string): MessageRow =>
-		sqlite
-			.prepare("SELECT * FROM message WHERE message_id = ?")
-			.get(messageId) as MessageRow;
-
-	before(() => {
-		sqlite = new Database(":memory:");
-		const entries = migrationJournal();
-
-		// Everything the previous release shipped, and nothing this one adds.
-		for (const entry of entries.filter(
-			(candidate) => candidate.idx < ORIGINAL_UID_BACKFILL,
-		)) {
-			applyMigration(sqlite, entry.tag);
-		}
-
-		const insert = sqlite.prepare(
-			`INSERT INTO message (
-				message_id, mailbox_id, uid, sequence_number, rfc822_size,
-				internal_date, envelope_id, root_body_part_id,
-				status, sync_status, original_mailbox_id, original_uid,
-				created_at, updated_at
-			) VALUES (?, ?, ?, 1, 100, 0, ?, ?, ?, ?, ?, ?, 0, 0)`,
-		);
-
-		// Settled, with the `original_uid` a pre-#1217 `updateUid` left behind —
-		// and Trash handing back the source's own number, which on a young
-		// account is the common case rather than the exotic one.
-		insert.run(
-			STALE_ORIGINAL_UID,
-			"mbx-trash",
-			10,
-			`env-${STALE_ORIGINAL_UID}`,
-			`bp-${STALE_ORIGINAL_UID}`,
-			"active",
-			"synced",
-			"mbx-inbox",
-			10,
-		);
-
-		// Genuinely mid-move: this row's `original_uid` is not stale and must
-		// survive, or the guard that stops a move binding somebody else's uid
-		// stops working on every row the upgrade touched.
-		insert.run(
-			IN_FLIGHT,
-			"mbx-archive",
-			42,
-			`env-${IN_FLIGHT}`,
-			`bp-${IN_FLIGHT}`,
-			"moving",
-			"pending",
-			"mbx-inbox",
-			42,
-		);
-
-		// The pair a give-up wrote before this release. Two writers produced it —
-		// `abandonDelete` and the paused-cursor hand-back for an unproven MOVE —
-		// through the identical `restoreSourcePlacement` call, so the row cannot
-		// say which.
-		insert.run(
-			GAVE_UP,
-			"mbx-inbox",
-			7,
-			`env-${GAVE_UP}`,
-			`bp-${GAVE_UP}`,
-			"active",
-			"failed",
-			"mbx-inbox",
-			null,
-		);
-
-		// A transient attempt with a redelivery behind it. It writes the same
-		// `failed`, and keeping `deleting` beside it is the only thing that tells
-		// the two apart — so the backfill must not touch it.
-		insert.run(
-			RETRYING_DELETE,
-			"mbx-trash",
-			8,
-			`env-${RETRYING_DELETE}`,
-			`bp-${RETRYING_DELETE}`,
-			"deleting",
-			"failed",
-			"mbx-inbox",
-			8,
-		);
-
-		for (const entry of entries.filter(
-			(candidate) => candidate.idx >= ORIGINAL_UID_BACKFILL,
-		)) {
-			applyMigration(sqlite, entry.tag);
-		}
-	});
-
-	after(() => {
-		sqlite.close();
-	});
-
-	test("the journal ships both backfills", () => {
-		const idxs = migrationJournal().map((entry) => entry.idx);
-		assert.ok(idxs.includes(ORIGINAL_UID_BACKFILL));
-		assert.ok(idxs.includes(GIVE_UP_BACKFILL));
-	});
-
-	test("a settled row loses the stale uid that made it look foreign", () => {
-		const row = rowFor(STALE_ORIGINAL_UID);
-		assert.equal(row.original_uid, null);
-		assert.equal(
-			row.original_mailbox_id,
-			"mbx-inbox",
-			"Undo still restores to the folder the message came from",
-		);
-	});
-
-	test("a row still mid-move keeps the uid its guard depends on", () => {
-		assert.equal(rowFor(IN_FLIGHT).original_uid, 42);
-	});
-
-	test("a give-up keeps its chip, on the value the client now reads", () => {
-		const row = rowFor(GAVE_UP);
-		assert.equal(row.sync_status, "abandoned");
-		assert.equal(row.status, "active");
-	});
-
-	/**
-	 * The two pre-upgrade writers are indistinguishable in the row, so the
-	 * backfill has to pick one label for both. It picks the survivable mistake:
-	 * a wrongly-labelled move offers a folder picker the user can dismiss, while
-	 * a wrongly-labelled delete offers a button that destroys the message — the
-	 * #1229 defect, on a press the user believed was a repair.
-	 */
-	test("and is never labelled a delete, which would offer to destroy it", () => {
-		assert.equal(rowFor(GAVE_UP).abandoned_mutation, "move");
-	});
-
-	test("a delete mid-retry is left exactly as it was", () => {
-		const row = rowFor(RETRYING_DELETE);
-		assert.equal(row.sync_status, "failed");
-		assert.equal(row.abandoned_mutation, "none");
-		assert.equal(row.status, "deleting");
-	});
-});