@remit/data-ports 0.0.68 → 0.0.70

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/data-ports",
-  "version": "0.0.68",
+  "version": "0.0.70",
   "type": "module",
   "main": "src/index.ts",
   "types": "src/index.ts",

package/src/conformance/account.ts

@@ -0,0 +1,82 @@
+import assert from "node:assert/strict";
+import { after, before, describe, test } from "node:test";
+import { AccountService, ConnectionState } from "@remit/domain-enums";
+import type { IAccountRepository } from "../interfaces/account.js";
+import type { CreateAccountInput } from "../types.js";
+import type { RepositoryConformanceHarness } from "./harness.js";
+
+const accountInput = (accountConfigId: string): CreateAccountInput => ({
+	accountConfigId,
+	username: "person@example.com",
+	email: "person@example.com",
+	imapHost: "imap.example.com",
+	imapPort: 993,
+	imapTls: true,
+	imapStartTls: false,
+	isActive: true,
+	connectionState: ConnectionState.NotAuthenticated,
+});
+
+export function accountRepositoryConformance(
+	harness: RepositoryConformanceHarness<IAccountRepository>,
+): void {
+	describe("IAccountRepository conformance", () => {
+		let repo: IAccountRepository;
+
+		before(async () => {
+			repo = await harness.createRepository();
+		});
+
+		after(() => harness.teardown());
+
+		test("an account created without a service selection syncs mail", async () => {
+			const created = await repo.create(accountInput(harness.makeId()));
+
+			assert.deepEqual(created.syncedServices, [AccountService.Mail]);
+			assert.deepEqual((await repo.get(created.accountId)).syncedServices, [
+				AccountService.Mail,
+			]);
+		});
+
+		test("an account keeps the selection it was created with", async () => {
+			const created = await repo.create({
+				...accountInput(harness.makeId()),
+				syncedServices: [AccountService.Calendar],
+			});
+
+			assert.deepEqual((await repo.get(created.accountId)).syncedServices, [
+				AccountService.Calendar,
+			]);
+		});
+
+		test("an update replaces the selection outright", async () => {
+			const created = await repo.create(accountInput(harness.makeId()));
+
+			const updated = await repo.update(created.accountId, {
+				syncedServices: [AccountService.Mail, AccountService.Calendar],
+			});
+
+			assert.deepEqual(updated.syncedServices, [
+				AccountService.Mail,
+				AccountService.Calendar,
+			]);
+			assert.deepEqual((await repo.get(created.accountId)).syncedServices, [
+				AccountService.Mail,
+				AccountService.Calendar,
+			]);
+		});
+
+		test("an update that leaves the selection out keeps it", async () => {
+			const created = await repo.create({
+				...accountInput(harness.makeId()),
+				syncedServices: [AccountService.Calendar],
+			});
+
+			await repo.update(created.accountId, { lastError: "timeout" });
+
+			assert.deepEqual((await repo.get(created.accountId)).syncedServices, [
+				AccountService.Calendar,
+			]);
+		});
+	});
+}

package/src/conformance/index.ts

@@ -1,3 +1,4 @@
+export { accountRepositoryConformance } from "./account.js";
 export { calendarCollectionRepositoryConformance } from "./calendar-collection.js";
 export { calendarEventIndexRepositoryConformance } from "./calendar-event-index.js";
 export { calendarFeedTokenRepositoryConformance } from "./calendar-feed-token.js";

package/src/errors.ts

@@ -81,13 +81,19 @@ export class FolderRoleUnresolvedError extends ConflictError {
 }
 
 /**
- * A role cannot be appointed to a mailbox the mail server has not settled yet
- * (imap-mutations R2: wait). Its own code, because the role is not unresolved —
- * the target is: the client words a wait, not a retry. Clearing a role is never
- * refused this way.
+ * A durable reference cannot be bound to a mailbox whose own mutation has not
+ * settled (folder-rename-and-delete.md D12, imap-mutations R2: wait). Its own
+ * code, because the role is not unresolved — the target is: the client words a
+ * wait, not a retry. Clearing a role is never refused this way.
+ *
+ * **422, not 409** (D4). 409 already means "this folder is being changed right
+ * now, refresh"; this means "the folder you are pointing at has not settled
+ * yet", which is a different sentence and a different remedy. The status is
+ * what separates them for a client that reads no further.
  */
-export class MailboxNotSettledError extends ConflictError {
+export class MailboxNotSettledError extends HTTPError {
 	name = "MailboxNotSettledError";
+	public statusCode = 422;
 
 	constructor(message: string, mailboxId: string, syncStatus: string) {
 		super(message);

package/src/types.ts

@@ -207,9 +207,11 @@ export type CreateAccountInput = Omit<
 	| "smtpTls"
 	| "smtpStartTls"
 	| "smtpUsername"
+	| "syncedServices"
 > & {
 	accountId?: string;
 	authType?: AccountItem["authType"];
+	syncedServices?: AccountItem["syncedServices"];
 	smtpEnabled?: AccountItem["smtpEnabled"];
 	smtpHost?: AccountItem["smtpHost"];
 	smtpPort?: AccountItem["smtpPort"];