@remit/data-ports 0.0.19 → 0.0.21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/data-ports",
-  "version": "0.0.19",
+  "version": "0.0.21",
   "type": "module",
   "main": "src/index.ts",
   "types": "src/index.ts",

package/src/conformance/label.ts

@@ -85,15 +85,20 @@ export function labelRepositoryConformance(
 			const accountConfigId = harness.makeId();
 			const other = harness.makeId();
 
-			const first = await repo.create({ accountConfigId, name: "First" });
-			const second = await repo.create({ accountConfigId, name: "Second" });
+			// Created concurrently so their `createdAt` millisecond can tie (as it
+			// reliably does against the synchronous sqlite driver): the keyset's
+			// `labelId` tiebreak then decides order, so this asserts pagination is
+			// exhaustive and duplicate-free rather than a specific creation order.
+			const created = await Promise.all([
+				repo.create({ accountConfigId, name: "First" }),
+				repo.create({ accountConfigId, name: "Second" }),
+			]);
 			await repo.create({ accountConfigId: other, name: "Foreign" });
 
 			const page1 = await repo.listPageByAccountConfig(accountConfigId, {
 				limit: 1,
 			});
 			assert.equal(page1.items.length, 1);
-			assert.equal(page1.items[0]?.labelId, first.labelId);
 			assert.ok(page1.continuationToken);
 
 			const page2 = await repo.listPageByAccountConfig(accountConfigId, {
@@ -101,8 +106,20 @@ export function labelRepositoryConformance(
 				continuationToken: page1.continuationToken,
 			});
 			assert.equal(page2.items.length, 1);
-			assert.equal(page2.items[0]?.labelId, second.labelId);
 			assert.equal(page2.continuationToken, undefined);
+
+			const seen = new Set([
+				...page1.items.map((label) => label.labelId),
+				...page2.items.map((label) => label.labelId),
+			]);
+			assert.equal(
+				seen.size,
+				created.length,
+				"every label is paged exactly once",
+			);
+			for (const label of created) {
+				assert.ok(seen.has(label.labelId));
+			}
 		});
 
 		test("delete removes the row", async () => {

package/src/index.ts

@@ -6,6 +6,7 @@ export type { IAddressRepository } from "./interfaces/address.js";
 export type { IEnvelopeRepository } from "./interfaces/envelope.js";
 export type { IFilterRepository } from "./interfaces/filter.js";
 export type { IFilterAnchorRepository } from "./interfaces/filter-anchor.js";
+export type { IFilterAnchorTransaction } from "./interfaces/filter-anchor-transaction.js";
 export type { ILabelRepository } from "./interfaces/label.js";
 export type { IMailboxRepository } from "./interfaces/mailbox.js";
 export type { IMailboxLockRepository } from "./interfaces/mailbox-lock.js";

package/src/interfaces/filter-anchor-transaction.ts

@@ -0,0 +1,23 @@
+import type {
+	CreateFilterAnchorInput,
+	CreateFilterInput,
+	FilterItem,
+} from "../types.js";
+
+/**
+ * Atomically creates a `Filter` row and its optional sibling `FilterAnchor`
+ * row (#351). Without this, the two writes ran sequentially: a failure on the
+ * second left a `Filter` durably marked `hasAnchor: true` with no matching
+ * `FilterAnchor` row — a filter that looks normal but silently matches
+ * nothing, forever, with no repair path (the anchor message id is never
+ * retained once `createFilterWithAnchor` returns).
+ *
+ * `anchor` omits `filterId` — it is not known until the `Filter` row is
+ * created inside the same transaction.
+ */
+export interface IFilterAnchorTransaction {
+	createWithAnchor(
+		filter: CreateFilterInput,
+		anchor: Omit<CreateFilterAnchorInput, "filterId"> | null,
+	): Promise<FilterItem>;
+}