@remit/backend 2.7.0 → 2.7.1

package/dist/src/handlers/thread.d.ts

@@ -52,6 +52,8 @@ type ThreadSearch = {
     starred?: boolean;
     attachments?: boolean;
     category?: MessageCategory[];
+    senderTrust?: SenderTrust[];
+    dkimMismatch?: boolean;
 };
 /**
  * Minimal client surface `executeThreadSearch` needs. Declared structurally
@@ -84,21 +86,12 @@ export type ThreadSearchParams = {
     limit?: number;
 };
 /**
- * Run a per-mailbox thread search: select the index/window read, optionally
- * count, and resolve off-row criteria by enriching+filtering the window. The
- * `results` toggle omits `items` (count-only) and `count` adds the match count.
+ * Run a per-mailbox thread search: select the index/window read and optionally
+ * count. The `results` toggle omits `items` (count-only) and `count` adds the
+ * match count.
  *
  * `count` names the whole match, never the page: a page size bounds the rows a
  * response carries and has no bearing on how many messages match (#509).
- *
- * An off-row criterion is the one shape that has no such number. `senderTrust`
- * and `dkimMismatch` are resolved by enriching a window, so counting them means
- * enriching every candidate row in the mailbox. `count` is therefore absent
- * (#305) — a page's post-filter length labelled `count` is a page length
- * presented as a total, which is the defect the field exists to avoid. Absence
- * is the same answer the response already gives for a count nobody asked for,
- * so no caller needs a second shape to read it. A count-only request under an
- * off-row criterion therefore reads nothing at all.
  */
 export declare const executeThreadSearch: (client: ThreadSearchClient, accountConfigId: string, mailboxId: string, params: ThreadSearchParams) => Promise<ThreadSearchResponse>;
 /**

package/dist/src/handlers/thread.js

@@ -1,7 +1,6 @@
 import { NotFoundError } from "@remit/data-ports/errors";
 import { isValidMessageId } from "@remit/data-ports/id";
 import { enrichThreadRows, } from "../derive/enrichThreadRows.js";
-import { filterByOffRowCriteria, hasOffRowCriteria, } from "../derive/filterThreadCriteria.js";
 const DEFAULT_THREADS_PAGE_SIZE = 50;
 // Project to fields used by ListThreadsResponse — keep in sync with handler mapping.
 // Includes ThreadMessage table key fields (accountConfigId, threadMessageId) and
@@ -63,21 +62,12 @@ const toArray = (value) => {
     return Array.isArray(value) ? value : [value];
 };
 /**
- * Run a per-mailbox thread search: select the index/window read, optionally
- * count, and resolve off-row criteria by enriching+filtering the window. The
- * `results` toggle omits `items` (count-only) and `count` adds the match count.
+ * Run a per-mailbox thread search: select the index/window read and optionally
+ * count. The `results` toggle omits `items` (count-only) and `count` adds the
+ * match count.
  *
  * `count` names the whole match, never the page: a page size bounds the rows a
  * response carries and has no bearing on how many messages match (#509).
- *
- * An off-row criterion is the one shape that has no such number. `senderTrust`
- * and `dkimMismatch` are resolved by enriching a window, so counting them means
- * enriching every candidate row in the mailbox. `count` is therefore absent
- * (#305) — a page's post-filter length labelled `count` is a page length
- * presented as a total, which is the defect the field exists to avoid. Absence
- * is the same answer the response already gives for a count nobody asked for,
- * so no caller needs a second shape to read it. A count-only request under an
- * off-row criterion therefore reads nothing at all.
  */
 export const executeThreadSearch = async (client, accountConfigId, mailboxId, params) => {
     const search = {
@@ -88,8 +78,6 @@ export const executeThreadSearch = async (client, accountConfigId, mailboxId, pa
         starred: params.starred,
         attachments: params.attachments,
         category: params.category,
-    };
-    const offRow = {
         senderTrust: params.senderTrust,
         dkimMismatch: params.dkimMismatch,
     };
@@ -100,16 +88,6 @@ export const executeThreadSearch = async (client, accountConfigId, mailboxId, pa
         order: params.order,
         limit: params.limit,
     });
-    if (hasOffRowCriteria(offRow)) {
-        if (!wantResults)
-            return {};
-        const window = await client.threadMessage.searchByMailboxWindow(accountConfigId, mailboxId, search, options);
-        const enriched = await enrichThreadRows(window.items, client, accountConfigId);
-        return {
-            items: filterByOffRowCriteria(enriched, offRow),
-            continuationToken: window.continuationToken,
-        };
-    }
     const response = {};
     if (wantResults) {
         const window = await client.threadMessage.searchByMailboxWindow(accountConfigId, mailboxId, search, options);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@remit/backend",
-	"version": "2.7.0",
+	"version": "2.7.1",
 	"description": "Remit Mail Inspector API backend",
 	"license": "MIT",
 	"author": "",

package/dist/src/derive/filterThreadCriteria.d.ts

@@ -1,23 +0,0 @@
-import type { SenderTrust, ThreadMessageResponse } from "@remit/api-openapi-types";
-/**
- * Off-row search criteria — fields that live on the underlying Message/Address,
- * not on the ThreadMessage row. They are resolved by enriching the windowed
- * rows (see enrichThreadRows) and filtering in app code, because no index or
- * FilterExpression can serve them.
- *
- * `senderTrust` derives from AddressItem.flags and `dkimMismatch` from
- * MessageItem.authenticity. `category` is not one of these: it is denormalized
- * onto the ThreadMessage row and filtered in SQL, inside the window.
- */
-export interface OffRowCriteria {
-    senderTrust?: SenderTrust[];
-    dkimMismatch?: boolean;
-}
-export declare const hasOffRowCriteria: (criteria: OffRowCriteria) => boolean;
-/**
- * Filter enriched rows by the off-row criteria. Each active criterion is an
- * any-of set (AND across criteria, OR within a set). A row with no
- * `authenticity` signal never matches a `dkimMismatch` filter (absence means no
- * signal, not a verdict).
- */
-export declare const filterByOffRowCriteria: (rows: ThreadMessageResponse[], criteria: OffRowCriteria) => ThreadMessageResponse[];

package/dist/src/derive/filterThreadCriteria.js

@@ -1,24 +0,0 @@
-export const hasOffRowCriteria = (criteria) => Boolean(criteria.senderTrust?.length) || criteria.dkimMismatch !== undefined;
-/**
- * Filter enriched rows by the off-row criteria. Each active criterion is an
- * any-of set (AND across criteria, OR within a set). A row with no
- * `authenticity` signal never matches a `dkimMismatch` filter (absence means no
- * signal, not a verdict).
- */
-export const filterByOffRowCriteria = (rows, criteria) => {
-    if (!hasOffRowCriteria(criteria))
-        return rows;
-    const trustSet = criteria.senderTrust?.length
-        ? new Set(criteria.senderTrust)
-        : undefined;
-    const { dkimMismatch } = criteria;
-    return rows.filter((row) => {
-        if (trustSet && !trustSet.has(row.senderTrust))
-            return false;
-        if (dkimMismatch !== undefined &&
-            row.authenticity?.dkimMismatch !== dkimMismatch) {
-            return false;
-        }
-        return true;
-    });
-};