@remit/backend 0.0.60 → 0.0.62

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/backend",
-  "version": "0.0.60",
+  "version": "0.0.62",
   "description": "Remit Mail Inspector API backend",
   "license": "MIT",
   "author": "",

package/src/handlers/address.test.ts

@@ -0,0 +1,132 @@
+import assert from "node:assert/strict";
+import { afterEach, describe, it } from "node:test";
+import type { AddressItem, ResultList } from "@remit/data-ports";
+import type { APIGatewayProxyEvent } from "aws-lambda";
+import type { Context } from "openapi-backend";
+import { deriveAccountConfigId } from "../auth.js";
+import {
+	_resetForTest,
+	type RemitClient,
+	setClient,
+} from "../service/data-client.js";
+import { AddressOperations } from "./address.js";
+
+const searchAddresses =
+	AddressOperations.AddressOperations_searchAddresses as unknown as (
+		context: Context,
+		event: APIGatewayProxyEvent,
+	) => Promise<ResultList<AddressItem>>;
+
+const SUB = "cognito-sub-704";
+const ACCOUNT_CONFIG_ID = deriveAccountConfigId(SUB);
+
+const eventFor = (sub: string): APIGatewayProxyEvent =>
+	({
+		requestContext: { authorizer: { claims: { sub } } },
+	}) as unknown as APIGatewayProxyEvent;
+
+const contextFor = (query: { q: string; limit?: number }): Context =>
+	({ request: { query } }) as unknown as Context;
+
+const address = (over: Partial<AddressItem>): AddressItem =>
+	({
+		addressId: "addr-1",
+		accountConfigId: ACCOUNT_CONFIG_ID,
+		localPart: "amsterdam",
+		domain: "pocahondas.nl",
+		normalizedEmail: "amsterdam@pocahondas.nl",
+		normalizedCompound: "pocahondas locatie amsterdam amsterdam@pocahondas.nl",
+		displayName: "Pocahondas locatie amsterdam",
+		flags: {},
+		inboundCount: 4,
+		outboundCount: 1,
+		replyCount: 2,
+		lastInboundAt: 1_000,
+		lastReplyAt: 900,
+		createdAt: 100,
+		updatedAt: 200,
+		...over,
+	}) as AddressItem;
+
+interface Listing {
+	accountConfigId: string;
+	search?: string;
+	limit?: number;
+}
+
+const clientReturning = (items: AddressItem[], seen: Listing[]): RemitClient =>
+	({
+		address: {
+			listByAccountConfig: async (
+				input: Listing,
+			): Promise<ResultList<AddressItem>> => {
+				seen.push(input);
+				return { items, continuationToken: undefined };
+			},
+		},
+	}) as unknown as RemitClient;
+
+afterEach(() => {
+	_resetForTest();
+});
+
+describe("AddressOperations_searchAddresses", () => {
+	it("looks a partial term up against the caller's own addresses (#704)", async () => {
+		const seen: Listing[] = [];
+		setClient(clientReturning([address({})], seen));
+
+		const response = await searchAddresses(
+			contextFor({ q: "Po", limit: 8 }),
+			eventFor(SUB),
+		);
+
+		assert.deepEqual(seen, [
+			{ accountConfigId: ACCOUNT_CONFIG_ID, search: "po", limit: 8 },
+		]);
+		assert.deepEqual(
+			response.items.map((item) => item.normalizedEmail),
+			["amsterdam@pocahondas.nl"],
+		);
+		assert.equal(response.items[0].displayName, "Pocahondas locatie amsterdam");
+	});
+
+	it("hands the suggestion list back in the order it was ranked", async () => {
+		const seen: Listing[] = [];
+		setClient(
+			clientReturning(
+				[
+					address({
+						addressId: "addr-frequent",
+						normalizedEmail: "zoe@pocahondas.nl",
+					}),
+					address({
+						addressId: "addr-stranger",
+						normalizedEmail: "aaron@pocahondas.nl",
+						inboundCount: 0,
+						replyCount: 0,
+					}),
+				],
+				seen,
+			),
+		);
+
+		const response = await searchAddresses(
+			contextFor({ q: "po" }),
+			eventFor(SUB),
+		);
+
+		assert.deepEqual(
+			response.items.map((item) => item.addressId),
+			["addr-frequent", "addr-stranger"],
+		);
+	});
+
+	it("asks for a suggestion-sized window when the caller names no limit", async () => {
+		const seen: Listing[] = [];
+		setClient(clientReturning([], seen));
+
+		await searchAddresses(contextFor({ q: "po" }), eventFor(SUB));
+
+		assert.equal(seen[0].limit, 10);
+	});
+});

package/src/service/compose-sqlite.ts

@@ -25,6 +25,7 @@ import {
 	OutboxAttachmentRepo,
 	OutboxMessageRepo,
 	QuarantineRepo,
+	SenderSignerStandingRepo,
 } from "@remit/drizzle-service";
 import { env } from "expect-env";
 import {
@@ -73,6 +74,7 @@ export const buildSqliteClient = async (): Promise<RemitClient> => {
 		filterAnchorTransaction: new DrizzleFilterAnchorTransaction(genericDb),
 		label: new LabelRepo(genericDb),
 		messageLabel: new MessageLabelRepo(genericDb),
+		senderSignerStanding: new SenderSignerStandingRepo(genericDb),
 		unitOfWork: new DrizzleUnitOfWork(messageDataDb),
 	};
 

package/src/service/create-remit-client.ts

@@ -21,6 +21,7 @@ import type {
 	IOutboxAttachmentRepository,
 	IOutboxMessageRepository,
 	IQuarantineRepository,
+	ISenderSignerStandingRepository,
 	IThreadMessageRepository,
 	IUnitOfWork,
 } from "@remit/data-ports";
@@ -102,6 +103,12 @@ export interface RemitClient {
 	label: ILabelRepository;
 	messageLabel: IMessageLabelRepository;
 
+	// How often a sender has been seen arriving under one DKIM signing identity,
+	// per account. Read by the authenticity derivation to tell a familiar
+	// third-party signer from a first sighting; written once per message by
+	// body-sync, which is its only writer.
+	senderSignerStanding: ISenderSignerStandingRepository;
+
 	// Atomic write set for a message save. Present on the relational backend (real
 	// transaction); absent on DynamoDB, where callers fall back to per-repo
 	// writes with that backend's own (non-transactional) guarantees.
@@ -182,6 +189,7 @@ export interface RemitClientRepositories {
 	filterAnchorTransaction: IFilterAnchorTransaction;
 	label: ILabelRepository;
 	messageLabel: IMessageLabelRepository;
+	senderSignerStanding: ISenderSignerStandingRepository;
 	unitOfWork?: IUnitOfWork;
 }
 
@@ -403,6 +411,7 @@ export const createRemitClient = (deps: RemitClientDeps): RemitClient => {
 		filterAnchorTransaction: repositories.filterAnchorTransaction,
 		label: repositories.label,
 		messageLabel: repositories.messageLabel,
+		senderSignerStanding: repositories.senderSignerStanding,
 		unitOfWork: repositories.unitOfWork,
 
 		storage,