@remit/backend 0.0.49 → 0.0.51

package/.env.test

@@ -1,7 +1,4 @@
 SERVER_PORT=5433
-DYNAMODB_PORT=5434
-DYNAMODB_TABLE_NAME=remit-local
-DYNAMODB_PAGINATION_SALT=test-salt
 SQS_QUEUE_URL=http://localhost:9324/queue/remit-local
 NODE_ENV=development
 LOG_LEVEL=debug

package/dev-server/server.ts

@@ -327,8 +327,7 @@ app.listen(Number(port), "0.0.0.0", () => {
 		{
 			port: Number(port),
 			url: `http://localhost:${port}`,
-			dynamodbPort: env.DYNAMODB_PORT,
-			dynamodbTable: env.DYNAMODB_TABLE_NAME,
+			dataBackend: process.env.DATA_BACKEND,
 			nodeEnv: env.NODE_ENV,
 			...(isSelfHostBackend
 				? {}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/backend",
-  "version": "0.0.49",
+  "version": "0.0.51",
   "description": "Remit Mail Inspector API backend",
   "license": "MIT",
   "author": "",

package/src/handlers/organize.test.ts

@@ -1,7 +1,9 @@
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
 import type { OrganizeInput } from "@remit/api-openapi-types";
+import { BadRequestError } from "@remit/data-ports/errors";
 import { FilterMatchOperator } from "@remit/domain-enums";
+import { handleError } from "../error.js";
 import { predicateFromInput } from "./organize.js";
 
 const input = (over: Partial<OrganizeInput> = {}): OrganizeInput => ({
@@ -41,3 +43,21 @@ describe("predicateFromInput (move back-apply accepted)", () => {
 		assert.equal(predicate.actionLabelId, "None");
 	});
 });
+
+// previewOrganize rejects a body-content (HasWords) clause by throwing
+// BadRequestError (see service/organize.test.ts for the throw site). Proving
+// the 4xx actually reaches the wire — not just that the right class is
+// thrown — means proving the shared error handler maps it, since a plain
+// Error would otherwise fall through to a 500 (reader #457).
+describe("previewOrganize rejected-rule response (reader #457)", () => {
+	it("maps a rejected HasWords clause to a 400 naming the reason, not a 500", async () => {
+		const error = new BadRequestError(
+			"Organize literal matching cannot evaluate a body-content (HasWords) clause without the vector pipeline — it requires the semantic widen path",
+		);
+
+		const response = await handleError(error);
+
+		assert.equal(response.statusCode, 400);
+		assert.match(JSON.parse(response.body).message, /HasWords/);
+	});
+});

package/src/service/organize.test.ts

@@ -1,7 +1,7 @@
 import assert from "node:assert/strict";
 import { afterEach, beforeEach, describe, it } from "node:test";
 import type { FilterAnchorItem, FilterItem } from "@remit/data-ports";
-import { NotFoundError } from "@remit/data-ports/errors";
+import { BadRequestError, NotFoundError } from "@remit/data-ports/errors";
 import { FilterMatchOperator, FilterState } from "@remit/domain-enums";
 import type {
 	AnchorPayload,
@@ -487,7 +487,7 @@ describe("matchOrganize on a deployment without the vector pipeline", () => {
 		);
 	});
 
-	it("fails loud on a body-content (HasWords) clause rather than matching it against a preview", async () => {
+	it("rejects a body-content (HasWords) clause as a 400 rather than matching it against a preview", async () => {
 		const deps = vectorlessDeps([
 			candidate("msg-1", { subject: "Dinner reservation" }),
 		]);
@@ -499,7 +499,12 @@ describe("matchOrganize on a deployment without the vector pipeline", () => {
 					anchorMessageId: "None",
 					literalClauses: [{ field: "HasWords", value: "invoice" }],
 				}),
-			/HasWords/,
+			(error: unknown) => {
+				assert.ok(error instanceof BadRequestError);
+				assert.equal(error.statusCode, 400);
+				assert.match(error.message, /HasWords/);
+				return true;
+			},
 			"the vector-free literal path must not silently narrow a body match to a preview",
 		);
 		assert.equal(deps.semanticUsed(), false);

package/src/service/organize.ts

@@ -3,7 +3,7 @@ import type {
 	IFilterAnchorRepository,
 	OrganizeJobRequestItem,
 } from "@remit/data-ports";
-import { NotFoundError } from "@remit/data-ports/errors";
+import { BadRequestError, NotFoundError } from "@remit/data-ports/errors";
 import { FilterClauseField, FilterState } from "@remit/domain-enums";
 import {
 	buildMatchText,
@@ -280,16 +280,14 @@ const matchSemantic = async (
  * happened to be indexed. Body-content matching therefore requires the widen
  * (vector) path — {@link matchSemantic} reconstructs body text from chunk
  * previews there. This guard keeps the two matchers from diverging silently: a
- * body-content clause reaching the vector-free path fails loud instead of
- * returning a wrong set. It is unreachable today — no product surface emits a
- * `HasWords` clause (the organize UI sends empty `literalClauses`, the filter
- * builder emits none) — and stays a fail-fast for any future surface that does.
+ * body-content clause reaching the vector-free path is rejected instead of
+ * returning a wrong set.
  */
 const assertNoBodyContentClause = (
 	clauses: OrganizePredicate["literalClauses"],
 ): void => {
 	if (clauses.some((clause) => clause.field === FilterClauseField.HasWords)) {
-		throw new Error(
+		throw new BadRequestError(
 			"Organize literal matching cannot evaluate a body-content (HasWords) clause without the vector pipeline — it requires the semantic widen path",
 		);
 	}