@remit/backend 0.0.37 → 0.0.39

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/backend",
-  "version": "0.0.37",
+  "version": "0.0.39",
   "description": "Remit Mail Inspector API backend",
   "license": "MIT",
   "author": "",

package/src/handlers/filter.test.ts

@@ -1,6 +1,6 @@
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
-import type { UpdateFilterInput } from "@remit/data-ports";
+import type { UpdateFilterInput as UpdateFilterRequestBody } from "@remit/api-openapi-types";
 import { FilterScope, FilterState } from "@remit/domain-enums";
 import {
 	pickFilterUpdate,
@@ -35,7 +35,7 @@ describe("pickFilterUpdate", () => {
 			ruleChangedAt: 999,
 			filterId: "sneaky",
 		};
-		const patch = pickFilterUpdate(raw as Partial<UpdateFilterInput>);
+		const patch = pickFilterUpdate(raw as Partial<UpdateFilterRequestBody>);
 		assert.deepEqual(patch, { name: "Receipts" });
 	});
 });

package/src/handlers/filter.ts

@@ -1,6 +1,7 @@
 import type {
 	CreateFilterInput,
 	FilterResponse,
+	UpdateFilterInput as UpdateFilterRequestBody,
 } from "@remit/api-openapi-types";
 import type { FilterItem, UpdateFilterInput } from "@remit/data-ports";
 import { BadRequestError } from "@remit/data-ports/errors";
@@ -93,19 +94,9 @@ export const deriveFilterTtl = (
  * dropped. `scope`/`expiresAt` land here as the caller sent them; a patch that
  * touches either still needs `resolveFilterScopeExpiry` to merge them against
  * the stored row and derive `ttl`/`state` before this reaches the repo.
- *
- * Typed against the internal `@remit/data-ports` `UpdateFilterInput`, not the
- * generated `@remit/api-openapi-types` one: that package publishes separately
- * from this repo, so a PR that both widens the TypeSpec model and reads the
- * new field in the same change would typecheck in-tree (fresh local codegen)
- * but fail `check-consumer-typecheck`/`release:dry-run`, which resolve
- * generated `@remit/*` packages off the registry, not the local `build/`
- * output. The data-ports shape carries every field this reads regardless —
- * it derives from the full `Filter` row, which has never gated `scope` or
- * `expiresAt` behind an API-visibility distinction.
  */
 export const pickFilterUpdate = (
-	body: Partial<UpdateFilterInput>,
+	body: Partial<UpdateFilterRequestBody>,
 ): Partial<UpdateFilterInput> => {
 	const patch: Partial<UpdateFilterInput> = {};
 	if (Object.hasOwn(body, "name")) patch.name = body.name;
@@ -368,7 +359,7 @@ export const FilterDetailOperations: Record<
 		assertAccountOwnership(account, accountConfigId, "act");
 
 		const { filter } = client;
-		const patch = pickFilterUpdate(body as Partial<UpdateFilterInput>);
+		const patch = pickFilterUpdate(body as Partial<UpdateFilterRequestBody>);
 		const touchesScopeOrExpiry =
 			Object.hasOwn(patch, "scope") || Object.hasOwn(patch, "expiresAt");
 		const resolvedPatch: Partial<UpdateFilterInput> = touchesScopeOrExpiry

package/src/index.ts

@@ -2,7 +2,7 @@ import { existsSync, readFileSync } from "node:fs";
 import { dirname, join } from "node:path";
 import { fileURLToPath } from "node:url";
 import { inspect } from "node:util";
-import { logger, withTelemetry } from "@remit/logger-lambda";
+import { logger, withLogContext, withTelemetry } from "@remit/logger-lambda";
 import type { APIGatewayProxyEvent, Context } from "aws-lambda";
 import {
 	type Document,
@@ -141,30 +141,36 @@ const readOriginHeader = (
 	return undefined;
 };
 
-const rawHandler = async (event: APIGatewayProxyEvent, context: Context) => {
-	logger.setBindings({
-		requestId: context.awsRequestId,
-		path: event.path,
-		method: event.httpMethod,
-	});
-
-	logger.debug(
-		{ method: event.httpMethod, path: event.path },
-		"Request received",
-	);
-
-	const origin = readOriginHeader(event.headers);
-
-	if (usesBetterAuthJwt()) {
-		const denied = await authenticatePostgresRequest(event);
-		if (denied) return denied;
-	}
-
-	return runWithRequestContext({ origin }, () =>
-		api
-			.handleRequest(normalizeRequest(event), event, context)
-			.catch(handleError),
+// A scope, not `logger.setBindings`: this process serves requests concurrently,
+// and bindings on the shared logger belong to whichever request wrote them last,
+// so a line gets attributed to the wrong request. The scope follows the request
+// through its own async continuations and nothing else.
+const rawHandler = async (event: APIGatewayProxyEvent, context: Context) =>
+	withLogContext(
+		{
+			requestId: context.awsRequestId,
+			path: event.path,
+			method: event.httpMethod,
+		},
+		async () => {
+			logger.debug(
+				{ method: event.httpMethod, path: event.path },
+				"Request received",
+			);
+
+			const origin = readOriginHeader(event.headers);
+
+			if (usesBetterAuthJwt()) {
+				const denied = await authenticatePostgresRequest(event);
+				if (denied) return denied;
+			}
+
+			return runWithRequestContext({ origin }, () =>
+				api
+					.handleRequest(normalizeRequest(event), event, context)
+					.catch(handleError),
+			);
+		},
 	);
-};
 
 export const handler = withTelemetry(rawHandler);

package/src/service/filter.ts

@@ -28,10 +28,7 @@ const build = (): BuildFilterAnchor => {
 	const embedder = buildEmbeddingServiceFromEnv();
 	const store = buildVectorStoreFromEnv(embedder.dimensions);
 	return (accountConfigId, anchorMessageId) =>
-		buildMessageAnchor(
-			{ store, embedder },
-			{ accountConfigId, anchorMessageId },
-		);
+		buildMessageAnchor({ store }, { accountConfigId, anchorMessageId });
 };
 
 export const buildFilterAnchor: BuildFilterAnchor = (

package/src/service/organize.ts

@@ -341,10 +341,7 @@ const buildSemanticFromEnv = (): OrganizeSemanticDeps => {
 	const store = buildVectorStoreFromEnv(embedder.dimensions);
 	cachedSemantic = {
 		buildAnchor: (accountConfigId, anchorMessageId) =>
-			buildMessageAnchor(
-				{ store, embedder },
-				{ accountConfigId, anchorMessageId },
-			),
+			buildMessageAnchor({ store }, { accountConfigId, anchorMessageId }),
 		vectorStore: store,
 	};
 	return cachedSemantic;