@remit/backend 0.0.31 → 0.0.32

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/backend",
-  "version": "0.0.31",
+  "version": "0.0.32",
   "description": "Remit Mail Inspector API backend",
   "license": "MIT",
   "author": "",

package/src/handlers/system-update.test.ts

@@ -130,11 +130,14 @@ describe("GET /system/update", () => {
 		assert.deepEqual(result, okState);
 	});
 
-	it("returns a disabled, empty resource when no state file exists", async () => {
+	it("reports an unknown version, not its own process env, when no state file exists", async () => {
+		// The updater owns the running version and writes it into state.json; with
+		// no state file the backend has nothing authoritative, so it says unknown
+		// rather than surfacing REMIT_TAG, which drifts from the real running tag.
 		const result = await getUpdate(buildEvent(USER));
 
 		assert.deepEqual(result, {
-			currentVersion: "v1.4.1",
+			currentVersion: "unknown",
 			check: { status: "disabled" },
 			run: null,
 		});

package/src/handlers/system-update.ts

@@ -24,7 +24,17 @@ const controlDir = (): string =>
 const manifestUrl = (): string | undefined =>
 	process.env.REMIT_UPDATE_MANIFEST_URL;
 
-const currentVersion = (): string => process.env.REMIT_TAG ?? "unknown";
+/**
+ * The running version is a fact the updater owns: it reads the tag from `.env`
+ * and writes it into `state.json`, which is the only honest source across an
+ * update that rewrites that tag underneath a long-lived backend process. When no
+ * state file exists yet the backend has nothing authoritative to report, so it
+ * reports the version as unknown rather than fabricating one from its own
+ * process environment — a value captured at container start that drifts from the
+ * real running tag the moment an update lands. The first updater check writes a
+ * real `currentVersion` within seconds of the stack coming up.
+ */
+const UNKNOWN_VERSION = "unknown";
 
 const notFound = (): APIGatewayProxyResult => ({
 	statusCode: 404,
@@ -65,7 +75,7 @@ const readState = (): SystemUpdateResponse | null => {
 };
 
 const emptyResource = (): SystemUpdateResponse => ({
-	currentVersion: currentVersion(),
+	currentVersion: UNKNOWN_VERSION,
 	check: { status: "disabled" },
 	run: null,
 });
@@ -115,7 +125,7 @@ const requestedResource = (
 	targetVersion: string,
 	requestedAt: string,
 ): SystemUpdateResponse => {
-	const from = state?.currentVersion ?? currentVersion();
+	const from = state?.currentVersion ?? UNKNOWN_VERSION;
 	return {
 		currentVersion: from,
 		check: state?.check ?? { status: "disabled" },