@remit/backend 0.0.143 → 0.0.144

package/src/handlers/unified-threads.test.ts

@@ -1,785 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, test } from "node:test";
-import type { MessageCategory } from "@remit/api-openapi-types";
-import type {
-	AccountItem,
-	AccountSettingItem,
-	MailboxItem,
-	SearchOptions,
-} from "@remit/data-ports";
-import {
-	buildInboxMailboxMap,
-	buildListAllThreadsOptions,
-	buildListStarredThreadsOptions,
-	buildSearchAllThreadsOptions,
-	dedupeByMessageId,
-	executeUnifiedThreadListing,
-	type InboxMapClient,
-	type UnifiedThreadClient,
-	type UnifiedThreadParams,
-} from "./unified-threads.js";
-
-// #44: Flagged filtered client-side over the newest 50 unified-inbox rows, so a
-// star outside that window — or in any folder that is not INBOX — never showed.
-// The starred scope is every non-muted mailbox, served by its own access
-// pattern.
-
-const CONFIG_ID = "cfg-1";
-
-const account = (accountId: string): AccountItem =>
-	({ accountId }) as unknown as AccountItem;
-
-const mailbox = (
-	mailboxId: string,
-	accountId: string,
-	fullPath: string,
-	specialUse?: string[],
-): MailboxItem =>
-	({ mailboxId, accountId, fullPath, specialUse }) as unknown as MailboxItem;
-
-const mutedSetting = (
-	name: "AccountMuted" | "MailboxMuted",
-	targetId: string,
-): AccountSettingItem =>
-	({
-		name: `${name}#${targetId}`,
-		value: { kind: "MutedFlag", value: { value: true, setAt: 0 } },
-	}) as unknown as AccountSettingItem;
-
-const buildClient = (
-	accounts: AccountItem[],
-	mailboxesByAccount: Record<string, MailboxItem[]>,
-	settings: AccountSettingItem[] = [],
-): InboxMapClient =>
-	({
-		account: { listMailSourcesByAccountConfig: async () => accounts },
-		mailbox: {
-			listAllByAccount: async (accountId: string) =>
-				mailboxesByAccount[accountId] ?? [],
-		},
-		accountSetting: { listByAccountConfig: async () => settings },
-	}) as unknown as InboxMapClient;
-
-describe("buildInboxMailboxMap", () => {
-	test("separates the INBOX scope from the wider starred scope", async () => {
-		const client = buildClient([account("a1")], {
-			a1: [
-				mailbox("m-inbox", "a1", "INBOX"),
-				mailbox("m-archive", "a1", "Archive", ["Archive"]),
-				mailbox("m-sub", "a1", "INBOX/Receipts"),
-			],
-		});
-
-		const { inboxMailboxIds, starredMailboxIds, mailboxIdToAccountId } =
-			await buildInboxMailboxMap(CONFIG_ID, client);
-
-		assert.deepEqual([...inboxMailboxIds], ["m-inbox"]);
-		assert.deepEqual([...starredMailboxIds].sort(), [
-			"m-archive",
-			"m-inbox",
-			"m-sub",
-		]);
-		// The map must cover every mailbox, or a starred row from Archive could
-		// not resolve its accountId.
-		assert.equal(mailboxIdToAccountId.get("m-archive"), "a1");
-	});
-
-	// A star on mail in Spam or Trash is not something the starred view should
-	// resurface; Gmail's All Mail is a second copy of everything, so including it
-	// renders every starred Gmail message twice.
-	test("the starred scope excludes All Mail, Junk and Trash", async () => {
-		const client = buildClient([account("a1")], {
-			a1: [
-				mailbox("m-inbox", "a1", "INBOX"),
-				mailbox("m-all", "a1", "[Gmail]/All Mail", ["All"]),
-				mailbox("m-junk", "a1", "[Gmail]/Spam", ["Junk"]),
-				mailbox("m-trash", "a1", "[Gmail]/Trash", ["Trash"]),
-				mailbox("m-sent", "a1", "[Gmail]/Sent Mail", ["Sent"]),
-			],
-		});
-
-		const { starredMailboxIds, mailboxIdToAccountId } =
-			await buildInboxMailboxMap(CONFIG_ID, client);
-
-		assert.deepEqual([...starredMailboxIds].sort(), ["m-inbox", "m-sent"]);
-		// Excluded mailboxes still resolve an accountId — the map is the wider set.
-		assert.equal(mailboxIdToAccountId.get("m-trash"), "a1");
-	});
-
-	test("a mailbox carrying several special uses is excluded on any one of them", async () => {
-		const client = buildClient([account("a1")], {
-			a1: [mailbox("m-archive-all", "a1", "Archive", ["Archive", "All"])],
-		});
-
-		const { starredMailboxIds } = await buildInboxMailboxMap(CONFIG_ID, client);
-		assert.equal(starredMailboxIds.size, 0);
-	});
-
-	// #49: the unified list backing the unscoped search was INBOX-only, so a
-	// search from the daily brief could not see Archive, Sent, Spam or any
-	// custom folder. The scope is defined by what it excludes — anything not on
-	// that list is searched, Drafts included.
-	test("the search scope reaches every folder but Trash", async () => {
-		const client = buildClient([account("a1")], {
-			a1: [
-				mailbox("m-inbox", "a1", "INBOX"),
-				mailbox("m-sub", "a1", "INBOX/Receipts"),
-				mailbox("m-archive", "a1", "Archive", ["Archive"]),
-				mailbox("m-sent", "a1", "[Gmail]/Sent Mail", ["Sent"]),
-				mailbox("m-junk", "a1", "[Gmail]/Spam", ["Junk"]),
-				mailbox("m-drafts", "a1", "[Gmail]/Drafts", ["Drafts"]),
-				mailbox("m-custom", "a1", "Projects/Remit"),
-				mailbox("m-trash", "a1", "[Gmail]/Trash", ["Trash"]),
-			],
-		});
-
-		const { searchMailboxIds } = await buildInboxMailboxMap(CONFIG_ID, client);
-
-		assert.deepEqual(
-			[...searchMailboxIds].sort(),
-			[
-				"m-archive",
-				"m-custom",
-				"m-drafts",
-				"m-inbox",
-				"m-junk",
-				"m-sent",
-				"m-sub",
-			],
-			"Spam and Drafts are in scope; Trash is not",
-		);
-	});
-
-	// Trash is matched by path too, for servers that do not advertise the
-	// special-use attribute.
-	test("Trash is excluded without a special-use attribute", async () => {
-		const client = buildClient([account("a1")], {
-			a1: [
-				mailbox("m-inbox", "a1", "INBOX"),
-				mailbox("m-trash", "a1", "[Gmail]/Trash"),
-				// Whole path, never a prefix — a user's own folder is real mail.
-				mailbox("m-trash-talk", "a1", "Trash talk"),
-			],
-		});
-
-		const { searchMailboxIds } = await buildInboxMailboxMap(CONFIG_ID, client);
-		assert.deepEqual([...searchMailboxIds].sort(), ["m-inbox", "m-trash-talk"]);
-	});
-
-	// A row is keyed by (threadId, messageId), both mailbox-independent, so
-	// Gmail's copies collapse into ONE row owned by whichever mailbox synced it
-	// first. Barring the virtual folders from the scope would therefore delete
-	// the only row such a message has — mail that exists and cannot be found.
-	test("the virtual copies stay IN the search scope, so mail they own is findable", async () => {
-		const client = buildClient([account("a1")], {
-			a1: [
-				mailbox("m-inbox", "a1", "INBOX"),
-				mailbox("m-all", "a1", "[Gmail]/All Mail", ["All"]),
-				mailbox("m-starred", "a1", "[Gmail]/Starred", ["Flagged"]),
-				mailbox("m-important", "a1", "[Gmail]/Important", ["Important"]),
-			],
-		});
-
-		const { searchMailboxIds, virtualCopyMailboxIds } =
-			await buildInboxMailboxMap(CONFIG_ID, client);
-
-		assert.deepEqual(
-			[...searchMailboxIds].sort(),
-			["m-all", "m-important", "m-inbox", "m-starred"],
-			"nothing is barred — duplicates are dropped after the read instead",
-		);
-		assert.deepEqual(
-			[...virtualCopyMailboxIds].sort(),
-			["m-all", "m-important", "m-starred"],
-			"they are still identified, to decide which duplicate to drop",
-		);
-	});
-
-	test("a user folder named like a virtual copy is not treated as one", async () => {
-		const client = buildClient([account("a1")], {
-			a1: [
-				mailbox("m-starred-ideas", "a1", "Starred ideas"),
-				mailbox("m-important-clients", "a1", "Important clients"),
-			],
-		});
-
-		const { virtualCopyMailboxIds } = await buildInboxMailboxMap(
-			CONFIG_ID,
-			client,
-		);
-		assert.equal(virtualCopyMailboxIds.size, 0);
-	});
-
-	// The starred scope drops Junk; the search scope keeps it. Two sets, two
-	// judgements — a star in Spam is noise, a search for mail that landed in
-	// Spam is the whole point.
-	test("the search scope and the starred scope differ on Junk", async () => {
-		const client = buildClient([account("a1")], {
-			a1: [
-				mailbox("m-inbox", "a1", "INBOX"),
-				mailbox("m-junk", "a1", "[Gmail]/Spam", ["Junk"]),
-			],
-		});
-
-		const { searchMailboxIds, starredMailboxIds } = await buildInboxMailboxMap(
-			CONFIG_ID,
-			client,
-		);
-
-		assert.equal(searchMailboxIds.has("m-junk"), true);
-		assert.equal(starredMailboxIds.has("m-junk"), false);
-	});
-
-	test("the search scope spans every non-muted account", async () => {
-		const client = buildClient([account("a1"), account("a2")], {
-			a1: [mailbox("m1-archive", "a1", "Archive", ["Archive"])],
-			a2: [mailbox("m2-sent", "a2", "Sent", ["Sent"])],
-		});
-
-		const { searchMailboxIds } = await buildInboxMailboxMap(CONFIG_ID, client);
-
-		assert.deepEqual([...searchMailboxIds].sort(), ["m1-archive", "m2-sent"]);
-	});
-
-	test("muted mailboxes are excluded from the search scope too", async () => {
-		const client = buildClient(
-			[account("a1")],
-			{
-				a1: [
-					mailbox("m-inbox", "a1", "INBOX"),
-					mailbox("m-muted", "a1", "Archive"),
-				],
-			},
-			[mutedSetting("MailboxMuted", "m-muted")],
-		);
-
-		const { searchMailboxIds } = await buildInboxMailboxMap(CONFIG_ID, client);
-		assert.deepEqual([...searchMailboxIds], ["m-inbox"]);
-	});
-
-	test("muted mailboxes are excluded from both scopes", async () => {
-		const client = buildClient(
-			[account("a1")],
-			{
-				a1: [
-					mailbox("m-inbox", "a1", "INBOX"),
-					mailbox("m-muted", "a1", "Archive"),
-				],
-			},
-			[mutedSetting("MailboxMuted", "m-muted")],
-		);
-
-		const { inboxMailboxIds, starredMailboxIds } = await buildInboxMailboxMap(
-			CONFIG_ID,
-			client,
-		);
-
-		assert.deepEqual([...inboxMailboxIds], ["m-inbox"]);
-		assert.deepEqual([...starredMailboxIds], ["m-inbox"]);
-	});
-
-	test("a muted account contributes no mailboxes", async () => {
-		const client = buildClient(
-			[account("a1")],
-			{ a1: [mailbox("m-inbox", "a1", "INBOX")] },
-			[mutedSetting("AccountMuted", "a1")],
-		);
-
-		const { starredMailboxIds } = await buildInboxMailboxMap(CONFIG_ID, client);
-		assert.equal(starredMailboxIds.size, 0);
-	});
-});
-
-describe("buildListStarredThreadsOptions", () => {
-	test("scopes to every supplied mailbox, not just the inbox", () => {
-		const options = buildListStarredThreadsOptions(
-			{},
-			new Set(["m-inbox", "m-archive"]),
-		);
-
-		assert.deepEqual([...options.mailboxIds].sort(), ["m-archive", "m-inbox"]);
-		assert.equal(options.order, "desc");
-		assert.equal(options.excludeDeleted, true);
-	});
-
-	test("carries the caller's paging through", () => {
-		const options = buildListStarredThreadsOptions(
-			{ continuationToken: "tok", order: "asc", limit: 10 },
-			new Set(["m-inbox"]),
-		);
-
-		assert.equal(options.continuationToken, "tok");
-		assert.equal(options.order, "asc");
-		assert.equal(options.limit, 10);
-	});
-
-	test("defaults the page size to the unified default", () => {
-		const starred = buildListStarredThreadsOptions({}, new Set(["m-inbox"]));
-		const unified = buildListAllThreadsOptions({}, new Set(["m-inbox"]));
-		assert.equal(starred.limit, unified.limit);
-	});
-});
-
-// A backend that keys a row by its mailbox returns one row per Gmail copy, so
-// a starred, Important inbox message arrives four times and crowds genuine
-// matches off the page. Dropping the extras here — rather than barring the
-// virtual folders from the scope — keeps the message reachable when the only
-// row it has sits in one of them.
-describe("dedupeByMessageId", () => {
-	const row = (messageId: string, mailboxId: string) => ({
-		messageId,
-		mailboxId,
-	});
-	const virtual = new Set(["m-all", "m-starred", "m-important"]);
-	const isVirtual = (r: { mailboxId: string }) => virtual.has(r.mailboxId);
-
-	test("a starred, Important Gmail inbox message collapses to one row", () => {
-		const deduped = dedupeByMessageId(
-			[
-				row("msg-1", "m-inbox"),
-				row("msg-1", "m-all"),
-				row("msg-1", "m-starred"),
-				row("msg-1", "m-important"),
-			],
-			isVirtual,
-		);
-
-		assert.equal(deduped.length, 1);
-		assert.equal(deduped[0].mailboxId, "m-inbox");
-	});
-
-	test("the real folder wins even when a virtual copy came first", () => {
-		const deduped = dedupeByMessageId(
-			[row("msg-1", "m-all"), row("msg-1", "m-archive")],
-			isVirtual,
-		);
-
-		assert.deepEqual(
-			deduped.map((r) => r.mailboxId),
-			["m-archive"],
-		);
-	});
-
-	// The case the scope exclusion would have broken: nothing but a virtual
-	// copy holds this message, so that row must survive.
-	test("a message that exists only in a virtual folder is kept", () => {
-		const deduped = dedupeByMessageId([row("msg-1", "m-starred")], isVirtual);
-
-		assert.deepEqual(
-			deduped.map((r) => r.mailboxId),
-			["m-starred"],
-		);
-	});
-
-	test("the same mail in two real folders keeps the first, newest by order", () => {
-		const deduped = dedupeByMessageId(
-			[row("msg-1", "m-archive"), row("msg-1", "m-custom")],
-			isVirtual,
-		);
-
-		assert.deepEqual(
-			deduped.map((r) => r.mailboxId),
-			["m-archive"],
-		);
-	});
-
-	test("distinct messages are all kept, in order", () => {
-		const deduped = dedupeByMessageId(
-			[
-				row("msg-1", "m-inbox"),
-				row("msg-2", "m-archive"),
-				row("msg-3", "m-junk"),
-			],
-			isVirtual,
-		);
-
-		assert.deepEqual(
-			deduped.map((r) => r.messageId),
-			["msg-1", "msg-2", "msg-3"],
-		);
-	});
-
-	test("an empty page stays empty", () => {
-		assert.deepEqual(dedupeByMessageId([], isVirtual), []);
-	});
-});
-
-describe("buildSearchAllThreadsOptions", () => {
-	test("carries the whole search scope, not just the inbox", () => {
-		const options = buildSearchAllThreadsOptions(
-			{},
-			new Set(["m-inbox", "m-archive", "m-junk"]),
-		);
-
-		assert.deepEqual([...options.mailboxIds].sort(), [
-			"m-archive",
-			"m-inbox",
-			"m-junk",
-		]);
-		assert.equal(options.order, "desc");
-		assert.equal(options.excludeDeleted, true);
-	});
-
-	test("carries the caller's paging through", () => {
-		const options = buildSearchAllThreadsOptions(
-			{ continuationToken: "tok", order: "asc", limit: 10 },
-			new Set(["m-inbox"]),
-		);
-
-		assert.equal(options.continuationToken, "tok");
-		assert.equal(options.order, "asc");
-		assert.equal(options.limit, 10);
-	});
-
-	test("defaults the page size to the unified default", () => {
-		const search = buildSearchAllThreadsOptions({}, new Set(["m-inbox"]));
-		const unified = buildListAllThreadsOptions({}, new Set(["m-inbox"]));
-		assert.equal(search.limit, unified.limit);
-	});
-});
-
-// #308: the cross-account collections filtered and counted in the browser, over
-// the pages a client happened to have loaded. Both are the query's job now.
-describe("executeUnifiedThreadListing", () => {
-	interface Call {
-		mode: "listByDate" | "listByStarred" | "searchByDate" | "count";
-		search?: SearchOptions;
-		limit?: number;
-		continuationToken?: string;
-		inboxMailboxIds?: Set<string>;
-		mailboxIds?: Set<string>;
-	}
-
-	const emptyPage = { items: [], continuationToken: undefined };
-
-	const buildListingClient = (calls: Call[], count = 0) =>
-		({
-			account: {
-				listMailSourcesByAccountConfig: async () => [
-					account("a1"),
-					account("a2"),
-				],
-			},
-			mailbox: {
-				listAllByAccount: async (accountId: string) =>
-					accountId === "a1"
-						? [
-								mailbox("m-inbox", "a1", "INBOX"),
-								mailbox("m-archive", "a1", "Archive"),
-							]
-						: [
-								mailbox("m2-inbox", "a2", "INBOX"),
-								mailbox("m2-archive", "a2", "Archive"),
-								mailbox("m2-trash", "a2", "Trash", ["Trash"]),
-							],
-			},
-			accountSetting: { listByAccountConfig: async () => [] },
-			message: { get: async () => [] },
-			address: { getAddress: async () => [] },
-			messageLabel: { listByMessageIds: async () => [] },
-			label: { listByAccountConfig: async () => [] },
-			threadMessage: {
-				listByDate: async (
-					_config: string,
-					options?: { search?: SearchOptions; limit?: number },
-				) => {
-					calls.push({ mode: "listByDate", ...options });
-					return emptyPage;
-				},
-				listByStarred: async (
-					_config: string,
-					options?: { search?: SearchOptions; limit?: number },
-				) => {
-					calls.push({ mode: "listByStarred", ...options });
-					return emptyPage;
-				},
-				searchByDate: async (
-					_config: string,
-					search: SearchOptions,
-					options?: { limit?: number },
-				) => {
-					calls.push({ mode: "searchByDate", search, ...options });
-					return emptyPage;
-				},
-				countThreadsInScope: async (
-					_config: string,
-					search: SearchOptions,
-					options?: { mailboxIds?: Set<string> },
-				) => {
-					calls.push({ mode: "count", search, ...options });
-					return count;
-				},
-			},
-		}) as unknown as UnifiedThreadClient;
-
-	const params = (
-		overrides: Partial<UnifiedThreadParams> = {},
-	): UnifiedThreadParams => ({
-		starredOnly: false,
-		count: false,
-		results: true,
-		...overrides,
-	});
-
-	test("sends the row filters into the starred query", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(buildListingClient(calls), CONFIG_ID, {
-			...params({ starredOnly: true }),
-			category: ["social", "personal"] as MessageCategory[],
-			unread: true,
-			attachments: true,
-		});
-
-		assert.equal(calls.length, 1);
-		assert.equal(calls[0].mode, "listByStarred");
-		assert.deepEqual(calls[0].search, {
-			starred: true,
-			category: ["social", "personal"],
-			unread: true,
-			attachments: true,
-		});
-	});
-
-	test("sends the row filters into the INBOX query", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(buildListingClient(calls), CONFIG_ID, {
-			...params(),
-			category: ["uncategorized"] as MessageCategory[],
-		});
-
-		assert.equal(calls[0].mode, "listByDate");
-		assert.deepEqual(calls[0].search, { category: ["uncategorized"] });
-	});
-
-	test("sends the row filters into the search query", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(buildListingClient(calls), CONFIG_ID, {
-			...params({ starredOnly: true }),
-			searchText: "invoice",
-			unread: true,
-		});
-
-		assert.equal(calls[0].mode, "searchByDate");
-		assert.deepEqual(calls[0].search, {
-			query: "invoice",
-			starred: true,
-			unread: true,
-		});
-	});
-
-	// The defect the count replaces: a page-length figure grew with every press
-	// of "load more" while the header presented it as a total.
-	test("counts the same however far the caller has paged", async () => {
-		const calls: Call[] = [];
-		const first = await executeUnifiedThreadListing(
-			buildListingClient(calls, 42),
-			CONFIG_ID,
-			params({ starredOnly: true, count: true, unread: true }),
-		);
-		const later = await executeUnifiedThreadListing(
-			buildListingClient(calls, 42),
-			CONFIG_ID,
-			params({
-				starredOnly: true,
-				count: true,
-				unread: true,
-				continuationToken: "page-3",
-				limit: 10,
-			}),
-		);
-
-		assert.equal(first.count, 42);
-		assert.equal(later.count, 42);
-	});
-
-	test("reads the count alone when results are not wanted", async () => {
-		const calls: Call[] = [];
-		const response = await executeUnifiedThreadListing(
-			buildListingClient(calls, 7),
-			CONFIG_ID,
-			params({ starredOnly: true, count: true, results: false }),
-		);
-
-		assert.deepEqual(
-			calls.map((call) => call.mode),
-			["count"],
-		);
-		assert.equal(response.items, undefined);
-		assert.equal(response.count, 7);
-	});
-
-	test("omits the count when it was not asked for", async () => {
-		const calls: Call[] = [];
-		const response = await executeUnifiedThreadListing(
-			buildListingClient(calls, 7),
-			CONFIG_ID,
-			params({ starredOnly: true }),
-		);
-
-		assert.equal(response.count, undefined);
-		assert.deepEqual(response.items, []);
-	});
-
-	// #1128: the one free-text parameter matches subject and From at once, so
-	// `from:` and `subject:` could not be asked for separately and the Flagged
-	// view applied both over the pages it had already fetched.
-	test("sends from and subject as their own terms", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(buildListingClient(calls), CONFIG_ID, {
-			...params({ starredOnly: true }),
-			from: "alice",
-			subject: "invoice",
-		});
-
-		assert.deepEqual(calls[0].search, {
-			from: "alice",
-			subject: "invoice",
-			starred: true,
-		});
-	});
-
-	test("blank field text asks for nothing", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(buildListingClient(calls), CONFIG_ID, {
-			...params(),
-			from: "",
-			subject: "",
-		});
-
-		assert.deepEqual(calls[0].search, {});
-	});
-
-	// #1137: the count answered a wider set than the list, because the browser
-	// dropped muted senders after the rows arrived and nothing told the server.
-	test("the muted term reaches the listing and the count alike", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(buildListingClient(calls), CONFIG_ID, {
-			...params({ count: true }),
-			muted: false,
-		});
-
-		const listing = calls.find((call) => call.mode === "listByDate");
-		const counting = calls.find((call) => call.mode === "count");
-		assert.deepEqual(listing?.search, { muted: false });
-		assert.deepEqual(counting?.search, { muted: false });
-	});
-
-	test("an unstated muted term filters nothing", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(
-			buildListingClient(calls),
-			CONFIG_ID,
-			params(),
-		);
-
-		assert.equal(Object.hasOwn(calls[0].search ?? {}, "muted"), false);
-	});
-
-	// #1136: the account pill narrowed the rows after they arrived, so a count
-	// over every account was not the size of a list showing one and the brief
-	// withheld every number rather than overstate.
-	test("an account scope narrows the listing and the count to that account", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(
-			buildListingClient(calls, 3),
-			CONFIG_ID,
-			params({ accountId: "a2", count: true }),
-		);
-
-		const listing = calls.find((call) => call.mode === "listByDate");
-		const counting = calls.find((call) => call.mode === "count");
-		assert.deepEqual([...(listing?.inboxMailboxIds ?? [])], ["m2-inbox"]);
-		assert.deepEqual([...(counting?.mailboxIds ?? [])].sort(), ["m2-inbox"]);
-	});
-
-	test("an account scope narrows the search scope too", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(buildListingClient(calls), CONFIG_ID, {
-			...params({ accountId: "a2" }),
-			searchText: "invoice",
-		});
-
-		assert.equal(calls[0].mode, "searchByDate");
-		assert.deepEqual([...(calls[0].mailboxIds ?? [])].sort(), [
-			"m2-archive",
-			"m2-inbox",
-		]);
-	});
-
-	test("no account scope leaves the cross-account aggregate", async () => {
-		const calls: Call[] = [];
-		await executeUnifiedThreadListing(
-			buildListingClient(calls),
-			CONFIG_ID,
-			params(),
-		);
-
-		assert.deepEqual([...(calls[0].inboxMailboxIds ?? [])].sort(), [
-			"m-inbox",
-			"m2-inbox",
-		]);
-	});
-
-	// An account the config does not read narrows to nothing, which is the
-	// honest answer — never the whole aggregate under another account's name.
-	test("an unknown account matches nothing", async () => {
-		const calls: Call[] = [];
-		const response = await executeUnifiedThreadListing(
-			buildListingClient(calls, 99),
-			CONFIG_ID,
-			params({ accountId: "a-other", count: true }),
-		);
-
-		assert.deepEqual(calls, []);
-		assert.deepEqual(response.items, []);
-		assert.equal(response.count, 0);
-	});
-
-	// #313: the Spam offer stated the junk share of the page the client had
-	// loaded, offered as a folder total. A count of one folder under the search's
-	// own criteria is what makes that number the folder's.
-	test("a folder scope narrows the search and the count to that folder", async () => {
-		const calls: Call[] = [];
-		const response = await executeUnifiedThreadListing(
-			buildListingClient(calls, 12),
-			CONFIG_ID,
-			{ ...params({ mailboxId: "m2-archive", count: true }), searchText: "x" },
-		);
-
-		const searching = calls.find((call) => call.mode === "searchByDate");
-		const counting = calls.find((call) => call.mode === "count");
-		assert.deepEqual([...(searching?.mailboxIds ?? [])], ["m2-archive"]);
-		assert.deepEqual([...(counting?.mailboxIds ?? [])], ["m2-archive"]);
-		assert.equal(response.count, 12);
-	});
-
-	test("a folder scope intersects the account scope rather than replacing it", async () => {
-		const calls: Call[] = [];
-		const response = await executeUnifiedThreadListing(
-			buildListingClient(calls, 99),
-			CONFIG_ID,
-			{
-				...params({ accountId: "a1", mailboxId: "m2-archive", count: true }),
-				searchText: "x",
-			},
-		);
-
-		assert.deepEqual(calls, []);
-		assert.equal(response.count, 0);
-	});
-
-	// Trash is the one folder the unscoped search never reaches, so a caller
-	// asking what it holds of a search is asking about mail the search does not
-	// see. Answering with the folder's own contents would widen the scope.
-	test("a folder the search scope excludes matches nothing", async () => {
-		const calls: Call[] = [];
-		const response = await executeUnifiedThreadListing(
-			buildListingClient(calls, 99),
-			CONFIG_ID,
-			{ ...params({ mailboxId: "m2-trash", count: true }), searchText: "x" },
-		);
-
-		assert.deepEqual(calls, []);
-		assert.equal(response.count, 0);
-	});
-});