@remit/backend 0.0.142 → 0.0.144

package/src/handlers/outbox-attachment.ts

@@ -1,126 +0,0 @@
-import type {
-	MintOutboxAttachmentInput,
-	MintOutboxAttachmentResponse,
-	OutboxAttachmentRejection,
-	OutboxAttachmentResponse,
-} from "@remit/api-openapi-types";
-import type { OutboxAttachmentItem } from "@remit/data-ports";
-import { OutboxAttachmentRejectionReason } from "@remit/domain-enums";
-import type {
-	OutboxAttachmentRejectionDetail,
-	OutboxAttachmentRejectionReasonValue,
-} from "@remit/mailbox-service";
-import { outboxAttachmentContentId } from "@remit/mailbox-service/outbox-attachment-content";
-import type { APIGatewayProxyEvent } from "aws-lambda";
-import type { Context } from "openapi-backend";
-import { getAccountConfigIdFromEvent } from "../auth.js";
-import { getContentSigner } from "../derive/contentSignature.js";
-import {
-	buildStorageContentUrl,
-	getContentDeliveryDomain,
-} from "../derive/contentUrl.js";
-import { getClient } from "../service/data-client.js";
-
-// Every error body the API emits carries a `code` (issue #371). A refusal here
-// is one kind, so the code is one value and `reason` says which refusal it was.
-const ATTACHMENT_REJECTED_CODE = "attachment_rejected";
-
-const TOO_LARGE: ReadonlySet<OutboxAttachmentRejectionReasonValue> = new Set([
-	OutboxAttachmentRejectionReason.FileTooLarge,
-	OutboxAttachmentRejectionReason.MessageTooLarge,
-	OutboxAttachmentRejectionReason.TooManyAttachments,
-]);
-
-export const toOutboxAttachmentResponse = (
-	item: OutboxAttachmentItem,
-): OutboxAttachmentResponse => ({
-	outboxAttachmentId: item.outboxAttachmentId,
-	outboxMessageId: item.outboxMessageId,
-	filename: item.filename,
-	contentType: item.contentType,
-	sizeBytes: item.sizeBytes,
-	state: item.state,
-	contentId: outboxAttachmentContentId(item.outboxAttachmentId),
-	contentUrl: buildStorageContentUrl({
-		domain: getContentDeliveryDomain(),
-		storageKey: item.storageKey,
-		sign: getContentSigner(),
-	}),
-});
-
-interface RejectionResponse {
-	statusCode: number;
-	body: OutboxAttachmentRejection;
-}
-
-const refuse = (
-	detail: OutboxAttachmentRejectionDetail,
-): RejectionResponse => ({
-	statusCode: TOO_LARGE.has(detail.reason) ? 413 : 400,
-	body: {
-		code: ATTACHMENT_REJECTED_CODE,
-		reason: detail.reason,
-		message: detail.message,
-		limitBytes: detail.limitBytes,
-		usedBytes: detail.usedBytes,
-	},
-});
-
-/**
- * Reserve room on a draft and hand back somewhere to put the bytes. Small JSON
- * in, small JSON out — the file itself never passes through here, which is what
- * lets the upload live on its own fleet and keeps this operation under any
- * payload ceiling the REST tier has.
- */
-export const mintOutboxAttachment = async (
-	context: Context,
-	...args: unknown[]
-): Promise<MintOutboxAttachmentResponse | RejectionResponse> => {
-	const event = args[0] as APIGatewayProxyEvent;
-	const accountConfigId = getAccountConfigIdFromEvent(event);
-	const { outboxMessageId } = context.request.params as {
-		outboxMessageId: string;
-	};
-	const input = context.request.requestBody as MintOutboxAttachmentInput;
-
-	const client = await getClient();
-	const result = await client.outboxAttachment.mint({
-		accountConfigId,
-		outboxMessageId,
-		filename: input.filename,
-		contentType: input.contentType,
-		sizeBytes: input.sizeBytes,
-	});
-
-	if (result.outcome === "Rejected") return refuse(result.rejection);
-
-	return result.reservation;
-};
-
-/**
- * Confirm the upload landed. The size in the response is read back from
- * storage — on a deployment where the browser PUT straight to block storage
- * this call is the first the API hears of the bytes, and the client's word for
- * how many there are is not evidence.
- */
-export const completeOutboxAttachment = async (
-	context: Context,
-	...args: unknown[]
-): Promise<OutboxAttachmentResponse | RejectionResponse> => {
-	const event = args[0] as APIGatewayProxyEvent;
-	const accountConfigId = getAccountConfigIdFromEvent(event);
-	const { outboxMessageId, outboxAttachmentId } = context.request.params as {
-		outboxMessageId: string;
-		outboxAttachmentId: string;
-	};
-	const client = await getClient();
-	const result = await client.outboxAttachment.complete({
-		accountConfigId,
-		outboxMessageId,
-		outboxAttachmentId,
-	});
-
-	if (result.outcome === "Rejected") return refuse(result.rejection);
-
-	return toOutboxAttachmentResponse(result.attachment);
-};

package/src/handlers/outbox-list.test.ts

@@ -1,179 +0,0 @@
-/**
- * Issue #1013: the outbox listing took the head of the configured account list,
- * so on an instance with two accounts the second account's drafts and failed
- * sends were never on screen.
- *
- * The operation takes no account parameter and does not gain one — the fan-out
- * is the handler's job. What is pinned here is that every account under the
- * caller's config is asked for, and that the continuation token the handler
- * hands back resumes the one merged ordering rather than one account's.
- */
-
-import assert from "node:assert/strict";
-import { afterEach, describe, it } from "node:test";
-import type {
-	AccountItem,
-	IAccountRepository,
-	IOutboxMessageRepository,
-	OutboxMessageItem,
-	ResultList,
-} from "@remit/data-ports";
-import { APPENDED_UID_NONE } from "@remit/data-ports";
-import { OutboxMessageStatus } from "@remit/domain-enums";
-import type { APIGatewayProxyEvent } from "aws-lambda";
-import type { Context } from "openapi-backend";
-import { deriveAccountConfigId } from "../auth.js";
-import {
-	_resetForTest,
-	type RemitClient,
-	setClient,
-} from "../service/data-client.js";
-import { OutboxOperations } from "./outbox.js";
-
-const SUB = "cognito-sub-1013";
-const ACCOUNT_CONFIG_ID = deriveAccountConfigId(SUB);
-const FIRST_ACCOUNT = "acc-first";
-const SECOND_ACCOUNT = "acc-second";
-
-const outboxRow = (
-	outboxMessageId: string,
-	accountId: string,
-	createdAt: number,
-): OutboxMessageItem => ({
-	outboxMessageId,
-	accountId,
-	accountConfigId: ACCOUNT_CONFIG_ID,
-	fromAddress: `${accountId}@example.com`,
-	toAddresses: ["recipient@example.com"],
-	ccAddresses: [],
-	bccAddresses: [],
-	references: [],
-	messageIdValue: `<${outboxMessageId}@example.com>`,
-	status: OutboxMessageStatus.draft,
-	appendedUid: APPENDED_UID_NONE,
-	createdAt,
-	updatedAt: createdAt,
-});
-
-/**
- * Four rows, the two accounts alternating in time, so a page of two can only
- * hold rows from both and a listing that follows one account is visibly short.
- */
-const rows: OutboxMessageItem[] = [
-	outboxRow("out-1", FIRST_ACCOUNT, 4000),
-	outboxRow("out-2", SECOND_ACCOUNT, 3000),
-	outboxRow("out-3", FIRST_ACCOUNT, 2000),
-	outboxRow("out-4", SECOND_ACCOUNT, 1000),
-];
-
-const askedFor: string[][] = [];
-
-/** The keyset the drizzle repository implements, over the fixture above. */
-const outboxRepository = {
-	listByAccounts: async (
-		accountIds: string[],
-		options?: { limit?: number; continuationToken?: string },
-	): Promise<ResultList<OutboxMessageItem>> => {
-		askedFor.push([...accountIds]);
-		const limit = options?.limit ?? 2;
-		const after = options?.continuationToken
-			? (JSON.parse(
-					Buffer.from(options.continuationToken, "base64url").toString("utf8"),
-				) as { createdAt: number })
-			: undefined;
-		const matching = rows
-			.filter((row) => accountIds.includes(row.accountId))
-			.filter((row) => after === undefined || row.createdAt < after.createdAt)
-			.sort((left, right) => right.createdAt - left.createdAt);
-		const items = matching.slice(0, limit);
-		const last = items[items.length - 1];
-		const hasMore = matching.length > limit;
-		return {
-			items,
-			continuationToken:
-				hasMore && last
-					? Buffer.from(JSON.stringify({ createdAt: last.createdAt })).toString(
-							"base64url",
-						)
-					: undefined,
-		};
-	},
-} as unknown as IOutboxMessageRepository;
-
-const accountRepository = {
-	listAllByAccountConfig: async (): Promise<AccountItem[]> =>
-		[FIRST_ACCOUNT, SECOND_ACCOUNT].map(
-			(accountId) =>
-				({
-					accountId,
-					accountConfigId: ACCOUNT_CONFIG_ID,
-					email: `${accountId}@example.com`,
-				}) as unknown as AccountItem,
-		),
-} as unknown as IAccountRepository;
-
-const installClient = (): void => {
-	askedFor.length = 0;
-	setClient({
-		account: accountRepository,
-		outboxMessage: outboxRepository,
-	} as unknown as RemitClient);
-};
-
-const authorizedEvent = (): APIGatewayProxyEvent =>
-	({
-		body: null,
-		requestContext: { authorizer: { claims: { sub: SUB } } },
-	}) as unknown as APIGatewayProxyEvent;
-
-const queryContext = (query: Record<string, string> = {}): Context =>
-	({ request: { query } }) as unknown as Context;
-
-type ListResult = {
-	items: { outboxMessageId: string; accountId: string }[];
-	continuationToken?: string;
-};
-
-const listOutbox = async (query?: Record<string, string>) =>
-	(await (
-		OutboxOperations.OutboxOperations_listOutboxMessages as unknown as (
-			context: Context,
-			event: APIGatewayProxyEvent,
-		) => Promise<ListResult>
-	)(queryContext(query), authorizedEvent())) as ListResult;
-
-afterEach(() => {
-	_resetForTest();
-});
-
-describe("the outbox of an instance with two accounts (#1013)", () => {
-	it("lists rows from every account, not just the first", async () => {
-		installClient();
-
-		const first = await listOutbox();
-
-		assert.deepEqual(askedFor, [[FIRST_ACCOUNT, SECOND_ACCOUNT]]);
-		assert.deepEqual(
-			[...new Set(first.items.map((item) => item.accountId))].sort(),
-			[FIRST_ACCOUNT, SECOND_ACCOUNT],
-		);
-	});
-
-	it("resumes the merged ordering on the second page", async () => {
-		installClient();
-
-		const first = await listOutbox();
-		assert.ok(first.continuationToken, "a second page is offered");
-
-		const second = await listOutbox({
-			continuationToken: first.continuationToken,
-		});
-
-		const seen = [...first.items, ...second.items].map(
-			(item) => item.outboxMessageId,
-		);
-		assert.deepEqual(seen, ["out-1", "out-2", "out-3", "out-4"]);
-		assert.equal(new Set(seen).size, 4, "no row on both pages");
-		assert.equal(second.continuationToken, undefined, "paging terminates");
-	});
-});