@remit/backend 0.0.133 → 0.0.134

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/backend",
-  "version": "0.0.133",
+  "version": "0.0.134",
   "description": "Remit Mail Inspector API backend",
   "license": "MIT",
   "author": "",

package/src/handlers/calendar-suggestion.test.ts

@@ -10,6 +10,7 @@ import type {
 	SettleCalendarSuggestionInput,
 } from "@remit/data-ports";
 import {
+	CalendarInviteAnswer,
 	CalendarInviteMethod,
 	CalendarSuggestionSource,
 	CalendarSuggestionState,
@@ -354,6 +355,7 @@ const INVITATION = [
 const putSuggestion = (
 	accountConfigId: string,
 	messageId: string,
+	method: CalendarSuggestionItem["method"] = CalendarInviteMethod.Request,
 ): Promise<CalendarSuggestionItem> =>
 	client.calendarSuggestion.put({
 		accountConfigId,
@@ -361,7 +363,7 @@ const putSuggestion = (
 		bodyPartId: "part-1",
 		icalUid: "invite@example.test",
 		sequence: 0,
-		method: CalendarInviteMethod.Request,
+		method,
 		source: CalendarSuggestionSource.IcalendarPart,
 		summary: "Quarterly review",
 		dtStart: "2026-09-01T10:00:00+02:00",
@@ -506,6 +508,45 @@ describe("POST /calendar-suggestions/{suggestionId}/accept", () => {
 		assert.equal(untouched.state, CalendarSuggestionState.Pending);
 		assert.equal(untouched.acceptedCalendarObjectId, "");
 	});
+
+	test("refuses a maybe to a cancellation, before writing anything", async () => {
+		const { accountConfigId, event } = anAccount();
+		const calendar = await client.calendarCollection.create({
+			accountConfigId,
+			urlSegment: "default",
+			displayName: "Calendar",
+		});
+		const card = await putSuggestion(
+			accountConfigId,
+			"msg-cancel-maybe",
+			CalendarInviteMethod.Cancel,
+		);
+
+		await assert.rejects(
+			() =>
+				acceptSuggestion(
+					contextOf({
+						params: { suggestionId: card.suggestionId },
+						requestBody: {
+							calendarId: calendar.calendarId,
+							answer: CalendarInviteAnswer.Tentative,
+						},
+					}),
+					event,
+				),
+			(error: unknown) => (error as { statusCode?: number }).statusCode === 400,
+		);
+
+		assert.deepEqual(
+			await client.calendarObject.listByCalendar(calendar.calendarId),
+			[],
+		);
+		const untouched = await client.calendarSuggestion.get(
+			accountConfigId,
+			card.suggestionId,
+		);
+		assert.equal(untouched.state, CalendarSuggestionState.Pending);
+	});
 });
 
 describe("POST /calendar-suggestions/{suggestionId}/dismiss", () => {

package/src/handlers/calendar-suggestion.ts

@@ -1,4 +1,7 @@
-import type { CalendarSuggestionResponse } from "@remit/api-openapi-types";
+import type {
+	CalendarInviteAnswer as CalendarInviteAnswerValue,
+	CalendarSuggestionResponse,
+} from "@remit/api-openapi-types";
 import { acceptCalendarSuggestion } from "@remit/calendar-service";
 import {
 	type CalendarSuggestionItem,
@@ -9,6 +12,8 @@ import {
 } from "@remit/data-ports";
 import { BadRequestError } from "@remit/data-ports/errors";
 import {
+	CalendarInviteAnswer,
+	CalendarInviteMethod,
 	CalendarSource,
 	CalendarSuggestionState,
 	FilterClauseField,
@@ -211,8 +216,10 @@ export const CalendarSuggestionActionOperations: Record<
 		const { suggestionId } = context.request.params as {
 			suggestionId: string;
 		};
-		const { calendarId } = context.request.requestBody as {
+		const { calendarId, answer = CalendarInviteAnswer.Accepted } = context
+			.request.requestBody as {
 			calendarId: string;
+			answer?: CalendarInviteAnswerValue;
 		};
 
 		const client = await getClient();
@@ -220,7 +227,20 @@ export const CalendarSuggestionActionOperations: Record<
 			accountConfigId,
 			suggestionId,
 		);
-		assertSettleable(suggestion, CalendarSuggestionState.Accepted);
+		if (
+			answer === CalendarInviteAnswer.Tentative &&
+			suggestion.method === CalendarInviteMethod.Cancel
+		) {
+			throw new BadRequestError(
+				"This is a cancellation, so there is nothing to answer maybe to.",
+			);
+		}
+		assertSettleable(
+			suggestion,
+			answer === CalendarInviteAnswer.Tentative
+				? CalendarSuggestionState.Tentative
+				: CalendarSuggestionState.Accepted,
+		);
 
 		// Reads the collection through the caller's own account config, so a
 		// calendarId naming somebody else's collection is a 404 before anything
@@ -240,6 +260,7 @@ export const CalendarSuggestionActionOperations: Record<
 			calendarId,
 			suggestion,
 			attendee: await accountEmailForMessage(client, suggestion.messageId),
+			answer,
 		});
 		if (!accepted.ok) {
 			throw new BadRequestError(accepted.error.message);