@remit/backend 0.0.124 → 0.0.125

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/backend",
-  "version": "0.0.124",
+  "version": "0.0.125",
   "description": "Remit Mail Inspector API backend",
   "license": "MIT",
   "author": "",

package/src/handlers/mailbox.test.ts

@@ -1,6 +1,7 @@
 import assert from "node:assert/strict";
 import { afterEach, describe, it } from "node:test";
 import type { MailboxItem } from "@remit/data-ports";
+import { BadRequestError } from "@remit/data-ports/errors";
 import { MailboxSyncStatus } from "@remit/domain-enums";
 import { UnconfirmedTrashMailboxError } from "@remit/mailbox-service";
 import type { APIGatewayProxyEvent } from "aws-lambda";
@@ -11,7 +12,11 @@ import {
 	type RemitClient,
 	setClient,
 } from "../service/data-client.js";
-import { MailboxDetailOperations, TrashOperations } from "./mailbox.js";
+import {
+	MailboxDetailOperations,
+	MailboxOperations,
+	TrashOperations,
+} from "./mailbox.js";
 
 const SUB = "cognito-sub-887";
 const ACCOUNT_ID = "acc-887";
@@ -230,3 +235,46 @@ describe("MailboxDetailOperations_deleteMailbox — what it refuses (D4, D16)",
 		assert.deepEqual(deleted, ["mbx-1"]);
 	});
 });
+
+const createMailbox =
+	MailboxOperations.MailboxOperations_createMailbox as unknown as (
+		context: Context,
+		event: APIGatewayProxyEvent,
+	) => Promise<unknown>;
+
+describe("MailboxOperations_createMailbox", () => {
+	afterEach(() => {
+		_resetForTest();
+	});
+
+	it("refuses a path the account already has a folder at", async () => {
+		setClient({
+			account: {
+				get: async () => ({
+					accountId: ACCOUNT_ID,
+					accountConfigId: deriveAccountConfigId(SUB),
+				}),
+			},
+			mailboxQueue: {
+				createMailbox: async () => ({ outcome: "PathTaken" }),
+			},
+		} as unknown as RemitClient);
+
+		await assert.rejects(
+			createMailbox(
+				{
+					request: {
+						params: { accountId: ACCOUNT_ID },
+						requestBody: { namespaceType: "personal", fullPath: "Receipts" },
+					},
+				} as unknown as Context,
+				{
+					requestContext: { authorizer: { claims: { sub: SUB } } },
+				} as unknown as APIGatewayProxyEvent,
+			),
+			(error: unknown) =>
+				error instanceof BadRequestError &&
+				error.message === "A folder named “Receipts” is already there.",
+		);
+	});
+});

package/src/handlers/mailbox.ts

@@ -402,7 +402,7 @@ export const MailboxOperations: Record<
 		const account = await client.account.get(accountId);
 		assertAccountOwnership(account, accountConfigId, "act");
 
-		const mailbox = await client.mailboxQueue.createMailbox(
+		const created = await client.mailboxQueue.createMailbox(
 			{
 				accountId,
 				namespaceType: namespaceType as "personal" | "other_users" | "shared",
@@ -423,8 +423,13 @@ export const MailboxOperations: Record<
 			accountId,
 			true,
 		);
+		if (created.outcome === "PathTaken") {
+			throw new BadRequestError(
+				`A folder named “${fullPath}” is already there.`,
+			);
+		}
 
-		return toMailboxResponse(mailbox);
+		return toMailboxResponse(created.mailbox);
 	},
 };