@remit/account-worker 0.0.22 → 0.0.24

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remit/account-worker",
-  "version": "0.0.22",
+  "version": "0.0.24",
   "type": "module",
   "main": "dist/index.js",
   "exports": {
@@ -29,7 +29,8 @@
     "bundle": "esbuild src/index.ts --sourcemap --bundle --platform=node --format=esm --outfile=dist/index.js",
     "test:typecheck": "tsgo --noEmit",
     "test:run": "node $NODE_TEST_FLAGS --env-file=../../localhost-test-unit.env --experimental-test-coverage --test-coverage-include='src/**' --test-coverage-exclude='src/**/*.test.ts' --test-coverage-exclude='src/**/*.test.tsx' --test-coverage-lines=91 --test 'src/**/*.test.ts'",
-    "test": "npm run test:typecheck && npm run test:run"
+    "test": "npm run test:typecheck && npm run test:run",
+    "dev": "node --import tsx src/poller.ts"
   },
   "dependencies": {
     "@remit/data-ports": "*",

package/src/cascade-enumerate.test.ts

@@ -1,7 +1,7 @@
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
 import type { MessageDescription } from "@remit/data-ports";
-import type { Logger } from "@remit/logger-lambda";
+import { noopLogger } from "@remit/logger-lambda/noop-logger";
 import {
 	type CascadeEntity,
 	type CascadeServices,
@@ -9,16 +9,6 @@ import {
 	enumerateCascadeEntities,
 } from "./cascade.js";
 
-const noopLog = {
-	info: () => {},
-	warn: () => {},
-	error: () => {},
-	debug: () => {},
-	fatal: () => {},
-	trace: () => {},
-	child: () => noopLog,
-} as unknown as Logger;
-
 const messageWithChildren = {
 	messageFlag: [{ messageFlagId: "flag-1" }],
 	envelope: [{ envelopeId: "env-1" }],
@@ -127,7 +117,7 @@ describe("enumerateCascadeEntities", () => {
 		const { entities, messageIds } = await enumerateCascadeEntities(
 			"cfg-1",
 			fullServices(),
-			noopLog,
+			noopLogger,
 		);
 
 		assert.deepEqual(messageIds, ["msg-1"]);
@@ -166,7 +156,7 @@ describe("enumerateCascadeEntities", () => {
 		const { entities } = await enumerateCascadeEntities(
 			"cfg-1",
 			services,
-			noopLog,
+			noopLogger,
 		);
 
 		assert.equal(entities.filter((e) => e.entityType === "Filter").length, 1);
@@ -183,7 +173,7 @@ describe("enumerateCascadeEntities", () => {
 		const { entities } = await enumerateCascadeEntities(
 			"cfg-1",
 			services,
-			noopLog,
+			noopLogger,
 		);
 
 		assert.equal(
@@ -204,7 +194,7 @@ describe("enumerateCascadeEntities", () => {
 		const { entities, messageIds } = await enumerateCascadeEntities(
 			"cfg-empty",
 			services,
-			noopLog,
+			noopLogger,
 		);
 
 		assert.equal(messageIds.length, 0);

package/src/compose-relational.test.ts

@@ -3,19 +3,9 @@ import { mkdir, mkdtemp, stat, writeFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { dirname, join } from "node:path";
 import { afterEach, beforeEach, describe, it } from "node:test";
-import type { Logger } from "@remit/logger-lambda";
+import { noopLogger } from "@remit/logger-lambda/noop-logger";
 import { buildRelationalDeletionCapabilities } from "./compose-relational.js";
 
-const noopLog = {
-	info: () => {},
-	warn: () => {},
-	error: () => {},
-	debug: () => {},
-	fatal: () => {},
-	trace: () => {},
-	child: () => noopLog,
-} as unknown as Logger;
-
 const exists = (path: string): Promise<boolean> =>
 	stat(path)
 		.then(() => true)
@@ -54,7 +44,7 @@ describe("relational deletion capabilities — filesystem storage cleanup", () =
 			"accounts/cfg-2/acc-9/messages/m9/body.eml",
 		);
 
-		await caps.deleteStoragePrefix("accounts/cfg-1/", noopLog);
+		await caps.deleteStoragePrefix("accounts/cfg-1/", noopLogger);
 
 		for (const path of deleted) {
 			assert.equal(await exists(path), false, `${path} must be deleted`);
@@ -74,7 +64,7 @@ describe("relational deletion capabilities — filesystem storage cleanup", () =
 			"accounts/cfg-1/acc-2/messages/m2/body.eml",
 		);
 
-		await caps.deleteStoragePrefix("accounts/cfg-1/acc-1/", noopLog);
+		await caps.deleteStoragePrefix("accounts/cfg-1/acc-1/", noopLogger);
 
 		assert.equal(await exists(deleted), false);
 		assert.equal(
@@ -86,19 +76,19 @@ describe("relational deletion capabilities — filesystem storage cleanup", () =
 
 	it("is replay-safe — deleting a missing prefix does not throw", async () => {
 		const caps = buildRelationalDeletionCapabilities();
-		await caps.deleteStoragePrefix("accounts/never-existed/", noopLog);
+		await caps.deleteStoragePrefix("accounts/never-existed/", noopLogger);
 	});
 });
 
 describe("relational deletion capabilities — CDN and sign-out are no-ops", () => {
 	it("invalidateContent resolves without a CDN", async () => {
 		const caps = buildRelationalDeletionCapabilities();
-		await caps.invalidateContent("cfg-1", noopLog);
-		await caps.invalidateContent("cfg-1/acc-1", noopLog);
+		await caps.invalidateContent("cfg-1", noopLogger);
+		await caps.invalidateContent("cfg-1/acc-1", noopLogger);
 	});
 
 	it("signOut resolves without a federated session store", async () => {
 		const caps = buildRelationalDeletionCapabilities();
-		await caps.signOut("user-123", noopLog);
+		await caps.signOut("user-123", noopLogger);
 	});
 });

package/src/handlers/account-export.test.ts

@@ -1,7 +1,7 @@
 import assert from "node:assert/strict";
 import { Readable } from "node:stream";
 import { describe, it } from "node:test";
-import type { Logger } from "@remit/logger-lambda";
+import { noopLogger } from "@remit/logger-lambda/noop-logger";
 import type { StorageService } from "@remit/storage-service";
 import type { CascadeServices } from "../cascade.js";
 import type { AccountExportEvent } from "../events.js";
@@ -10,16 +10,6 @@ import {
 	processAccountExport,
 } from "./account-export.js";
 
-const noopLog = {
-	info: () => {},
-	warn: () => {},
-	error: () => {},
-	debug: () => {},
-	fatal: () => {},
-	trace: () => {},
-	child: () => noopLog,
-} as unknown as Logger;
-
 interface Update {
 	state: string;
 	objectKey?: string;
@@ -84,7 +74,7 @@ const event: AccountExportEvent = {
 describe("processAccountExport", () => {
 	it("drives the request Processing then Ready and stores the archive key", async () => {
 		const updates: Update[] = [];
-		await processAccountExport(event, noopLog, buildDeps(updates));
+		await processAccountExport(event, noopLogger, buildDeps(updates));
 
 		assert.deepEqual(
 			updates.map((u) => u.state),
@@ -103,7 +93,7 @@ describe("processAccountExport", () => {
 		let retrieved = 0;
 		await processAccountExport(
 			event,
-			noopLog,
+			noopLogger,
 			buildDeps(updates, {
 				retrieveMessageBodyStream: async (
 					_cfg: string,
@@ -125,7 +115,7 @@ describe("processAccountExport", () => {
 		await assert.rejects(
 			processAccountExport(
 				event,
-				noopLog,
+				noopLogger,
 				buildDeps(updates, {
 					storeExportArchiveStream: async (
 						_cfg: string,

package/src/handlers/account-fanout.test.ts

@@ -1,21 +1,11 @@
 import assert from "node:assert/strict";
 import { afterEach, describe, it } from "node:test";
 import type { SQSClient } from "@aws-sdk/client-sqs";
-import type { Logger } from "@remit/logger-lambda";
+import { noopLogger } from "@remit/logger-lambda/noop-logger";
 import type { CascadeServices } from "../cascade.js";
 import type { AccountDeleteEvent } from "../events.js";
 import { processAccountFanout } from "./account-fanout.js";
 
-const noopLog = {
-	info: () => {},
-	warn: () => {},
-	error: () => {},
-	debug: () => {},
-	fatal: () => {},
-	trace: () => {},
-	child: () => noopLog,
-} as unknown as Logger;
-
 // A CascadeServices fake with one account and no data: enough for
 // enumerateCascadeEntities to yield a single Account row (so the stop-signal
 // loop has one accountId to iterate) without standing up a database.
@@ -81,7 +71,7 @@ describe("processAccountFanout — imap-worker stop signal on account delete", (
 		delete process.env.SQS_QUEUE_URL_IMAP_WORKER;
 		const sent: SentMessage[] = [];
 
-		await processAccountFanout(deleteEvent, noopLog, {
+		await processAccountFanout(deleteEvent, noopLogger, {
 			services: buildServices(),
 			sqs: recordingSqs(sent),
 			signOut: async () => {},
@@ -99,7 +89,7 @@ describe("processAccountFanout — imap-worker stop signal on account delete", (
 	it("enqueues one stop signal per account when a queue is configured", async () => {
 		const sent: SentMessage[] = [];
 
-		await processAccountFanout(deleteEvent, noopLog, {
+		await processAccountFanout(deleteEvent, noopLogger, {
 			services: buildServices(),
 			sqs: recordingSqs(sent),
 			signOut: async () => {},

package/src/handlers/account-purge.test.ts

@@ -1,7 +1,7 @@
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
 import type { SQSClient } from "@aws-sdk/client-sqs";
-import type { Logger } from "@remit/logger-lambda";
+import { noopLogger } from "@remit/logger-lambda/noop-logger";
 import type { CascadeServices } from "../cascade.js";
 import type { AccountDataPurgeEvent } from "../events.js";
 import {
@@ -9,16 +9,6 @@ import {
 	processAccountDataPurge,
 } from "./account-purge.js";
 
-const noopLog = {
-	info: () => {},
-	warn: () => {},
-	error: () => {},
-	debug: () => {},
-	fatal: () => {},
-	trace: () => {},
-	child: () => noopLog,
-} as unknown as Logger;
-
 interface Sent {
 	queueUrl: string | undefined;
 	body: Record<string, unknown>;
@@ -91,7 +81,7 @@ const baseDeps = (
 describe("processAccountDataPurge", () => {
 	it("enqueues vector deletes then a subtrees batch and one container leftover", async () => {
 		const sent: Sent[] = [];
-		await processAccountDataPurge(event, noopLog, baseDeps(sent));
+		await processAccountDataPurge(event, noopLogger, baseDeps(sent));
 
 		const vectorBatch = sent.find((m) => m.queueUrl === "http://queue/search");
 		assert.equal(vectorBatch?.entries?.length, 2, "one entry per message");
@@ -110,7 +100,7 @@ describe("processAccountDataPurge", () => {
 		const sent: Sent[] = [];
 		await processAccountDataPurge(
 			event,
-			noopLog,
+			noopLogger,
 			baseDeps(sent, { dataBackend: "sqlite" }),
 		);
 
@@ -129,7 +119,7 @@ describe("processAccountDataPurge", () => {
 
 	it("drops manifest rows outside the account's mailbox set", async () => {
 		const sent: Sent[] = [];
-		await processAccountDataPurge(event, noopLog, {
+		await processAccountDataPurge(event, noopLogger, {
 			...baseDeps(sent),
 			services: buildServices([
 				{ threadMessageId: "tm-1", messageId: "msg-1", mailboxId: "mbx-1" },
@@ -143,7 +133,7 @@ describe("processAccountDataPurge", () => {
 
 	it("no-ops when the account is already gone", async () => {
 		const sent: Sent[] = [];
-		await processAccountDataPurge(event, noopLog, {
+		await processAccountDataPurge(event, noopLogger, {
 			...baseDeps(sent),
 			services: {
 				accountService: {
@@ -163,7 +153,7 @@ describe("processAccountDataPurge", () => {
 	it("rethrows a non-NotFound describe error", async () => {
 		const sent: Sent[] = [];
 		await assert.rejects(
-			processAccountDataPurge(event, noopLog, {
+			processAccountDataPurge(event, noopLogger, {
 				...baseDeps(sent),
 				services: {
 					accountService: {
@@ -181,7 +171,7 @@ describe("processAccountDataPurge", () => {
 	it("throws when a vector-delete batch reports failed entries", async () => {
 		const sent: Sent[] = [];
 		await assert.rejects(
-			processAccountDataPurge(event, noopLog, {
+			processAccountDataPurge(event, noopLogger, {
 				...baseDeps(sent),
 				sqs: recordingSqs(sent, true),
 			}),

package/src/handlers/organize-job.test.ts

@@ -2,20 +2,10 @@ import assert from "node:assert/strict";
 import { describe, it } from "node:test";
 import type { RemitClient } from "@remit/backend/client";
 import type { OrganizeMatchDeps } from "@remit/backend/organize";
-import type { Logger } from "@remit/logger-lambda";
+import { noopLogger } from "@remit/logger-lambda/noop-logger";
 import type { OrganizeJobEvent } from "../events.js";
 import { processOrganizeJob } from "./organize-job.js";
 
-const noopLog = {
-	info: () => {},
-	warn: () => {},
-	error: () => {},
-	debug: () => {},
-	fatal: () => {},
-	trace: () => {},
-	child: () => noopLog,
-} as unknown as Logger;
-
 interface Update {
 	state: string;
 	errorMessage?: string;
@@ -77,7 +67,7 @@ describe("processOrganizeJob (reader #463)", () => {
 	it("fails the job on a refused rule and acknowledges the record", async () => {
 		const updates: Update[] = [];
 
-		await processOrganizeJob(event, noopLog, {
+		await processOrganizeJob(event, noopLogger, {
 			client: jobClient(updates, [{ field: "HasWords", value: "invoice" }]),
 			matchDeps: explodingMatchDeps(),
 		});
@@ -97,7 +87,7 @@ describe("processOrganizeJob (reader #463)", () => {
 		const updates: Update[] = [];
 
 		await assert.rejects(
-			processOrganizeJob(event, noopLog, {
+			processOrganizeJob(event, noopLogger, {
 				client: jobClient(updates, [
 					{ field: "Subject", value: "reservation" },
 				]),

package/src/poller.ts

@@ -4,10 +4,13 @@ import { env } from "expect-env";
 import { fanoutHandler, finalizeHandler } from "./index.js";
 
 /**
- * Production queue poller. No e2e shim exists for account-worker today —
- * the deletion cascade is not exercised on the compose stack in
- * CI (see AGENTS.md worker roster notes). This is the standalone
- * production entrypoint for the dedicated image.
+ * Production queue poller, and the standalone entrypoint for the dedicated
+ * image. The sibling workers carry a separate `e2e-processor-shim.ts` because
+ * they predate `runQueuePoller`; this one has no shim and needs none — the
+ * poller drains an SQS-compatible endpoint (the queue sidecar) exactly as it
+ * drains SQS, which is what deploy/vps/docker-compose.sqlite.yml already does,
+ * so the source-built e2e stack runs this same file (`npm run dev -w
+ * @remit/account-worker`, wired in npm-scripts/e2e-dev-up.sh).
  *
  * The deployment-specific steps of the cascade — sign-out, content
  * invalidation, storage cleanup, and the row cascade — resolve through the