@remcp/remcp 0.2.26 → 0.2.28

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remcp/remcp",
-  "version": "0.2.26",
+  "version": "0.2.28",
   "description": "ReMCP device client: pair a computer with ReMCP and run the outbound-only agent that hosts the local MCP runtime.",
   "type": "module",
   "license": "MIT",

package/src/agent.mjs

@@ -531,10 +531,21 @@ export async function runAgent(options) {
       child.stderr?.on('data', forward);
       child.on('exit', code => {
         updateInFlight = false;
-        if (code !== 0) {
+        // The updater installs the packages and then restarts the service this agent runs in, so it is
+        // routinely killed by that restart and exits with a signal (`code` is null). That is success,
+        // not failure: the installed version is the proof. Without this check the agent kept
+        // reinstalling every few seconds — each cycle taking the device offline and making every tool
+        // call in that window fail in 1-3 ms ("Device is offline").
+        const targetVersion = String(target).split('@').pop();
+        const installedNow = globalInstalledVersion();
+        const installedTarget = installedNow && targetVersion && !isNewer(targetVersion, installedNow);
+        if (code !== 0 && !installedTarget) {
           console.error(`remcp update exited with ${code}; keeping ${VERSION} and retrying after the cooldown.`);
           return;
         }
+        if (code !== 0) {
+          console.error(`remcp update was terminated (${code}) after installing ${installedNow}; applying it.`);
+        }
         void restartToApplyUpdate(cli, stop, () => { stopping = true; }, async () => {
           // The packages are installed now: clear the failure, reset the backoff and start again.
           runtimeRestartDelay = RUNTIME_RESTART_BASE_MS;

package/src/cli.mjs

@@ -170,7 +170,10 @@ function macLaunchDomain() {
 function installMacService(cliPath = globalCliPath()) {
   const domain = macLaunchDomain();
   const target = `${domain}/${macServiceLabel}`;
-  const cliScript = fs.realpathSync(cliPath);
+  // launchd wants an absolute path; a symlinked prefix that npm has not materialised yet (or a path
+  // that is about to be replaced by the next install) must not abort the repair — a stale plist is
+  // exactly the loop this function exists to break.
+  const cliScript = fs.existsSync(cliPath) ? fs.realpathSync(cliPath) : path.resolve(cliPath);
   fs.mkdirSync(path.dirname(macServiceFile), { recursive: true });
   fs.mkdirSync(path.dirname(macLogFile), { recursive: true });
   const plist = `<?xml version="1.0" encoding="UTF-8"?>\n<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">\n<plist version="1.0"><dict>\n<key>Label</key><string>${macServiceLabel}</string>\n<key>ProgramArguments</key><array><string>${xmlEscape(process.execPath)}</string><string>${xmlEscape(cliScript)}</string><string>start</string></array>\n<key>RunAtLoad</key><true/><key>KeepAlive</key><true/>\n<key>ProcessType</key><string>Background</string>\n<key>StandardOutPath</key><string>${xmlEscape(macLogFile)}</string>\n<key>StandardErrorPath</key><string>${xmlEscape(macLogFile)}</string>\n</dict></plist>\n`;
@@ -255,9 +258,35 @@ function ensureServiceIfRecorded(config) {
   try {
     const cliPath = globalCliPath();
     const platform = servicePlatform();
-    if (platform === 'linux') { if (!fs.existsSync(linuxServiceFile)) installLinuxService(cliPath); }
-    else if (platform === 'darwin') { if (!fs.existsSync(macServiceFile)) installMacService(cliPath); }
-    else if (platform === 'win32') installWindowsService(cliPath);
+    if (platform === 'linux') {
+      if (!fs.existsSync(linuxServiceFile)) {
+        installLinuxService(cliPath);
+      } else {
+        // Node managers can move the global npm prefix between updates (nvm -> Hermes was observed in
+        // production). An existing systemd unit then keeps launching the old CLI forever even though
+        // npm successfully installed the new one. Repair the launcher in place before restarting it.
+        const unit = fs.readFileSync(linuxServiceFile, 'utf8');
+        const expected = `ExecStart=${quoteSystemd(cliPath)} start`;
+        if (!unit.includes(expected)) {
+          const repaired = /^ExecStart=/m.test(unit) ? unit.replace(/^ExecStart=.*$/m, expected) : '';
+          if (!repaired) {
+            // A unit that lost its ExecStart line (edited by hand, or written as `ExecStart = …`) cannot
+            // be patched by substitution. Rewriting the whole unit is what keeps the machine out of the
+            // "old CLI forever" loop, so fall back to a fresh install instead of giving up.
+            installLinuxService(cliPath);
+          } else {
+            fs.writeFileSync(linuxServiceFile, repaired);
+            run('systemctl', ['--user', 'daemon-reload']);
+          }
+        }
+      }
+    } else if (platform === 'darwin') {
+      // launchd bakes the interpreter and the CLI path into the plist, so a Node manager that moves
+      // its global prefix leaves the agent launching a file that no longer exists — the same loop the
+      // Linux unit above is repaired for. Reinstalling is idempotent (bootout, bootstrap, enable,
+      // kickstart) and is what the Windows task already does on every update.
+      installMacService(cliPath);
+    } else if (platform === 'win32') installWindowsService(cliPath);
     return true;
   } catch (error) {
     console.error(`Could not ensure the background service: ${error instanceof Error ? error.message : String(error)}`);
@@ -646,9 +675,11 @@ export async function main(argv = process.argv.slice(2)) {
       return;
     }
     const before = { cli: VERSION, runtime: installedVersion(cfg.runtime.packageName) };
-    ensureServiceIfRecorded(cfg);
     console.log(`Updating ReMCP to the latest published version (${runtimeSpec})…`);
     npmGlobalInstall(`${PACKAGE_NAME}@latest`, runtimeSpec);
+    // The npm prefix can change across Node-manager upgrades. Repair an existing persistent-service
+    // launcher only after the install, when globalCliPath() points at the CLI we just installed.
+    ensureServiceIfRecorded(cfg);
     // Only a validated spec is persisted, so a failed update cannot leave the install unable to start.
     if (requested && runtimeSpec !== cfg.runtime.packageSpec) saveConfig({ ...cfg, runtime: { ...cfg.runtime, packageSpec: runtimeSpec } });
     const after = { cli: installedVersion(PACKAGE_NAME), runtime: installedVersion(cfg.runtime.packageName) };