@remcp/remcp 0.2.227 → 0.2.229

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remcp/remcp",
-  "version": "0.2.227",
+  "version": "0.2.229",
   "description": "ReMCP device client: pair a computer with ReMCP and run the outbound-only agent that hosts the local MCP runtime.",
   "type": "module",
   "license": "MIT",
@@ -18,7 +18,7 @@
     "README.md"
   ],
   "scripts": {
-    "check": "node --check bin/remcp.mjs && node --check src/agent-deploy-reconnect.mjs && node --check src/agent-network-probe-client.mjs && node --check src/agent-relay-connection.mjs && node --check src/agent-responder.mjs && node --check src/agent-runtime-capabilities.mjs && node --check src/agent-update-monitor.mjs && node --check src/agent-update.mjs && node --check src/agent-utilities.mjs && node --check src/agent.mjs && node --check src/cli.mjs && node --check src/cli/config.mjs && node --check src/cli/connect.mjs && node --check src/cli/doctor.mjs && node --check src/cli/env.mjs && node --check src/cli/installation-audit.mjs && node --check src/cli/mac-native-temperature.mjs && node --check src/cli/npm-global.mjs && node --check src/cli/pairing-qr.mjs && node --check src/cli/service-inventory.mjs && node --check src/cli/service-macos.mjs && node --check src/cli/service-paths.mjs && node --check src/cli/service.mjs && node --check src/cli/shell.mjs && node --check src/cli/supervised-agent-lifecycle.mjs && node --check src/cli/update.mjs && node --check src/cli/windows-owned-job-source.mjs && node --check src/cli/windows-owned-job.mjs && node --check src/cli/windows-supervisor.mjs && node --check src/cli/windows-update-lock.mjs && node --check src/cli/windows-user-supervisor.mjs && node --check src/fetch-update-manifest.mjs && node --check src/fs-access.mjs && node --check src/npm.mjs && node --check src/runtime.mjs && node --check src/version.mjs",
+    "check": "node --check bin/remcp.mjs && node --check src/agent-deploy-reconnect.mjs && node --check src/agent-network-probe-client.mjs && node --check src/agent-relay-connection.mjs && node --check src/agent-responder.mjs && node --check src/agent-runtime-capabilities.mjs && node --check src/agent-update-monitor.mjs && node --check src/agent-update.mjs && node --check src/agent-utilities.mjs && node --check src/agent.mjs && node --check src/cli.mjs && node --check src/cli/config.mjs && node --check src/cli/connect.mjs && node --check src/cli/doctor.mjs && node --check src/cli/env.mjs && node --check src/cli/installation-audit.mjs && node --check src/cli/mac-native-temperature.mjs && node --check src/cli/npm-global.mjs && node --check src/cli/pairing-qr.mjs && node --check src/cli/service-inventory.mjs && node --check src/cli/service-macos.mjs && node --check src/cli/service-paths.mjs && node --check src/cli/service.mjs && node --check src/cli/shell.mjs && node --check src/cli/supervised-agent-lifecycle.mjs && node --check src/cli/update.mjs && node --check src/cli/windows-cli-shim.mjs && node --check src/cli/windows-owned-job-source.mjs && node --check src/cli/windows-owned-job.mjs && node --check src/cli/windows-supervisor.mjs && node --check src/cli/windows-update-lock.mjs && node --check src/cli/windows-user-supervisor.mjs && node --check src/fetch-update-manifest.mjs && node --check src/fs-access.mjs && node --check src/npm.mjs && node --check src/runtime.mjs && node --check src/version.mjs",
     "test": "node --test test/*.test.mjs"
   },
   "dependencies": {

package/src/agent-relay-connection.mjs

@@ -43,7 +43,9 @@ export function createAgentRelayConnection({
       reconnectTimer = null;
       connect();
     }, safeDelay);
-    reconnectTimer.unref?.();
+    // A failed handshake may leave no other referenced handles. Keep the reconnect
+    // timer referenced, or Node exits 0 and a supervisor can restart it forever.
+    // clearReconnect() releases the timer on intentional shutdown.
   }
 
   function scheduleBackoffReconnect() {

package/src/cli/npm-global.mjs

@@ -7,6 +7,7 @@ import { home, npm } from './env.mjs';
 import { buildVettedMacTemperatureAddon } from './mac-native-temperature.mjs';
 import { output, run } from './shell.mjs';
 import { withWindowsUpdateLock } from './windows-update-lock.mjs';
+import { assertWindowsNpmPowerShellShimOwned, preferWindowsCmdShim } from './windows-cli-shim.mjs';
 
 export function servicePlatform() {
   return process.env.NODE_ENV === 'test' && process.env.REMCP_TEST_PLATFORM ? process.env.REMCP_TEST_PLATFORM : process.platform;
@@ -55,7 +56,14 @@ function npmGlobalInstallArgs(specs, { preferOnline = false } = {}) {
 
 export function npmGlobalInstall(...specs) {
   const prefix = assertSafeReMcpNpmPrefix(globalPrefix()); // Reject an unsafe prefix before npm writes anything.
-  const install = () => run(npm.command, [...npm.args, ...npmGlobalInstallArgs(specs)]);
+  const install = () => {
+    const updatingClient = servicePlatform() === 'win32' && isManagedWindowsRuntimePrefix(prefix)
+      && specs.some(spec => /^@remcp\/remcp@/.test(spec));
+    // A custom remcp.ps1 must be refused BEFORE npm overwrites its contents.
+    if (updatingClient) assertWindowsNpmPowerShellShimOwned(prefix);
+    run(npm.command, [...npm.args, ...npmGlobalInstallArgs(specs)]);
+    if (updatingClient) preferWindowsCmdShim(prefix);
+  };
   if (servicePlatform() === 'win32') withWindowsUpdateLock(prefix, install);
   else install();
   if (servicePlatform() === 'darwin' && specs.some(spec => /^@remcp\/runtime@[0-9]/.test(spec))) {
@@ -184,6 +192,9 @@ function transactionalWindowsGlobalInstall({ resolved, prefix, packageNames, spe
     return;
   }
 
+  // The transaction deletes its previous shim backup after success. Reject a
+  // user-created remcp.ps1 before touching npm or moving any existing files.
+  if (packageNames.includes(PACKAGE_NAME)) assertWindowsNpmPowerShellShimOwned(prefix);
   const backupRoot = path.join(prefix, `.remcp-update-backup-${process.pid}-${Date.now()}`);
   const moved = [];
   const moveAside = (source, label) => {
@@ -221,6 +232,7 @@ function transactionalWindowsGlobalInstall({ resolved, prefix, packageNames, spe
       for (const shim of ['remcp', 'remcp.cmd', 'remcp.ps1']) moveAside(path.join(prefix, shim), `bin-${shim}`);
     }
     run(resolved.command, [...resolved.args, ...npmGlobalInstallArgs(specs, { preferOnline })]);
+    if (uniqueNames.includes(PACKAGE_NAME)) preferWindowsCmdShim(prefix);
   } catch (error) {
     restore(error);
     throw error;

package/src/cli/windows-cli-shim.mjs

@@ -0,0 +1,39 @@
+// ReMCP's private Windows npm prefix is called from both cmd.exe and PowerShell.
+// npm generates both remcp.cmd and remcp.ps1, but PowerShell prefers the .ps1
+// even when ExecutionPolicy=Restricted. That makes a successful installation
+// appear broken. Keep the batch shim, and remove only the recognizable npm shim.
+import fs from 'node:fs';
+import path from 'node:path';
+
+export function assertWindowsNpmPowerShellShimOwned(prefix) {
+  const powershell = path.join(prefix, 'remcp.ps1');
+  let metadata;
+  try { metadata = fs.lstatSync(powershell); }
+  catch (error) { if (error?.code === 'ENOENT') return false; throw error; }
+  if (!metadata.isFile() || metadata.isSymbolicLink()) {
+    throw new Error('Refusing to replace an unknown ReMCP PowerShell launcher');
+  }
+  const contents = fs.readFileSync(powershell, 'utf8');
+  if (contents.length > 16000 || !contents.startsWith('#!/usr/bin/env pwsh')
+    || !contents.includes('$basedir/node_modules/@remcp/remcp/bin/remcp.mjs')) {
+    throw new Error('Refusing to remove a non-npm ReMCP PowerShell launcher');
+  }
+  return true;
+}
+
+export function preferWindowsCmdShim(prefix) {
+  if (!assertWindowsNpmPowerShellShimOwned(prefix)) return false;
+  const batch = path.join(prefix, 'remcp.cmd');
+  const powershell = path.join(prefix, 'remcp.ps1');
+  let batchStat;
+  try { batchStat = fs.lstatSync(batch); }
+  catch (error) {
+    if (error?.code !== 'ENOENT') throw error;
+    throw new Error('Cannot remove the PowerShell launcher without a ReMCP .cmd launcher');
+  }
+  if (!batchStat.isFile() || batchStat.isSymbolicLink()) {
+    throw new Error('Cannot remove the PowerShell launcher without a trusted ReMCP .cmd launcher');
+  }
+  fs.unlinkSync(powershell);
+  return true;
+}