@remcp/remcp 0.2.117 → 0.2.119

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@remcp/remcp",
-  "version": "0.2.117",
+  "version": "0.2.119",
   "description": "ReMCP device client: pair a computer with ReMCP and run the outbound-only agent that hosts the local MCP runtime.",
   "type": "module",
   "license": "MIT",

package/src/cli/service.mjs

@@ -51,13 +51,30 @@ function pathEntryExists(file) {
   }
 }
 
-function globalPackagePath(prefix, packageName) {
+function globalPackagePath(prefix, packageName, platform = servicePlatform()) {
   const name = String(packageName || '').trim();
   const parts = name.split('/');
   const validUnscoped = parts.length === 1 && parts[0] && !parts[0].startsWith('@') && parts[0] !== '.' && parts[0] !== '..';
   const validScoped = parts.length === 2 && /^@[^/]+$/.test(parts[0]) && parts[1] && parts[1] !== '.' && parts[1] !== '..';
   if (!validUnscoped && !validScoped) throw new Error(`Invalid npm package name for update: ${name || '(empty)'}`);
-  return path.join(prefix, 'lib', 'node_modules', ...parts);
+  const modulesRoot = platform === 'win32'
+    ? path.join(prefix, 'node_modules')
+    : path.join(prefix, 'lib', 'node_modules');
+  return path.join(modulesRoot, ...parts);
+}
+
+function managedWindowsRuntimePrefix() {
+  return path.resolve(
+    process.env.LOCALAPPDATA || path.join(home, 'AppData', 'Local'),
+    'ReMCP',
+    'runtime',
+  );
+}
+
+function isManagedWindowsRuntimePrefix(prefix) {
+  const actual = path.resolve(String(prefix || ''));
+  const expected = managedWindowsRuntimePrefix();
+  return actual.toLowerCase() === expected.toLowerCase();
 }
 
 function transactionalMacGlobalInstall({ resolved, prefix, packageNames, specs, preferOnline = false }) {
@@ -111,26 +128,93 @@ function transactionalMacGlobalInstall({ resolved, prefix, packageNames, specs,
   }
 }
 
+function transactionalWindowsGlobalInstall({ resolved, prefix, packageNames, specs, preferOnline = false }) {
+  prefix = String(prefix || '').trim();
+  if (!path.isAbsolute(prefix)) throw new Error(`npm global prefix must be absolute for a Windows update: ${prefix || '(empty)'}`);
+  if (!isManagedWindowsRuntimePrefix(prefix)) {
+    run(resolved.command, [...resolved.args, ...npmGlobalInstallArgs(specs, { preferOnline })]);
+    return;
+  }
+
+  const backupRoot = path.join(prefix, `.remcp-update-backup-${process.pid}-${Date.now()}`);
+  const moved = [];
+  const moveAside = (source, label) => {
+    if (!pathEntryExists(source)) return;
+    const backup = path.join(backupRoot, label);
+    fs.renameSync(source, backup);
+    moved.push({ source, backup });
+  };
+  const restore = originalError => {
+    let rollbackError = null;
+    for (const item of [...moved].reverse()) {
+      try {
+        if (pathEntryExists(item.source)) fs.rmSync(item.source, { recursive:true, force:true });
+        fs.mkdirSync(path.dirname(item.source), { recursive:true });
+        fs.renameSync(item.backup, item.source);
+      } catch (error) {
+        rollbackError ??= error;
+      }
+    }
+    try { fs.rmSync(backupRoot, { recursive:true, force:true }); } catch (error) { rollbackError ??= error; }
+    if (rollbackError) {
+      throw new Error(
+        `ReMCP update failed and the previous Windows installation could not be fully restored: ${rollbackError instanceof Error ? rollbackError.message : String(rollbackError)}`,
+        { cause:originalError },
+      );
+    }
+  };
+
+  fs.mkdirSync(prefix, { recursive:true });
+  fs.mkdirSync(backupRoot, { recursive:false, mode:0o700 });
+  try {
+    const uniqueNames = [...new Set(packageNames.map(name => String(name || '').trim()).filter(Boolean))];
+    uniqueNames.forEach((name, index) => moveAside(globalPackagePath(prefix, name, 'win32'), `package-${index}`));
+    if (uniqueNames.includes(PACKAGE_NAME)) {
+      for (const shim of ['remcp', 'remcp.cmd', 'remcp.ps1']) moveAside(path.join(prefix, shim), `bin-${shim}`);
+    }
+    run(resolved.command, [...resolved.args, ...npmGlobalInstallArgs(specs, { preferOnline })]);
+  } catch (error) {
+    restore(error);
+    throw error;
+  }
+
+  try {
+    fs.rmSync(backupRoot, { recursive:true, force:true });
+  } catch (error) {
+    console.error(`ReMCP update: could not remove Windows rollback backup ${backupRoot}: ${error instanceof Error ? error.message : String(error)}`);
+  }
+}
+
 // Release updates use exact versions that may have been published only moments ago. npm can keep a
 // cached pre-publication packument long enough to answer ETARGET after the registry already serves the
 // version, so updates revalidate metadata while retaining npm's cache for package bytes.
 export function npmGlobalUpdate(packageNames, ...specs) {
-  if (servicePlatform() !== 'darwin') {
-    run(npm.command, [...npm.args, ...npmGlobalInstallArgs(specs, { preferOnline:true })]);
+  const platform = servicePlatform();
+  const prefix = globalPrefix();
+  if (platform === 'darwin') {
+    transactionalMacGlobalInstall({ resolved:npm, prefix, packageNames, specs, preferOnline:true });
     return;
   }
-  const prefix = globalPrefix();
-  transactionalMacGlobalInstall({ resolved:npm, prefix, packageNames, specs, preferOnline:true });
+  if (platform === 'win32') {
+    transactionalWindowsGlobalInstall({ resolved:npm, prefix, packageNames, specs, preferOnline:true });
+    return;
+  }
+  run(npm.command, [...npm.args, ...npmGlobalInstallArgs(specs, { preferOnline:true })]);
 }
 
 export function npmGlobalUpdateForNode(nodePath, packageNames, ...specs) {
-  const resolved = resolveNpm({ nodePath, home, platform:servicePlatform() });
-  if (servicePlatform() !== 'darwin') {
-    run(resolved.command, [...resolved.args, ...npmGlobalInstallArgs(specs, { preferOnline:true })]);
+  const platform = servicePlatform();
+  const resolved = resolveNpm({ nodePath, home, platform });
+  const prefix = output(resolved.command, [...resolved.args, 'prefix', '--global']);
+  if (platform === 'darwin') {
+    transactionalMacGlobalInstall({ resolved, prefix, packageNames, specs, preferOnline:true });
     return;
   }
-  const prefix = output(resolved.command, [...resolved.args, 'prefix', '--global']);
-  transactionalMacGlobalInstall({ resolved, prefix, packageNames, specs, preferOnline:true });
+  if (platform === 'win32') {
+    transactionalWindowsGlobalInstall({ resolved, prefix, packageNames, specs, preferOnline:true });
+    return;
+  }
+  run(resolved.command, [...resolved.args, ...npmGlobalInstallArgs(specs, { preferOnline:true })]);
 }
 
 export function quoteSystemd(value) {
@@ -376,7 +460,10 @@ export function writeWindowsServiceLauncher(cliPath = globalCliPath(), nodePath
 export function installWindowsService(cliPath = globalCliPath(), { nodePath = process.execPath } = {}) {
   const launcherFile = writeWindowsServiceLauncher(cliPath, nodePath);
   const command = `"${launcherFile}"`;
-  run('schtasks.exe', ['/Create', '/TN', windowsTaskName, '/TR', command, '/SC', 'ONLOGON', '/RL', 'HIGHEST', '/F']);
+  // Computer-use needs the signed-in interactive desktop. Create the task with /IT from the start
+  // instead of changing it afterwards: schtasks /Change can request the account password even when
+  // the task already belongs to the current user, which turns a one-command install into a prompt.
+  run('schtasks.exe', ['/Create', '/TN', windowsTaskName, '/TR', command, '/SC', 'ONLOGON', '/RL', 'HIGHEST', '/IT', '/F']);
   run('schtasks.exe', ['/Run', '/TN', windowsTaskName]);
 }
 
@@ -601,12 +688,13 @@ export function configureMacWriteAccess() {
 }
 
 export function configureWindowsWriteAccess() {
-  try { run('schtasks.exe', ['/Change', '/TN', windowsTaskName, '/RL', 'HIGHEST', '/IT']); } catch {}
+  // installWindowsService already creates the task as HighestAvailable + InteractiveToken. Keep
+  // post-install access setup non-interactive so a fresh install never asks for the Windows password.
   try {
     const workspaceDir = path.join(process.env.LOCALAPPDATA || path.join(home, 'AppData', 'Local'), 'ReMCP');
     fs.mkdirSync(workspaceDir, { recursive: true });
   } catch {}
-  console.log('ReMCP configured with elevated privileges for full write access.');
+  console.log('ReMCP configured with the highest available user privileges for interactive desktop access.');
 }
 
 export function configureLinuxWriteAccess() {