@reltio/components 1.4.2211 → 1.4.2212

package/cjs/features/workflow/helpers/validation.test.js

@@ -0,0 +1,257 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+var validation_1 = require("./validation");
+var metadata_test_data_1 = require("./metadata.test-data");
+var validation_test_data_1 = require("./validation.test-data");
+var mdm_sdk_1 = require("@reltio/mdm-sdk");
+describe('getValidationErrors', function () {
+    it('should validate required attributes with user changes', function () {
+        var metadata = (0, metadata_test_data_1.getMetadata)();
+        var result = (0, validation_1.getValidationErrors)({
+            changes: (0, validation_test_data_1.getChanges)(),
+            userChanges: (0, validation_test_data_1.getUserChanges)(),
+            entitiesOrRelations: (0, validation_test_data_1.getEntitiesOrRelations)(),
+            metadata: metadata
+        });
+        var firstNameAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCP/attributes/FirstName');
+        var prescriberIndicatorAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCP/attributes/Boolean');
+        var addressAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCP/attributes/Address');
+        var internalPostCodeAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/relationTypes/HasAddress/attributes/InternalPostCode');
+        var primarySpecialityIndAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCP/attributes/Specialities/attributes/PrimarySpecialityInd');
+        expect(result).toEqual([
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: firstNameAttributeType,
+                    attributeTypeUri: 'configuration/entityTypes/HCP/attributes/FirstName',
+                    parentUri: 'FirstName/2QHFlPPP',
+                    uri: 'entityUri1/0SBmZIW/newValue',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: [
+                        expect.objectContaining({
+                            label: '<No label>',
+                            type: 'attributeValue',
+                            value: expect.objectContaining({
+                                uri: 'entities/entityUri1/attributes/FirstName/2QHFlPPP'
+                            }),
+                            valueType: firstNameAttributeType
+                        })
+                    ]
+                },
+                lineIds: ['entityUri1/0SBmZIW/newValue']
+            },
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: prescriberIndicatorAttributeType,
+                    attributeTypeUri: 'configuration/entityTypes/HCP/attributes/Boolean',
+                    parentUri: 'Boolean/2DEYFcfk',
+                    uri: 'entityUri1/0SBmys4/newValue',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: [
+                        expect.objectContaining({
+                            label: '<No label>',
+                            type: 'attributeValue',
+                            value: expect.objectContaining({
+                                uri: 'entities/entityUri1/attributes/Boolean/2DEYFcfk'
+                            }),
+                            valueType: prescriberIndicatorAttributeType
+                        })
+                    ]
+                },
+                lineIds: ['entityUri1/0SBmys4/newValue']
+            },
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: internalPostCodeAttributeType,
+                    attributeTypeUri: 'configuration/entityTypes/HCP/attributes/Address/attributes/InternalPostCode',
+                    parentUri: 'InternalPostCode',
+                    uri: 'entityUri1/0SBmubo/newValue',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: [
+                        expect.objectContaining({
+                            label: expect.any(String),
+                            type: 'attributeValue',
+                            value: expect.objectContaining({
+                                uri: 'entities/entityUri1/attributes/Address/0HfPK9G'
+                            }),
+                            valueType: addressAttributeType
+                        }),
+                        expect.objectContaining({
+                            label: '<No label>',
+                            type: 'attributeValue',
+                            value: expect.objectContaining({
+                                uri: 'entities/entityUri1/attributes/Address/0HfPK9G/InternalPostCode/2GMCNw4E'
+                            }),
+                            valueType: internalPostCodeAttributeType
+                        })
+                    ]
+                },
+                lineIds: ['entityUri1/0SBmubo/newValue']
+            },
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: primarySpecialityIndAttributeType,
+                    attributeTypeUri: 'configuration/entityTypes/HCP/attributes/Specialities/attributes/PrimarySpecialityInd',
+                    parentUri: undefined,
+                    uri: 'entityUri1/0SBn7Oa/newValue/value/PrimarySpecialityInd/0',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: []
+                },
+                lineIds: ['entityUri1/0SBn7Oa/newValue/value/PrimarySpecialityInd/0']
+            }
+        ]);
+    });
+    it('should validate required attributes with subnested user changes', function () {
+        var metadata = (0, metadata_test_data_1.getMetadata)();
+        var result = (0, validation_1.getValidationErrors)({
+            changes: (0, validation_test_data_1.getChanges)(),
+            userChanges: (0, validation_test_data_1.getUserChangesRejectSubnestedAttributes)(),
+            entitiesOrRelations: (0, validation_test_data_1.getEntitiesOrRelations)(),
+            metadata: metadata
+        });
+        var specialitiesAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCP/attributes/Specialities');
+        var primarySpecialityIndAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCP/attributes/Specialities/attributes/PrimarySpecialityInd');
+        expect(result).toEqual([
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: primarySpecialityIndAttributeType,
+                    attributeTypeUri: 'configuration/entityTypes/HCP/attributes/Specialities/attributes/PrimarySpecialityInd',
+                    parentUri: undefined,
+                    uri: 'entityUri1/0SBn7Oa/newValue/value/PrimarySpecialityInd/0',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: []
+                },
+                lineIds: ['entityUri1/0SBn7Oa/newValue/value/PrimarySpecialityInd/0']
+            },
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: specialitiesAttributeType,
+                    attributeTypeUri: 'configuration/entityTypes/HCP/attributes/Specialities',
+                    parentUri: undefined,
+                    uri: 'entityUri1/0SBn7Oa/newValue',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: []
+                },
+                lineIds: ['entityUri1/0SBn7Oa/newValue']
+            }
+        ]);
+    });
+    it('should validate required attributes with subnested relation user changes', function () {
+        var metadata = (0, metadata_test_data_1.getMetadata)();
+        var result = (0, validation_1.getValidationErrors)({
+            changes: (0, validation_test_data_1.getChanges)(),
+            userChanges: (0, validation_test_data_1.getUserChangesRejectSubnestedRelationAttributes)(),
+            entitiesOrRelations: (0, validation_test_data_1.getEntitiesOrRelations)(),
+            metadata: metadata
+        });
+        var refFirstLevelNestedAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/relationTypes/HCPtoHCA/attributes/NestedAttr');
+        expect(result).toEqual([
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: refFirstLevelNestedAttributeType,
+                    attributeTypeUri: 'configuration/relationTypes/HCPtoHCA/attributes/NestedAttr',
+                    parentUri: undefined,
+                    uri: '0pSTmm8/0MCLpVw/newValue/attributes/NestedAttr/0',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: []
+                },
+                lineIds: ['0pSTmm8/0MCLpVw/newValue/attributes/NestedAttr/0']
+            }
+        ]);
+    });
+    it('should validate required subnested attribute when value is empty', function () {
+        var metadata = (0, metadata_test_data_1.getMetadata)();
+        var result = (0, validation_1.getValidationErrors)({
+            changes: (0, validation_test_data_1.getChanges)(),
+            userChanges: (0, validation_test_data_1.getUserChangesSubnestedEmpty)(),
+            entitiesOrRelations: (0, validation_test_data_1.getEntitiesOrRelations)(),
+            metadata: metadata
+        });
+        var nestedAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCP/attributes/NestedAttr');
+        var intAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCP/attributes/NestedAttr/attributes/Int');
+        expect(result).toEqual([
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: intAttributeType,
+                    attributeTypeUri: 'configuration/entityTypes/HCP/attributes/NestedAttr/attributes/Int',
+                    parentUri: 'NestedAttr/2BNyTheu',
+                    uri: 'entityUri1/0IEmjjX/newValue',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: [
+                        expect.objectContaining({
+                            label: '<No label>',
+                            type: 'attributeValue',
+                            value: expect.objectContaining({
+                                uri: 'entities/entityUri1/attributes/NestedAttr/2BNyTheu'
+                            }),
+                            valueType: nestedAttributeType
+                        }),
+                        expect.objectContaining({
+                            label: '<No label>',
+                            type: 'attributeValue',
+                            value: expect.objectContaining({
+                                uri: 'entities/entityUri1/attributes/NestedAttr/2BNyTheu/Int/2BNyTlvA'
+                            }),
+                            valueType: intAttributeType
+                        })
+                    ]
+                },
+                lineIds: ['entityUri1/0IEmjjX/newValue']
+            }
+        ]);
+    });
+    it('should validate required attributes in new entity', function () {
+        var metadata = (0, metadata_test_data_1.getMetadata)();
+        var result = (0, validation_1.getValidationErrors)({
+            changes: (0, validation_test_data_1.getChanges)(),
+            userChanges: (0, validation_test_data_1.getUserChangesNewEntity)(),
+            entitiesOrRelations: (0, validation_test_data_1.getEntitiesOrRelations)(),
+            metadata: metadata
+        });
+        var nameAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCO/attributes/Name');
+        var emailAttributeType = (0, mdm_sdk_1.findAttributeTypeByUri)(metadata, 'configuration/entityTypes/HCO/attributes/ContactInfo/attributes/Email');
+        expect(result).toEqual([
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: nameAttributeType,
+                    attributeTypeUri: 'configuration/entityTypes/HCO/attributes/Name',
+                    parentUri: undefined,
+                    uri: 'entityUri2/0IEiwoe/newValue/attributes/Name/0',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: []
+                },
+                lineIds: ['entityUri2/0IEiwoe/newValue/attributes/Name/0']
+            },
+            {
+                error: {
+                    type: 'missed',
+                    attributeType: emailAttributeType,
+                    attributeTypeUri: 'configuration/entityTypes/HCO/attributes/ContactInfo/attributes/Email',
+                    parentUri: undefined,
+                    uri: 'entityUri2/0IEiwoe/newValue/attributes/ContactInfo/0/value/Email/0',
+                    message: 'Attribute is required',
+                    source: 'local',
+                    path: []
+                },
+                lineIds: ['entityUri2/0IEiwoe/newValue/attributes/ContactInfo/0/value/Email/0']
+            }
+        ]);
+    });
+});

package/cjs/features/workflow/hooks/useDCRValidation.js

@@ -132,7 +132,7 @@ var useDCRValidation = function (dcr) {
                 case 3:
                     relations = _a;
                     loadedRelationsObject = relations.reduce(function (acc, relation) {
-                        acc[relation.uri] = relation;
+                        acc[relation === null || relation === void 0 ? void 0 : relation.uri] = relation;
                         return acc;
                     }, {});
                     objectsByUri = __assign(__assign({}, localObjects), loadedRelationsObject);

package/features/workflow/ReviewDCRDialog/DCRErrorsPanel/DCRErrorsPanel.js

@@ -10,5 +10,5 @@ export var DCRErrorsPanel = function () {
         return null;
     }
     return (React.createElement("div", { className: styles.DCRErrorsPanel },
-        React.createElement(AttributesErrorsPanel, { attributesWithErrors: validationErrors })));
+        React.createElement(AttributesErrorsPanel, { attributesWithErrors: validationErrors, alwaysShowLink: true })));
 };

package/features/workflow/helpers/attributes.test.js

@@ -10,10 +10,11 @@ var __assign = (this && this.__assign) || function () {
     return __assign.apply(this, arguments);
 };
 import { DCRTypes, EntityAttrTypes, DCROperationTypes } from '@reltio/mdm-sdk';
-import { metadata } from './metadata.test-data';
+import { getMetadata } from './metadata.test-data';
 import { getEntityChanges, getRelationChanges } from './attributes';
 describe('attributes helpers tests', function () {
     it('getEntityChanges behaviour', function () {
+        var metadata = getMetadata();
         var objectInfo = {
             isExist: true,
             label: '12345 - Address Line 1 City',
@@ -139,6 +140,7 @@ describe('attributes helpers tests', function () {
             ]
         };
         it('should not show operation for relation title', function () {
+            var metadata = getMetadata();
             expect(getRelationChanges(metadata, relationInfo, changes, DCRTypes.INSERT_ATTRIBUTE, ['lineIds'])).toEqual([
                 {
                     attributeType: null,
@@ -167,6 +169,7 @@ describe('attributes helpers tests', function () {
             ]);
         });
         it('should show operation for relation title if it is new', function () {
+            var metadata = getMetadata();
             expect(getRelationChanges(metadata, relationInfo, changes, DCRTypes.CREATE_RELATIONSHIP, ['lineIds'])).toEqual([
                 {
                     attributeType: null,
@@ -196,6 +199,7 @@ describe('attributes helpers tests', function () {
             ]);
         });
         it('should show operation for relation title if it was deleted and changes are empty', function () {
+            var metadata = getMetadata();
             expect(getRelationChanges(metadata, relationInfo, {}, DCRTypes.DELETE_RELATIONSHIP, ['lineIds'])).toEqual([
                 {
                     attributeType: null,

package/features/workflow/helpers/merge.test.js

@@ -10,7 +10,7 @@ var __assign = (this && this.__assign) || function () {
     return __assign.apply(this, arguments);
 };
 import { DCRTypes, EntityAttrTypes, DCROperationTypes } from '@reltio/mdm-sdk';
-import { metadata } from './metadata.test-data';
+import { getMetadata } from './metadata.test-data';
 import { mergeChanges } from './merge';
 describe('mergeChanges tests', function () {
     var entityUri = 'entities/1hRTSKE5';
@@ -23,6 +23,7 @@ describe('mergeChanges tests', function () {
     };
     it('should create path to change', function () {
         var _a;
+        var metadata = getMetadata();
         var changes = (_a = {},
             _a[entityUri] = [
                 {
@@ -68,6 +69,7 @@ describe('mergeChanges tests', function () {
     });
     it('should merge changes with the same paths', function () {
         var _a;
+        var metadata = getMetadata();
         var changes = (_a = {},
             _a[entityUri] = [
                 {
@@ -157,6 +159,7 @@ describe('mergeChanges tests', function () {
     });
     it('should not merge changes with the same paths, but different types', function () {
         var _a;
+        var metadata = getMetadata();
         var changes = (_a = {},
             _a[entityUri] = [
                 {
@@ -236,6 +239,7 @@ describe('mergeChanges tests', function () {
     });
     it('should merge special attributes', function () {
         var _a;
+        var metadata = getMetadata();
         var changes = (_a = {},
             _a[entityUri] = [
                 {
@@ -273,6 +277,7 @@ describe('mergeChanges tests', function () {
     });
     it('should merge relations', function () {
         var _a;
+        var metadata = getMetadata();
         var changes = {
             'relations/1EvCRmwC': [
                 {
@@ -335,6 +340,7 @@ describe('mergeChanges tests', function () {
     it('should merge lineIds when multiple changes have the same attributePath', function () {
         var _a;
         var _b, _c;
+        var metadata = getMetadata();
         var changes = (_a = {},
             _a[entityUri] = [
                 {

package/features/workflow/helpers/metadata.test-data.d.ts

@@ -1,2 +1,2 @@
 import { Metadata } from '@reltio/mdm-sdk';
-export declare const metadata: Metadata;
+export declare const getMetadata: () => Metadata;

package/features/workflow/helpers/metadata.test-data.js

@@ -1,5 +1,5 @@
 import { RelationTypeDirection } from '@reltio/mdm-sdk';
-export var metadata = {
+export var getMetadata = function () { return ({
     entityTypes: [
         {
             uri: 'configuration/entityTypes/HCA',
@@ -52,14 +52,125 @@ export var metadata = {
                 }
             ]
         },
+        {
+            uri: 'configuration/entityTypes/HCP',
+            label: 'HCP',
+            attributes: [
+                {
+                    uri: 'configuration/entityTypes/HCP/attributes/FirstName',
+                    label: 'First Name',
+                    name: 'FirstName',
+                    type: 'String',
+                    required: true
+                },
+                {
+                    uri: 'configuration/entityTypes/HCP/attributes/Boolean',
+                    label: 'Boolean',
+                    name: 'Boolean',
+                    type: 'Boolean',
+                    required: true
+                },
+                {
+                    uri: 'configuration/entityTypes/HCP/attributes/Specialities',
+                    label: 'Specialities',
+                    name: 'Specialities',
+                    type: 'Nested',
+                    required: true,
+                    attributes: [
+                        {
+                            uri: 'configuration/entityTypes/HCP/attributes/Specialities/attributes/SpecialityStatus',
+                            label: 'Speciality Status',
+                            name: 'SpecialityStatus',
+                            type: 'String'
+                        },
+                        {
+                            uri: 'configuration/entityTypes/HCP/attributes/Specialities/attributes/PrimarySpecialityInd',
+                            label: 'Primary Speciality Ind',
+                            name: 'PrimarySpecialityInd',
+                            type: 'Boolean',
+                            required: true
+                        }
+                    ]
+                },
+                {
+                    uri: 'configuration/entityTypes/HCP/attributes/NestedAttr',
+                    label: 'Nested Attr',
+                    name: 'NestedAttr',
+                    type: 'Nested',
+                    attributes: [
+                        {
+                            uri: 'configuration/entityTypes/HCP/attributes/NestedAttr/attributes/Int',
+                            label: 'Int',
+                            name: 'Int',
+                            type: 'String',
+                            required: true
+                        }
+                    ]
+                },
+                {
+                    uri: 'configuration/entityTypes/HCP/attributes/Address',
+                    label: 'Address',
+                    name: 'Address',
+                    type: 'Reference',
+                    referencedAttributeURIs: ['configuration/relationTypes/HasAddress/attributes/InternalPostCode'],
+                    referencedEntityTypeURI: 'configuration/entityTypes/Location',
+                    relationshipTypeURI: 'configuration/relationTypes/HasAddress'
+                }
+            ]
+        },
+        {
+            uri: 'configuration/entityTypes/Location',
+            label: 'Location',
+            attributes: [
+                {
+                    uri: 'configuration/entityTypes/Location/attributes/AddressLine1',
+                    label: 'AddressLine1',
+                    name: 'AddressLine1',
+                    type: 'String'
+                },
+                {
+                    uri: 'configuration/entityTypes/Location/attributes/City',
+                    label: 'City',
+                    name: 'City',
+                    type: 'String'
+                }
+            ]
+        },
         {
             label: 'HCO',
             uri: 'configuration/entityTypes/HCO',
             attributes: [
+                {
+                    uri: 'configuration/entityTypes/HCO/attributes/Name',
+                    name: 'Name',
+                    type: 'String',
+                    required: true
+                },
                 {
                     uri: 'configuration/entityTypes/HCO/attributes/WebsiteURL',
                     name: 'WebsiteURL',
                     type: 'String'
+                },
+                {
+                    uri: 'configuration/entityTypes/HCO/attributes/ContactInfo',
+                    label: 'Contact Info',
+                    name: 'ContactInfo',
+                    type: 'Nested',
+                    attributes: [
+                        {
+                            uri: 'configuration/entityTypes/HCO/attributes/ContactInfo/attributes/Email',
+                            label: 'Email',
+                            name: 'Email',
+                            type: 'String',
+                            required: true
+                        },
+                        {
+                            uri: 'configuration/entityTypes/HCO/attributes/ContactInfo/attributes/Phone',
+                            label: 'Phone',
+                            name: 'Phone',
+                            type: 'String'
+                        }
+                    ]
                 }
             ]
         }
@@ -97,6 +208,13 @@ export var metadata = {
                             uri: 'configuration/relationTypes/HasAddress/attributes/AdditionalAttributes/attributes/AttributeValue'
                         }
                     ]
+                },
+                {
+                    uri: 'configuration/relationTypes/HasAddress/attributes/InternalPostCode',
+                    label: 'Internal Post Code',
+                    name: 'InternalPostCode',
+                    type: 'String',
+                    required: true
                 }
             ]
         },
@@ -115,6 +233,33 @@ export var metadata = {
                     uri: 'configuration/relationTypes/Assistant/attributes/TestAttribute'
                 }
             ]
+        },
+        {
+            uri: 'configuration/relationTypes/HCPtoHCA',
+            label: 'HCP to HCA',
+            attributes: [
+                {
+                    uri: 'configuration/relationTypes/HCPtoHCA/attributes/Status',
+                    label: 'Status',
+                    name: 'Status',
+                    type: 'String'
+                },
+                {
+                    uri: 'configuration/relationTypes/HCPtoHCA/attributes/NestedAttr',
+                    label: 'Nested Attr',
+                    name: 'NestedAttr',
+                    type: 'Nested',
+                    required: true,
+                    attributes: [
+                        {
+                            uri: 'configuration/relationTypes/HCPtoHCA/attributes/NestedAttr/attributes/SubAttr',
+                            label: 'Sub Attr',
+                            name: 'SubAttr',
+                            type: 'String'
+                        }
+                    ]
+                }
+            ]
         }
     ]
-};
+}); };

package/features/workflow/helpers/validation.js

@@ -234,7 +234,6 @@ var createRequiredError = function (_a) {
         parentUri: parentUri,
         message: i18n.text('Attribute is required'),
         source: ErrorSource.local,
-        alwaysShow: true,
         uri: lineIds[0]
     });
     var path = [];

package/features/workflow/helpers/validation.test-data.d.ts

@@ -0,0 +1,14 @@
+import { DCRChanges, Entity, Relation } from '@reltio/mdm-sdk';
+import { LineData } from '../types';
+type UserChange = {
+    lineId: string;
+    data: LineData;
+};
+export declare const getChanges: () => DCRChanges;
+export declare const getEntitiesOrRelations: () => Record<string, Entity | Relation>;
+export declare const getUserChanges: () => UserChange[];
+export declare const getUserChangesRejectSubnestedAttributes: () => UserChange[];
+export declare const getUserChangesRejectSubnestedRelationAttributes: () => UserChange[];
+export declare const getUserChangesSubnestedEmpty: () => UserChange[];
+export declare const getUserChangesNewEntity: () => UserChange[];
+export {};