@reltio/components 1.4.2201 → 1.4.2202

package/cjs/features/workflow/ChangeRequestEditor/helpers/helper.test.js

@@ -0,0 +1,237 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+var mdm_sdk_1 = require("@reltio/mdm-sdk");
+var helpers_1 = require("./helpers");
+describe('addLineIdToValue', function () {
+    it('should add lineIds for a simple attribute', function () {
+        var changes = {
+            'entities/0FaSodQ': [
+                {
+                    id: '4pomtm9',
+                    type: mdm_sdk_1.DCRTypes.INSERT_ATTRIBUTE,
+                    newValue: { value: '434' }
+                }
+            ]
+        };
+        var result = (0, helpers_1.addLineIdToValue)(changes);
+        expect(result).toEqual({
+            'entities/0FaSodQ': [
+                {
+                    id: '4pomtm9',
+                    type: mdm_sdk_1.DCRTypes.INSERT_ATTRIBUTE,
+                    newValue: {
+                        value: '434',
+                        lineIds: ['0FaSodQ/4pomtm9/newValue']
+                    },
+                    lineIds: ['0FaSodQ/4pomtm9']
+                }
+            ]
+        });
+    });
+    it('should add lineIds to the newValue of a UPDATE_TAGS change', function () {
+        var changes = {
+            'entities/0FaSodQ': [
+                {
+                    id: '0OSJEYr',
+                    type: mdm_sdk_1.DCRTypes.UPDATE_TAGS,
+                    newValue: ['www', 'qqq', 'sss'],
+                    oldValue: ['aaa', 'bbb', 'ccc']
+                }
+            ]
+        };
+        var result = (0, helpers_1.addLineIdToValue)(changes);
+        expect(result).toEqual({
+            'entities/0FaSodQ': [
+                {
+                    id: '0OSJEYr',
+                    type: mdm_sdk_1.DCRTypes.UPDATE_TAGS,
+                    newValue: {
+                        value: ['www', 'qqq', 'sss'],
+                        lineIds: ['0FaSodQ/0OSJEYr/newValue']
+                    },
+                    oldValue: {
+                        value: ['aaa', 'bbb', 'ccc'],
+                        lineIds: ['0FaSodQ/0OSJEYr/oldValue']
+                    },
+                    lineIds: ['0FaSodQ/0OSJEYr']
+                }
+            ]
+        });
+    });
+    it('should recursively add lineIds to nested attribute values', function () {
+        var changes = {
+            'entities/0FaSodQ': [
+                {
+                    id: '4ponaOj',
+                    type: mdm_sdk_1.DCRTypes.INSERT_ATTRIBUTE,
+                    newValue: {
+                        value: {
+                            TextField: [{ value: 'Test' }],
+                            Int: [{ value: '42' }]
+                        }
+                    }
+                }
+            ]
+        };
+        var result = (0, helpers_1.addLineIdToValue)(changes);
+        expect(result).toEqual({
+            'entities/0FaSodQ': [
+                {
+                    id: '4ponaOj',
+                    type: mdm_sdk_1.DCRTypes.INSERT_ATTRIBUTE,
+                    newValue: {
+                        value: {
+                            TextField: [
+                                {
+                                    value: 'Test',
+                                    lineIds: ['0FaSodQ/4ponaOj/newValue/value/TextField/0']
+                                }
+                            ],
+                            Int: [
+                                {
+                                    value: '42',
+                                    lineIds: ['0FaSodQ/4ponaOj/newValue/value/Int/0']
+                                }
+                            ]
+                        },
+                        lineIds: ['0FaSodQ/4ponaOj/newValue']
+                    },
+                    lineIds: ['0FaSodQ/4ponaOj']
+                }
+            ]
+        });
+    });
+    it('should add lineIds to all attributes of CREATE_ENTITY changes', function () {
+        var changes = {
+            'entities/1PMfzz2w': [
+                {
+                    id: '36a3GSVm',
+                    type: mdm_sdk_1.DCRTypes.CREATE_ENTITY,
+                    objectType: 'configuration/entityTypes/Location',
+                    newValue: {
+                        attributes: {
+                            AddressLine1: [{ value: 'www' }],
+                            CityTierName: [{ value: 'ALBY' }]
+                        },
+                        type: 'configuration/entityTypes/Location',
+                        uri: 'entities/0T5H79G'
+                    }
+                }
+            ]
+        };
+        var result = (0, helpers_1.addLineIdToValue)(changes);
+        expect(result).toEqual({
+            'entities/1PMfzz2w': [
+                {
+                    id: '36a3GSVm',
+                    type: mdm_sdk_1.DCRTypes.CREATE_ENTITY,
+                    objectType: 'configuration/entityTypes/Location',
+                    newValue: {
+                        attributes: {
+                            AddressLine1: [
+                                {
+                                    value: 'www',
+                                    lineIds: ['1PMfzz2w/36a3GSVm/newValue/attributes/AddressLine1/0']
+                                }
+                            ],
+                            CityTierName: [
+                                {
+                                    value: 'ALBY',
+                                    lineIds: ['1PMfzz2w/36a3GSVm/newValue/attributes/CityTierName/0']
+                                }
+                            ]
+                        },
+                        type: 'configuration/entityTypes/Location',
+                        uri: 'entities/0T5H79G',
+                        lineIds: ['1PMfzz2w/36a3GSVm/newValue']
+                    },
+                    lineIds: ['1PMfzz2w/36a3GSVm']
+                }
+            ]
+        });
+    });
+    it('should add lineIds to all attributes of CREATE_RELATIONSHIP changes', function () {
+        var changes = {
+            'relations/0lVSmtX': [
+                {
+                    id: '0G7u0JP',
+                    type: mdm_sdk_1.DCRTypes.CREATE_RELATIONSHIP,
+                    newValue: {
+                        attributes: {
+                            PrefOrActive: [{ value: 'yfhgvm' }],
+                            AffiliationStatus: [{ value: 'Status 1' }],
+                            PrimaryAffiliationIndicator: [{ value: 'true' }]
+                        },
+                        type: 'configuration/relationTypes/DirPharmacy',
+                        uri: 'relations/0Mj0zAI'
+                    }
+                }
+            ]
+        };
+        var result = (0, helpers_1.addLineIdToValue)(changes);
+        expect(result).toEqual({
+            'relations/0lVSmtX': [
+                {
+                    id: '0G7u0JP',
+                    type: mdm_sdk_1.DCRTypes.CREATE_RELATIONSHIP,
+                    newValue: {
+                        attributes: {
+                            PrefOrActive: [
+                                {
+                                    value: 'yfhgvm',
+                                    lineIds: ['0lVSmtX/0G7u0JP/newValue/attributes/PrefOrActive/0']
+                                }
+                            ],
+                            AffiliationStatus: [
+                                {
+                                    value: 'Status 1',
+                                    lineIds: ['0lVSmtX/0G7u0JP/newValue/attributes/AffiliationStatus/0']
+                                }
+                            ],
+                            PrimaryAffiliationIndicator: [
+                                {
+                                    value: 'true',
+                                    lineIds: ['0lVSmtX/0G7u0JP/newValue/attributes/PrimaryAffiliationIndicator/0']
+                                }
+                            ]
+                        },
+                        type: 'configuration/relationTypes/DirPharmacy',
+                        uri: 'relations/0Mj0zAI',
+                        lineIds: ['0lVSmtX/0G7u0JP/newValue']
+                    },
+                    lineIds: ['0lVSmtX/0G7u0JP']
+                }
+            ]
+        });
+    });
+    it('should add lineIds to both oldValue and newValue for UPDATE_ATTRIBUTE changes', function () {
+        var changes = {
+            'entities/0FaSodQ': [
+                {
+                    id: '4pomtm9',
+                    type: mdm_sdk_1.DCRTypes.UPDATE_ATTRIBUTE,
+                    oldValue: { value: 'old' },
+                    newValue: { value: 'new' }
+                }
+            ]
+        };
+        var result = (0, helpers_1.addLineIdToValue)(changes);
+        expect(result).toEqual({
+            'entities/0FaSodQ': [
+                {
+                    id: '4pomtm9',
+                    type: mdm_sdk_1.DCRTypes.UPDATE_ATTRIBUTE,
+                    oldValue: {
+                        value: 'old',
+                        lineIds: ['0FaSodQ/4pomtm9/oldValue']
+                    },
+                    newValue: {
+                        value: 'new',
+                        lineIds: ['0FaSodQ/4pomtm9/newValue']
+                    },
+                    lineIds: ['0FaSodQ/4pomtm9']
+                }
+            ]
+        });
+    });
+});

package/cjs/features/workflow/ChangeRequestEditor/helpers/helpers.d.ts

@@ -0,0 +1,4 @@
+import { DCRChanges, GroupedObjectsInfo, EnrichedDCRChanges } from '@reltio/mdm-sdk';
+import { Diff } from '../../types';
+export declare const isEditableChange: (change: Diff, entityInfo: GroupedObjectsInfo["entity"]) => boolean;
+export declare const addLineIdToValue: (data: DCRChanges) => EnrichedDCRChanges;

package/cjs/features/workflow/ChangeRequestEditor/helpers/helpers.js

@@ -0,0 +1,105 @@
+"use strict";
+var __assign = (this && this.__assign) || function () {
+    __assign = Object.assign || function(t) {
+        for (var s, i = 1, n = arguments.length; i < n; i++) {
+            s = arguments[i];
+            for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p))
+                t[p] = s[p];
+        }
+        return t;
+    };
+    return __assign.apply(this, arguments);
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.addLineIdToValue = exports.isEditableChange = void 0;
+var ramda_1 = require("ramda");
+var mdm_sdk_1 = require("@reltio/mdm-sdk");
+var isEditableChange = function (change, entityInfo) {
+    var _a;
+    var currentAttributeTypeUri = (_a = change.attributeType) === null || _a === void 0 ? void 0 : _a.uri;
+    var isExistingReferenceEntityChange = entityInfo.isExist &&
+        currentAttributeTypeUri &&
+        change.isReferenceSubAttribute &&
+        change.operation === mdm_sdk_1.DCROperationTypes.ADDED &&
+        !(0, mdm_sdk_1.isRelationTypeUri)(currentAttributeTypeUri);
+    return !!currentAttributeTypeUri && !isExistingReferenceEntityChange && !(0, ramda_1.isNil)(change.newValue);
+};
+exports.isEditableChange = isEditableChange;
+var isPrimitiveValue = function (value) {
+    return typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean';
+};
+var addLineIdRecursively = function (value, basePath) {
+    if (value == null)
+        return value;
+    if (Array.isArray(value)) {
+        return value.map(function (entry, index) {
+            if (entry && typeof entry === 'object') {
+                var entryPath = "".concat(basePath, "/").concat(index);
+                var newEntry = (0, ramda_1.clone)(entry);
+                newEntry.lineIds = [entryPath];
+                var v = newEntry.value;
+                if (typeof v === 'object' && v !== null) {
+                    newEntry.value = addLineIdRecursively(v, "".concat(entryPath, "/value"));
+                }
+                return newEntry;
+            }
+            return entry;
+        });
+    }
+    if (typeof value === 'object') {
+        var result = {};
+        for (var _i = 0, _a = Object.entries(value); _i < _a.length; _i++) {
+            var _b = _a[_i], key = _b[0], val = _b[1];
+            var childPath = "".concat(basePath, "/").concat(key);
+            result[key] = addLineIdRecursively(val, childPath);
+        }
+        return result;
+    }
+    return value;
+};
+var addLineIdToChangeValue = function (container, basePath, type) {
+    if (container == null)
+        return container;
+    if ([mdm_sdk_1.DCRTypes.CREATE_ENTITY, mdm_sdk_1.DCRTypes.CREATE_RELATIONSHIP].includes(type)) {
+        var attributes = void 0;
+        if ('attributes' in container && typeof container.attributes === 'object') {
+            attributes = addLineIdRecursively(container.attributes, "".concat(basePath, "/attributes"));
+        }
+        return __assign(__assign({}, container), { attributes: attributes, lineIds: [basePath] });
+    }
+    if (Array.isArray(container)) {
+        return { value: container, lineIds: [basePath] };
+    }
+    if (typeof container === 'object' && 'value' in container) {
+        var containerValue = container.value;
+        return __assign(__assign({}, container), { lineIds: [basePath], value: isPrimitiveValue(containerValue)
+                ? containerValue
+                : addLineIdRecursively(containerValue, "".concat(basePath, "/value")) });
+    }
+    return container;
+};
+var addLineIdToValue = function (data) {
+    var enrichedData = (0, ramda_1.clone)(data);
+    for (var entityOrRelationKey in enrichedData) {
+        var entityOrRelationId = entityOrRelationKey.split('/')[1];
+        var changeList = enrichedData[entityOrRelationKey];
+        if (!Array.isArray(changeList))
+            continue;
+        for (var _i = 0, changeList_1 = changeList; _i < changeList_1.length; _i++) {
+            var change = changeList_1[_i];
+            var changeId = change.id;
+            var type = change.type;
+            if (change.newValue != null) {
+                var root = "".concat(entityOrRelationId, "/").concat(changeId, "/newValue");
+                change.newValue = addLineIdToChangeValue(change.newValue, root, type);
+            }
+            if (change.oldValue != null) {
+                var root = "".concat(entityOrRelationId, "/").concat(changeId, "/oldValue");
+                change.oldValue = addLineIdToChangeValue(change.oldValue, root, type);
+            }
+            change.lineIds = ["".concat(entityOrRelationId, "/").concat(changeId)];
+        }
+    }
+    return enrichedData;
+};
+exports.addLineIdToValue = addLineIdToValue;

package/cjs/features/workflow/ReviewDCRDialog/ReviewDCRDialog.js

@@ -15,6 +15,7 @@ var ui_i18n_1 = __importDefault(require("ui-i18n"));
 var useWorkflowCheckPermission_1 = require("../hooks/useWorkflowCheckPermission");
 var useWorkflowActions_1 = require("../hooks/useWorkflowActions");
 var MdmModuleContext_1 = require("../../../contexts/MdmModuleContext");
+var context_1 = require("../ChangeRequestEditor/context");
 var ProfileBand_1 = require("../../../ProfileBand");
 var DueDateField_1 = require("../DueDateField");
 var PrioritySelector_1 = require("../PrioritySelector");
@@ -54,7 +55,8 @@ var ReviewDCRDialog = function (_a) {
                         react_1.default.createElement("div", { className: ReviewDCRDialog_module_css_1.default.editableItem },
                             react_1.default.createElement(AssigneeSelector_1.AssigneeSelector, { taskId: task.taskId, assignee: task.assignee, isTaskOpen: task.isOpen })))),
                 react_1.default.createElement("div", { className: ReviewDCRDialog_module_css_1.default.changesSection },
-                    react_1.default.createElement(ChangeRequestEditor_1.ChangeRequestEditor, { dcr: dcr, task: task, groupedObjects: groupedObjects }))),
+                    react_1.default.createElement(context_1.ChangeRequestEditorProvider, null,
+                        react_1.default.createElement(ChangeRequestEditor_1.ChangeRequestEditor, { dcr: dcr, task: task, groupedObjects: groupedObjects })))),
             canViewComments && (react_1.default.createElement(WorkflowComments_1.WorkflowComments, { workflowActions: workflowActions, actionRequestIsInProgress: actionRequestIsInProgress, preferredAction: task.preferredAction, taskId: task.taskId, processInstanceComments: task.processInstanceComments, isTaskOpen: task.isOpen, showActionButtons: false, alwaysExpanded: true, classes: {
                     container: ReviewDCRDialog_module_css_1.default.commentsRootContainer,
                     commentsContainer: ReviewDCRDialog_module_css_1.default.commentsContainer

package/cjs/features/workflow/helpers/attributes.js

@@ -64,19 +64,30 @@ var dcrAttributesFactory = function (metadata, attributeType, attributeValue, le
         }
     }
 };
+var extractLineIds = function (attributeValue) {
+    var _a, _b;
+    return typeof attributeValue.value === 'object' &&
+        'newValue' in attributeValue.value &&
+        'lineIds' in attributeValue.value.newValue &&
+        Array.isArray(attributeValue.value.newValue.lineIds)
+        ? (_b = (_a = attributeValue === null || attributeValue === void 0 ? void 0 : attributeValue.value) === null || _a === void 0 ? void 0 : _a.newValue) === null || _b === void 0 ? void 0 : _b.lineIds
+        : attributeValue.lineIds;
+};
 var getNestedAttributeChange = function (metadata, attributeType, attributeValue, level) {
     var attributeTypeList = (0, mdm_sdk_1.getAttributeTypeSubAttributes)({}, attributeType);
     var label = (0, mdm_sdk_1.getLabel)((attributeType === null || attributeType === void 0 ? void 0 : attributeType.label) || (attributeType === null || attributeType === void 0 ? void 0 : attributeType.name));
+    var lineIds = extractLineIds(attributeValue);
     return [
-        { level: level, label: label, attributeType: attributeType, attributeValue: attributeValue },
+        { level: level, label: label, attributeType: attributeType, attributeValue: attributeValue, lineIds: lineIds },
         getAttributesList(metadata, attributeTypeList, attributeValue.value, level + 1)
     ];
 };
 var getReferenceAttributeChange = function (metadata, attributeType, attributeValue, level) {
     var attributeTypeList = (0, mdm_sdk_1.getAttributeTypeSubAttributes)(metadata, attributeType);
     var label = (attributeType === null || attributeType === void 0 ? void 0 : attributeType.label) || (attributeType === null || attributeType === void 0 ? void 0 : attributeType.name);
+    var lineIds = extractLineIds(attributeValue);
     return [
-        { level: level, label: label, attributeType: attributeType, attributeValue: attributeValue },
+        { level: level, label: label, attributeType: attributeType, attributeValue: attributeValue, lineIds: lineIds },
         getAttributesList(metadata, attributeTypeList, attributeValue.value, level + 1, true)
     ];
 };
@@ -114,7 +125,7 @@ exports.getRelationChanges = (0, ramda_1.curry)(function (metadata, relationInfo
     var relationType = (0, mdm_sdk_1.getRelationType)(metadata, relationInfo.type);
     var attrTypes = (0, mdm_sdk_1.getRelationAttributesList)(metadata, relationInfo.type);
     return (0, ramda_1.flatten)([
-        __assign({ level: 1, label: (0, ramda_1.propOr)('', 'label', relationType), attributeType: null, relationType: relationType, attributeValue: __assign(__assign({}, relationInfo), changes) }, addRelationOperationIfNeeded(changes, changeType)),
+        __assign({ level: 1, label: (0, ramda_1.propOr)('', 'label', relationType), attributeType: null, relationType: relationType, attributeValue: __assign(__assign({}, relationInfo), changes), lineIds: changes === null || changes === void 0 ? void 0 : changes.lineIds }, addRelationOperationIfNeeded(changes, changeType)),
         getAttributesList(metadata, attrTypes, changes, 2)
     ]);
 });

package/cjs/features/workflow/helpers/attributes.test.js

@@ -32,8 +32,20 @@ describe('attributes helpers tests', function () {
                         attributeType: 'configuration/entityTypes/HCA/attributes/CountryCode',
                         id: '41cb3gGy',
                         newPinOrIgnoreValue: true,
-                        newValue: { value: 'Chile', lookupCode: 'CL', lookupRawValue: 'Chile', pin: true },
-                        oldValue: { value: 'Chile', lookupCode: 'CL', lookupRawValue: 'Chile', pin: true },
+                        newValue: {
+                            value: 'Chile',
+                            lookupCode: 'CL',
+                            lookupRawValue: 'Chile',
+                            pin: true,
+                            lineIds: ['3AqlrpfGa/value/newValue']
+                        },
+                        oldValue: {
+                            value: 'Chile',
+                            lookupCode: 'CL',
+                            lookupRawValue: 'Chile',
+                            pin: true,
+                            lineIds: ['3AqlrpfGa/value/oldValue']
+                        },
                         type: mdm_sdk_1.DCRTypes.IGNORE_ATTRIBUTE
                     }
                 },
@@ -44,7 +56,12 @@ describe('attributes helpers tests', function () {
                         attributeType: 'configuration/entityTypes/HCA/attributes/CountryCode',
                         id: '41cb3c0i',
                         newPinOrIgnoreValue: false,
-                        newValue: { value: 'Bahamas', lookupCode: 'BS', lookupRawValue: 'BS' },
+                        newValue: {
+                            value: 'Bahamas',
+                            lookupCode: 'BS',
+                            lookupRawValue: 'BS',
+                            lineIds: ['uri$$1643545710682']
+                        },
                         type: mdm_sdk_1.DCRTypes.INSERT_ATTRIBUTE
                     }
                 }
@@ -76,7 +93,7 @@ describe('attributes helpers tests', function () {
                 attributeType: metadata_test_data_1.metadata.entityTypes[0].attributes[1],
                 label: 'Country Code',
                 level: 0,
-                newValue: changes.CountryCode[0].value.newValue,
+                newValue: __assign(__assign({}, changes.CountryCode[0].value.newValue), { lineIds: ['3AqlrpfGa/value/oldValue'] }),
                 operation: 'ignored',
                 isReferenceSubAttribute: false
             },
@@ -116,7 +133,12 @@ describe('attributes helpers tests', function () {
         };
         var changes = {
             TestAttribute: [{ value: { newValue: '123', type: mdm_sdk_1.DCRTypes.INSERT_ATTRIBUTE } }],
-            'activeness.startDate': [{ newValue: { value: 1644001200000 }, type: mdm_sdk_1.DCRTypes.INSERT_ATTRIBUTE }]
+            'activeness.startDate': [
+                {
+                    newValue: { value: 1644001200000, lineIds: ['relations/t58vHMD/activeness/startDate/newValue'] },
+                    type: mdm_sdk_1.DCRTypes.INSERT_ATTRIBUTE
+                }
+            ]
         };
         it('should not show operation for relation title', function () {
             expect((0, attributes_1.getRelationChanges)(metadata_test_data_1.metadata, relationInfo, changes, mdm_sdk_1.DCRTypes.INSERT_ATTRIBUTE)).toEqual([
@@ -131,7 +153,7 @@ describe('attributes helpers tests', function () {
                     attributeType: mdm_sdk_1.EntityAttrTypes.startDate,
                     label: mdm_sdk_1.EntityAttrTypes.startDate.label,
                     level: 2,
-                    newValue: { value: 1644001200000 },
+                    newValue: { value: 1644001200000, lineIds: ['relations/t58vHMD/activeness/startDate/newValue'] },
                     operation: mdm_sdk_1.DCROperationTypes.ADDED,
                     isReferenceSubAttribute: false
                 },
@@ -159,7 +181,7 @@ describe('attributes helpers tests', function () {
                     attributeType: mdm_sdk_1.EntityAttrTypes.startDate,
                     label: mdm_sdk_1.EntityAttrTypes.startDate.label,
                     level: 2,
-                    newValue: { value: 1644001200000 },
+                    newValue: { value: 1644001200000, lineIds: ['relations/t58vHMD/activeness/startDate/newValue'] },
                     operation: mdm_sdk_1.DCROperationTypes.ADDED,
                     isReferenceSubAttribute: false
                 },

package/cjs/features/workflow/helpers/merge.d.ts

@@ -1,3 +1,4 @@
-import { DCRChanges, GroupedObjectsInfo, Metadata } from '@reltio/mdm-sdk';
+import { GroupedObjectsInfo, Metadata, EnrichedDCRChanges, EnrichedChangeValue, ChangeValue, DCRChanges } from '@reltio/mdm-sdk';
 import { Diff } from '../types';
-export declare const mergeChanges: (metadata: Metadata, changes: DCRChanges, entityInfo: GroupedObjectsInfo["entity"], relationsInfo: GroupedObjectsInfo["relations"]) => [Diff[], Diff[]];
+export declare const extractLineIds: (value: ChangeValue | EnrichedChangeValue) => string[] | undefined;
+export declare const mergeChanges: (metadata: Metadata, changes: EnrichedDCRChanges | DCRChanges, entityInfo: GroupedObjectsInfo["entity"], relationsInfo: GroupedObjectsInfo["relations"]) => [Diff[], Diff[]];